[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 394766. HsiangKai added a comment. Fix build errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[clang] 6bca9a4 - [CodeGen] Store ElementType in LValue

Author: Nikita Popov Date: 2021-12-16T09:23:33+01:00 New Revision: 6bca9a428e32c598f793821e407d5c9d7bbe7cd8 URL: https://github.com/llvm/llvm-project/commit/6bca9a428e32c598f793821e407d5c9d7bbe7cd8 DIFF: https://github.com/llvm/llvm-project/commit/6bca9a428e32c598f793821e407d5c9d7bbe7cd8.diff

[PATCH] D115791: [CodeGen] Store ElementType in LValue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bca9a428e32: [CodeGen] Store ElementType in LValue (authored by nikic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 27818f0 - [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false.

Author: Marek Kurdej Date: 2021-12-16T09:28:00+01:00 New Revision: 27818f01fec2dd8f18325281f97646aed5ca9c89 URL: https://github.com/llvm/llvm-project/commit/27818f01fec2dd8f18325281f97646aed5ca9c89 DIFF: https://github.com/llvm/llvm-project/commit/27818f01fec2dd8f18325281f97646aed5ca9c89.diff

[PATCH] D115803: [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27818f01fec2: [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false. (authored by curdeius). Repository: rG LLVM Github Monorepo C

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. hokein requested review of this revision. Herald added a project: clang. Also, add a dummy clang-pseudo tool (right now it accepts and parses the grammar file). Repository: rG LLVM Github Monor

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394780. sammccall added a comment. Make hasDeclaration look through UsingType, and throughUsingDecl work on UsingType too. This is more ergonomic, more similar to existing behavior that matchers rely on, and similar in spirit to DeclRefExpr. Repository:

[clang] f668034 - [clang][deps] Squash caches for original and minimized files

Author: Jan Svoboda Date: 2021-12-16T09:57:21+01:00 New Revision: f66803457ec7f88fa86376d9aef677dea107818c URL: https://github.com/llvm/llvm-project/commit/f66803457ec7f88fa86376d9aef677dea107818c DIFF: https://github.com/llvm/llvm-project/commit/f66803457ec7f88fa86376d9aef677dea107818c.diff L

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rGf66803457ec7: [clang][deps] Squash caches for original and minimized files (authored by jansvoboda11).

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 394782. HsiangKai added a comment. Herald added a subscriber: jdoerfert. Update attribute test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 added a comment. Committed with the writes swapped and explanation in the comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115346/new/ https://reviews.llvm.org/D115346

[PATCH] D113622: [analyzer] support ignoring use-after-free checking with reference_counted attribute

steakhal added a comment. In D113622#3195985 , @NoQ wrote: > In D113622#3194580 , @steakhal > wrote: > >> Could you please share the results to have look? How can I reproduce and >> evaluate the effect of this c

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

ChuanqiXu updated this revision to Diff 394786. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115792/new/ https://reviews.llvm.org/D115792 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/TypeProperties.td clang/lib/

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 394789. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/Basic/Dia

[PATCH] D115865: [clang-format] add support for branch attribute macros

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49184 clang-format doesn't handle the use

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. It seems this patch has nothing to do with the failure in the Linux build. I think it is now ready to land. Thanks a lot for your suggestions during the revision. Could you please commit this patch on my behalf? Thanks. Ella Ma CHANGES SINCE LAST ACTION https://

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

RKSimon added a comment. In D115231#3194439 , @junaire wrote: > In D115231#3194372 , @RKSimon wrote: > >> Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well >> in the same patch since the

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3192009 , @SjoerdMeijer wrote: > Ok, fair enough, perhaps adding features is a valid use-case. > > I will refrain from commenting on "things are terribly broken". I agree it > is broken, but in a different way than sug

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn accepted this revision. fhahn added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, lxfind. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. See the discussion in https://reviews.llvm.org/D100282. Since coroutine couldn't be **properly** in

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire added a comment. Thanks for accepting this patch! I would appreciate it if someone is willing to commit this for me since I don't have commit access ;D You can use: Jun Zhang j...@junz.org Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[clang] 9fa15e0 - [CodeGen] Remove an unused MakeAddrLValue() overload (NFC)

Author: Nikita Popov Date: 2021-12-16T11:49:20+01:00 New Revision: 9fa15e0073b97dc2aa3482f297c13cb9509238e4 URL: https://github.com/llvm/llvm-project/commit/9fa15e0073b97dc2aa3482f297c13cb9509238e4 DIFF: https://github.com/llvm/llvm-project/commit/9fa15e0073b97dc2aa3482f297c13cb9509238e4.diff

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang

ChuanqiXu updated this revision to Diff 394801. ChuanqiXu retitled this revision from "[Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine" to "[Coroutines] Set presplit attribute in Clang". ChuanqiXu edited the summary of this revision. Chuan

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys updated this revision to Diff 394802. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h clang/unittests/Format/FormatTestCSharp.cpp Index: clan

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys marked 4 inline comments as done. peterstys added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1870 // C# may break after => if the next character is a newline. if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == t

[clang] 34eb715 - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-16T12:03:11+01:00 New Revision: 34eb715f61991cd3abd19b02af689b84409363f1 URL: https://github.com/llvm/llvm-project/commit/34eb715f61991cd3abd19b02af689b84409363f1 DIFF: https://github.com/llvm/llvm-project/commit/34eb715f61991cd3abd19b02af689b84409363f1.diff

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang

ChuanqiXu added a comment. @ezhulenev hi, we are discussing if we should set the coroutine attributes in middle-end or front-end. Now in this revision, it would set the `coroutine.presplit` attribute in frontend, which would break the MLIR test. I have tried to implement it myself today. But

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 394806. sammccall added a comment. Fix serialization (found with msan) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114251/new/ https://reviews.llvm.org/D114251 Files: clang-tools-extra/clang-tidy/google/

[PATCH] D115865: [clang-format] add support for branch attribute macros

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Tested locally. Has Bolt landed? It seems that the CI adds bolt as the project but it isn't recognized... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

stuart added a comment. In D110742#3194608 , @svenvh wrote: > Apologies for the late reply... I'd prefer to get the langref updated first, > for the sake of consistency and to ensure other stakeholders agree with the > interpretation. You can still go

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys marked an inline comment as done. peterstys added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:766 + + verifyFormat(R"(// +public class Sample { peterstys wrote: > MyDeveloperDay wrote: > > Nit: (only my preference) but I do

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

steakhal added a comment. I haven't checked the code, but only the tests and expectations for scalar values. I'll dive deeper if we settled on those. A couple of remarks: 1. I would rather use top-level function parameters of the given type instead of declaring an instance of that type and tak

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:766 + + verifyFormat(R"(// +public class Sample { peterstys wrote: > peterstys wrote: > > MyDeveloperDay wrote: > > > Nit: (only my preference) but I don't like the use of R

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

nemanjai added a comment. In D106120#3196010 , @q66 wrote: > On x86_64, the program predictably prints `Dv4_i`. The semantics here are not new, but the warning is emitted for generic vector types as a result of https://reviews.llvm.org/D103615. This is

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM In D115804#3195158 , @spatel wrote: > In D115804#3195002 , @nikic wrote: > >> Looks reasonable. Making fl

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

owenpan accepted this revision. owenpan added a comment. Thanks! LGTM other than the extraneous braces on lines 1859-1861. (See https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements.) Comment at: clang/lib/Form

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

q66 added a comment. Well, I'm more concerned about the actual semantics - as I see it, when using generic vectors, they should be unaffected by the comparison behavior of AltiVec vectors, which is not the case when you set the mode to `xl`. If the semantics are affected, it means creating a ma

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

peterstys updated this revision to Diff 394814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h clang/unittests/Format/FormatTestCSharp.cpp Index: clan

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. In D110742#3197183 , @stuart wrote: > Thanks! I have updated the review to use `__attribute__((pure))` only (i.e. > it no longer uses `__attribute__(

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added a comment. > This feature requires support of opencl_c_generic_address_space and opencl_c_program_scope_global_variables so diagnostics for that is provided as well. Do we have a spec issue for it or a PR? It would be good to list it here since it is not yet published in the re

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Mostly some minor comments that you can address at commit time. It would be good to get approval from another reviewer. Comment at: clang/docs/UsersManual.rst:3538 +

[clang] a1879e5 - Fix crash on invalid code involving late parsed inline methods

Author: Aaron Ballman Date: 2021-12-16T07:58:51-05:00 New Revision: a1879e52e3ae9424b59747d9b837a7a87bcb996d URL: https://github.com/llvm/llvm-project/commit/a1879e52e3ae9424b59747d9b837a7a87bcb996d DIFF: https://github.com/llvm/llvm-project/commit/a1879e52e3ae9424b59747d9b837a7a87bcb996d.diff

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks, I've commit in a1879e52e3ae9424b59747d9b837a7a87bcb996d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D113943: Add `withIntrospection` matcher.

aaron.ballman added a comment. In D113943#3184076 , @avogelsgesang wrote: > Nit: > Personally, I would prefer the name `withDebugOutput` over > `withIntrospection`, as it more clearly describes the intent of this matcher. > At least to me, "introspectio

[clang-tools-extra] 9198d04 - Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Author: Paul Altin Date: 2021-12-16T08:24:09-05:00 New Revision: 9198d04c06b561cd78d9407cedd50f7b995ee6d8 URL: https://github.com/llvm/llvm-project/commit/9198d04c06b561cd78d9407cedd50f7b995ee6d8 DIFF: https://github.com/llvm/llvm-project/commit/9198d04c06b561cd78d9407cedd50f7b995ee6d8.diff LO

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

linjamaki added a comment. If I understand correctly, the default optimization level is `-O2` for the OpenCL and OpenCL++ language mode (according to CompilerInvocation.cpp:getOptimizationLevel()). Since higher than `-O0` may not work with the translator, should the SPIR-V tool chain override t

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

aaron.ballman closed this revision. aaron.ballman added a comment. In D112881#3181082 , @paulaltin wrote: >> Thanks! Do you need someone to commit on your behalf? If so, what name and >> email address would you like used for patch attribution? > > That w

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6853 +if (R->isReserveIDT() || R->isClkEventT() || R->isEventT() || +R.getUnqualifiedType().getAsString() == "ndrange_t" || R->isQueueT()) { Se.Diag(NewVD->getLocation(),

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added a comment. In D112410#3197441 , @linjamaki wrote: > If I understand correctly, the default optimization level is `-O2` for the > OpenCL and OpenCL++ language mode (according to > CompilerInvocation.cpp:getOptimizationLevel()). Since high

[clang] 8561e15 - [clang][dataflow] Fix unused-variable warning.

Author: Yitzhak Mandelbaum Date: 2021-12-16T13:37:17Z New Revision: 8561e15c5befd84542637493a76c8f2de25d08b9 URL: https://github.com/llvm/llvm-project/commit/8561e15c5befd84542637493a76c8f2de25d08b9 DIFF: https://github.com/llvm/llvm-project/commit/8561e15c5befd84542637493a76c8f2de25d08b9.diff

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

aaron.ballman added a reviewer: alexfh. aaron.ballman added a subscriber: alexfh. aaron.ballman added a comment. In D114317#3169067 , @carlosgalvezp wrote: > Kind ping to reviewers, I mostly want to know if you agree with the general > direction so I ca

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 _

[clang] 8c7f2a4 - [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

Author: Sanjay Patel Date: 2021-12-16T09:10:12-05:00 New Revision: 8c7f2a4f871928d8734ee3f03e67d09086850b60 URL: https://github.com/llvm/llvm-project/commit/8c7f2a4f871928d8734ee3f03e67d09086850b60 DIFF: https://github.com/llvm/llvm-project/commit/8c7f2a4f871928d8734ee3f03e67d09086850b60.diff

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c7f2a4f8719: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast… (authored by spatel). Herald added a project: clang. Chan

[clang] 58c8c53 - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-16T15:26:21+01:00 New Revision: 58c8c5326329bb55df6b9d4f7f8f43a2c82e67c1 URL: https://github.com/llvm/llvm-project/commit/58c8c5326329bb55df6b9d4f7f8f43a2c82e67c1 DIFF: https://github.com/llvm/llvm-project/commit/58c8c5326329bb55df6b9d4f7f8f43a2c82e67c1.diff

[clang] a0cf066 - [CodeGen] Store element type in ParamValue

Author: Nikita Popov Date: 2021-12-16T15:31:55+01:00 New Revision: a0cf066eac8aa55782a6dd2deb90adc89a707a8b URL: https://github.com/llvm/llvm-project/commit/a0cf066eac8aa55782a6dd2deb90adc89a707a8b DIFF: https://github.com/llvm/llvm-project/commit/a0cf066eac8aa55782a6dd2deb90adc89a707a8b.diff

[clang] 1a376bc - [OpenCL] Add pure attribute to vload builtins

Author: Stuart Brady Date: 2021-12-16T14:55:31Z New Revision: 1a376bc285358037a5edc48b0d125f91bf5a69ca URL: https://github.com/llvm/llvm-project/commit/1a376bc285358037a5edc48b0d125f91bf5a69ca DIFF: https://github.com/llvm/llvm-project/commit/1a376bc285358037a5edc48b0d125f91bf5a69ca.diff LOG:

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a376bc28535: [OpenCL] Add pure attribute to vload builtins (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

thakis added a comment. looks like this broke tests: http://45.33.8.238/linux/63308/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D1

[clang] 5aefb1d - Revert "[OpenCL] Add pure attribute to vload builtins"

Author: Stuart Brady Date: 2021-12-16T15:16:41Z New Revision: 5aefb1dc1eabd9286da9511b5227aa83443091b9 URL: https://github.com/llvm/llvm-project/commit/5aefb1dc1eabd9286da9511b5227aa83443091b9 DIFF: https://github.com/llvm/llvm-project/commit/5aefb1dc1eabd9286da9511b5227aa83443091b9.diff LOG:

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

davrec added a comment. `throughUsingDecl` seems like a good solution, though I defer to regular ASTMatchers users. One other thought: can we add diagnostic notes using this new information, e.g. struct A1 { protected: using IntType = char; }; struct A2 { protected: using I

[clang] 5fbe21a - [clang] p2085 out-of-class comparison operator defaulting

Author: Nathan Sidwell Date: 2021-12-16T07:22:46-08:00 New Revision: 5fbe21a7748f91adbd1b16c95bbfe180642320a3 URL: https://github.com/llvm/llvm-project/commit/5fbe21a7748f91adbd1b16c95bbfe180642320a3 DIFF: https://github.com/llvm/llvm-project/commit/5fbe21a7748f91adbd1b16c95bbfe180642320a3.diff

[PATCH] D104478: [clang] p2085 out-of-class comparison operator defaulting

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbe21a7748f: [clang] p2085 out-of-class comparison operator defaulting (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://re

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan, MarcusJohnson91. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49804 Interaction betwee

[clang] 8285522 - [CodeGen] Always update map entry after adding initializer

Author: Nikita Popov Date: 2021-12-16T16:29:35+01:00 New Revision: 828552201420720ff52c9a27ea4e8f3697f1abc1 URL: https://github.com/llvm/llvm-project/commit/828552201420720ff52c9a27ea4e8f3697f1abc1 DIFF: https://github.com/llvm/llvm-project/commit/828552201420720ff52c9a27ea4e8f3697f1abc1.diff

[clang] bbc690c - Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

Author: Hans Wennborg Date: 2021-12-16T16:30:06+01:00 New Revision: bbc690c57213054907284d8964dc0487d38fc57a URL: https://github.com/llvm/llvm-project/commit/bbc690c57213054907284d8964dc0487d38fc57a DIFF: https://github.com/llvm/llvm-project/commit/bbc690c57213054907284d8964dc0487d38fc57a.diff

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc690c57213: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704) (authored by hans). Changed prior to commit: https://reviews.llvm.org/D112081?vs=380704&id=394877#toc Repository: rG LLV

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

hans added a comment. Thanks for the reminder! Landed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112081/new/ https://reviews.llvm.org/D112081 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

stuart updated this revision to Diff 394878. stuart added a comment. I've updated the review to include test changes that are required for check-clang-semaopencl to pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D110742 Files: clang/lib/Head

[clang] 2d89382 - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-16T16:34:09+01:00 New Revision: 2d89382b5a21423180c7860163bb0e4cd3082e4b URL: https://github.com/llvm/llvm-project/commit/2d89382b5a21423180c7860163bb0e4cd3082e4b DIFF: https://github.com/llvm/llvm-project/commit/2d89382b5a21423180c7860163bb0e4cd3082e4b.diff

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

thakis added a comment. Thanks! Bots look happy again :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110742/new/ https://reviews.llvm.org/D110742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. > me pretty far behind on reviews Wow, that's a lot to review! I will keep it in mind and hopefully only ping you when I have a nice final design ready to go. Really appreciate your early feedback! > I'd like to make sure I'm on the same page as you. Yes, exactl

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyModule.h:25-26 +#define CLANG_TIDY_REGISTER_CHECK(Factory, CheckType, CheckName) \ + Factory.registerCheck(CheckName, #CheckType) + aaron.ballman wrote: > I'm

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

aaron.ballman added a comment. Thanks for this new check! In terms of whether we should expose the check in C++: I think we shouldn't. Annex K *could* be supported by a C++ library implementation (http://eel.is/c++draft/library#headers-10), but none of the identifiers are added to namespace `s

[clang] 2d0bf14 - [clang] Cleanup unneeded Function nullptr checks [NFC]

Author: Mike Rice Date: 2021-12-16T08:28:10-08:00 New Revision: 2d0bf14397276d1ece9db1eb1858a644aad77ff2 URL: https://github.com/llvm/llvm-project/commit/2d0bf14397276d1ece9db1eb1858a644aad77ff2 DIFF: https://github.com/llvm/llvm-project/commit/2d0bf14397276d1ece9db1eb1858a644aad77ff2.diff LOG

[PATCH] D115817: [clang] Cleanup unneeded Function nullptr checks [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d0bf1439727: [clang] Cleanup unneeded Function nullptr checks [NFC] (authored by mikerice). Herald added a project: clang. Herald added a subscriber

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:200-210 + // FIXME: This read can fail. + // In that case, we should probably update `CacheEntry::MaybeStat`. + // However, that is co

[clang] 333d66b - [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

Author: Ella Ma Date: 2021-12-16T17:47:59+01:00 New Revision: 333d66b09494b7ebc1a89f2befa79128a56f77e3 URL: https://github.com/llvm/llvm-project/commit/333d66b09494b7ebc1a89f2befa79128a56f77e3 DIFF: https://github.com/llvm/llvm-project/commit/333d66b09494b7ebc1a89f2befa79128a56f77e3.diff LOG:

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG333d66b09494: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space… (authored by OikawaKirie, committed by steakhal). Repository

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

aaron.ballman added a comment. In D114317#3197815 , @carlosgalvezp wrote: >> me pretty far behind on reviews > > Wow, that's a lot to review! I will keep it in mind and hopefully only ping > you when I have a nice final design ready to go. Really apprec

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a comment. In D112221#3196740 , @tambre wrote: > In D112221#3195955 , @ldionne wrote: > >> @tambre Any appetite for a libc++ patch? :) >> >> Otherwise, let me know and I'll put it in my list of thing

[PATCH] D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: xazax.hun, steakhal, NoQ, martong, baloghadamsoftware. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet. ASDenysPetrov requested re

[PATCH] D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115883/new/ https://reviews.llvm.org/D115883

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:616 + bool isInExportDeclContext() const; + I think it would be good to add some comments to document the function (as done with surrounding code). Comment

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman added a comment. In D114995#3183240 , @malcolm.parsons wrote: > In D114995#3180475 , @aaron.ballman > wrote: > >> was there a reason we didn't cover that case originally or was it an >> oversight/

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

rnk added a comment. I see, thanks for the info. Can you please add a targeted LLVM test for long double arguments? From what I can tell, the auto-generated update_llc_test_checks.py style tests are not a good fit for testing parameter passing because they pattern-match away the stack offsets

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

erichkeane added a comment. Note: I think I've done everything requested, so I'm hoping to commit this tomorrow 1st thing in order to have it in time for everyone's vacations (and so my downstream can get it before the new year), unless I hear objections from the other reviewers. CHANGES SINC

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceb80557e523: [OpenCL] Add pure attribute to vload builtins (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ceb8055 - [OpenCL] Add pure attribute to vload builtins

Author: Stuart Brady Date: 2021-12-16T18:30:58Z New Revision: ceb80557e523f1894799ebadd5d985e11ee80461 URL: https://github.com/llvm/llvm-project/commit/ceb80557e523f1894799ebadd5d985e11ee80461 DIFF: https://github.com/llvm/llvm-project/commit/ceb80557e523f1894799ebadd5d985e11ee80461.diff LOG:

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

rnk added a comment. I probably don't have time to review this, so let me redirect to @hans. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:2400 +static llvm::GlobalValue *getTlsGuardVar(CodeGenModule &CGM) { + llvm::Type *VTy = llvm::Type::getInt8Ty(CGM.getLLVMContext())

[libunwind] 1c4867e - [libunwind] Provide a way to conveniently install libunwind headers

Author: PoYao Chang Date: 2021-12-16T13:32:40-05:00 New Revision: 1c4867e6fc507fe6e81cfc0e3c7148307b4b7433 URL: https://github.com/llvm/llvm-project/commit/1c4867e6fc507fe6e81cfc0e3c7148307b4b7433 DIFF: https://github.com/llvm/llvm-project/commit/1c4867e6fc507fe6e81cfc0e3c7148307b4b7433.diff L

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10546-10548 + if (PointeeTy->isDependentType()) { +return true; + } Comment at: clang/lib/Sema/SemaExpr.cpp:13824 Sourc

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

estewart08 added a comment. In D109885#3194819 , @ronlieb wrote: > @estewart08 thoughts on a good CMAKE variable to allow users to define > equivalent of /opt/rocm ? and not use environment variable inside the > cmake file. I would be ok with the fo

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm requested changes to this revision. arsenm added a comment. Dropping the default install location from the default search hint is entirely unreasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109885/new/ https://reviews.llvm.org/D1098

[PATCH] D111100: enable plugins for clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:392-394 + cl::Option *load_opt = cl::getRegisteredOptions().lookup("load"); + if (load_opt) +load_opt->addCategory(ClangTidyCategory); C

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. In D109885#3198232 , @arsenm wrote: > Dropping the default install location from the default search hint is > entirely unreasonable That seems to be the feature request, though I haven't gone through the jira web to wor

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added a comment. In D109885#3198290 , @JonChesterfield wrote: > In D109885#3198232 , @arsenm wrote: > >> Dropping the default install location from the default search hint is >> entirely unreasonable > >

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added inline comments. Comment at: clang/tools/amdgpu-arch/CMakeLists.txt:13 + +find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATH ${ROCM_PATH}) if (NOT ${hsa-runtime64_FOUND}) I also think CMAKE_INSTALL_PREFIX in the search hints

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. In D109885#3198296 , @arsenm wrote: > This isn't a feature, it's the introduction of a bug. It would regress people depending on the implicit pickup of /opt/rocm, leaving them with a straightforward workaround of setting

  1   2   >