[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna added a comment. In D115648#3196142 , @luna wrote: > Simplify test case by using `-O3` to generate IR. Probably because of the diff from `ThinLTO/X86/devirt_hybrid_after_filtering_unreachable.ll` to `ThinLTO/X86/devirt_after_filtering_unreachable.

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

aqjune added a comment. This sounds like a great fix to me! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115804/new/ https://reviews.llvm.org/D115804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir Jake-Egan wrote: > jsji wrote: > > there is no `fmodule-format=obj` here, why are we failing here? > > >

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:739 static constexpr ImpliedExtsEntry ImpliedExts[] = { -{{"v"}, {ImpliedExtsV}}, -{{"zfh"}, {ImpliedExtsZfh}}, +{"v", {ImpliedExtsV}}, +{"zfh", {ImpliedExtsZfh}},

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 394697. junaire added a comment. Rename SemaBuiltinReduceMathPreCheck to PrepareBuiltinReduceMathOneArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files: clang

[PATCH] D115790: [Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine

ChuanqiXu added inline comments. Comment at: llvm/test/Other/new-pm-O0-defaults.ll:34 ; CHECK-DIS-NEXT: Running pass: AddDiscriminatorsPass +; CHECK-CORO: Running pass: CoroEarlyPass ; CHECK-DIS-NEXT: Running pass: AlwaysInlinerPass aeubanks wrote: > should hav

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

owenpan added a comment. Thanks for factoring the code. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1872 // calling `addUnwrappedLine()` here causes odd parsing errors. FormatTok->MustBreakBefore = true; } MyDevelop

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining abandoned this revision. SixWeining added a comment. Abandon because https://reviews.llvm.org/D115580 has already fixed it although later than my fix. Thanks @dexonsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ab5527c15f0: [ThinLTO] Ignore unreachable virtual functions in WPD in thin LTO. (authored by luna). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D115709: [RISCV] Remove Vamo Extention

achieveartificialintelligence added a comment. I've updated the description. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709 ___ cfe-commits mailing lis

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. Hi @rnk , mine is Phoebe#3036. I haven't really used it before. No sure if I invited you correctly, so I try to explain here. > My comment here refers to the alignment of argument values, not user-declared > variables. The frontend controls the alignment of user-declare

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:110-111 + +CachedFileContents &DependencyScanningFilesystemSharedCache::getFileContents( +StringRef Filename, llvm::sys::fs::UniqueID UID) { + CacheShard &Sha

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen created this revision. ychen added reviewers: pcc, vsk, rjmccall. Herald added subscribers: dexonsmith, hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Information in the function `Prologue Data` is

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394739. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/B

[PATCH] D115790: [Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I don't find it at all weird to say that there's an invariant that certain intrinsics can only appear in functions with a particular attribute, and so the frontend has a responsi

[PATCH] D115791: [CodeGen] Store ElementType in LValue

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115791/new/ https://reviews.llvm.org/D115791 ___

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

rjmccall added a comment. I don't have a strong opinion about attribute vs. metadata; if metadata are the best technical path forward, that's fine with me. I don't think function metadata can be "lost" the same way that metadata internal to a function can, right? Repository: rG LLVM Github

[PATCH] D115848: tidy-llvm

CSears created this revision. CSears added a reviewer: jroelofs. Herald added a subscriber: carlosgalvezp. CSears requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Using clang-tidy on LLVM itself (the proverbial eating your own do

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai added inline comments. Herald added subscribers: VincentWu, luke957. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b01; craig.topper wrote: > Is c

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18610 unsigned NF = 1; constexpr unsigned TAIL_UNDISTURBED = 0; + constexpr unsigned TAIL_AGNOSTIC = 0b01; HsiangKai wrote: > craig.topper wrote: > > Is constant still used? > Yes

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

ychen added a comment. In D114728#3196591 , @rjmccall wrote: > I don't have a strong opinion about attribute vs. metadata; if metadata are > the best technical path forward, that's fine with me. I don't think function > metadata can be "lost" the same

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie updated this revision to Diff 394748. OikawaKirie added a comment. Fix `YAML:1:293: error: Unrecognized escape code` error by replacing lit substitution pattern `%S` to `%/S`. Fix `cp` problems by removing the file copy operations. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 394751. HsiangKai added a comment. Address @craig.topper and @frasercrmck's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/B

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. Ping! Could we see this previously approved patch over the line I’d like to use it to build a regression suit of code and format files without the need for every test to be in its own directory CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ ht

[PATCH] D113638: [xray] Add support for hexagon architecture

dberris added a comment. Whoops -- sorry, I had forgotten to change my email settings and missed this. Thanks for the patch, it's exciting to see XRay being supported in the Hexagon architecture! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11363

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

rjmccall added a comment. This seems reasonable, but I think it's probably better to just doing it in the ASTContext code (`getTypeDeclTypeSlow`) the same way it's done for e.g. `RecordDecl`s with previous declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195955 , @ldionne wrote: > @tambre Any appetite for a libc++ patch? :) > > Otherwise, let me know and I'll put it in my list of things to fix up. Sure, I can take it up during the weekend. CHANGES SINCE LAST ACTION

[PATCH] D115848: tidy-llvm

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Just use compilation database? https://github.com/llvm-mirror/clang-tools-extra/blob/1c8cadde7ea4ca20a449edcffe10d23b612fe5d6/clang-tidy/tool/run-clang-tidy.py#L100 Repositor

<    1   2   3