[clang] abbc2e9 - [CodeGen] Store ElementType in Address

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T08:59:44+01:00 New Revision: abbc2e997bbf8f60ccb18f04c477c28f3ad0a7a2 URL: https://github.com/llvm/llvm-project/commit/abbc2e997bbf8f60ccb18f04c477c28f3ad0a7a2 DIFF: https://github.com/llvm/llvm-project/commit/abbc2e997bbf8f60ccb18f04c477c28f3ad0a7a2.diff

[PATCH] D115725: [CodeGen] Store ElementType in Address

2021-12-15 Thread Nikita Popov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabbc2e997bbf: [CodeGen] Store ElementType in Address (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Rep

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

2021-12-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Thank you for the patch, this looks good but we do need a unit test in `clang/unittest/Format/FormatTestJson.cpp` you can then build them with `ninja FormatTests`, if you need help let me know Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

2021-12-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. The following will show the issue TEST_F(FormatTestJson, DisableJsonFormat) { FormatStyle Style = getLLVMStyle(FormatStyle::LK_Json); verifyFormat("{}", Style); verifyFormat("{\n" " \"name\": 1\n" "}",

[clang] b4f4655 - [CodeGen] Avoid some pointer element type accesses

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T09:29:27+01:00 New Revision: b4f46555d7462a88a8743026459ae40412ed4ed2 URL: https://github.com/llvm/llvm-project/commit/b4f46555d7462a88a8743026459ae40412ed4ed2 DIFF: https://github.com/llvm/llvm-project/commit/b4f46555d7462a88a8743026459ae40412ed4ed2.diff

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

2021-12-15 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added inline comments. Comment at: clang/CMakeLists.txt:232 +if(CLANG_DEFAULT_PIE_ON_LINUX) + set(CLANG_DEFAULT_PIE_ON_LINUX 1) +endif() Can these 3 lines be removed after D115751? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

2021-12-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Hi, the new test is failing on our arm/aarch64 quick bots. These build only the respective backend so you might need to add a requires x86 target. https://lab.llvm.org/buildbot/#/builders/171/builds/7189 /home/tcwg-buildbot/worker/clang-armv7-quick/llvm/clang/t

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

2021-12-15 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

2021-12-15 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115429/new/ https://reviews.llvm.org/D115429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] c3b624a - [CodeGen] Avoid deprecated ConstantAddress constructor

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T10:42:41+01:00 New Revision: c3b624a191e09f1f16ce32f35b59fc4ca22ec780 URL: https://github.com/llvm/llvm-project/commit/c3b624a191e09f1f16ce32f35b59fc4ca22ec780 DIFF: https://github.com/llvm/llvm-project/commit/c3b624a191e09f1f16ce32f35b59fc4ca22ec780.diff

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

2021-12-15 Thread Amilendra Kodithuwakku via Phabricator via cfe-commits
amilendra added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:391-392 + if (!Arch.empty() && !isBranchProtectionSupportedArch(Arch)) +return false; + chill wrote: > On empty `Arch` it'd continue down the function, but we'd like to return >

[clang-tools-extra] 5298333 - [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN)

2021-12-15 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2021-12-15T10:58:30+01:00 New Revision: 529833377ccdf4381f8bc9961bfa96ec4f5e2eed URL: https://github.com/llvm/llvm-project/commit/529833377ccdf4381f8bc9961bfa96ec4f5e2eed DIFF: https://github.com/llvm/llvm-project/commit/529833377ccdf4381f8bc9961bfa96ec4f5e2eed.diff LO

[PATCH] D115650: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN)

2021-12-15 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG529833377ccd: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN) (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D92270: [ConstantFold] Fold more operations to poison

2021-12-15 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. I bisected an arm 32 bit issue with WebKit Javascript's infinity value (https://github.com/llvm/llvm-project/issues/52669) down to this commit. Just to make people aware there is another failing case. No reproducer yet I'm still working on a way to reduce it, but

[clang] 834c8ff - [CodeGen] Avoid some uses of deprecated Address constructor

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T11:13:10+01:00 New Revision: 834c8ff5879839d108af256dfd86bd498ac65efd URL: https://github.com/llvm/llvm-project/commit/834c8ff5879839d108af256dfd86bd498ac65efd DIFF: https://github.com/llvm/llvm-project/commit/834c8ff5879839d108af256dfd86bd498ac65efd.diff

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

2021-12-15 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well in the same patch since they are very similar? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___

[clang-tools-extra] b7d2d14 - [clangd] Disable the NOLINTBBEGIN testcase in clangd.

2021-12-15 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2021-12-15T11:32:27+01:00 New Revision: b7d2d147477e4fa5e34a3bb74b2a393cdaab9779 URL: https://github.com/llvm/llvm-project/commit/b7d2d147477e4fa5e34a3bb74b2a393cdaab9779 DIFF: https://github.com/llvm/llvm-project/commit/b7d2d147477e4fa5e34a3bb74b2a393cdaab9779.diff LO

[clang] bd9e239 - [analyzer] Expand conversion check to check more expressions for overflow and underflow

2021-12-15 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2021-12-15T11:41:34+01:00 New Revision: bd9e23943a2299804172da69b308533241f99b60 URL: https://github.com/llvm/llvm-project/commit/bd9e23943a2299804172da69b308533241f99b60 DIFF: https://github.com/llvm/llvm-project/commit/bd9e23943a2299804172da69b308533241f99b60.diff

[PATCH] D46081: [analyzer] Expand conversion check to check more expressions for overflow and underflow

2021-12-15 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd9e23943a22: [analyzer] Expand conversion check to check more expressions for overflow and… (authored by martong). Changed prior to commit: https://reviews.llvm.org/D46081?vs=144202&id=394502#toc Repo

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

2021-12-15 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie added a comment. When running my test case `ctu-lookup-name-with-space.cpp` on Windows, `llvm-lit` reports `'cp': command not found`. And this is the reason why it fails on Windows. And when I remove the `cp`s and replace them with original file names, clang reports `YAML:1:293: err

[clang] 481de0e - [CodeGen] Prefer CreateElementBitCast() where possible

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T11:48:39+01:00 New Revision: 481de0ed804c8547fbfac5fe88d109c692c8d117 URL: https://github.com/llvm/llvm-project/commit/481de0ed804c8547fbfac5fe88d109c692c8d117 DIFF: https://github.com/llvm/llvm-project/commit/481de0ed804c8547fbfac5fe88d109c692c8d117.diff

[PATCH] D115790: [Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine

2021-12-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, lxfind, aeubanks. ChuanqiXu added a project: clang. Herald added subscribers: ormris, steven_wu, hiraditya. ChuanqiXu requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Herald added a project:

[PATCH] D115650: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN)

2021-12-15 Thread Shraiysh via Phabricator via cfe-commits
shraiysh added a comment. Hey folks, this commit seems to cause multiple buildbot failures 1 2 3 . Can someone pleas

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread Peter Stys via Phabricator via cfe-commits
peterstys updated this revision to Diff 394503. peterstys added a comment. Applied fixes suggested by the reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/For

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread Peter Stys via Phabricator via cfe-commits
peterstys updated this revision to Diff 394505. peterstys marked 4 inline comments as done. peterstys added a comment. Removed braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/un

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread Peter Stys via Phabricator via cfe-commits
peterstys updated this revision to Diff 394506. peterstys marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: c

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

2021-12-15 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. In D115231#3194372 , @RKSimon wrote: > Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well > in the same patch since they are very similar? Hi, thanks for take a look at this. Yes, you're right. The reaso

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread Peter Stys via Phabricator via cfe-commits
peterstys added a comment. In D115738#3193107 , @MyDeveloperDay wrote: > I tested this on the original code that made me make the original change, and > I like your fix much better ;-) > > Thank you for this patch, interested on working on other C# clan

[PATCH] D115791: [CodeGen] Store ElementType in LValue

2021-12-15 Thread Nikita Popov via Phabricator via cfe-commits
nikic created this revision. nikic added reviewers: opaque-pointers, rjmccall. nikic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Store the pointer element type inside LValue so that we can preserve it when converting it back into an Ad

[PATCH] D115792: [Modules] Incorrect ODR detection for unresolved using type

2021-12-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, iains. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. See https://github.com/llvm/llvm-project/issues/52713. This patch is a attempt

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

2021-12-15 Thread Momchil Velikov via Phabricator via cfe-commits
chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:391-392 + if (!Arch.empty() && !isBranchProtectionSupportedArch(Arch)) +return false; + amilendra wrote: > chill wrote: > > On empty `Arch` it'd continue down the function, but we'd l

[clang] 90bbf79 - [CodeGen] Avoid some deprecated Address constructors

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T12:45:23+01:00 New Revision: 90bbf79c7b9330bba91f4f2abd4e0a43cb93e42b URL: https://github.com/llvm/llvm-project/commit/90bbf79c7b9330bba91f4f2abd4e0a43cb93e42b DIFF: https://github.com/llvm/llvm-project/commit/90bbf79c7b9330bba91f4f2abd4e0a43cb93e42b.diff

[PATCH] D115709: [RISCV] Remove Vamo Extention

2021-12-15 Thread Fraser Cormack via Phabricator via cfe-commits
frasercrmck added a comment. I think it'd be helpful for the description to note why this is being removed, what happened to the extension, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709 __

[PATCH] D115794: [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty

2021-12-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: Sam0523, HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/52715 Fixes #52715 `AllowShortBl

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

2021-12-15 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D102669#3194405 , @OikawaKirie wrote: > Should I disable this test case on Windows? Or is there any other approaches > to make it work on Windows? I'm fine with disabling this test on Windows. CHANGES SINCE LAST ACTION

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1870 // C# may break after => if the next character is a newline. if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { // calling `addUnwrappedLi

[PATCH] D113622: [analyzer] support ignoring use-after-free checking with reference_counted attribute

2021-12-15 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D113622#3193319 , @chrisdangelo wrote: > I've successfully exercised these changes against a large C / C++ project and > studied the output with @NoQ. Could you please share the results to have look? How can I reproduce and

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1872 // calling `addUnwrappedLine()` here causes odd parsing errors. FormatTok->MustBreakBefore = true; } part of me thinks the MustBre

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

2021-12-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:766 + + verifyFormat(R"(// +public class Sample { Nit: (only my preference) but I don't like the use of RawStrings in these tests (I know others have let them creep in

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thanks for this! Comment at: clang/www/cxx_status.html:1202 https://wg21.link/p0912r5";>P0912R5 - Partial + Partial (12) Rather than following this approach, it'd be nice to have the information provided di

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The failing precommit CI tests look to be unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

2021-12-15 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. > Does the langref need to be amended, first, or is it okay to interpret the > `readnone` attribute as it was clearly intended, without going through the > process of updating the langref first? > > I can update this review to use `__attribute__((pure))` for all address

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:651 +BUILTIN(__builtin_elementwise_floor, "v.", "nct") +BUILTIN(__builtin_elementwise_roundeven, "v.", "nct") +BUILTIN(__builtin_elementwise_trunc, "v.", "nct") The RFC does n

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2021-12-15 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Herald added a subscriber: carlosgalvezp. @aaron.ballman ping for review :) I do not intend to fix the raised issues with this revision. I think it is more valuable to get this check in and get more user-feedback. But the found bugs are on the todo-list! Repository:

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 394527. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115778/new/ https://reviews.llvm.org/D115778 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html

[PATCH] D115622: [Debugify] Optimize debugify original mode

2021-12-15 Thread Stephen Tozer via Phabricator via cfe-commits
StephenTozer accepted this revision. StephenTozer added a comment. This revision is now accepted and ready to land. Seems like a simple and sensible change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115622/new/ https://reviews.llvm.org/D115622

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2115 + +const auto *Arg = TheCall->getArg(0); +const VectorType *TyA = Arg->getType()->getAs(); Please spell out the type here (same below). Comment at: cl

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/www/cxx_status.html:1267-1270 +(12): The optimizer couldn't handle TLS with + `__attribute__((const))` attribute correctly. It implies that there would + be problems if the coroutine is possible to resume on a different thread.

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor wording fix. Thank you for this! Comment at: clang/www/cxx_status.html:1206-1207 + `__attribute__((const))` attribute correctly. There

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thanks for pinging on this, it had fallen off my radar! @JonasToth -- did you ever get the chance to talk with @cjdb about the overlap mentioned in https://reviews.llvm.org/D54943#2950100? (The other review also seems to have stalled out, so I'm not certain where

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2021-12-15 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. In D54943#3194643 , @aaron.ballman wrote: > Thanks for pinging on this, it had fallen off my radar! @JonasToth -- did you > ever get the chance to talk with @cjdb about the overlap mentioned in > https://reviews.llvm.org/D5494

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 394529. ChuanqiXu added a comment. Address comments. Thanks for reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115778/new/ https://reviews.llvm.org/D115778 Files: clang/www/cxx_status.html Inde

[clang] 5653d12 - [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2021-12-15T21:01:46+08:00 New Revision: 5653d127d7c454be2df1024b26f06612b79f4435 URL: https://github.com/llvm/llvm-project/commit/5653d127d7c454be2df1024b26f06612b79f4435 DIFF: https://github.com/llvm/llvm-project/commit/5653d127d7c454be2df1024b26f06612b79f4435.diff LO

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

2021-12-15 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5653d127d7c4: [docs] Give the reason why the support for coroutine is partial (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGE

[clang] d930c31 - [CodeGen] Pass element type to EmitCheckedInBoundsGEP()

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T14:03:33+01:00 New Revision: d930c3155c1ba5114ad12fc15635cb0a2480ac9f URL: https://github.com/llvm/llvm-project/commit/d930c3155c1ba5114ad12fc15635cb0a2480ac9f DIFF: https://github.com/llvm/llvm-project/commit/d930c3155c1ba5114ad12fc15635cb0a2480ac9f.diff

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

2021-12-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, dblaikie, rnk. Herald added subscribers: dexonsmith, jdoerfert, mgrang, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-

[PATCH] D114394: Compile-time computation of string attribute hashes

2021-12-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. Update: the strategy used by ``AttrBuilder`` might not be the best way to build new attributes. I've proposed an alternative implementation in https://reviews.llvm.org/D115798. This is somehow orthogonal to that patch, but it removes the need for temporary cop

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

2021-12-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. My plan mid-term plan would be to rename `AttrBuilder` into `AttrQuery` at some point, and use `SmallAttrBuilder` as the actual `AttrBuilder` in most places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/ne

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D54943#3194647 , @JonasToth wrote: > In D54943#3194643 , @aaron.ballman > wrote: > >> Thanks for pinging on this, it had fallen off my radar! @JonasToth -- did >> you ever get the

[clang] e7007b6 - [Sema] Add FixIt when a C++ out-of-line method has extra/missing const

2021-12-15 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2021-12-15T14:30:54+01:00 New Revision: e7007b69d43b36032975d759ab4ae473fb389851 URL: https://github.com/llvm/llvm-project/commit/e7007b69d43b36032975d759ab4ae473fb389851 DIFF: https://github.com/llvm/llvm-project/commit/e7007b69d43b36032975d759ab4ae473fb389851.diff LO

[PATCH] D115567: [Sema] Add FixIt when a C++ out-of-line method has extra/missing const

2021-12-15 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGe7007b69d43b: [Sema] Add FixIt when a C++ out-of-line method has extra/missing const (authored by sammccall). Changed prior to commit: https://reviews.llvm.or

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

2021-12-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D115243#3185393 , @kadircet wrote: > Yes and no. As mentioned SymbolSlabs are frozen once created and I totally > agree with the reasons there. But AFAICT in none of the indexes (apart from > monolithic FileIndex) we ever h

[PATCH] D113917: Add infrastructure to support matcher names.

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D113917#3193374 , @ymandel wrote: > Aaron - agreed on the points about `StringRef` vs `std::string`. But, before > I make that change, what did you think of moving to a more general method > `getMatcherSpec` that return

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

2021-12-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 394538. sammccall added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://reviews.llvm.org/D115243 Files: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp clang

[clang] b9492ec - [CodeGen] Avoid some pointer element type accesses

2021-12-15 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-12-15T14:46:10+01:00 New Revision: b9492ec649144976ec4748bdeebab9d5b92b67f4 URL: https://github.com/llvm/llvm-project/commit/b9492ec649144976ec4748bdeebab9d5b92b67f4 DIFF: https://github.com/llvm/llvm-project/commit/b9492ec649144976ec4748bdeebab9d5b92b67f4.diff

[PATCH] D115799: [clangd] Add ) to signature-help triggers

2021-12-15 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It is important for nested function calls. Repository: rG LLVM Gi

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

2021-12-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. (Our plan is to land this after new year some time, so that remote index servers don't get disrupted by format changes while people are on holiday) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://review

[clang-tools-extra] 517f1d9 - [clangd] Add ) to signature-help triggers

2021-12-15 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2021-12-15T14:56:27+01:00 New Revision: 517f1d9e5cd0b78b37eda83f58ed531f73b7a15c URL: https://github.com/llvm/llvm-project/commit/517f1d9e5cd0b78b37eda83f58ed531f73b7a15c DIFF: https://github.com/llvm/llvm-project/commit/517f1d9e5cd0b78b37eda83f58ed531f73b7a15c.dif

[PATCH] D115799: [clangd] Add ) to signature-help triggers

2021-12-15 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG517f1d9e5cd0: [clangd] Add ) to signature-help triggers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

2021-12-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 394542. serge-sans-paille added a comment. Leverage the fact that AttributeSet nodes are already sorted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.llvm.org/D115798 Files: clang/include/clang/CodeGen/CodeGe

[PATCH] D115794: [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty

2021-12-15 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115794/new/ https://reviews.llvm.org/D115794 ___ cfe-commits mailing list cfe-commits@lists.

[clang] b41bb6c - [Driver] Default to contemporary FreeBSD profiling behaviour

2021-12-15 Thread Ed Maste via cfe-commits
Author: Ed Maste Date: 2021-12-15T09:05:35-05:00 New Revision: b41bb6c1b715da77025962f736740c78128c78e1 URL: https://github.com/llvm/llvm-project/commit/b41bb6c1b715da77025962f736740c78128c78e1 DIFF: https://github.com/llvm/llvm-project/commit/b41bb6c1b715da77025962f736740c78128c78e1.diff LOG:

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

2021-12-15 Thread Ed Maste via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb41bb6c1b715: [Driver] Default to contemporary FreeBSD profiling behaviour (authored by emaste). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

2021-12-15 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. > The RFC does not mention this builtin. It specifies > `__builtin_elementwise_rint` and `__builtin_elementwise_round`. Is there a > reason why this uses `roundeven` instead and should there be other rounding > options provided at the same time? Well, I think there may

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

2021-12-15 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. I like the general direction. A possible reframing would be SmallAttrBuilder -> MutableAttributeSet. I think my main question here would be in which contexts we still use / want to use the old AttrBuilder? Comment at: llvm/include/llvm/IR/Attributes.h:9

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

2021-12-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. Actual benchmarks: https://llvm-compile-time-tracker.com/compare.php?from=7d97678df7f514c14b7611447dad02e9cc5168c9&to=f39a39e09e8f4f3b7dc94e4d23d9acfbf36ab2e5&stat=instructions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. Herald added a subscriber: mgorny. ymandel updated this revision to Diff 394325. ymandel added a comment. ymandel updated this revision to Diff 394417. ymandel updated this revision to Diff 394549. ymandel edited the summary of this revision. ymandel added reviewers:

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

2021-12-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 394553. sammccall marked an inline comment as done. sammccall added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D115728: [mlir][linalg] Replace LinalgOps.h and LinalgTypes.h by a single header.

2021-12-15 Thread Tobias Gysi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7f2c108eb87: [mlir][linalg] Replace LinalgOps.h and LinalgTypes.h by a single header. (authored by gysit). Changed prior to commit: https://revie

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

2021-12-15 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added subscribers: estewart08, ronlieb. ronlieb added a comment. Herald added a reviewer: bondhugula. Herald added a subscriber: sdasgup3. @estewart08 thoughts on a good CMAKE variable to allow users to define equivalent of /opt/rocm ? and not use environment variable inside the cmake

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

2021-12-15 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Diff was created without context unfortunately, scrolling through the cmake locally suggests variables have names of the form `LIBOMPTARGET_AMDGPU_FOO` though the namespacing isn't as consistent as it might be. Something like: if (not defined (LIBOMPTARGET_AM

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

2021-12-15 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:974 + SmallVector EnumAttrs; + SmallVector StringAttrs; + using iterator = typename SmallVector::iterator; nikic wrote: > Just wondering if storing both in one vector would

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2021-12-15 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.h:31 +WarnPointersAsValues(Options.get("WarnPointersAsValues", 0)), +TransformValues(Options.get("TransformValues", 1)), +TransformReferences

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.h:31 +WarnPointersAsValues(Options.get("WarnPointersAsValues", 0)), +TransformValues(Options.get("TransformValues", 1)), +TransformRefere

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

2021-12-15 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 394563. junaire added a comment. Explicitly speak out types for Arg, but don't repeat the vector type name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files: c

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

2021-12-15 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Note, my pre-merge check failure seems completely unrelated. It seems to have some problem with the some 'go' bindings, but I don't believe that has anything to do with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 394568. ymandel added a comment. updated file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files: clang/unittests/Analysis/FlowSensitive/CMakeLists.txt

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 394566. ymandel added a comment. Coalesce all CP files into one test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115740/new/ https://reviews.llvm.org/D115740 Files: clang/unittests/Analysis/FlowSensi

[PATCH] D115803: [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false.

2021-12-15 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/52724. This is rather a worka

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you also add a release note about the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115576/new/ https://reviews.llv

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

2021-12-15 Thread Sanjay Patel via Phabricator via cfe-commits
spatel created this revision. spatel added reviewers: MatzeB, neildhar, nikic, aqjune, dmgreen. Herald added a subscriber: mcrosier. spatel requested review of this revision. We got an unintended consequence of the optimizer getting smarter when compiling in a non-standard mode, and there's no go

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10389 +return false; + case UO_Minus: { +for (unsigned EltNum = 0; EltNum < VD->getNumElements(); ++EltNum) { Would it be worth handling ~ and ! as well given that they seem

[PATCH] D92270: [ConstantFold] Fold more operations to poison

2021-12-15 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:633 // the input constant. -return UndefValue::get(DestTy); +return PoisonValue::get(DestTy); } aqjune wrote: > neildhar wrote: > > spatel wrote: > > > MatzeB w

[clang-tools-extra] b7d5577 - [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

2021-12-15 Thread Markus Böck via cfe-commits
Author: Markus Böck Date: 2021-12-15T16:59:14+01:00 New Revision: b7d55771ce3ecc5c1768bd5877dbdd312f9ab0d7 URL: https://github.com/llvm/llvm-project/commit/b7d55771ce3ecc5c1768bd5877dbdd312f9ab0d7 DIFF: https://github.com/llvm/llvm-project/commit/b7d55771ce3ecc5c1768bd5877dbdd312f9ab0d7.diff L

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

2021-12-15 Thread Markus Böck via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d55771ce3e: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw… (authored by zero9178). Changed prior to commit: https://reviews.llvm.org/D115576?vs=393671&id=394575#toc Repos

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

2021-12-15 Thread Markus Böck via Phabricator via cfe-commits
zero9178 added a comment. In D115576#3194944 , @aaron.ballman wrote: > LGTM! Can you also add a release note about the fix? Addressed in the final commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1155

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

2021-12-15 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. Looks reasonable. Making float to int cast well defined is exactly why these intrinsics exist. Should we also drop the "string-float-cast-overflow" attribute, as UB is now prevented in a different way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115804/new/ ht

[PATCH] D115740: [clang][dataflow] Add simplistic constant-propagation analysis.

2021-12-15 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SingleVarConstantPropagationTest.cpp:69 + + friend bool operator==(ConstantPropagationLattice Element1, + ConstantPropagationLattice Element2) { Should this

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

2021-12-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { erichkeane wrote: > steffenlarsen wrote: > > erichkeane wrote:

[clang] da920c3 - [clang][deps] NFC: Move entry initialization into member functions

2021-12-15 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2021-12-15T16:39:29+01:00 New Revision: da920c3bcc794ee86c48f0e77eab4db068f17b5d URL: https://github.com/llvm/llvm-project/commit/da920c3bcc794ee86c48f0e77eab4db068f17b5d DIFF: https://github.com/llvm/llvm-project/commit/da920c3bcc794ee86c48f0e77eab4db068f17b5d.diff L

  1   2   3   >