[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. > I have a thought. Why do you need to change the LLVM data layout at all? > Clang's record layout is distinct from LLVM's data layout. This is similar to > how -malign-double works, which does not affect LLVM's data layout, it is > entirely a frontend change. We have

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir added a comment. https://reviews.llvm.org/harbormaster/unit/view/1536685/ Test failure seems unrelated to this patch. Unable to reproduce locally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 __

[PATCH] D115625: [clang-format] add support for cppm files

MyDeveloperDay updated this revision to Diff 394161. MyDeveloperDay added a comment. Add other support module file types for completeness CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115625/new/ https://reviews.llvm.org/D115625 Files: clang/tools/clang-format/clang-format-diff.py

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. In D115441#3189551 , @JohnReagan wrote: > Does any of this impact the -f128 support? We use f128 x-float on OpenVMS. > We've historically only aligned on 8-byte boundaries for legacy reasons (I'm > not opposed to having my ow

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

MyDeveloperDay updated this revision to Diff 394163. MyDeveloperDay added a comment. use endsWith() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115647/new/ https://reviews.llvm.org/D115647 Files: clang/lib/Format/NamespaceEndCommentsFixer.cpp clang/unittests/Format/NamespaceEndCo

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

melver reclaimed this revision. melver added a comment. > Let's consult libc's own documentation > https://www.gnu.org/software/libc/manual/html_node/Variable-Size-Automatic.html > > It states: > >> Automatic Storage with Variable Size >> The function alloca supports a kind of half-dynamic alloca

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 394173. schittir added a comment. Rebasing patch to see if the test failure will go away. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenF

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

jeroen.dobbelaere added inline comments. Comment at: clang/test/CodeGen/avoidTBAAonASMstore.cpp:3 +double foo(double z) { + // CHECK-LABEL: define{{.*}} double @_Z3food + unsigned short ControlWord; Shouldn't this be `STORE-LINE-LABEL: ...` ? CHANGES SINCE LA

[PATCH] D113237: [RISCV] Support I extension version 2.1

achieveartificialintelligence updated this revision to Diff 394174. achieveartificialintelligence added a comment. Support both i2p0 and i2p1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113237/new/ https://reviews.llvm.org/D113237 Files: clang

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 394176. schittir added a comment. Change CHECK-LABEL to STORE-LINE-LABEL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h clang

[PATCH] D115709: [RISCV] Remove Vamo Extention

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: kito-cheng, HsiangKai, arcbbb, jrtc27, craig.topper. Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna,

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

curdeius created this revision. curdeius added reviewers: aaron.ballman, hokein, bkramer, salman-javed-nz, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. curdeius requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

martong added a comment. In D115149#3188743 , @ASDenysPetrov wrote: >> @steakhal >> I don't get this one. I've provided a bunch of tests, even annotated with >> `no-crash` comments where we crashed prior to this change. > > I wasn't able to catch any cr

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

sberg added a comment. > So the check, for a file called e.g. "C:\test\test.h" would suggest the guard > C:_TEST_TEST_H being an invalid name due to the presence of the colon. ...though the new suggestion `C__TEST_TEST_H` isn't ideal either, in that it uses an identifier that is reserved for th

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @rnk @stella.stamenova How long do you think it will be before you can update your buildbots to VS2019 or VS2022 please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 _

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

salman-javed-nz added a comment. The problem at the root of all this is that llvm-header-guard isn't written flexible enough to support non-LLVM project structures. See https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp#L44 For a path like `C:

[PATCH] D115716: [Analyzer][BugReporter] Replace the example bug report with the one used to generate PathDiagnostic

OikawaKirie created this revision. OikawaKirie added reviewers: NoQ, steakhal, vsavchenko, ASDenysPetrov. OikawaKirie added a project: clang. Herald added subscribers: manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. OikawaKirie requ

[clang] 47eec78 - [clang][deps] Remove hard-coded resource directory from tests

Author: Jan Svoboda Date: 2021-12-14T10:59:47+01:00 New Revision: 47eec789ed9cc7d4cb9f1eaa0cafe3e509af015c URL: https://github.com/llvm/llvm-project/commit/47eec789ed9cc7d4cb9f1eaa0cafe3e509af015c DIFF: https://github.com/llvm/llvm-project/commit/47eec789ed9cc7d4cb9f1eaa0cafe3e509af015c.diff L

[PATCH] D115628: [clang][deps] Remove hard-coded resource directory from tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47eec789ed9c: [clang][deps] Remove hard-coded resource directory from tests (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

melver added a subscriber: tstellar. melver added a comment. @tstellar , we were told maybe you have some input. TLDR; - Clang and GCC appear to behave differently wrt `-ftrivial-auto-var-init=` on `__builtin_alloca()` (and VLAs?) - Clang's behavior is (per @jfb above) correct; - How to documen

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp:57 std::replace(Guard.begin(), Guard.end(), '-', '_'); + std::replace(Guard.begin(), Guard.end(), ':', '_'); Are there other characters we should be sa

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp:57 std::replace(Guard.begin(), Guard.end(), '-', '_'); + std::replace(Guard.begin(), Guard.end(), ':', '_'); salman-javed-nz wrote: > Are there other c

[PATCH] D115630: [CodeGen] Require use of Address::invalid() for invalid address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8d121eb1d61: [CodeGen] Require use of Address::invalid() for invalid address (NFC) (authored by nikic). Herald added a project: clang. Herald added

[clang] b8d121e - [CodeGen] Require use of Address::invalid() for invalid address (NFC)

Author: Nikita Popov Date: 2021-12-14T12:06:05+01:00 New Revision: b8d121eb1d619adca637bfd926d08a095c93b117 URL: https://github.com/llvm/llvm-project/commit/b8d121eb1d619adca637bfd926d08a095c93b117 DIFF: https://github.com/llvm/llvm-project/commit/b8d121eb1d619adca637bfd926d08a095c93b117.diff

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

curdeius added a comment. In D115715#3191742 , @sberg wrote: >> So the check, for a file called e.g. "C:\test\test.h" would suggest the >> guard C:_TEST_TEST_H being an invalid name due to the presence of the colon. > > ...though the new suggestion `C__T

[clang] b81450a - [CodeGen] Add std:: qualifier

Author: Nikita Popov Date: 2021-12-14T12:17:55+01:00 New Revision: b81450afb6529cd4d1eece46e9945caa5de51c11 URL: https://github.com/llvm/llvm-project/commit/b81450afb6529cd4d1eece46e9945caa5de51c11 DIFF: https://github.com/llvm/llvm-project/commit/b81450afb6529cd4d1eece46e9945caa5de51c11.diff

[PATCH] D115566: Quote some more destination paths with variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddcc02dbcc47: Quote some more destination paths with variables (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: [clang] 9791b58 - [C++20 Modules] Don't create global module fragment for extern linkage declaration in GMF already

Hi Richard, Sorry for disturbing. I sent https://reviews.llvm.org/D115610 to try to fix this. BTW, the example you posted might not work with libstdc++, here is a bug I reported: https://github.com/llvm/llvm-project/issues/51873 Thanks, Chuanqi --

[PATCH] D115425: [clangd] Generate ConfigFragment/YAML/docs from one tablegen source

sammccall added a comment. In D115425#3190740 , @nridge wrote: > In D115425#3190698 , @sammccall > wrote: > >>> there's perhaps a matter of principle where clangd should try to avoid >>> using code patterns (her

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. ping :) Any additional thoughts? Since the original concerns were raised both @manojgupta and myself tried to share a bit of additional background on the motivation and to clarify the difference between `-mXXX` and `-march`. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D115630: [CodeGen] Require use of Address::invalid() for invalid address

yubing added inline comments. Comment at: clang/lib/CodeGen/Address.h:79 class ConstantAddress : public Address { + ConstantAddress(nullptr_t) : Address(nullptr) {} + Has anyone encountered buildfail due to missing "std" before nullptr_t? Repository: rG LLV

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 394208. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inclu

[PATCH] D115673: [clang-format] C# switch expression formatting differs from normal switch formatting

MyDeveloperDay added a comment. In D115673#3191408 , @curdeius wrote: > LGTM. AFAIK (which is very limited when it comes to C#), the cases can have > also other expressions, not only ints and _. But that can be left for a > different patch. > Example fr

[PATCH] D115630: [CodeGen] Require use of Address::invalid() for invalid address

nikic added inline comments. Comment at: clang/lib/CodeGen/Address.h:79 class ConstantAddress : public Address { + ConstantAddress(nullptr_t) : Address(nullptr) {} + yubing wrote: > Has anyone encountered buildfail due to missing "std" before nullptr_t? Yeah, t

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

SjoerdMeijer added a comment. Ok, fair enough, perhaps adding features is a valid use-case. I will refrain from commenting on "things are terribly broken". I agree it is broken, but in a different way than suggested in previous comments. If others also think this makes sense, then here a few f

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. This patch should be ready to land. @tra, could you please commit this to the LLVM for us. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 _

[PATCH] D113237: [RISCV] Support I extension version 2.1

asb added a comment. @kito-cheng In D113237#3183969 , @kito-cheng wrote: > Here is a long discussion[1] at 2019, at that moment I think we all agree > -misa-spec is a good solution, > > However it's kind of awkward for this scheme is ISA spec changing

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 394224. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp clang/lib/Sema/SemaExpr.cpp clang/test/

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

kadircet added a comment. Hi @salman-javed-nz ! Thanks for the great work and working on the performance improvements. Just FYI, we are also disabling this in clangd's clang-tidy integration as it is increasing the latency of diagnostic generation. It would be great if you also provided some up

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

aaron.ballman added a comment. In D115715#3191842 , @curdeius wrote: > In D115715#3191742 , @sberg wrote: > >>> So the check, for a file called e.g. "C:\test\test.h" would suggest the >>> guard C:_TEST_TEST_H bei

[PATCH] D115650: [clangd] Disable support for clang-tidy suppression blocks (NOLINTBEGIN)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. I am a little worried about the discrepancy we'll get here, but (un)fortunately it won't be the first with clang-tidy. Also gave the author a headsup in https://reviews.llvm.org/D108560#31

[PATCH] D115670: Correct behavior of Vector boolean-operations, implement vector operator-

erichkeane updated this revision to Diff 394230. erichkeane added a comment. Enable __int128 vectors, and fix the issue of the >64 bit vectors for negation. Also add a test for these. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115670/new/ https://reviews.llvm.org/D115670 Files:

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115253/new/ https://reviews.llvm.org/D115253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D115728: [mlir][linalg] Replace LinalgOps.h and LinalgTypes.h by a single header.

gysit created this revision. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, armkevincheng, jsmolens, eric-k256, dcaballe, cota, mravishankar, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, luc

[PATCH] D115728: [mlir][linalg] Replace LinalgOps.h and LinalgTypes.h by a single header.

gysit added a comment. After removing the last Linalg Type in https://reviews.llvm.org/D115727, I think it would make sense to merge the LinalgTypes.h and LinalgOp.h headers. However, this causes quite of header fixes in downstream projects. We can also abandon this revision if preferred. Rep

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

frasercrmck added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:230 +// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s +// CHECK-V-MINVLEN: __riscv_v_min_vlen 128 Are we able to test non-default values of `__riscv_v_min_vlen` he

[clang] 6482383 - [clang-format] FixNamespaceComments does not understand namespace aliases

Author: mydeveloperday Date: 2021-12-14T14:53:04Z New Revision: 6482383e50a4f02e337e7ce61a471e6295f008e4 URL: https://github.com/llvm/llvm-project/commit/6482383e50a4f02e337e7ce61a471e6295f008e4 DIFF: https://github.com/llvm/llvm-project/commit/6482383e50a4f02e337e7ce61a471e6295f008e4.diff LOG

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6482383e50a4: [clang-format] FixNamespaceComments does not understand namespace aliases (authored by MyDeveloperDay). Repository: rG LLVM Github M

[clang] cea81e9 - [clang-format] add support for cppm files

Author: mydeveloperday Date: 2021-12-14T14:55:38Z New Revision: cea81e95b05f92d1dd24547e086ec97b9510634a URL: https://github.com/llvm/llvm-project/commit/cea81e95b05f92d1dd24547e086ec97b9510634a DIFF: https://github.com/llvm/llvm-project/commit/cea81e95b05f92d1dd24547e086ec97b9510634a.diff LOG

[PATCH] D115625: [clang-format] add support for cppm files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcea81e95b05f: [clang-format] add support for cppm files (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:70 - bool validateBranchProtection(StringRef, BranchProtectionInfo &, + bool validateBranchProtection(StringRef, StringRef, BranchProtectionInfo &, StringRef &) const o

[PATCH] D115685: [NFC] Fix typos in release notes

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115685/new/ https://reviews.llvm.org/D115685 ___

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

peterstys created this revision. peterstys added a reviewer: MyDeveloperDay. peterstys requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The alignment fix introduced by https://reviews.llvm.org/D104388 caused a regression whereby formatting

[PATCH] D115685: [NFC] Fix typos in release notes

Mordante accepted this revision. Mordante added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115685/new/ https://reviews.llvm.org/D115685 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 ___ cfe-commits mail

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna marked 5 inline comments as done. luna added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:396 + } + // Identifies a function as unreachable if and only if + // 1) All summaries are live. tejohnson wrote: > Actually I think w

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 394281. luna marked 2 inline comments as done. luna added a comment. Revise based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: clang/test/CodeGe

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm after adding a description to test as noted below. Comment at: llvm/test/ThinLTO/X86/devirt_hybrid_after_filtering_unreachable.ll:1 +; Generate split module with s

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov updated this revision to Diff 394290. ASDenysPetrov added a comment. Changed handler `check::` functions. Reworked. Covered more cases. Several cases left (marked as FIXME in the test file). For the glance some of them we can't handle because of (possibly) wrong symbolic modeling.

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 394291. aaron.ballman added a reviewer: joerg. aaron.ballman added a comment. Updating based on off-list review feedback and adding a new reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115253/new/ https://reviews.llvm.org/D115253 Fil

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added a comment. In D115253#3192652 , @aaron.ballman wrote: > Updating based on off-list review feedback and adding a new reviewer. This added `DefineTypeSizeAndWidth()` as a helper for setting the `_MAX` and `_WIDTH` macros as a pair and

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 394293. luna added a comment. Describe what the test case devirt_hybrid_after_filtering_unreachable.ll is for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: c

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna added a comment. In D115492#3192624 , @tejohnson wrote: > lgtm after adding a description to test as noted below. Done. Thanks for review and feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

salman-javed-nz added a comment. In D115715#3192085 , @aaron.ballman wrote: > It could be made to be useful outside of LLVM, but as it stands today, the > check is only intended to be useful for LLVM. If we want to make it useful > outside of LLVM, tha

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

jyknight added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__", Twine(TI.

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. @martong wrote: > Denis, you can see in the `Revision Contents` that Diff 3 has the baseline > commit `63a6348`. When I check out `63a6348` then the newly added test file > triggers the assertion about `BO_Add`. Yes is see it: F21029827: image.png

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

peterstys updated this revision to Diff 394299. peterstys added a comment. Applied clang-formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cp

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. In D108560#3192081 , @kadircet wrote: > Hi @salman-javed-nz ! > Also I am not sure what kind of timelines you have in mind for the > performance improvements, but I think it would be great to have them before > LLVM-14 r

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1042de90589c: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie (authored by MaskRay). Changed prior to commit: https://

[clang] 0419242 - [Clang][ScanDeps] Use the virtual path for module maps

Author: Michael Spencer Date: 2021-12-14T11:21:42-07:00 New Revision: 04192422c4e3b730c580498b8e948088cb15580b URL: https://github.com/llvm/llvm-project/commit/04192422c4e3b730c580498b8e948088cb15580b DIFF: https://github.com/llvm/llvm-project/commit/04192422c4e3b730c580498b8e948088cb15580b.dif

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04192422c4e3: [Clang][ScanDeps] Use the virtual path for module maps (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 4e94cba - [HIPSPV][2/4] Add HIPSPV tool chain

Author: Henry Linjamäki Date: 2021-12-14T10:22:38-08:00 New Revision: 4e94cba5b4e431794026085b89a34112b2d9ac0d URL: https://github.com/llvm/llvm-project/commit/4e94cba5b4e431794026085b89a34112b2d9ac0d DIFF: https://github.com/llvm/llvm-project/commit/4e94cba5b4e431794026085b89a34112b2d9ac0d.dif

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94cba5b4e4: [HIPSPV][2/4] Add HIPSPV tool chain (authored by linjamaki, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:900-903 + Builder.defineMacro("__USHRT_WIDTH__", Twine(TI.getShortWidth())); + Builder.defineMacro("__UINT_WIDTH__", Twine(TI.getIntWidth())); + Builder.defineMacro("__ULONG_WIDTH__", Twin

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3191752 , @RKSimon wrote: > @rnk @stella.stamenova How long do you think it will be before you can update > your buildbots to VS2019 or VS2022 please? The mlir buildbot was updated already. The lldb buildbot

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added a comment. In D115503#3191156 , @Esme wrote: > In D115503#3188302 , @dblaikie > wrote: > >> Got any data on how much this (combined with the LLVM patch) increases debug >> info size of, say, a cla

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman updated this revision to Diff 394320. aaron.ballman added a comment. Updated based on review feedback. This protects all of the _WIDTH macros in stdint.h, which was a previous oversight. It also corrects the test case to actually test the scenario we care about (which requires that

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. ping:-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. Hi @aaron.ballman, does this make sense to you? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-

[clang] bc5f2d1 - [clang] diagnose_as_builtin attribute for Fortify diagnosing like builtins.

Author: Michael Benfield Date: 2021-12-14T19:42:23Z New Revision: bc5f2d12cadce765620efc56a1ca815221db47af URL: https://github.com/llvm/llvm-project/commit/bc5f2d12cadce765620efc56a1ca815221db47af DIFF: https://github.com/llvm/llvm-project/commit/bc5f2d12cadce765620efc56a1ca815221db47af.diff L

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5f2d12cadc: [clang] diagnose_as_builtin attribute for Fortify diagnosing like builtins. (authored by mbenfield). Repository: rG LLVM Github Mono

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

estewart08 added a comment. In D115661#3190477 , @yaxunl wrote: > This may cause perf regressions for HIP. Do you have a test that would show such a regression? Emitting a store to address space (4) in a constructor seems the wrong thing to do. =

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

aaron.ballman added a comment. Thanks for the fix for this -- I think the changes look like they're correct, but the test coverage needs a bit of work. Comment at: clang/lib/Sema/SemaDecl.cpp:9191 << FixItHint::CreateInsertion(InsertLoc, "<>"); + NewFD->s

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Lexer/pragma-message.c:14 #define STRING(x) STRING2(x) -#pragma message(":O I'm a message! " STRING(__LINE__)) // expected-warning {{:O

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

dexonsmith added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:106-108 + std::unique_ptr OriginalContents; + std::unique_ptr MinimizedContents; PreprocessorSkippedRangeMapping PPSkippedRangeMapping; --

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

thakis created this revision. thakis added a reviewer: MaskRay. Herald added subscribers: mikhail.ramalho, mgorny. thakis requested review of this revision. See D28294 for context. https://reviews.llvm.org/D115751 Files: clang/test/CMakeLists.txt clang/test

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

MyDeveloperDay added a comment. I tested this on the original code that made me make the original change, and I like your fix much better ;-) Thank you for this patch, interested on working on other C# clang-format issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ http

[clang] 09a704c - [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO.

Author: Mingming Liu Date: 2021-12-14T20:18:04Z New Revision: 09a704c5efba2c07af5b457bf3afc5eb746f22c2 URL: https://github.com/llvm/llvm-project/commit/09a704c5efba2c07af5b457bf3afc5eb746f22c2 DIFF: https://github.com/llvm/llvm-project/commit/09a704c5efba2c07af5b457bf3afc5eb746f22c2.diff LOG:

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09a704c5efba: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO. (authored by luna). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394351. ychen added a comment. - Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/temp/te

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394352. ychen added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/temp/temp.spec/temp.expl.s

[PATCH] D113917: Add infrastructure to support matcher names.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:88 +/// can be useful for cases like debugging matchers. +template std::string makeMatcherNameFromType() { + return "Matcher"; ymandel wrote: > Please note in

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115751/new/ https://reviews.llvm.org/D115751 ___ cfe-commits mailing list cfe

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl added a comment. In D115661#3192983 , @estewart08 wrote: > In D115661#3190477 , @yaxunl wrote: > >> This may cause perf regressions for HIP. > > Do you have a test that would show such a regression? Emitti

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3193152 , @yaxunl wrote: > In D115661#3192983 , @estewart08 > wrote: > >> In D115661#3190477 , @yaxunl wrote: >> >>> This may cause per

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 394353. Anastasia added a comment. Addressed review comments from Sven: - Improved docs and code comments; - Simplified tests; - Added warning in a group. - Aligned with translator PRs after merge. Note, that this change now references documentation from P

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

JonChesterfield added a comment. Changing the has-constant-initialiser check to a more precise/robust one sounds reasonable to me. In D115661#3193157 , @arsenm wrote: > The backend also knows because the constant flag is set on the global > variable. A

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true; Yo

  1   2   >