[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2590 + llvm::Regex RawStringRegex( + "R\"([A-Za-z0-9_{}#<>%:;.?*+/^&\\$|~!=,'\\-]*)\\("); + SmallVector RawStringMatches; I'm picky but you missed `[` and `]`, no? C

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;break; case options::OPT_fno_approx

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

snehasish added a comment. @xur Could you please take a look with a focus on ensuring that this change retains the semantics that you expect? Previously there were different enum values which indicated CS+IR vs IR only. Now the IR bit is set for both cases (to be consistent with the version mas

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:145 + if ((!ReceivingCallExpr || + ReceivingCallExpr->getDirectCallee()->isTemplateInstantiation()) && + (!ReceivingConstructExpr || ---

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple amdgcn-am

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 393247. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/ms-thread_local.cpp Index: clang/test/CodeGenCXX/ms-thread_local.cpp =

[PATCH] D115379: ASTMatchers: Avoid using SmallVector::set_size()

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115379/new/ https://reviews.llvm.org/D115379

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2590 + llvm::Regex RawStringRegex( + "R\"([A-Za-z0-9_{}#<>%:;.?*+/^&\\$|~!=,'\\-]*)\\("); + SmallVector RawStringMatches; curdeius wrote: > I'm picky but you missed `[` and `]`,

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith added a comment. Returning from https://reviews.llvm.org/D115421, it looks like that `raw_string_ostream` has unbuffered by default since 65b13610a5226b84889b923bae884ba395ad084d . Seems like all the new `flush()`s

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2590 + llvm::Regex RawStringRegex( + "R\"([A-Za-z0-9_{}#<>%:;.?*+/^&\\$|~!=,'\\-]*)\\("); + SmallVector RawStringMatches; MyDeveloperDay wrote: > curdeius wrote: > > I'm picky but you

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

yaxunl added a comment. In D115283#3183034 , @JonChesterfield wrote: > In D115283#3182879 , @yaxunl wrote: > >> In D115283#3181128 , >> @JonChesterfield wrote: >> >>> No

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 updated this revision to Diff 393262. logan-5 added a comment. Removed `.flush()`es. Seems like this might be able to land without https://reviews.llvm.org/D115421? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115374/new/ https://reviews.

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

melver abandoned this revision. melver added a comment. GCC devs say that initializing explicit alloca() is a bug, because they aren't "automatic storage": https://lkml.kernel.org/r/20211209201616.gu...@gate.crashing.org .. which is also the reason why GCC's behaviour differs here at the moment.

[PATCH] D113623: [OpenMP][FIX] Pass the num_threads value directly to parallel_51

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc9c4d7216a5: [OpenMP][FIX] Pass the num_threads value directly to parallel_51 (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113623/ne

[clang] bc9c4d7 - [OpenMP][FIX] Pass the num_threads value directly to parallel_51

Author: Joseph Huber Date: 2021-12-09T16:30:29-05:00 New Revision: bc9c4d7216a5bcdeec8543834fe1451db2c46e5c URL: https://github.com/llvm/llvm-project/commit/bc9c4d7216a5bcdeec8543834fe1451db2c46e5c DIFF: https://github.com/llvm/llvm-project/commit/bc9c4d7216a5bcdeec8543834fe1451db2c46e5c.diff

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 393278. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D115374#3183776 , @logan-5 wrote: > Removed `.flush()`es. Seems like this might be able to land without > https://reviews.llvm.org/D115421?

[PATCH] D113237: [RISCV] Support I extension version 2.1

kito-cheng added a comment. There is several issue around the default extension version stuffs. - Should we add `-misa-spec=` option to Clang/LLVM? - Behavior for `zifencei` and `zicsr` with `i` 2.0? - How to encode the extension version in LLVM? by attribute or module flags? --- Should we add

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, efriedma, jyknight, craig.topper. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that the following case would compile in Clang but not

[PATCH] D113237: [RISCV] Support I extension version 2.1

jrtc27 added a comment. Outside of the I/F/D special cases, where F/D don't really matter and I2p0 is just I2p1Zicsr2p0_Zifencei2p0,, I thought the new policy was that ratified extensions would never be changed, only new extensions published, and thus version numbers are basically irrelevant ot

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

dexonsmith added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:106-108 + std::unique_ptr OriginalContents; + std::unique_ptr MinimizedContents; PreprocessorSkippedRangeMapping PPSkippedRangeMapping; --

[PATCH] D113943: Add `withIntrospection` matcher.

avogelsgesang added a comment. Nit: Personally, I would prefer the name `withDebugOutput` over `withIntrospection`, as it more clearly describes the intent of this matcher. At least to me, "introspection" is usually something done programatically, i.e. the matcher somehow reflects about its own

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. In D111617#3183146 , @HsiangKai wrote: > Release build: > Before this patch: > > text data bssdec hex > 115471733 7987112 443760 123902605 7629a8d ./bin/clang > > After this patch:

[clang] 715c72b - [NFC][analyzer] Return underlying strings directly instead of OS.str()

Author: Logan Smith Date: 2021-12-09T16:05:46-08:00 New Revision: 715c72b4fbf43d00909ebc9677d59ce8bb24bc23 URL: https://github.com/llvm/llvm-project/commit/715c72b4fbf43d00909ebc9677d59ce8bb24bc23 DIFF: https://github.com/llvm/llvm-project/commit/715c72b4fbf43d00909ebc9677d59ce8bb24bc23.diff L

[clang] 08eb614 - [NFC][testing] Return underlying strings directly instead of OS.str()

Author: Logan Smith Date: 2021-12-09T16:05:46-08:00 New Revision: 08eb614e309048b695a9eb0d94e636b2324de094 URL: https://github.com/llvm/llvm-project/commit/08eb614e309048b695a9eb0d94e636b2324de094 DIFF: https://github.com/llvm/llvm-project/commit/08eb614e309048b695a9eb0d94e636b2324de094.diff L

[clang] ad17ea1 - [NFC][AST] Return underlying strings directly instead of OS.str()

Author: Logan Smith Date: 2021-12-09T16:05:46-08:00 New Revision: ad17ea12e70abb05b6984f530618131181be9dad URL: https://github.com/llvm/llvm-project/commit/ad17ea12e70abb05b6984f530618131181be9dad DIFF: https://github.com/llvm/llvm-project/commit/ad17ea12e70abb05b6984f530618131181be9dad.diff L

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

This revision was automatically updated to reflect the committed changes. Closed by commit rG715c72b4fbf4: [NFC][analyzer] Return underlying strings directly instead of OS.str() (authored by logan-5). Changed prior to commit: https://reviews.llvm.org/D115374?vs=393262&id=393319#toc Repository:

[clang] 0cf6f7b - [NFC][clang] Return underlying strings directly instead of OS.str()

Author: Logan Smith Date: 2021-12-09T16:05:46-08:00 New Revision: 0cf6f7b128dd457711ba5c0ebfcb8143dc1632f8 URL: https://github.com/llvm/llvm-project/commit/0cf6f7b128dd457711ba5c0ebfcb8143dc1632f8 DIFF: https://github.com/llvm/llvm-project/commit/0cf6f7b128dd457711ba5c0ebfcb8143dc1632f8.diff L

[clang] 5276002 - [NFC][Sema] Return underlying strings directly instead of OS.str()

Author: Logan Smith Date: 2021-12-09T16:05:46-08:00 New Revision: 5276002a89b9aeb4c5f920d627630b1637c68ddc URL: https://github.com/llvm/llvm-project/commit/5276002a89b9aeb4c5f920d627630b1637c68ddc DIFF: https://github.com/llvm/llvm-project/commit/5276002a89b9aeb4c5f920d627630b1637c68ddc.diff L

[clang] 5336bef - [NFC][tools] Return underlying strings directly instead of OS.str()

Author: Logan Smith Date: 2021-12-09T16:05:46-08:00 New Revision: 5336befe8c3cde08cec020583700b4d2ba25ac16 URL: https://github.com/llvm/llvm-project/commit/5336befe8c3cde08cec020583700b4d2ba25ac16 DIFF: https://github.com/llvm/llvm-project/commit/5336befe8c3cde08cec020583700b4d2ba25ac16.diff L

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

Carrot added a comment. I'm trying to understand the problem in this pass. It looks both of @thopre's and @lebedev.ri's problems are loop related. Is there any other regression not loop related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. In D115441#3182938 , @craig.topper wrote: > Doesn’t icc also emit code into main to change the FPCW precision control > field? Is making long double 80 bits useful if you don’t increase the > precision in hardware? Yes, but it

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. This change broke our kernel build. I believe that the issue is that the compiler doesn't consider function attributes. This can be trivially reproduced as: $ cat >t.c < EOF $ ./bin/clang -c t.c -o t.o -mno-sse In file included from t.c:1: In file included from

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. Note that GCC had the same issue in the past https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80298 which was later addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114782/new/ https://reviews.llvm.org/D114782

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid updated this revision to Diff 393335. starsid added a comment. rebase and resurrect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 Files: compiler-rt/lib/builtins/extendhftf2.c compiler-rt/lib/

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

pengfei added a comment. Hi @phosek , thanks for reporting it. I would consider it as a misuse of the header file when SSE is not usable, especially we now have the specific header "x86gprintrin.h" for such scenarios. Can you help to try if changing to "x86gprintrin.h" works? Repository: rG

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid updated this revision to Diff 393340. starsid added a comment. fix commit author name and email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 Files: compiler-rt/lib/builtins/extendhftf2.c comp

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid added a comment. I have tried my best to follow the conversation here and complete this patch. Please let me know if it is missing something, or if I need to assign new reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ h

[PATCH] D115484: [clangd] Include-fixer: handle more "incomplete type" diags, clean up tests

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay, ilya-biryukov. Herald added a reviewer: jdoerfert. Herald added a project: cla

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

joerg added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;break; case options::OPT_fno_approx_func:

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

jyknight added a comment. It's rather sad that GCC made the quite-unintuitive decision to number the arguments in this way -- LONG AFTER clang had already implemented the other way... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/ http

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. In D114782#3184317 , @pengfei wrote: > Hi @phosek , thanks for reporting it. > I would consider it as a misuse of the header file when SSE is not usable, > especially we now have the specific header "x86gprintrin.h" for such > sc

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

phosek added a comment. In D114782#3184406 , @phosek wrote: > In D114782#3184317 , @pengfei wrote: > >> Hi @phosek , thanks for reporting it. >> I would consider it as a misuse of the header file when SSE is not u

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7c07f60b35f: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11522

[clang] d7c07f6 - [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

Author: Phoebe Wang Date: 2021-12-10T09:29:38+08:00 New Revision: d7c07f60b35f901f5bd9153b11807124a9bdde60 URL: https://github.com/llvm/llvm-project/commit/d7c07f60b35f901f5bd9153b11807124a9bdde60 DIFF: https://github.com/llvm/llvm-project/commit/d7c07f60b35f901f5bd9153b11807124a9bdde60.diff L

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

pengfei added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115225/new/ https://reviews.llvm.org/D115225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers added a comment. In D115471#3184384 , @jyknight wrote: > It's rather sad that GCC made the quite-unintuitive decision to number the > arguments in this way -- LONG AFTER clang had already implemented the other > way... I doubt it was in

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

apinski-cavium added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98096 GCC even documents it this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/ https://reviews.llvm.org/D115471 _

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

shafik added a comment. LGTM but I want to give a chance for others to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new/ https://reviews.llvm.org/D115355 ___ cfe-commits mailing list cf

[clang] 925ec98 - Revert "[X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits"

Author: Phoebe Wang Date: 2021-12-10T10:31:09+08:00 New Revision: 925ec98d000a9df7749e93e8831282cbbb5839b2 URL: https://github.com/llvm/llvm-project/commit/925ec98d000a9df7749e93e8831282cbbb5839b2 DIFF: https://github.com/llvm/llvm-project/commit/925ec98d000a9df7749e93e8831282cbbb5839b2.diff L

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

pengfei added a comment. Oh, that makes sense to me. Reverted and I will investigate it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114782/new/ https://reviews.llvm.org/D114782 ___ cfe-commits

[PATCH] D114569: [PowerPC] Require htm feature for HTM builtins

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114569/new/ https://reviews.llvm.org/D114569 __

[PATCH] D115490: [clangd] Include fixer for missing functions in C

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. A function call `unreso

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

ychen added a comment. In D114728#3159303 , @rjmccall wrote: > I agree that coroutine resumption functions have a different formal type from > the ramp function and so would need different treatment from > `-fsanitize=functions` if it wants to sanitize

[clang] e308b8e - [RISCV] Fix arch string parsing for multi-character extensions

Author: eopXD Date: 2021-12-09T21:13:44-08:00 New Revision: e308b8e0c71b5ce783035d73722f59d395245cf9 URL: https://github.com/llvm/llvm-project/commit/e308b8e0c71b5ce783035d73722f59d395245cf9 DIFF: https://github.com/llvm/llvm-project/commit/e308b8e0c71b5ce783035d73722f59d395245cf9.diff LOG: [R

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe308b8e0c71b: [RISCV] Fix arch string parsing for multi-character extensions (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/

[clang] a4bf1b4 - [RISCV] Unify depedency check and extension implication parsing logics

Author: eopXD Date: 2021-12-09T21:16:04-08:00 New Revision: a4bf1b449dc0691e182db879bfb53bc52fbf11b7 URL: https://github.com/llvm/llvm-project/commit/a4bf1b449dc0691e182db879bfb53bc52fbf11b7 DIFF: https://github.com/llvm/llvm-project/commit/a4bf1b449dc0691e182db879bfb53bc52fbf11b7.diff LOG: [R

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4bf1b449dc0: [RISCV] Unify depedency check and extension implication parsing logics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11235

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393381. schittir added a comment. Updated test per Jeroen's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeGenFunction.h clang/l

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir added a comment. In D115320#3182581 , @jeroen.dobbelaere wrote: > When I try out the example on llvm-13, I get a 'omnipotent char' tbaa > description. That should be ok in general. When I replace the 'float > _Complex' with 'double', I do get

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna created this revision. Herald added subscribers: ormris, pengfei, arphaman, steven_wu, hiraditya, inglorion. luna requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - In FunctionSummary, add a new bit `mustBeUnreachable

<    1   2