[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1271 OS << " = " << *P.Default; + if (P.Type && P.Type->AKA) +OS << llvm::formatv(" (aka {0})", *P.Type->AKA); lh123 wrote: > sammccall wrote: > > kadircet wrote: > > > sammccal

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 392446. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 Files: clang/lib/Driver/ToolChains/MSVC.cpp compiler-rt/cmake/config-ix.cmake compiler-rt/lib/lsan/CMakeLists.txt compiler-rt/lib/lsan/ls

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392450. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp llvm/include/llvm/ADT/Triple.h Index: llvm/include/llvm/ADT/Triple

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3873 + let Subjects = SubjectList<[Function]>; + let LateParsed = 1; + let Documentation = [DiagnoseAsBuiltinDocs]; Why does this need to be late parsed? I don't think the argum

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3176852 , @clemenswasser wrote: > Split this patch up into multiple smaller ones: > > - D115186 > - D115204 > - D115262

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

aaron.ballman added a comment. I'm not opposed to the idea of issuing this diagnostic when it's explicitly enabled, but the changes aren't quite correct. `ext_mixed_decls_code` is defined as an `Extension` in DiagnosticSemaKinds.td, which means that these changes will cause us to issue a pedant

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. In D115140#3176800 , @stuij wrote: > @danielkiss Yes that needs to be addressed, but we are doing that in another > patch that will (hopefully

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 392471. ellis added a comment. Add a proper warning and simplify compiler-rt profile writer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

tra added a comment. In D110622#3176804 , @yaxunl wrote: >>> So, the question is -- what's the right way to specify something like this >>> in a consistent manner? >>> `--offload` option proposed here does not seem to be a good fit. It was >>> intended

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray added a comment. Ping. Ready to review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392477. dgoldman added a comment. Add HeaderSearch tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h clang/lib/

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2588-2594 +if (isa(C) || isa(C) || +isa(C) || isa(C) || +isa(C) || isa(C) || +

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:271 + /// Describes hover preferences. + struct HoverBlock { +/// Whether hover show a.k.a type. kadircet wrote: > lh123 wrote: > > sammccall wrote: > > > One question is

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

rjmccall added a comment. In D115219#3175660 , @ChuanqiXu wrote: > In D115219#3175582 , @rjmccall > wrote: > >> I agree that you shouldn't call `suspend`, but doesn't `coro.end` have the >> behavior of marking t

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

rjmccall added a comment. The only alternative to this that I can see would be for the invalid code to produce more valid-seeming AST. Are deduction guides just not normally allowed for methods? Also, while I don't think it would eliminate the need to be defensive here, our recovery from misna

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

rjmccall added a comment. Like a lot of the switched-resume lowering, this intrinsic is extremely tied to C++ semantics. If C++ doesn't actually allow the optimization anymore, then I completely agree that we should go ahead and remove the intrinsic. If it's allowed and we just haven't implem

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

erichkeane added a comment. In D112616#3177261 , @rjmccall wrote: > The only alternative to this that I can see would be for the invalid code to > produce more valid-seeming AST. > > Are deduction guides just not normally allowed for methods? > > Also, w

Re: [PATCH] D114665: [clangd] Make a.k.a printing configurable.

SG if you also considered the style block. I suppose the risks of having this in a feature-specific block is much lower. On Tue, Dec 7, 2021, 20:14 Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added inline comments. > > > > Comment at: clang-tools-ext

[clang] c4582a6 - [Analysis] Ignore casts and unary ops for uninitialized values

Author: Bill Wendling Date: 2021-12-07T11:49:18-08:00 New Revision: c4582a689c2c74e0635309979176c7ada086f066 URL: https://github.com/llvm/llvm-project/commit/c4582a689c2c74e0635309979176c7ada086f066 DIFF: https://github.com/llvm/llvm-project/commit/c4582a689c2c74e0635309979176c7ada086f066.diff

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4582a689c2c: [Analysis] Ignore casts and unary ops for uninitialized values (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ h

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392496. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp llvm/include/llvm/ADT/Triple.h Index: llvm/include/llvm/ADT/Triple

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/CMakeLists.txt:1 +set(LLVM_LINK_COMPONENTS + Support Why create a new sub directory? From what I've seen elsewhere, it seems uncommon. I'm fine either way, but want to be sure we

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added a comment. This change for the profile writer looks good to me! Before signing it off, I'd like to hear any other suggestions or opinions from @davidxl @MaskRay @alanphipps since this is technically the very first change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3175301 , @dblaikie wrote: > Not super surprising that lldb might not be able to deal with DWARF in this > shape - is LLDB support important to you/something you plan to work on for > this DWARF? Otherwise we might need

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added a comment. In D110622#3177111 , @tra wrote: > In D110622#3176804 , @yaxunl wrote: > So, the question is -- what's the right way to specify something like this in a consistent manner?

RFC: proposing to relax standardization requirements for Clang extensions

tl;dr: our Clang "get involved" page implies that proposed extensions to Clang must also be proposed to a standards committee (https://clang.llvm.org/get_involved.html#criteria). This is a good goal, but is not inclusive or something we enforce with any consistency. I'm proposing to clarify our goa

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

tra added a comment. In D110622#3177490 , @yaxunl wrote: > I don't think `--offload=` is restricted to be specified only once. The test > checks `--offload-arch=` and `--offload=` are mutually exclusive. It effectively is. See my inline comment. // R

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf reopened this revision. brunodf added a comment. This revision is now accepted and ready to land. When the previous diff was committed, two problems were discovered in the buildbots: 1. One pattern in the `PR51855.cpp` test failed on certain targets due to a difference in calling conven

Re: RFC: proposing to relax standardization requirements for Clang extensions

Hi Aaron, FWIW, I like your new wording (and rationale for it) better than the old wording. Of course I've got a conflict of interest, because of P1144 [[trivially_relocatable]] and P2266 "Simpler implicit move" and so on. ;) This sentence in particular, though... > Clang should drive the standar

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov created this revision. kpyzhov added a reviewer: yaxunl. kpyzhov added a project: AMDGPU. Herald added subscribers: t-tye, tpr, dstuttard, kzhuravl. kpyzhov requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392531. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp llvm/include/llvm/ADT/Triple.h Index: llvm/include/llvm/ADT/Triple

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added a comment. Needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115283/new/ https://reviews.llvm.org/D115283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov added a comment. In D115283#3177615 , @dfukalov wrote: > Needs a test. Yes, good point, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115283/new/ https://reviews.llvm.org/D115283

Re: RFC: proposing to relax standardization requirements for Clang extensions

On Tue, Dec 7, 2021 at 4:48 PM Arthur O'Dwyer wrote: > > Hi Aaron, > > FWIW, I like your new wording (and rationale for it) better than the old > wording. Of course I've got a conflict of interest, because of P1144 > [[trivially_relocatable]] and P2266 "Simpler implicit move" and so on. ;) Than

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:105-109 +auto HIPOffloadTargets = Args.getAllArgValues(options::OPT_offload_EQ); +switch (HIPOffloadTargets.size()) { +default: + D.Diag(diag::err_drv_only_one_offload_target_supported_in) << "

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3211-3215 +The compiler will pass and return a trivially relocatable type using the C ABI +for the underlying type, even when the type would otherwise be considered +non-trivially-relocatable. If

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a subscriber: rsmith. philnik added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392539. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp llvm/include/llvm/ADT/Triple.h Index: llvm/include/llvm/ADT/Triple

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rsmith added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3211-3215 +The compiler will pass and return a trivially relocatable type using the C ABI +for the underlying type, even when the type would otherwise be considered +non-trivially-relocatable. If a ty

[PATCH] D113749: [Clang] Fix nesting of discarded and immediate contexts.

aaron.ballman added a comment. In D113749#3172722 , @hollinsky wrote: > This change breaks return value deduction of template instantiations that > first occur within a discarded context. Thank you for letting us know! I think we've fixed this issue in

[clang] d55f05d - [CUDA][HIP] Add pre-defined macro `__CLANG_RDC__`

Author: Yaxun (Sam) Liu Date: 2021-12-07T18:08:16-05:00 New Revision: d55f05d9f7dc8aa0468a9db19d84671acf05823a URL: https://github.com/llvm/llvm-project/commit/d55f05d9f7dc8aa0468a9db19d84671acf05823a DIFF: https://github.com/llvm/llvm-project/commit/d55f05d9f7dc8aa0468a9db19d84671acf05823a.dif

[PATCH] D114812: [CUDA][HIP] Add pre-defined macro `__CLANG_RDC__`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd55f05d9f7dc: [CUDA][HIP] Add pre-defined macro `__CLANG_RDC__` (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov updated this revision to Diff 392557. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Passed a `CodeGenOptions` reference to `CheckerManager` as well. (Adjusted to D114718 ) CHANGES SINCE LAST ACTION https://rev

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9425 +void AMDGPUTargetCodeGenInfo::checkFunctionCallABI(CodeGenModule &CGM, + SourceLocation CallLoc, Doesn't seem to check an

[clang] 219672b - Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and

Author: James Farrell Date: 2021-12-07T23:15:21Z New Revision: 219672b8dd06c4765185fa3161c98437d49b4a1b URL: https://github.com/llvm/llvm-project/commit/219672b8dd06c4765185fa3161c98437d49b4a1b DIFF: https://github.com/llvm/llvm-project/commit/219672b8dd06c4765185fa3161c98437d49b4a1b.diff LOG:

[PATCH] D115254: Use VersionTuple for parsing versions in Triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG219672b8dd06: Revert "Revert "Use VersionTuple for parsing versions in Triple, fixing issues… (authored by jamesfarrell). Repository: rG LLVM Gith

[PATCH] D115254: Use VersionTuple for parsing versions in Triple

MaskRay added a comment. commit 219672b8dd06c4765185fa3161c98437d49b4a1b says `Revert "Revert "...""` For such commits, it is customary to use "Reland " and the commit message should include the original message and a short

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 392576. ellis added a comment. Fix MachO profile dumping code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov updated this revision to Diff 392577. Herald added subscribers: kerbowa, nhaehnle, jvesely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115283/new/ https://reviews.llvm.org/D115283 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/Cod

[PATCH] D115301: [clangd] Don't index __reserved_names in headers.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Main use of these is in the s

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire added a comment. In D114688#3176567 , @aaron.ballman wrote: > In D114688#3176433 , @fhahn wrote: > >> I think it might be good to split off the refactoring of >> `SemaBuiltinElementwiseMathOneArg`-> >>

[PATCH] D115232: [clangd] WIP various stdlib indexing stuff

sammccall updated this revision to Diff 392582. sammccall added a comment. remove parts split into other patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rjmccall added a comment. I am perfectly happy accepting that syllogism. Passing a value in registers is a trivial relocation. If there is a reason your type shouldn't be trivially relocated, you should not make it `trivial_abi`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 392605. sammccall retitled this revision from "[clangd] WIP various stdlib indexing stuff" to "[clangd] Indexing of standard library". sammccall edited the summary of this revision. sammccall added a subscriber: kuhnel. sammccall added a comment. Herald adde

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 392606. devin.jeanpierre added a comment. Use `PCK_ARCStrong` to check for ObjC strong pointers, marking them as trivially relocatable as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/

[PATCH] D115311: [WIP] alternative approach to D114895

nickdesaulniers created this revision. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As suggested in: https://reviews.llvm.org/D114895#3177794. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115311 Fil

[clang] 4a2c827 - [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

Author: Phoebe Wang Date: 2021-12-08T09:50:26+08:00 New Revision: 4a2c827b178f89d4cdeb56153d9440ad4ba786a3 URL: https://github.com/llvm/llvm-project/commit/4a2c827b178f89d4cdeb56153d9440ad4ba786a3 DIFF: https://github.com/llvm/llvm-project/commit/4a2c827b178f89d4cdeb56153d9440ad4ba786a3.diff L

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a2c827b178f: [X86][clang] Emit diagnostic for float and double when we have features -x87… (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D114782: [X86][clang] Emit diagnostic for float and double when we have features -x87 and -sse on 64-bits

pengfei added a comment. Thanks @asavonic for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114782/new/ https://reviews.llvm.org/D114782 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. (Sorry, I think I'm doing threading wrong here due to lack of experience with phabricator. The reply buttons are grayed out!) > 1. All trivial-abi types are in fact trivially relocated, specifically when > they are passed to functions. > 2. Therefore, all trivi

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall marked 2 inline comments as done. sammccall added a comment. In D115243#3176741 , @kadircet wrote: > I think we also need to update `index/remote/Server.cpp` && `FileSymbols` > (and `FileIndex` too). > > Regarding updates to `loadIndex`, I actu

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall updated this revision to Diff 392609. sammccall marked an inline comment as done. sammccall added a comment. fix sigils Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://reviews.llvm.org/D115243 Files: clang-tools-extra

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall updated this revision to Diff 392612. sammccall added a comment. Update remote index server and FileIndex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://reviews.llvm.org/D115243 Files: clang-tools-extra/clangd/index/

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall added a comment. > I think we also need to update index/remote/Server.cpp && FileSymbols (and > FileIndex too). Done. I wonder why premerge tests didn't fail for FileIndex not being updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rjmccall added a comment. Trivial relocation doesn't imply that types have to be safe against being suddenly relocated during the middle of operations while they're not in a safe internal state. That is not a consideration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks great. A couple of minor suggestions. Comment at: clang/include/clang/Lex/ModuleMap.h:542-543 + /// unit's Module until later, because we don't know what

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

ChuanqiXu added a comment. In D115222#3177269 , @rjmccall wrote: > Like a lot of the switched-resume lowering, this intrinsic is extremely tied > to C++ semantics. If C++ doesn't actually allow the optimization anymore, > then I completely agree that w

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu added a comment. In D115219#3177213 , @rjmccall wrote: > Okay. Well, I'm glad it works. I guess I find it a little strange that > `coro.end` doesn't already mark the coroutine done. I guess the normal C++ > lowering always generates a final

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. In D114732#3178312 , @rjmccall wrote: > Trivial relocation doesn't imply that types have to be safe against being > suddenly relocated during the middle of operations while they're not in a > safe internal state. That

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3211-3215 +The compiler will pass and return a trivially relocatable type using the C ABI +for the underlying type, even when the type would otherwise be considered +non-trivially-relocatable. If

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu updated this revision to Diff 392625. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 Files: clang/include/clang/Basic/Module.h clang/include/clang/Lex/ModuleMap.h clang/include/clan

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

rjmccall added a comment. Okay. I guess the only choice, then, would be to not try to parse a template deduction guide when you're in a context where template deduction guides aren't allowed. Maybe that's not actually reasonable. Well, whatever. I don't really have a problem with this patch;

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf updated this revision to Diff 392638. qiucf marked 5 inline comments as done. qiucf added a comment. Update some cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109751/new/ https://reviews.llvm.org/D109751 Files: clang/lib/CodeGen/CGEx

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf added a comment. In D109751#3168982 , @hubert.reinterpretcast wrote: > In D109751#3136543 , @qiucf wrote: > >> Because the piece of code will be expanded to: >> >> long double _Complex x; >> >> if ((

[clang-tools-extra] ec64d10 - [clangd] Add desugared type to hover

Author: lh123 Date: 2021-12-08T13:28:12+08:00 New Revision: ec64d10340daacb066ab1bbf6356727062a8236f URL: https://github.com/llvm/llvm-project/commit/ec64d10340daacb066ab1bbf6356727062a8236f DIFF: https://github.com/llvm/llvm-project/commit/ec64d10340daacb066ab1bbf6356727062a8236f.diff LOG: [c

[PATCH] D114522: [clangd] Add desugared type to hover

This revision was automatically updated to reflect the committed changes. lh123 marked 2 inline comments as done. Closed by commit rGec64d10340da: [clangd] Add desugared type to hover (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114522?vs=391545&id=392640#toc Reposit

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe587372f8510: [C++20] [Module] Support extern C/C++ semantics (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] e587372 - [C++20] [Module] Support extern C/C++ semantics

Author: Chuanqi Xu Date: 2021-12-08T13:29:16+08:00 New Revision: e587372f85105b85ae790fbe129b5d609d6dfb76 URL: https://github.com/llvm/llvm-project/commit/e587372f85105b85ae790fbe129b5d609d6dfb76 DIFF: https://github.com/llvm/llvm-project/commit/e587372f85105b85ae790fbe129b5d609d6dfb76.diff LO

[clang] 60f8266 - [C++20] [Modules] Namespace Declaration shouldn't have module linkage

Author: Chuanqi Xu Date: 2021-12-08T13:54:04+08:00 New Revision: 60f826663d86e9bdf7adef9a8f1b2fc398e07f2a URL: https://github.com/llvm/llvm-project/commit/60f826663d86e9bdf7adef9a8f1b2fc398e07f2a DIFF: https://github.com/llvm/llvm-project/commit/60f826663d86e9bdf7adef9a8f1b2fc398e07f2a.diff LO

[PATCH] D115132: [C++20] [Modules] Namespace Declaration shouldn't have module linkage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60f826663d86: [C++20] [Modules] Namespace Declaration shouldn't have module linkage (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 6fe577b - [clangd] Make a.k.a printing configurable.

Author: lh123 Date: 2021-12-08T14:17:01+08:00 New Revision: 6fe577b1c1e4b5a44f17cb668c5c346527bd08bd URL: https://github.com/llvm/llvm-project/commit/6fe577b1c1e4b5a44f17cb668c5c346527bd08bd DIFF: https://github.com/llvm/llvm-project/commit/6fe577b1c1e4b5a44f17cb668c5c346527bd08bd.diff LOG: [c

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

This revision was automatically updated to reflect the committed changes. lh123 marked 3 inline comments as done. Closed by commit rG6fe577b1c1e4: [clangd] Make a.k.a printing configurable. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114665?vs=391546&id=392648#toc R

[clang] 4168efe - [NFC] Fix C++20 module test in PPC and warning

Author: Chuanqi Xu Date: 2021-12-08T14:25:51+08:00 New Revision: 4168efe1b2243ed31c30c82583a18bff78cfa076 URL: https://github.com/llvm/llvm-project/commit/4168efe1b2243ed31c30c82583a18bff78cfa076 DIFF: https://github.com/llvm/llvm-project/commit/4168efe1b2243ed31c30c82583a18bff78cfa076.diff LO

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

vitalybuka added a comment. llvm-project/clang/lib/Sema/SemaModule.cpp:715:70: warning: missing field 'OuterVisibleModules' initializer [-Wmissing-field-initializers] ^ Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu added a comment. In D110215#3178575 , @vitalybuka wrote: > llvm-project/clang/lib/Sema/SemaModule.cpp:715:70: warning: missing field > 'OuterVisibleModules' initializer [-Wmissing-field-initializers] >

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir created this revision. Herald added subscribers: jeroen.dobbelaere, kosarev. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 32bit mode, attaching TBAA metadata to the store following the call to inline assembler resul

[clang] e166755 - [C++20] [Modules] [Concepts] Recognize same concepts more precisely in Serialization

Author: Chuanqi Xu Date: 2021-12-08T15:00:04+08:00 New Revision: e166755a691921612274fdad945d3a6b05d00439 URL: https://github.com/llvm/llvm-project/commit/e166755a691921612274fdad945d3a6b05d00439 DIFF: https://github.com/llvm/llvm-project/commit/e166755a691921612274fdad945d3a6b05d00439.diff LO

[PATCH] D114769: [C++20] [Modules] [Concepts] Recognize same concepts more precisely in Serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGe166755a6919: [C++20] [Modules] [Concepts] Recognize same concepts more precisely in… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

rjmccall added a comment. In D115219#3178370 , @ChuanqiXu wrote: > In D115219#3177213 , @rjmccall > wrote: > >> Okay. Well, I'm glad it works. I guess I find it a little strange that >> `coro.end` doesn't alre

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

jeroen.dobbelaere added a comment. Do you have a testcase ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 ___ cfe-commits mailing list cfe-commits@lists.llvm.

<    1   2