[clang] 1ad7de9 - Headers: exclude `#include_next ` on MSVC

Author: Saleem Abdulrasool Date: 2021-11-24T12:52:16-08:00 New Revision: 1ad7de9e92bc2977698e5f6d6493202b50c912d5 URL: https://github.com/llvm/llvm-project/commit/1ad7de9e92bc2977698e5f6d6493202b50c912d5 DIFF: https://github.com/llvm/llvm-project/commit/1ad7de9e92bc2977698e5f6d6493202b50c912d5.

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, delesley, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114562 Files: clang/docs/T

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

Quuxplusone added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:471 - + ``-Wthread-safety-attributes``: Sanity checks on attribute syntax. + + ``-Wthread-safety-attributes``: Validation checks on attribute syntax. + ``-Wthread-safety-analysis``: The core

[PATCH] D113925: [HIP] Add HIP scope atomic operations

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; m

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei created this revision. masoud.ataei added reviewers: andrew.w.kaylor, aaron.ballman, erichkeane, bmahjour. masoud.ataei added a project: clang. masoud.ataei requested review of this revision. Herald added a subscriber: cfe-commits. Fining the bug number Bug 52565: https://bugs.llvm.o

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 updated this revision to Diff 389620. jcking1034 marked 3 inline comments as done. jcking1034 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:152 + } +MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgument) +MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgumentLoc) hokein wrote: > These are types that are not covered in t

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:471 - + ``-Wthread-safety-attributes``: Sanity checks on attribute syntax. + + ``-Wthread-safety-attributes``: Validation checks on attribute syntax. + ``-Wthread-safety-analysis``: The cor

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

HazardyKnusperkeks added a comment. In D114430#3151082 , @klimek wrote: > Thanks for cleaning up after me, and sorry for the mess - do y'all have > clang-format set up as a presubmit or do you just remember to format manually? I think one "problem" is t

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

andrew.w.kaylor added a comment. Thanks for the patch! This looks mostly good. I have just a few suggestions. Could you add test cases in clang/test/Driver/clang_f_opts.c to verify that the various driver inputs get overridden in the expected way? Without such a test, this behavior is likely to

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_ne

[PATCH] D113925: [HIP] Add HIP scope atomic operations

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_ne

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5536 +// GCC does not enforce these rules for GNU atomics, but we do, because if +// we didn't it would be very confusing. FIXME: For whom? How so? auto IsAllowedValueType = [&](QualType

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

owenpan added a comment. In D114430#3152609 , @HazardyKnusperkeks wrote: > In D114430#3151082 , @klimek wrote: > >> Thanks for cleaning up after me, and sorry for the mess - do y'all have >> clang-format set up

[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai updated this revision to Diff 389630. vsapsai added a comment. Switch from checking module visibility to checking if a module is imported. Required to handle not re-exported modules - allow to deserialize decls from them even if the modules aren't visible. Repository: rG LLVM Github M

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; carlosgalve

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

rjmccall added subscribers: rsmith, rjmccall. rjmccall added a comment. If you aren't sure what a comment means, please feel free to CC Richard or me, and we might be able to help. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings

[PATCH] D113925: [HIP] Add HIP scope atomic operations

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5587 // the GNU atomics specification, but we enforce it, because if we didn't it // would be very confusing. FIXME: For whom? How so? Diag(ExprRange.getBegin(), diag::err_atomic_op_needs

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389638. lh123 added a comment. format code and add testcase for template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 added a comment. Related discussions: D72498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 ___ cfe-commits mailing lis

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

shraiysh added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.org/D114143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114569: [PowerPC] Require htm feature for HTM builtins

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, kbarton, PowerPC. Herald added a subscriber: shchenz. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389650. SixWeining retitled this revision from "[clang][unittests]Fix a clang unittest linking issue" to "[clang][unittests] Fix a clang unittest linking issue". SixWeining edited the summary of this revision. SixWeining added a comment. Herald add

[PATCH] D114571: add release notes, docs mention, and test example

vtjnash created this revision. Herald added subscribers: arphaman, mgorny. vtjnash requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114571 Files: clang-tools-ext

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389652. vtjnash added a comment. Herald added a subscriber: arphaman. add release notes, docs mention, and test example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389653. vtjnash added a comment. add release notes, docs mention, and test example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-ti

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389655. vtjnash added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/clang-

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389656. vtjnash added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/cl

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 389658. vtjnash added a comment. enable help Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. This is probably just a draft, but please let me know what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 ___ cfe-commits ma

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

tstellar added a comment. @ZarkoCA If you are planning to do a lot of this, it might be good to write a script (or a clang-tidy check even) that we can add to CI, so these terms don't get re-introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

nridge added a comment. In D114058#3150606 , @kadircet wrote: > thanks, lgtm! let me know of your email address (for commit attribution) if > you want me to land this for you. While I don't see it surfaced anywhere in the Phabricator UI, there is in fac

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder added a comment. Hey @MaskRay, I know you've already approved but just to be sure: does the last round of changes look good? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 ___ cfe-c

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. In D110618#3148501 , @Anastasia wrote: > Could you please clarify the interface to SPIRV-LLVM-Translator tool, > specifically: > > - Does clang lookup the path to the translator or assume any default path? HIPSPV primarily rel

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

<    1   2