[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. The test case is for Objective-C but it is likely other languages like C++ are affected as well, just haven't created appropriate test cases. The test case

[PATCH] D114408: Fold a lot of ffixed_x if judgments

achieveartificialintelligence updated this revision to Diff 389091. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114408/new/ https://reviews.llvm.org/D114408 Files: clang/lib/Driver/ToolChains/

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for helping to complete the OpenMPIRBuilder implementation! Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSi

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks added a comment. In D22505#3147501 , @MyDeveloperDay wrote: > I think so, it came to the top because someone subscribed to it, I was > wondering if this was something that is still needed or if our existing > options cover this. > > I

[PATCH] D114082: [WIP] Normalize String Attributes

mehdi_amini added a comment. The patch is pretty large, any chance you could split in two? First the change introducing the AttributeKey and changing the API, and then updating all the callees separately as a follow up? Comment at: llvm/include/llvm/IR/Attributes.h:84 + } +}

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Should also generate this same IR right? For `a + b + c`, yes, they are the same. For `a + b`, no. That's the difference between approaches #3 and #4, which I didn't emphasize before :) https://godbolt.org/z/onbGeqdYv CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/Float16-aritmetic.c:8-9 + // CHECK: alloca half + // CHECK: store half {{.*}}, half* + // CHECK: store half {{.*}}, half* + // CHECK: load half, half* zahiraam wrote: > pengfei wrote: > > This

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. For that example, yes, approach #3 would result in that exact same IR on targets that lack direct hardware support for `_Float16` operations. But getting that behavior right in general requires a different implementation than is provided by this patch, which is implem

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Ok now I'm a little puzzled, shouldn't this be covered by `AllowShortIfStatementsOnASingleLine`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 __

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114396/new/ https://reviews.llvm.org/D114396 ___ cfe-commits mailing list cfe-commits@lists.l

<    1   2