[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

2021-11-19 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax, committed by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 290cddc - Allow __attribute__((swift_attr)) in attribute push pragmas

2021-11-19 Thread Alex Lorenz via cfe-commits
Author: Becca Royal-Gordon Date: 2021-11-19T13:00:26-08:00 New Revision: 290cddcd139d668251821f11426f37481faf6d7f URL: https://github.com/llvm/llvm-project/commit/290cddcd139d668251821f11426f37481faf6d7f DIFF: https://github.com/llvm/llvm-project/commit/290cddcd139d668251821f11426f37481faf6d7f.

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

2021-11-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a reviewer: arphaman. dexonsmith added a subscriber: arphaman. dexonsmith added a comment. This revision now requires review to proceed. @arphaman , can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ htt

[clang] a075d67 - [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

2021-11-19 Thread Wei Wang via cfe-commits
Author: Wei Wang Date: 2021-11-19T13:22:07-08:00 New Revision: a075d67222832c234296ffd605f19e33023e6060 URL: https://github.com/llvm/llvm-project/commit/a075d67222832c234296ffd605f19e33023e6060 DIFF: https://github.com/llvm/llvm-project/commit/a075d67222832c234296ffd605f19e33023e6060.diff LOG:

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

2021-11-19 Thread Wei Wang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa075d6722283: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType (authored by weiwang). Changed prior to commit: https://reviews.llvm.org/D112481?vs=382375&id=388616#toc Repo

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

2021-11-19 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

2021-11-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the fix! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:108 + // Some expressions might be not resolved yet due to ADL: conservatively mark + //

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

2021-11-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > Add names to pgo registers for clarity. This may increase memory usage. Unless this is very helpful I might omit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

2021-11-19 Thread Ellis Hoag via Phabricator via cfe-commits
ellis added a comment. In D114268#3143976 , @MaskRay wrote: >> Add names to pgo registers for clarity. > > This may increase memory usage, especially for large LTO applications. Unless > this is very helpful I might omit it. I'll omit it. Thanks for the

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

2021-11-19 Thread Fabian Wolff via Phabricator via cfe-commits
fwolff created this revision. fwolff added reviewers: alexfh, whisperity, hokein. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#51620

[PATCH] D107944: [hmaptool] Port to python3

2021-11-19 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107944/new/ https://reviews.llvm.org/D107944 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

2021-11-19 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 388652. ellis added a comment. Remove register names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114268/new/ https://reviews.llvm.org/D114268 Files: clang/test/CodeGen/profile-filter.c clang/test/Profile/b

[clang] de11de3 - [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

2021-11-19 Thread Kyungwoo Lee via cfe-commits
Author: Ellis Hoag Date: 2021-11-19T15:45:14-08:00 New Revision: de11de308b6480fc35d901c7104f46918674418c URL: https://github.com/llvm/llvm-project/commit/de11de308b6480fc35d901c7104f46918674418c DIFF: https://github.com/llvm/llvm-project/commit/de11de308b6480fc35d901c7104f46918674418c.diff LO

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

2021-11-19 Thread Kyungwoo Lee via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde11de308b64: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment (authored by ellis, committed by kyulee). Repository: rG LL

[clang-tools-extra] f764a1a - [clangd] Avoid possible crash: apply configuration after binding methods

2021-11-19 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2021-11-20T01:13:38+01:00 New Revision: f764a1a5bd7c281d3d7cc3c6d7f1430711176762 URL: https://github.com/llvm/llvm-project/commit/f764a1a5bd7c281d3d7cc3c6d7f1430711176762 DIFF: https://github.com/llvm/llvm-project/commit/f764a1a5bd7c281d3d7cc3c6d7f1430711176762.diff LO

[PATCH] D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration

2021-11-19 Thread Fabian Wolff via Phabricator via cfe-commits
fwolff created this revision. fwolff added reviewers: Eugene.Zelenko, alexfh, Szelethus. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#48086

[clang] 1bd4dc4 - [hmaptool] Port to python3

2021-11-19 Thread Nathan Lanza via cfe-commits
Author: Nathan Lanza Date: 2021-11-19T19:25:31-05:00 New Revision: 1bd4dc4f2854edf3035732416ec7e4adbddaf982 URL: https://github.com/llvm/llvm-project/commit/1bd4dc4f2854edf3035732416ec7e4adbddaf982 DIFF: https://github.com/llvm/llvm-project/commit/1bd4dc4f2854edf3035732416ec7e4adbddaf982.diff

[PATCH] D107944: [hmaptool] Port to python3

2021-11-19 Thread Nathan Lanza via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd4dc4f2854: [hmaptool] Port to python3 (authored by lanza). Changed prior to commit: https://reviews.llvm.org/D107944?vs=388568&id=388668#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

2021-11-19 Thread Felix Berger via Phabricator via cfe-commits
flx added a comment. Thank you for catching and fixing this! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:97 + cxxOperatorCallExpr(callee(MethodDecl), hasArgument(0, ReceiverExpr), + hasArgument(0, hasType

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

2021-11-19 Thread David Rector via Phabricator via cfe-commits
davrec added a comment. Looks good, a few notes. Comment at: clang/include/clang/AST/ASTContext.h:1559 + QualType getUsingType(const NamedDecl *Found, QualType Underlying) const; + I believe you mentioned ObjC considerations might require expanding beyond U

[PATCH] D114312: libfuzzer: Disable broken tests for arm

2021-11-19 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta created this revision. manojgupta added reviewers: morehouse, metzman. Herald added a subscriber: kristof.beyls. manojgupta requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. libfuzzer was recently enabled for Arm32 in D112091

<    1   2