[PATCH] D113636: format_arg attribute does not support nullable instancetype return type

2021-11-10 Thread FĂ©lix Cloutier via Phabricator via cfe-commits
fcloutier created this revision. fcloutier added reviewers: NoQ, ahatanak. fcloutier added a project: clang. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. Following up with D112670 , it

[PATCH] D106585: Fix clang debug info irgen of i128 enums

2021-11-10 Thread Mike Hommey via Phabricator via cfe-commits
glandium added a comment. In D106585#3122726 , @glandium wrote: > It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8 > . Actually, there are some remaining cases

[PATCH] D112915: [clang][modules] Track number of includes per submodule

2021-11-10 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. As we've discussed earlier, tracking `isImport` shouldn't be done per .pcm and here is the test case https://gist.github.com/vsapsai/a2d2bd19c54c24540495fd9b262106aa I'm not sure it is worth adding the second `#include` as the test fails just with one. Overall, the cha

[PATCH] D113638: [xray] Add support for hexagon architecture

2021-11-10 Thread Brian Cain via Phabricator via cfe-commits
androm3da created this revision. androm3da added reviewers: dberris, kparzysz. Herald added subscribers: hiraditya, mgorny. androm3da requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Adds x-ray suppo

[PATCH] D110898: Pass template parameters when printing template argument lists for function templates

2021-11-10 Thread David Blaikie via Phabricator via cfe-commits
dblaikie abandoned this revision. dblaikie added a comment. Talked to Richard offline - this is undesirable because it would mean that certain template overloads would not be disambiguated in their naming. I'll post a patch with a test case that demonstrates that desired behavior and abandon th

[PATCH] D113638: [xray] Add support for hexagon architecture

2021-11-10 Thread Brian Cain via Phabricator via cfe-commits
androm3da added a comment. This patch spans several areas, so I would be happy to decompose it into smaller parts if it made it easier for reviewers. Comment at: compiler-rt/lib/xray/xray_hexagon.cpp:76-84 +static void WriteInstFlushCache(void *Addr, uint32_t NewInstruction) {

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

2021-11-10 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a subscriber: rsmith. dblaikie added a comment. Some offline post-commit feedback from @rsmith - Rename printing policy to match closer to the function it's tested in. Will think about that, check the function name, etc, and commit a patch in the next few days, hopefully. Reposi

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

2021-11-10 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Awesome! Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:559 + // Get the resolved template arguments from the canonical type. + // FIXME: Handle the as-written argume

[PATCH] D113642: [PowerPC] Provide XL-compatible vec_round implementation

2021-11-10 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai created this revision. nemanjai added reviewers: PowerPC, rzurob, qiongsiwu. Herald added subscribers: shchenz, kbarton, hiraditya. nemanjai requested review of this revision. Herald added projects: clang, LLVM. The XL implementation of `vec_round` for `vector double` uses "round-to-near

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

2021-11-10 Thread Greg Steuck via Phabricator via cfe-commits
blackgnezdo updated this revision to Diff 386414. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp Index: clang/lib/Driver/ToolChains/OpenBSD.cpp =

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

2021-11-10 Thread Greg Steuck via Phabricator via cfe-commits
blackgnezdo added a comment. I reformatted with clang-format to address the lint complaint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

2021-11-10 Thread Keith Smiley via Phabricator via cfe-commits
keith created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. keith requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tools-extra. It's common for CLIs on

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

2021-11-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: andrew.w.kaylor, erichkeane, pengfei. craig.topper requested review of this revision. Herald added a project: clang. If the feature is on the command line we should honor it for all functions. I don't think we could reliably target

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

2021-11-10 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 386425. atmnpatel added a comment. I removed the shared var opt - might be best to keep this in a separate patch @tianshilei1992. Also addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

2021-11-10 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 386426. atmnpatel added a comment. small nit fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113359/new/ https://reviews.llvm.org/D113359 Files: clang/lib/Basic/Targets/X86.h clang/lib/CodeGen/CGOpenMP

<    1   2