[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

bruno added a comment. Thanks for working on upstreaming this @ab. Overall looks good to me, I see clang-format issues, are those legit? One more comment inline. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in

[clang] 81081da - [OpenCL] Allow optional __generic in __remove_address_space utility

Author: Justas Janickas Date: 2021-11-09T08:13:34Z New Revision: 81081daef0299ad59fca299c7cde3888fa691c6a URL: https://github.com/llvm/llvm-project/commit/81081daef0299ad59fca299c7cde3888fa691c6a DIFF: https://github.com/llvm/llvm-project/commit/81081daef0299ad59fca299c7cde3888fa691c6a.diff LO

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81081daef029: [OpenCL] Allow optional __generic in __remove_address_space utility (authored by Topotuna). Repository: rG LLVM Github Monorepo CHA

[clang] 7ecec3f - [CUDA] Bump supported CUDA version to 11.5

Author: Carlos Galvez Date: 2021-11-09T08:20:53Z New Revision: 7ecec3f0f5215c99e45d7000c11230ba2f7e421c URL: https://github.com/llvm/llvm-project/commit/7ecec3f0f5215c99e45d7000c11230ba2f7e421c DIFF: https://github.com/llvm/llvm-project/commit/7ecec3f0f5215c99e45d7000c11230ba2f7e421c.diff LOG:

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ecec3f0f521: [CUDA] Bump supported CUDA version to 11.5 (authored by carlosgalvezp). Changed prior to commit: https://reviews.llvm.org/D113249?vs=385286&id=385717#toc Repository: rG LLVM Github Mono

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. Can someone please merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

steakhal added a comment. For testing this I would recommend using a separate test file. That being said, you should avoid globals even in tests when you can. The distance between its declaration and use just makes it harder to comprehend and reason about. You could have a parameter, and take it

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 updated this revision to Diff 385730. jansvoboda11 added a comment. Make loading of (sub)module includes lazy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: clang/include/clang/Lex/

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes updated this revision to Diff 385732. c-rhodes added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113294/new/ https://reviews.llvm.org/D113294 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/LangOptions.def

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes marked 4 inline comments as done. c-rhodes added a comment. In D113294#3115354 , @sdesmalen wrote: > It would be nice if the LLVM interfaces could be updated as well (could also > be done in a follow-up patch) Thanks for reviewing, I'll create

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

carlosgalvezp added a comment. Hi! I believe this commit broke a number of CI jobs, would you be able to look into it? https://lab.llvm.org/buildbot/#/builders/52/builds/12263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://revi

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna added a comment. In D110155#3117786 , @carlosgalvezp wrote: > Hi! I believe this commit broke a number of CI jobs, would you be able to > look into it? > > https://lab.llvm.org/buildbot/#/builders/52/builds/12263 Hi, I am aware it broke some o

[clang] d85d57e - Revert "[OpenCL] Allow optional __generic in __remove_address_space utility"

Author: Justas Janickas Date: 2021-11-09T09:42:17Z New Revision: d85d57e98789d187cac415d9d8a0973ae6f2e4e1 URL: https://github.com/llvm/llvm-project/commit/d85d57e98789d187cac415d9d8a0973ae6f2e4e1 DIFF: https://github.com/llvm/llvm-project/commit/d85d57e98789d187cac415d9d8a0973ae6f2e4e1.diff LO

[PATCH] D112915: [clang][modules] Track number of includes per submodule

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added a comment. Thanks for your feedback @dexonsmith. I reworked the patch to use more sensible data structures as suggested, and made the AST deserialization lazy (on (sub)module import). I think the only thing to figure out is the e

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

salman-javed-nz created this revision. salman-javed-nz added a reviewer: carlosgalvezp. salman-javed-nz added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. salman-javed-nz requested review of this revision. Calling clang-tidy on ClangTidyDiagnosticConsumer.cpp gives a "unmatc

[PATCH] D113473: [clang][deps] Don't emit `-fmodule-map-file=`

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai, bnbarham. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During explicit modules build, when all modules are provided via `-fmo

[PATCH] D113474: [clang] Don't crash on an incomplete-type base specifier in template context.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113474 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/base-class-ambiguity-chec

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

simon.giesecke accepted this revision. simon.giesecke added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113429/new/ https://reviews.llvm.org/D113429

[PATCH] D113473: [clang][deps] Don't emit `-fmodule-map-file=`

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. That was quick! Seems reasonable to me -hopefully there's not some strange case where this wouldn't work, will be nice to avoid the parsing time (which actually isn't insignificant). Rep

[PATCH] D112915: [clang][modules] Track number of includes per submodule

jansvoboda11 updated this revision to Diff 385751. jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. Make clang-format happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Fil

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

carlosgalvezp added a comment. Hmm, this sounds a bit hacky. I noticed a similar pattern in tests. I think it deteriorates readability a bit. Can we make the detection of the tag more robust? Right now we check if a line contains NOLINTBEGIN/END. Why not check if it contains "// NOLINTBEGIN"? (

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules -

[PATCH] D113477: [clang-tblgen] Fix non-determinism in generating AttributeReference.rst

ikudrin created this revision. ikudrin added reviewers: aaron.ballman, arphaman, rsmith. ikudrin added a project: clang. Herald added a subscriber: mgrang. ikudrin requested review of this revision. As for now, the categories are printed in an arbitrary order which depends on the addresses of dyn

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

MyDeveloperDay added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modul

[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

ikudrin added a comment. The compiler has to be deterministic and one way to check that is to recompile a relatively large project several times. For `clang`, that large project is usually `clang` itself, so it has to be compiled in a stable way. Anyway, I've prepared a fix for generating the d

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

salman-javed-nz added a comment. clang-tidy looking for `NOLINT` markers but not checking to see that the marker is within a comment, is long-standing behaviour at this point. cpplint has the same behaviour, which explains why clang-tidy's implementation started off this way. That's not to say

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

salman-javed-nz added a comment. I suspect that ensuring that `NOLINT`s are within a comment could be a reasonably large code change. If it is to be robust with `/* multiline comments */` and other shenanigans, then I would probably lean on the compiler to tell us what is and isn't a comment,

[PATCH] D113474: [clang] Don't crash on an incomplete-type base specifier in template context.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/base-class-ambiguity-check.cpp:15 + + // Should not crash on an incomplete-type base specifier. + struct Derived : Base {}; ---

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

carlosgalvezp added a comment. > If it is to be robust with /* multiline comments */ Does it have to be? I don't recall that we have unit tests for that. I would personally restrict the usage to only one way to write the line. I think it's not hard for users to adapt to that, plus it encourage

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:1 -[ - { -"directory": "DIR", -"command": "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fcxx-modules -

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu updated this revision to Diff 385765. ChuanqiXu added a reviewer: jansvoboda11. ChuanqiXu added a comment. Undo unnecessary style change in *.json files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113391/new/ https://reviews.llvm.org/D1

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. In D112730#3116281 , @tstellar wrote: > @carlosgalvezp The LLVM Foundation Board will conduct a legal reivew of this > patch. Would you be able to share any information you have about the license > or usage restrictions f

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet updated this revision to Diff 385768. courbet added a comment. one more spaceship operator fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112453/new/ https://reviews.llvm.org/D112453 Files: clang/include/clang/AST/Type.h clang/lib/

[clang-tools-extra] 0076957 - [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

Author: Salman Javed Date: 2021-11-10T01:09:35+13:00 New Revision: 00769572025f9b0d36dc832d3c1bc61500091ed5 URL: https://github.com/llvm/llvm-project/commit/00769572025f9b0d36dc832d3c1bc61500091ed5 DIFF: https://github.com/llvm/llvm-project/commit/00769572025f9b0d36dc832d3c1bc61500091ed5.diff

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG00769572025f: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC) (authored by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

salman-javed-nz added a comment. Thanks for the review. I will think some more about your suggestion to look for `//`. Once I have something that works, I will be back for another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113472/new/

[PATCH] D113450: [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Comment at: clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp:248-250 + runHeaderGuardCheck( + "", "Samba

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

carlosgalvezp added a comment. Great! I'd be open to supporting `/*` as well if people really need it. But so far that use case is not documented nor tested, so I think we shouldn't add new functionality if it's not needed. It can be added in the future if someone has a compelling case. Repos

[clang] b0de656 - Initial parsing/sema for 'align' clause

Author: David Pagan Date: 2021-11-09T07:34:18-05:00 New Revision: b0de656bdf0ee3f4e51d04ae29160dab99819e8e URL: https://github.com/llvm/llvm-project/commit/b0de656bdf0ee3f4e51d04ae29160dab99819e8e DIFF: https://github.com/llvm/llvm-project/commit/b0de656bdf0ee3f4e51d04ae29160dab99819e8e.diff L

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in b0de656bdf0ee3f4e51d04ae29160dab99819e8e (clang), b0de656bdf0ee3f4e51d04ae29160dab99819e8e

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, NoQ, martong. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested rev

[PATCH] D113450: [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

salman-javed-nz updated this revision to Diff 385780. salman-javed-nz added a comment. Unit tests: - Renamed Samba to SMB - Added test for UNC paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113450/new/ https://reviews.llvm.org/D113450 Files:

[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113168/new/ https://reviews.llvm.org/D113168

[PATCH] D113477: [clang-tblgen] Fix non-determinism in generating AttributeReference.rst

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113477/new/ https://reviews.llvm.org/D113477 _

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a project: libc++. aaron.ballman added a subscriber: libcxx-commits. aaron.ballman added a comment. Subscribing the libc++ commits list in an attempt to get the attention of a libc++ reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone added a comment. If libc++ is using these macros, then I think it would be useful to include (the removal of) those uses in this PR. ../libcxx/include/atomic:#define ATOMIC_VAR_INIT(value) see below ../libcxx/include/atomic:#define ATOMIC_FLAG_INIT see below ../libcxx/include/a

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang added a comment. @alexfh, @ymandel: Do you know who could review this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/new/ https://reviews.llvm.org/D112647 ___ cfe-commits mail

[clang] 8cc2de6 - [analyzer][docs] Fix the incorrect structure of the checker docs

Author: Kristóf Umann Date: 2021-11-09T15:26:00+01:00 New Revision: 8cc2de667ec2526b055e971f46f4b3731107546c URL: https://github.com/llvm/llvm-project/commit/8cc2de667ec2526b055e971f46f4b3731107546c DIFF: https://github.com/llvm/llvm-project/commit/8cc2de667ec2526b055e971f46f4b3731107546c.diff

[PATCH] D113397: [analyzer][docs] Fix the incorrect structure of the checker docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc2de667ec2: [analyzer][docs] Fix the incorrect structure of the checker docs (authored by Szelethus). Changed prior to commit: https://reviews.l

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3 + "directory" : "DIR", + "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fmodules-cache-path=DI

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall added a comment. In D112996#3106469 , @ckandeler wrote: > In D112996#3106459 , @sammccall > wrote: > >> can we the tests again though? > > Sorry, I don't understand what you mean by that. Apologies, I

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

whisperity added a comment. In D108893#3111674 , @steakhal wrote: > It seems like the checker is documented as `readability-data-pointer` but in > the tests it reports issues under the `readability-container-data-pointer` > name. > Shouldn't they be the

[PATCH] D112914: Misleading identifier detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299aa4dfa1d8: Misleading unicode identifier detection pass (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D112

[PATCH] D113474: [clang] Don't crash on an incomplete-type base specifier in template context.

hokein updated this revision to Diff 385807. hokein marked 2 inline comments as done. hokein added a comment. address comments and added a missing case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113474/new/ https://reviews.llvm.org/D113474 File

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3118314 , @Quuxplusone wrote: > If libc++ is using these macros, then I think it would be useful to include > (the removal of) those uses in this PR. > > ../libcxx/include/atomic:#define ATOMIC_VAR_INIT(value)

[PATCH] D113474: [clang] Don't crash on an incomplete-type base specifier in template context.

hokein added inline comments. Comment at: clang/test/SemaCXX/base-class-ambiguity-check.cpp:15 + // Should not crash on an incomplete-type and dependent base specifier. + struct Derived : Base1, Base2 {}; // expected-error {{implicit instantiation of undefined member 'Foo2::Ba

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 385813. vaibhav.y added a comment. Format code using patch from buildkite Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[clang] bf6986d - [clang] GCC directive extension extension: Hash NNN lines

Author: Nathan Sidwell Date: 2021-11-09T07:31:03-08:00 New Revision: bf6986d99eaa68ad850eb335cb3f98fe6406ccd0 URL: https://github.com/llvm/llvm-project/commit/bf6986d99eaa68ad850eb335cb3f98fe6406ccd0 DIFF: https://github.com/llvm/llvm-project/commit/bf6986d99eaa68ad850eb335cb3f98fe6406ccd0.diff

[PATCH] D113425: gcc extension # NNN directive lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6986d99eaa: [clang] GCC directive extension extension: Hash NNN lines (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://re

[PATCH] D113474: [clang] Don't crash on an incomplete-type base specifier in template context.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/test/SemaCXX/base-class-ambiguity-check.cpp:15 + // Should not crash on an incomplete-type and dependent base specifier. + struct Derived : Base1, Base2 {}; // expected-error {{implicit instant

[clang] ae5c52b - [clang] [docs] Fix markup

Author: Nathan Sidwell Date: 2021-11-09T07:40:27-08:00 New Revision: ae5c52b933f45ba9a782909a93d1ae3c7243c6be URL: https://github.com/llvm/llvm-project/commit/ae5c52b933f45ba9a782909a93d1ae3c7243c6be DIFF: https://github.com/llvm/llvm-project/commit/ae5c52b933f45ba9a782909a93d1ae3c7243c6be.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 385818. ggeorgakoudis added a comment. Update the interface for allocating/sharing the struct aggregate Simplify invoking tasks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.ll

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. TODO update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

yaxunl updated this revision to Diff 385812. yaxunl retitled this revision from "[HIP] Do not use kernel handle for MSVC target" to "[CUDA][HIP] Allow comdat for kernels". yaxunl edited the summary of this revision. yaxunl added a comment. fix comdat instead CHANGES SINCE LAST ACTION https://

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 385826. ckandeler added a comment. Added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeC

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 385830. Jake-Egan added a comment. Add `LLVM :: DebugInfo/attr-btf_type_tag.ll` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymo

[PATCH] D113447: [sancov] add tracing for loads and store

morehouse accepted this revision. morehouse added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/autocomplete.c:73 // FNOSANICOVERALL-NEXT: trace-pc-guard +// FNOSANICOVERALL-NEXT: trace-loads +// FNOSANICOVERALL-NEXT: trace-store

[PATCH] D111463: [OpenMP] Remove doing assumption propagation in the front end.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added a subscriber: asavonic. I'm assuming this is simply a revert, LG in that case, once the others landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:162-163 "'%0': unable to use module files with this tool">; +def err_drv_clang_module_cxx_module_conflicts : Error < + "Unable to use clang module and c++20 module at the same

[PATCH] D113490: [NFC] Let Microsoft mangler accept GlobalDecl

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. yaxunl requested review of this revision. This is a follow up of https://reviews.llvm.org/D75700 where support of GlobalDecl with Microsoft mangler is incomplete. https://reviews.llvm.org/D113490 Files: clang/lib/AST/Microso

[PATCH] D113491: [HIP] Fix device stub name for Windows

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. yaxunl requested review of this revision. This is a follow up of https://reviews.llvm.org/D68578 where device stub name is changed for Itanium mangling but not Microsoft mangling. https://reviews.llvm.org/D113491 Files: clan

[PATCH] D112914: Misleading identifier detection

RKSimon added a comment. @serge-sans-paille Any luck with a fix for all the buildbot failures or should we revert ? https://lab.llvm.org/buildbot/#/builders/109/builds/25932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://review

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1542 + if (unsupportedTypeConversion(*this, LHSType, RHSType) && + ACK != ACK_Conditional && ACK != ACK_CompAssign) return QualType(); GCC does not allow compound ass

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added a comment. It doesn't seem like the cases of implicit conversion that are expected to be allowed have been tested with C++? $ ./bin/clang -fsyntax-only -mcpu=pwr9 -mfloat128 -xc -<<<$'__ibm128 x; __float128 y; void f(void) { y = x; }' Return: 0x00:0 Tue Nov

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

dblaikie added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3 + "directory" : "DIR", + "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fmodules-cache-path=DIR/mo

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added a comment. @qiucf, I'm on vacation (for 3 weeks). For the C++ side, I suggest having a test for the narrowing conversion diagnostic in C++. My recollection is that GCC's odd behaviour around the conditional operator has an analogue in its implementation of narrowing

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

eandrews added a comment. This patch causes a regression. To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp` // expected-note@+2 {{'bar<__float128>' defined here}} template T bar() { return T(); }; void usage() { // expected-error@+2 {{'bar<__float128>' requires

[clang] a19da87 - [ARM] implement support for TLS register based stack protector

Author: Ard Biesheuvel Date: 2021-11-09T18:19:47+01:00 New Revision: a19da876ab93d54ebc20aadd12820f74220d2f50 URL: https://github.com/llvm/llvm-project/commit/a19da876ab93d54ebc20aadd12820f74220d2f50 DIFF: https://github.com/llvm/llvm-project/commit/a19da876ab93d54ebc20aadd12820f74220d2f50.diff

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

This revision was automatically updated to reflect the committed changes. ardb marked an inline comment as done. Closed by commit rGa19da876ab93: [ARM] implement support for TLS register based stack protector (authored by ardb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 2477272 - [ARM] reject -mtp=cp15 if target subarch does not support it

Author: Ard Biesheuvel Date: 2021-11-09T18:29:30+01:00 New Revision: 24772720c54500714e2d48b9109bb62d5867ad95 URL: https://github.com/llvm/llvm-project/commit/24772720c54500714e2d48b9109bb62d5867ad95 DIFF: https://github.com/llvm/llvm-project/commit/24772720c54500714e2d48b9109bb62d5867ad95.diff

[PATCH] D55067: [HIP] Fix offset of kernel argument for AMDGPU target

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Is this still relevant? We want to move towards consistently using byref for kernel arguments anyway CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55067/new/ https://review

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

adalava updated this revision to Diff 385849. adalava retitled this revision from "[PowerPC] [Clang] Add MMX intrinsics support to FreeBSD" to "[PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD". adalava edited the summary of this revision. adalava added a comment. add more ppc_wrappe

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

This revision was automatically updated to reflect the committed changes. ardb marked an inline comment as done. Closed by commit rG24772720c545: [ARM] reject -mtp=cp15 if target subarch does not support it (authored by ardb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check

fwolff added a comment. Thanks for reviewing this! Can you (or someone else) commit this for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113429/new/ https://reviews.llvm.org/D113429 __

[clang] 196554d - Comment parsing: Complete list of Doxygen commands

Author: Aaron Puchert Date: 2021-11-09T18:35:26+01:00 New Revision: 196554d42d329e45363afe2293d1fc19de75673d URL: https://github.com/llvm/llvm-project/commit/196554d42d329e45363afe2293d1fc19de75673d DIFF: https://github.com/llvm/llvm-project/commit/196554d42d329e45363afe2293d1fc19de75673d.diff

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG196554d42d32: Comment parsing: Complete list of Doxygen commands (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D90?vs=3

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

Bigcheese added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/header-search-pruning/cdb.json:3 + "directory" : "DIR", + "command" : "clang -E DIR/header-search-pruning.cpp -Ibegin -I1 -Ia -I3 -I4 -I5 -I6 -Ib -I8 -Iend DEFINES -fmodules -fmodules-cache-path=DIR/m

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. In D110927#3117728 , @steakhal wrote: > For testing this I would recommend using a separate test file. > That being said, you should avoid globals even in tests when you can. The > distance between its declaration and use j

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

guitard0g updated this revision to Diff 385870. guitard0g added a comment. Fixed code formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113455/new/ https://reviews.llvm.org/D113455 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/Code

[PATCH] D55067: [HIP] Fix offset of kernel argument for AMDGPU target

yaxunl abandoned this revision. yaxunl added a comment. this is no longer needed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55067/new/ https://reviews.llvm.org/D55067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic added a comment. In D98895#3118821 , @eandrews wrote: > This patch causes a regression. > > To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp` > > test.cpp:x:3: error: 'bar<__float128>' requires 128 bit size '__float128' > typ

[PATCH] D112914: Misleading identifier detection

aaronpuchert added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst:12 + +.. code-block:: c + Sphinx can't parse that (perhaps unsurprisingly), could you declare that as having no language? ``` Warning, treat

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

erichkeane added a comment. In D98895#3119027 , @asavonic wrote: > In D98895#3118821 , @eandrews wrote: > >> This patch causes a regression. >> >> To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp`

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

yaxunl added a comment. LGTM. It seems all concerns have been addressed. Shall we move ahead and land this patch? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 _

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. Yep, I'm currently validating locally, I somehow messed up a rebase :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 ___ c

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic added a comment. In D98895#3119064 , @erichkeane wrote: > In D98895#3119027 , @asavonic wrote: > >> In D98895#3118821 , @eandrews wrote: >> >>> This patch causes a r

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

erichkeane added a comment. In D98895#3119104 , @asavonic wrote: > In D98895#3119064 , @erichkeane > wrote: > >> In D98895#3119027 , @asavonic wrote: >> >>> In D98895#311882

  1   2   3   >