[PATCH] D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111860/new/ https://reviews.llvm.org/D111860 _

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks created this revision. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, eraman. Herald added a reviewer: ctetreau. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously, any change in

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc added a comment. > Maybe it should even be semantically restricted to require a constant decl > reference as its operand? I think we should do this. Maybe it should be named something like `__builtin_symbol_address` if we're intending for this to have an effect with PAuth as well? Reposi

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. Yeah, I think that's a better name. The documentation can say that ideally this also wouldn't include things like the THUMB bit, but there are technical limitations that make it hard to achieve that. You could also make this Just Work for things like C++ member functi

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

saghir created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calls to MMA builtins that take pointer to void do not accept other pointers/arrays whereas normal fu

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

craig.topper added a comment. The title of this patch isn't descriptive of the changes in this patch. Based on the title I would only expect changes to RISCVEmitter.cpp. Can you clarify the title? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1126

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev added a comment. Oh, sorry, I marked it as "changes intended" so that you could know it's not review-ready yet :) I was just playing around with it and previewing to see how it would feel to have a somewhat working solution. I didn't really implement the feature (add the proper header

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c:3 // REQUIRES: riscv-registered-target -// RUN: %clang_cc1 -triple riscv64 -target-feature +experimental-v -disable-O0-optnone -emit-llvm %s -o - | opt -S -mem2reg | FileC

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a comment. Reviewing the code, I don't see any obvious sources of non-determinism (hash iteration). The only source I can imagine is uninitialized memory usage in the APInt. Let me know if this can be repro'd somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113145: [Sema] Mark virtual method declaration in union as invalid

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! fyi, I'll be on vacation for the next three weeks. I've added some additional reviewers to the patch based on prior reviews. Repository: rG LLV

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

eugenis added a comment. In D105169#3111935 , @hyeongyukim wrote: > - long long res; > + register long long res __asm__("x0"); > > Is it okay to commit this change by myself? Yes, go ahead! Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Generally lg. I find the word "allowlist" (and to a lesser level also "ignorelist") a bit awkward; imho you can often make things more clear by rephrasing things away from "foolist". A few sug

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before th

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks added a comment. Or am I mistaken and we want to be able to control the line break? Also I would break before struct, class, union, but I would have needed to change the test, and I know that we at least need to talk about in in front. :) template require X class ...

[clang] 456a7e5 - [clang][asan] Add test for ensuring PR52382 is fixed

Author: Leonard Chan Date: 2021-11-05T14:10:34-07:00 New Revision: 456a7e52310d632be4e41a4b7c4853e910648621 URL: https://github.com/llvm/llvm-project/commit/456a7e52310d632be4e41a4b7c4853e910648621 DIFF: https://github.com/llvm/llvm-project/commit/456a7e52310d632be4e41a4b7c4853e910648621.diff

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

This revision was automatically updated to reflect the committed changes. Closed by commit rG456a7e52310d: [clang][asan] Add test for ensuring PR52382 is fixed (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113143/new/ http

[PATCH] D113320: [clang-format] Address fixme

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLV

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

nikic added a comment. I don't think I fully understand the interaction this has with eager invalidation. I would have expected that if we eagerly invalidate, then this fine-grained invalidation wouldn't make much of a difference, because we invalidate anyway after processing a function. ===

[clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created

Author: Zahira Ammarguellat Date: 2021-11-05T15:08:09-07:00 New Revision: 627868263cd4d57c230b61904483a3dad9e1a1da URL: https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da DIFF: https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:546 fs::make_absolute(TestScheme::TestDir, Path); +path::native(Path); return std::string(Path); mstorsjo wrote: > sammccall wrote: > > This change is an exampl

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. In D108482#314 , @tambre wrote: > In D108482#3108013 , @ricejasonf > wrote: > >> In D108482#3105889 , @tambre wrote: >> >>> I presume you

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen removed subscribers: rsmith, rjmccall. samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3112492 , @rjmccall wrote: > You could also make this Just Work for things like C++ member functions > rather than

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. I feel like we're getting lost in the weeds here. At the time a bitcode module is finalized, it is supposed to be in a valid state. The LLVM bitcode verifier does not consider GlobalAliases which have either a null or an undefined aliasee to be valid. The same shoul

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc added subscribers: rjmccall, rsmith. pcc added a comment. (Adding back @rsmith, @rjmccall.) In D108479#3113035 , @samitolvanen wrote: > In D108479#3112492 , @rjmccall > wrote: > >> You could also make this

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385211. ibookstein added a comment. Changed to using D->hasAttr() and passing that bool into the checkAliasedGlobal function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.or

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385212. ibookstein added a comment. Nicer param order for checkAliasedGlobal.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868 Files: clang/lib/CodeGen/CodeGenMo

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. In D108479#3113055 , @pcc wrote: > (Adding back @rsmith, @rjmccall.) > > In D108479#3113035 , @samitolvanen > wrote: > >> In D108479#3112492 , @

[PATCH] D112916: Confusable identifiers detection

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. The LLVM Board of Directors will do a legal review of this change. We will give an update in 4-6 weeks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3108140 , @salman-javed-nz wrote: > It looks good to me. I don't have any more comments to add - it is a very > small code change after all. > I have commit access and am happy to commit it on your behalf. > > However

[PATCH] D112926: run-clang-tidy.py analyze unique files only

salman-javed-nz added a comment. In D112926#3113206 , @serkazi wrote: > This is now accepted, please feel free to merge on my behalf. Thanks. What's the full name and email you want associated with your commit? CHANGES SINCE LAST ACTION https://revie

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3113220 , @salman-javed-nz wrote: > In D112926#3113206 , @serkazi wrote: > >> This is now accepted, please feel free to merge on my behalf. Thanks. > > What's the full name and

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. @joerg, @emaste -- I finally got a chance to experiment with a Linux docker container and confirmed that libgcc_s's `__register_frame` can handle individual frames. Unfortunately that does not help us on FreeBSD. If we ignore FreeBSD for a moment we could imagine switch

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

rjmccall added inline comments. Comment at: clang/include/clang/Driver/Options.td:2865-2872 +let Group = f_Group in { + let Flags = [CC1Option] in { +def fptrauth_intrinsics : Flag<["-"], "fptrauth-intrinsics">, + HelpText<"Enable pointer-authentication intrinsics">; +

[PATCH] D113320: [clang-format] Address fixme

owenpan added a comment. Looks okay. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3064-3068 + for (const auto &Node : Line.Tokens) { +for (const auto &ChildNode : Node.Children) + printDebugInfo(ChildNode, "\nChild: "); + } Nit: elide brace

[clang-tools-extra] 0dc856e - [clang-tidy] run-clang-tidy.py: analyze unique files only

Author: Serikzhan Kazi Date: 2021-11-06T19:53:18+13:00 New Revision: 0dc856ed20e0fb64dd7cb0a10db35c58c3ef95e6 URL: https://github.com/llvm/llvm-project/commit/0dc856ed20e0fb64dd7cb0a10db35c58c3ef95e6 DIFF: https://github.com/llvm/llvm-project/commit/0dc856ed20e0fb64dd7cb0a10db35c58c3ef95e6.diff

[PATCH] D112926: run-clang-tidy.py analyze unique files only

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dc856ed20e0: [clang-tidy] run-clang-tidy.py: analyze unique files only (authored by serkazi, committed by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

<    1   2