[PATCH] D112965: [GlobalDCE][IR] Allow and support multiple !vcall_visibility ranges

kubamracek created this revision. kubamracek added reviewers: pcc, rjmccall, fhahn. kubamracek added a project: LLVM. Herald added subscribers: ormris, dexonsmith, hiraditya. kubamracek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposi

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. In D112881#3100214 , @Eugene.Zelenko wrote: > Please mention improvement in Release Notes, in `Changes in existing checks` > section. See example >

[PATCH] D112913: Misleading bidirectional detection

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Nits and a suggested approach for invalid code sequences that's probably important to handle better. Please fix the clang-tidy findings too. Otherwise, LGTM. Comment at: cl

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001 + case ISD::INTRINSIC_VOID: { +if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw || +N->getConstantOperandVal(1) == Intrinsic::ppc_tw) { Might be a good idea

[PATCH] D112913: Misleading bidirectional detection

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. Nice addition! Please add this check to the documentation (list of available checks + individual page with the documentation for this check), plus mention in the clang-

[PATCH] D112914: Misleading identifier detection

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good as far as it goes (though I've not checked your classification functions are correct). We should have some detection for RTL characters in string literals and comments too, at leas

[PATCH] D112913: Misleading bidirectional detection

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:61 +CheckFactories.registerCheck( +"misc-misleading-bidirectional"); } Nit: please keep alphabetical order in the list of jobs. Repository: rG

[PATCH] D112628: NOT READY FOR REVIEW Nothing to see here, just exporting to show this to someone.

dblaikie added a comment. Rather than sending a review to the lists that you don't need review for, you can create draft reviews that send no mail and share them manually with your intended audience, discussed/documented here: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-c

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

dblaikie added a comment. In D107049#3100630 , @rnk wrote: > So, to back up a bit, do I understand correctly that this change adds tests > to the check-clang test suite that JIT compiles C++ code for the host and > throws C++ exceptions? Can we reconsid

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. Just to be sure my understanding is correct. Given an AttributedType node, we do have a way to get the corresponding Attr, is it right? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/ https:/

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks added a comment. Herald added a reviewer: ctetreau. I rebased this and there are still major memory regressions for tramp3d-v4: https://llvm-compile-time-tracker.com/compare.php?from=f63405f6e3d30f33e715ef5ad09136127535a3fb&to=aec1375e4afe90727f1c30dae1659d11a20d&stat=max-rss Perhaps

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383921. kstoimenov marked an inline comment as done. kstoimenov added a comment. Update after discussing with vitalybuka@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() vitalybuka wrote: > Why do we need to remove AddressSanitizerOptions? Adding it back

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3100376 , @HazardyKnusperkeks wrote: > In D95168#3099920 , @owenpan wrote: > >> In D95168#3099739 , @MyDeveloperDay >> wrote: >> >>> - Lo

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks created this revision. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added a

[PATCH] D112971: [NFC] Remove LinkAll*.h

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112971/new/ https://reviews.llvm.org/D112971

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

andrew.w.kaylor added a comment. Herald added a subscriber: luke957. I agree that the pragma should also control the evaluation of constant expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112094/new/ https://reviews.llvm.org/D112094 _

[clang] 8bf1244 - DebugInfo: workaround for context-sensitive use of non-type-template-parameter integer suffixes

Author: David Blaikie Date: 2021-11-01T17:08:26-07:00 New Revision: 8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa URL: https://github.com/llvm/llvm-project/commit/8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa DIFF: https://github.com/llvm/llvm-project/commit/8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa.diff

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf12445383b: DebugInfo: workaround for context-sensitive use of non-type-template-parameter… (authored by dblaikie). Herald added a project: libc++.

[PATCH] D112913: Misleading bidirectional detection

MaskRay added a comment. > Context not available. If you don't use `arc diff 'HEAD^'` to upload a Diff, please use -U9 https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cp

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1fdd745d510: Re-introduce `copts` hacks for lib/AST includes. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D112913: Misleading bidirectional detection

MaskRay requested changes to this revision. MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:19 + +static bool ContainsMisleadingBidi(StringRef Buffer, bool HonorLineBreaks=true) { + const char* CurPtr = Buffer.begin(); --

[PATCH] D112913: Misleading bidirectional detection

MaskRay added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-bidirectional.cpp:1 +// RUN: %check_clang_tidy %s misc-misleading-bidirectional %t + The test misses many interesting cases. Repository: rG LLVM Github Mono

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

emaste added a comment. In D111863#3100654 , @lhames wrote: > @joerg @dim @emaste Any further comments on this? I have no objection. 2016 (when I patched FreeBSD's in-tree libunwind) is long enough ago that I don't recall any of the context but indeed

[PATCH] D112916: Confusable identifiers detection

MaskRay added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-homoglyph.cpp:4 +int fo; +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: fo is confusable with 𝐟o [misc-homoglyph] +int 𝐟o; `[[@LINE-1]]` is deprecated lit feature. Use `[[#@

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. :-( Did you try the separate library with `strip_include_prefix`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___ cfe-commi

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:711 +# headers such as `CXXABI.h`. +"-I$(GENDIR)/external/llvm-project/clang/lib/AST", +"-I$(GENDIR)/external/llvm-project/clang/lib/AST/Interp",

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101645 , @GMNGeoffrey wrote: > :-( Did you try the separate library with `strip_include_prefix`? I can add a separate library to do that. It would still expose all consumers to `Opcodes.inc` instead of only ex

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added a comment. Thanks, making suggested changes and then landing! Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364 +# Clang-specific define on non-Windows platforms. +"CLANG_HAVE_RLIMITS=1", +], GMNG

[PATCH] D112975: Fix complex types declared using mode TC

eandrews created this revision. eandrews added reviewers: qiucf, rjmccall. eandrews requested review of this revision. This patch reverts incorrect IR - introduced in commit d11ec6f67e45 (https://reviews.llvm.org/rGd11ec6f67e4

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101665 , @chandlerc wrote: > In D112883#3101645 , @GMNGeoffrey > wrote: > >> :-( Did you try the separate library with `strip_include_prefix`? > > I can add a separate

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097652 , @rjmccall wrote: > In D109950#3097544 , @eandrews > wrote: > >> In D109950#3097161 , @rjmccall >> wrote: >> >>> Oh, yes, I

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

shafik added a comment. I think this is fine as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111477/new/ https://reviews.llvm.org/D111477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D112975: Fix complex types declared using mode TC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. For posterity in case someone tracks down this review: `TC` corresponds to an unspecified 128-bit format, which on some targets is a double-double format (like `__ibm128_t`) and on others

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a type out of a module

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5748-5750 +else if (isa(Cur)) + Diag(Loc, diag::err_invalid_declarator_in_export) + << Name << cast(DC) << SS.getRange(); aaron.ballman wrote: > I don't believe this is suf

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. Thanks. @hubert.reinterpretcast, @qiucf, can you verify that other compilers for PPC follow the logic for `TF` / `TC` that we now have with Elizabeth's patch? There are three different type specifiers (`long double`, `__ibm128`, and `float128_t`) which represent form

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101685 , @GMNGeoffrey wrote: >> Is this breaking actual users? I wouldn't expect it to break unless they >> depend on this target. > > I don't know :-) I just know that people have sent me patches to remove the >

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1828 ], -copts = [ -"-Wno-uninitialized", -], +copts = select({ +"@bazel_tools//src/conditions:windows": [], rnk wrote: > Enabling war

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0198d76e1e76: [Bazel] Get `//clang` building on Windows with clang-cl. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 383952. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. This caused regression in Thrust: /long_pathname_so_that_rpms_can_package_the_debug_info/data/driver/rocThrust/thrust/../thrust/detail/type_traits/pointer_traits.h:178:20: error: ambiguous partial specializations of 'pointer_element>' typedef typename pointer_elem

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383953. pcwang-thead added a comment. - Changes to `Args.AddLastArg(CmdArgs, ...)` - Adds a note to `clang/docs/ReleaseNotes.rst` - Fixs clangd test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. I am not familiar with inline assembly, but it seems the output variable (`%0`) is not updated because it does not appear in the code. 1382 __asm__ __volatile__( 1383"mov x0,x2\n" /* flags */ 1384"mov x2,x4\n" /* pt

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi updated this revision to Diff 383959. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112926/new/ https://reviews.llvm.org/D112926 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383970. pcwang-thead added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Removes unnecessary -fno-sized-deallocation and some comments. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383981. pcwang-thead marked an inline comment as done. pcwang-thead added a comment. - Regenerate `clang\test\AST\ast-dump-stmt-json.cpp` and `clang\test\AST\ast-dump-expr-json.cpp`. - Format code. Repository: rG LLVM Github Monorepo CHANGES SINCE L

<    1   2