[PATCH] D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface

fcloutier updated this revision to Diff 383227. fcloutier added a comment. Add test for a protocol method with `format_arg`, second NSString method accepting a NSString instead of a C string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112670/new/

[PATCH] D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3392 + // replace instancetype with the class type + if (Ty.getTypePtr() == S.Context.getObjCInstanceTypeDecl()->getTyp

[PATCH] D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a5f7437720e: format_arg attribute should allow instancetype in NSString definition (authored by fcloutier). Repository: rG LLVM Github Monorepo

[clang] 6a5f743 - format_arg attribute should allow instancetype in NSString definition

Author: Félix Cloutier Date: 2021-10-28T20:25:00-07:00 New Revision: 6a5f7437720ea0fa184469584600c27a1a912a41 URL: https://github.com/llvm/llvm-project/commit/6a5f7437720ea0fa184469584600c27a1a912a41 DIFF: https://github.com/llvm/llvm-project/commit/6a5f7437720ea0fa184469584600c27a1a912a41.diff

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

brad added a comment. Oh, and you would have to use chomp to eliminate the newline character. Never mind. That's kind of ugly. Maybe it is better to go back to the original diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 ___

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu added a comment. @rsmith gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

xazax.hun added a comment. In D112646#3092619 , @whisperity wrote: > @xazax.hun I think you did something similar wrt. `empty()`, right? Could you > take a look at this? The idea looks good to me. The module also sounds right. If we want to follow con

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

zixuan-wu added a comment. Herald added a subscriber: dang. Hi, I am wondering could -fsized-deallocation this be enabled by default nowadays in 2021? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8467/new/ https://reviews.llvm.org/D8467

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. > Ah, yeah, I see what you mean - that does seem sort of unfortunate. Is it > possible these attributes could only appear on typedefs and they'd be more > readily carried through that without needing extra typeloc tracking? (sorry > for not having read back throug

[clang] d758069 - [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

Author: Martin Storsjö Date: 2021-10-29T09:32:36+03:00 New Revision: d758069f5e0d483f85ed1ee2c84b3955238eedce URL: https://github.com/llvm/llvm-project/commit/d758069f5e0d483f85ed1ee2c84b3955238eedce DIFF: https://github.com/llvm/llvm-project/commit/d758069f5e0d483f85ed1ee2c84b3955238eedce.diff

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rGd758069f5e0d: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111952

[clang-tools-extra] fc1b24d - [clang-tidy]performance-unnecessary-copy-initialization: fix false negative

Author: Clement Courbet Date: 2021-10-29T08:41:03+02:00 New Revision: fc1b24d7360f59c8b89f1b6290fe849a6207dc44 URL: https://github.com/llvm/llvm-project/commit/fc1b24d7360f59c8b89f1b6290fe849a6207dc44 DIFF: https://github.com/llvm/llvm-project/commit/fc1b24d7360f59c8b89f1b6290fe849a6207dc44.dif

[PATCH] D112722: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1b24d7360f: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 383241. serge-sans-paille added a comment. Re-uploading previous version that walks redef, with a slight change in the walking algorithm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files:

[clang] 95e6e1c - [clang] Partially revert d8cd7806310c51af912a647a6ca46de62ff13214.

Author: Brad Smith Date: 2021-10-29T02:41:54-04:00 New Revision: 95e6e1cc923d6b88ebb4ac5e8f0887c2c77476cc URL: https://github.com/llvm/llvm-project/commit/95e6e1cc923d6b88ebb4ac5e8f0887c2c77476cc DIFF: https://github.com/llvm/llvm-project/commit/95e6e1cc923d6b88ebb4ac5e8f0887c2c77476cc.diff LO

<    1   2   3