[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 382445. fhahn marked an inline comment as done. fhahn added a comment. add comment to arg of Diag message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111986/new/ https://reviews.llvm.org/D111986 Files: clang

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382446. JonChesterfield added a comment. - rebase, having landed D111987 this time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) v.g.vassilev wrote: > thakis wrote: > > Why are these additions needed here again? This change doesn't add any code > > to ClangReplInterpreter

[PATCH] D112398: [RISCV] Add ABI testing for Float16.

craig.topper added a comment. In D112398#3087183 , @frasercrmck wrote: > It looks as though all checks are checking the same thing? Presumably this is > expected? I wonder if allowing an extra combined check > (`--check-prefixes=CHECK,CHECK-ZFH-ILP32F`

[PATCH] D112572: [docs][clang-format] warn on code indentation error

FederAndInk created this revision. FederAndInk added reviewers: MyDeveloperDay, HazardyKnusperkeks. FederAndInk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is an indentation issue in Format.h causing the html to not render correc

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. Problem with missing symbol for __omp_rtl_debug_kind was a local error. I did the initial testing of this with a jury rigged clang that linked the new bitcode and ignored the old. The generation of this integer is guarded by which runtime clang thinks it is comp

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian updated this revision to Diff 382451. ngzhian added a comment. No shuffles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112186/new/ https://reviews.llvm.org/D112186 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/lib/Co

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18262-18267 +case WebAssembly::BI__builtin_wasm_relaxed_trunc_zero_s_i32x4_f64x2: + IntNo = Intrinsic::wasm_relaxed_trunc_zero_signed; + break; +case WebAssembly::BI__builtin_wasm_relaxed

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. Requires either D112544 or disabling bug51982 on newRTL before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227

[PATCH] D92270: [ConstantFold] Fold more operations to poison

MatzeB added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:633 // the input constant. -return UndefValue::get(DestTy); +return PoisonValue::get(DestTy); } I believe this is causing some of our clients trouble, especiall

[PATCH] D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format))

fcloutier updated this revision to Diff 382461. fcloutier added a comment. Thanks Artem for pointing out that I was completely misusing `getFunctionScopeIndex`. This should be better. I added a test that you can pick a non-1 value for the format parameter in blocks. CHANGES SINCE LAST ACTION

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + chandlerc wrote: > thakis wrote: > > Why do we need this with bazel but not with other windows builds? > I don't know how this neve

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. It seems like you are fixing more than just the bug you highlight, i.e looks you might be fixing some autopep8 or pylint issues too. As this isn't a tool we ship, I don't have

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18614 + auto *PolicyAttr = E->getCalleeDecl()->getAttr(); + size_t PolicyValue; Why size_t? This would be the size_t of the host machine that's building/running the compiler and

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. > I don't recall any issues on my last benchmark, but i'll run the patch across > all of our modular files and see if anything comes up. I ran the patch against ~1500 sources here and there were no unexpected warnings or failures. Repository: rG LLVM Github Monorepo C

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

FederAndInk added a comment. In D112572#3088800 , @MyDeveloperDay wrote: > It seems like you are fixing more than just the bug you highlight, i.e looks > you might be fixing some autopep8 or pylint issues too. Yes, I also fixed some minor issues, my ba

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan created this revision. ddpagan added reviewers: ABataev, jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: aaron.ballman. ddpagan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects:

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thank you for fixing this terrible edge case; LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 ___ cfe-commits mailing li

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier created this revision. fcloutier added reviewers: dcoughlin, doug.gregor, rsmith. fcloutier added a project: clang. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. Clang only allows you to use `__attribute__((fo

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

vsapsai updated this revision to Diff 382477. vsapsai added a comment. Rebase and update the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) v.g.vassilev wrote: > v.g.vassilev wrote: > > thakis wrote: > > > Why are these additions needed here again? This change doesn't add any > > > code t

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

vsapsai added a comment. /cc @v.g.vassilev as he mentioned an issue with late-parsed templates can be similar to this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added a comment. Actually, it looks like: diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 69d2ef631872..8e77cdef2ed5 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -10927,6 +10927,10 @@ bool Sema::CheckFunctionD

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

vsapsai added a comment. Lots of relevant discussion can be found at https://reviews.llvm.org/D109632 I'll add the link to it to the summary later, for now the summary is the same as commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, I'll land my fix and with this we can switch over to the new RT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://rev

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

rjmccall accepted this revision. rjmccall added a comment. This seems reasonable. You could also give `ExitFunctionBodyRAII` an explicit `pop()` operation, but either way is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111814/new/ https://

[PATCH] D112059: Fix inline builtin handling in case of redefinition

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/user-func-gnu-inline-redecl.c:20 + return some_size(s); +} this test passes before this patch is applied; I wonder if we have existing coverage in tree for this case? Surprisingly, I don't t

[PATCH] D111669: No longer crash when a consteval function returns a structure

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. Hmm. Generally these cases are expected to handle the situation where there's no result slot passed in, which currently isn't exclusive to an ignored result (although you could

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382481. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382482. kstoimenov added a comment. Added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h ll

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382483. kstoimenov added a comment. Removed {} after if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Can you please fix in a separate patch llvm::runPassPipeline: it runs ModulePass after the function pass for -passes=asan-pipeline Comment at: llvm/lib/Transforms/In

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov marked 2 inline comments as done. kstoimenov added a comment. PTAL. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1265 GlobalsMetadata ASanGlobalsMetadataAnalysis::run(Module &M, ModuleAnalysis

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93 + bool invalidate(Module &, const PreservedAnalyses &, + ModuleAnalysi

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382486. kstoimenov added a comment. s/I/LI/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h llvm/lib/T

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

nickdesaulniers added a comment. Fixes https://bugs.llvm.org/show_bug.cgi?id=51498? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112143/new/ https://reviews.llvm.org/D112143 ___ cfe-commits mailing list

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added a comment. Fixes https://bugs.llvm.org/show_bug.cgi?id=23258? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112413/new/ https://reviews.llvm.org/D112413 ___ cfe-commits mailing list

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei added a comment. In D112143#3089072 , @nickdesaulniers wrote: > Fixes https://bugs.llvm.org/show_bug.cgi?id=51498? Yes. I mentioned pr51498 in commit message :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei added a comment. In D112413#3089073 , @nickdesaulniers wrote: > Fixes https://bugs.llvm.org/show_bug.cgi?id=23258? Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112413/new/ https://reviews.l

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

nickdesaulniers added a comment. In D112143#3089072 , @nickdesaulniers wrote: > Fixes https://bugs.llvm.org/show_bug.cgi?id=51498? sorry, I missed the PR # in the description; my mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

nickdesaulniers added a comment. In D112413#3089073 , @nickdesaulniers wrote: > Fixes https://bugs.llvm.org/show_bug.cgi?id=23258? sorry, I missed the PR # in the description; my mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D112415: [Driver] ignore -maccumulate_outgoing_args option

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Let me check on https://bugs.llvm.org/show_bug.cgi?id=28145 before we start ignoring this. That might be the right approach, but let me check. Otherwise we might a

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

tlively added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18373-18374 +llvm::Type *SrcT = Vec->getType(); +llvm::Type *TruncT = +FixedVectorType::get(llvm::IntegerType::get(getLLVMContext(), 32), 4); +Function *Callee = CGM.getIntrinsic(IntNo,

[clang] 9c7ace6 - [CUDA][NFC] Fix inexact warning message about lambdas

Author: Ben Shi Date: 2021-10-27T01:28:35Z New Revision: 9c7ace60aa629ecb7bc836802a7f4e33ee1045f1 URL: https://github.com/llvm/llvm-project/commit/9c7ace60aa629ecb7bc836802a7f4e33ee1045f1 DIFF: https://github.com/llvm/llvm-project/commit/9c7ace60aa629ecb7bc836802a7f4e33ee1045f1.diff LOG: [CUDA

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c7ace60aa62: [CUDA][NFC] Fix inexact warning message about lambdas (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112521/new/ https

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA created this revision. ZarkoCA added reviewers: akyrtzi, rsmith, quinnp. ZarkoCA added a project: clang. Herald added a subscriber: dang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Trying to update some options that don't at least have an inclusive l

[PATCH] D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format))

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7788 +if (MD && MD->isInstance()) + ++PVIndex; +for (const auto *PVFormat : D->specific_attrs()) { Isn't changing `dyn_cast` enough to avoid the warn

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:540 + if (STI.hasSSE1()) +AddRegs(CallUsedRegs, X86::VR128RegClass); + if (STI.hasAVX()) Do we need to consider VR128XRegClass and VR256XRegClass when `hasVLX()`?

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. All other comments make sense. Will fix them in the next revision. Comment at: clang/lib/Sema/SemaType.cpp:6526 + } + + ASTContext &Ctx = S.Context; aaron.ballman wrote: > Should you also validate that the type is a pointer type

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song updated this revision to Diff 382518. yonghong-song added a comment. - fix various clang-format and coding style issue suggested by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/ https://reviews.llvm.org/D111

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

usaxena95 added a comment. No worries. Thanks for taking a look :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

HazardyKnusperkeks added a comment. Thanks for fixing my mistake. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112572/new/ https://reviews.llvm.org/D112572 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka added subscribers: morehouse, pcc, eugenis. vitalybuka added inline comments. Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93 + bool invalidate(Module &, const PreservedAnalyses &, + ModuleAnalysisManager::Invalidator &) { +return

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

FederAndInk added a comment. In D112572#3089318 , @HazardyKnusperkeks wrote: > Thanks for fixing my mistake. :) You're welcome ;) Thanks for your reviews. Should we add other reviewers? Also, I don't have commit rights, can one of you commit it on my

[clang] 9fb9c6b - [Clang][NFC] Clang CUDA codegen clean-up

Author: Uday Bondhugula Date: 2021-10-27T11:07:20+05:30 New Revision: 9fb9c6b91e3ab4776e52694bba3e5b95d2bfa7a0 URL: https://github.com/llvm/llvm-project/commit/9fb9c6b91e3ab4776e52694bba3e5b95d2bfa7a0 DIFF: https://github.com/llvm/llvm-project/commit/9fb9c6b91e3ab4776e52694bba3e5b95d2bfa7a0.dif

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

This revision was automatically updated to reflect the committed changes. bondhugula marked an inline comment as done. Closed by commit rG9fb9c6b91e3a: [Clang][NFC] Clang CUDA codegen clean-up (authored by bondhugula). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy.

HsiangKai updated this revision to Diff 382529. HsiangKai added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112534/new/ https://reviews.llvm.org/D112534 Files: clang/include/clang/Basic/Attr.td cl

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

salman-javed-nz created this revision. salman-javed-nz added reviewers: whisperity, aaron.ballman. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. salman-javed-nz requested review of this revision. The string table `DefaultIgnoredPa

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

salman-javed-nz added a comment. Pretty sure this is a typo. Curiously the unit tests did not pick it up. I have gone through the liberty of adding a unit test to lock down the correct spellings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112596

<    1   2   3