[clang] 53fc510 - Revert "[HIP] Relax conditions for address space cast in builtin args"

2021-10-15 Thread Anshil Gandhi via cfe-commits
Author: Anshil Gandhi Date: 2021-10-15T14:42:28-06:00 New Revision: 53fc5100e07ac078782ffb4e8e2b627c3cc8d046 URL: https://github.com/llvm/llvm-project/commit/53fc5100e07ac078782ffb4e8e2b627c3cc8d046 DIFF: https://github.com/llvm/llvm-project/commit/53fc5100e07ac078782ffb4e8e2b627c3cc8d046.diff

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

2021-10-15 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D111734#3067624 , @gandhi21299 wrote: > @tra I see, we sure can rewrite that segment for readability. It could've been done with a follow-up clean-up commit. revert/reland works, too. Thank you for following up on the comment,

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

2021-10-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D111543#3067619 , @rsmith wrote: > In D111543#3066686 , @jansvoboda11 > wrote: > >> My understanding is that `Preprocessor::getIdentifierInfo` may trigger AST >> deserialization. The p

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

2021-10-15 Thread Anshil Gandhi via Phabricator via cfe-commits
gandhi21299 updated this revision to Diff 380098. gandhi21299 added a comment. cleaned up code for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp clang/

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

2021-10-15 Thread Michael Benfield via Phabricator via cfe-commits
mbenfield added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:662 +if (Index < FD->getNumParams()) { + if (const auto *POS = + FD->getParamDecl(Index)->getAttr()) enh wrote: > mbenfield wrote: > > enh wrote: > > > (stray tabs?

[clang] f92db6d - [HIP] Relax conditions for address space cast in builtin args

2021-10-15 Thread Anshil Gandhi via cfe-commits
Author: Anshil Gandhi Date: 2021-10-15T15:35:52-06:00 New Revision: f92db6d3fff13bdacdf9b24660eb3f3158c58a17 URL: https://github.com/llvm/llvm-project/commit/f92db6d3fff13bdacdf9b24660eb3f3158c58a17 DIFF: https://github.com/llvm/llvm-project/commit/f92db6d3fff13bdacdf9b24660eb3f3158c58a17.diff

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

2021-10-15 Thread Anshil Gandhi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf92db6d3fff1: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

2021-10-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I've stepped through this in a debugger. The problem is that the `CompilerInstance` is setting up an `ASTReaderListener` that is informed whenever a module is loaded, and that listener is called when the AST file has been added to the module manager but hasn't had its he

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

2021-10-15 Thread Matt D. via Phabricator via cfe-commits
Matt added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1832 + else { +assert(!Val.getAsInteger(10, Bits)); +CmdArgs.push_back( There may be a way to avoid side-effects in assertions (`getAsInteger` changing the value o

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

2021-10-15 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I don't think we currently hold very strongly to that ActOn vs. Build philosophy across all productions, but it does seem like a good idea. I don't really know why there's this much duplication between the code paths. The only semantic distinction I know of is that I

[clang] 1830ec9 - Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols"

2021-10-15 Thread Anshil Gandhi via cfe-commits
Author: Anshil Gandhi Date: 2021-10-15T16:16:18-06:00 New Revision: 1830ec94ac022ae0b6d6876fc2251e6b91e5931e URL: https://github.com/llvm/llvm-project/commit/1830ec94ac022ae0b6d6876fc2251e6b91e5931e DIFF: https://github.com/llvm/llvm-project/commit/1830ec94ac022ae0b6d6876fc2251e6b91e5931e.diff

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

2021-10-15 Thread Max Schroetter via Phabricator via cfe-commits
schrc3b6 created this revision. Herald added a subscriber: xazax.hun. schrc3b6 added a reviewer: alexfh. schrc3b6 updated this revision to Diff 380104. schrc3b6 added a comment. schrc3b6 published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-co

[PATCH] D111830: [clang] fix typo correction not looking for candidates in base classes.

2021-10-15 Thread Matheus Izvekov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG489561d46381: [clang] fix typo correction not looking for candidates in base classes. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] 489561d - [clang] fix typo correction not looking for candidates in base classes.

2021-10-15 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2021-10-16T00:35:22+02:00 New Revision: 489561d46381d41a068beed1a2e18e00f0660248 URL: https://github.com/llvm/llvm-project/commit/489561d46381d41a068beed1a2e18e00f0660248 DIFF: https://github.com/llvm/llvm-project/commit/489561d46381d41a068beed1a2e18e00f0660248.dif

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

2021-10-15 Thread Max Schroetter via Phabricator via cfe-commits
schrc3b6 added a comment. This is my first PR here, so if I missed something, I will be more than happy to change anything if you point me in the right direction. I didn't add an extra test so far, because check_clang_tidy.py doesn't support the .h extension so far. And before adding C support

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

2021-10-15 Thread Ng Zhi An via Phabricator via cfe-commits
ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM.

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

2021-10-15 Thread Thomas Lively via Phabricator via cfe-commits
tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Awesome, thanks! I'll go ahead and land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111914/new/ https://reviews.llvm.org/D111914

[clang] da07942 - [WebAssembly] Add prototype relaxed laneselect instructions

2021-10-15 Thread Thomas Lively via cfe-commits
Author: Zhi An Ng Date: 2021-10-15T17:45:09-07:00 New Revision: da07942834fe3ea575d7f7b980940d938411afe5 URL: https://github.com/llvm/llvm-project/commit/da07942834fe3ea575d7f7b980940d938411afe5 DIFF: https://github.com/llvm/llvm-project/commit/da07942834fe3ea575d7f7b980940d938411afe5.diff LOG

[PATCH] D109128: [VFS] Use original path when falling back to external FS

2021-10-15 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 380125. keith added a comment. Improve lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c llvm/include/llvm/Suppo

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

2021-10-15 Thread Thomas Lively via Phabricator via cfe-commits
tlively closed this revision. tlively added a comment. I forgot to include the revision URL in the commit message, but this has been landed as rGda07942834fe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111923: [RISCV] Split RISCV vector builtins into their own file and namespace.

2021-10-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: HsiangKai, khchen, arcbbb, kito-cheng. Herald added subscribers: achieveartificialintelligence, ctetreau, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, th

[clang] 80dba72 - [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

2021-10-15 Thread hyeongyu kim via cfe-commits
Author: Juneyoung Lee Date: 2021-10-16T12:01:37+09:00 New Revision: 80dba72a669b5416e97a42fd2c2a7bc5a6d3f44a URL: https://github.com/llvm/llvm-project/commit/80dba72a669b5416e97a42fd2c2a7bc5a6d3f44a DIFF: https://github.com/llvm/llvm-project/commit/80dba72a669b5416e97a42fd2c2a7bc5a6d3f44a.diff

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

2021-10-15 Thread Hyeongyu Kim via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80dba72a669b: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune, committed by hyeongyukim). Changed

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

2021-10-15 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. After this patch, `-print-stats` started erroring out. I filed a bug at https://bugs.llvm.org/show_bug.cgi?id=52193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270 _

[clang] 705387c - Resolve lit failures in clang after 8ca4b3e's land

2021-10-15 Thread Juneyoung Lee via cfe-commits
Author: Juneyoung Lee Date: 2021-10-16T13:51:50+09:00 New Revision: 705387c5074bcca36d626882462ebbc2bcc3bed4 URL: https://github.com/llvm/llvm-project/commit/705387c5074bcca36d626882462ebbc2bcc3bed4 DIFF: https://github.com/llvm/llvm-project/commit/705387c5074bcca36d626882462ebbc2bcc3bed4.diff

[clang] 9aa6c72 - Fix lit test failures in clang-ppc* and clang-x64-windows-msvc

2021-10-15 Thread Juneyoung Lee via cfe-commits
Author: Juneyoung Lee Date: 2021-10-16T14:33:59+09:00 New Revision: 9aa6c72b92b6c89cc6d23b693257df9af7de2d15 URL: https://github.com/llvm/llvm-project/commit/9aa6c72b92b6c89cc6d23b693257df9af7de2d15 DIFF: https://github.com/llvm/llvm-project/commit/9aa6c72b92b6c89cc6d23b693257df9af7de2d15.diff

<    1   2