[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 _

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks updated this revision to Diff 379827. aeubanks added a comment. add more comments about the cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111767/new/ https://reviews.llvm.org/D111767 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk added a comment. There are some invariants about what family of APIs TreeTransform methods should call, and I've forgotten what they are, so I'm hesitant to approve this. Test case looks good, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] d0a5f61 - [clang] Support -clear-ast-before-backend without -disable-free

Author: Arthur Eubanks Date: 2021-10-14T13:43:53-07:00 New Revision: d0a5f61c4f6fccec87fd5207e3fcd9502dd59854 URL: https://github.com/llvm/llvm-project/commit/d0a5f61c4f6fccec87fd5207e3fcd9502dd59854 DIFF: https://github.com/llvm/llvm-project/commit/d0a5f61c4f6fccec87fd5207e3fcd9502dd59854.diff

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a5f61c4f6f: [clang] Support -clear-ast-before-backend without -disable-free (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 379830. martong added a comment. - Fix signedness mismatch assertaion and add a test case for that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/ https://reviews.llvm.org/D110357 Files: clang/inc

[PATCH] D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

vsapsai added a comment. Ping. Failed tests seem to be unrelated (don't know how this change would cause "flangOmpReport.so: cannot open shared object file: No such file or directory"). If you think it would be better, can rebase and trigger new builds. Repository: rG LLVM Github Monorepo C

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111476/new/ https://reviews.llvm.org/D111476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Tue, Oct 12, 2021 at 7:35 PM David Blaikie wrote: > On Mon, Oct 11, 2021 at 2:46 PM Richard Smith > wrote: > >> On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: >> >>> On Tue, Sep 14, 2021 at 10:04 AM Richard Smith >>> wrote: >>> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

enh added a comment. "shut up and take my money!" :-) Comment at: clang/lib/Sema/SemaChecking.cpp:662 +if (Index < FD->getNumParams()) { + if (const auto *POS = + FD->getParamDecl(Index)->getAttr()) (stray tabs?) Repository: rG LLVM Gi

[clang] 675ed4c - [NFC][Interpreter] Remove unused CompilerInvocation

Author: Arthur Eubanks Date: 2021-10-14T15:17:49-07:00 New Revision: 675ed4c82df6bb53536270d900843a985ef9036e URL: https://github.com/llvm/llvm-project/commit/675ed4c82df6bb53536270d900843a985ef9036e DIFF: https://github.com/llvm/llvm-project/commit/675ed4c82df6bb53536270d900843a985ef9036e.diff

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. In D111078#3063245 , @lkail wrote: > This LGTM as the start point to support int128 on AIX. We might need more > patches involving libraries in the LLVM monorepo, we can do that > progressively. Agreed (although

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks updated this revision to Diff 379866. aeubanks added a comment. force off for the clang interpreter I thought I ran check-clang, apparently I didn't Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270

[PATCH] D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation

ychen added a comment. Herald added a subscriber: dang. In D58751#1417467 , @manmanren wrote: > r355333 Hello, thanks for this nice feature. Are there any docs on how to use it? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D111471: [NVPTX] Add a late SROA pass which allows optimizing away more allocas.

tra updated this revision to Diff 379872. tra edited the summary of this revision. tra added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111471/ne

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Caching.h:1 +//===- Caching.h - LLVM File Cache Handling Configuration -===// +// There needs to be a `*- C++ -*-`. Can you check whether the hea

[PATCH] D111853: [NFC][Interpreter] Remove unused CompilerInvocation

roligugus created this revision. roligugus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111853 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interprete

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + JDevlieghere wrote: > I'm pretty sure there was a reason we stopped doing this. There should be >

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379881. keith marked an inline comment as done. keith added a comment. Extract fallback status logic to another function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379882. keith added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c llvm/include/llvm/Support/Vir

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

craig.topper added a comment. In D111778#3064555 , @erichkeane wrote: > In D111778#3064439 , @craig.topper > wrote: > >> In D111778#3064287 , @FreddyYe >> wrote: >> >>>

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus updated this revision to Diff 379892. roligugus added a comment. [git-clang-format] Rebase D84375 on latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus added a comment. @MyDeveloperDay Thanks for the follow-up! I've rebased on latest main. Out of curiosity, as I am trying to wrap my head around the llvm workflow: Could I `arc land ...` myself once you sign off with "ready to land" even if I don't have llvm commit rights? If so, pleas

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted at 6 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions.

vsapsai created this revision. vsapsai added reviewers: Bigcheese, bnbarham. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Add a test that shows a warning is emitted when we cannot find a visible protocol and merge definition visibil

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @pchaigno as @efriedma suggested, we can add some transformation in BPF target IR passes to ignore @llvm.stacksave() and @llvm.stackrestore(). I should have a patch ready soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

ChuanqiXu updated this revision to Diff 379907. ChuanqiXu added a comment. Herald added a subscriber: dexonsmith. Address the comments from @rsmith. It looks much better now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 Files: clang/inclu

[clang] effbf0b - PR52183: Don't emit code for a void-typed constant expression.

Author: Richard Smith Date: 2021-10-14T20:55:51-07:00 New Revision: effbf0bdd039237542ac5e9afe1f23c9386010e2 URL: https://github.com/llvm/llvm-project/commit/effbf0bdd039237542ac5e9afe1f23c9386010e2 DIFF: https://github.com/llvm/llvm-project/commit/effbf0bdd039237542ac5e9afe1f23c9386010e2.diff

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel created this revision. housel added a reviewer: cfe-commits. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. housel requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 379912. noajshu added a comment. Add *- C++ -*- header indicator to Caching.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.c

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu marked an inline comment as done. noajshu added inline comments. Comment at: llvm/include/llvm/Support/Caching.h:1 +//===- Caching.h - LLVM File Cache Handling Configuration -===// +// MaskRay wrote: > There needs to be a `*- C++ -*-`. >

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

MaskRay added a comment. I looked at the libgcc mechanism at one time. I remember that most cases just use `PT_GNU_EH_FRAME` and these eh_frame boundary registry functions are not needed. Can ORC just use `PT_GNU_EH_FRAME`? Clang passes `--eh-frame-hdr` to ld even in `-static` mode, unlike GCC.

[clang] 12cbc8c - [analyzer] Fix property access kind detection inside parentheses.

Author: Artem Dergachev Date: 2021-10-14T21:07:19-07:00 New Revision: 12cbc8cbf071901686b36e192a6d4da19deb6ec6 URL: https://github.com/llvm/llvm-project/commit/12cbc8cbf071901686b36e192a6d4da19deb6ec6 DIFF: https://github.com/llvm/llvm-project/commit/12cbc8cbf071901686b36e192a6d4da19deb6ec6.dif

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 379917. pmatos added a comment. Herald added subscribers: cfe-commits, ormris, jdoerfert, steven_wu. Herald added a project: clang. Simplified a lot of code that required some further fixes and de-duplication. Most importantly, I added many more testcases to e

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos marked 4 inline comments as done. pmatos added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/externref-tableget.ll:8 + +define %externref @get_externref_from_table(i32 %i) { + %p = getelementptr [0 x %externref], [0 x %externref] addrspace (1)* @externref_ta

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3065992 , @MaskRay wrote: > I looked at the libgcc mechanism at one time. I remember that in most cases > it just uses `PT_GNU_EH_FRAME` and these eh_frame boundary registry functions > are not needed. > Can ORC just u

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 379918. hsmhsm marked 2 inline comments as done. hsmhsm added a comment. Rebase + minor clean-up to patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: cla

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ibm128-cast.c:59 + // IEEE: %{{.+}} = fadd ppc_fp128 %{{.+}}, %{{.+}} + w + q; + // CHECK: %{{.+}} = fadd ppc_fp128 %{{.+}}, %{{.+}} It's controversial enough to consider, as well-for

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added a comment. After more than 1 week without comments, I kindly ping reviewers @mgartmann @aaron.ballman @hokein @whisperity @njames93 to have a look and see if we can merge or is there something I should address. I have posted a question about Sema in cfe-dev, but didn't get

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, jrtc27, kito-cheng, asb, luismarques. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 379924. achieveartificialintelligence added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/lib/Basic/Target

<    1   2