[PATCH] D111529: Specify Clang vector builtins.

2021-10-13 Thread Florian Hahn via Phabricator via cfe-commits
fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:552 +operation(x, y) as pairwise tree reduction to the input. The pairs are formed +by concatenating both inputs and pairing adjacent elements. + cr

[PATCH] D111529: Specify Clang vector builtins.

2021-10-13 Thread Steve Canon via Phabricator via cfe-commits
scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. I'm happy with this now. Comment at: clang/docs/LanguageExtensions.rst:552 +operation(x, y) as pairwise tree reduction to the input. The pairs are formed +by concatenating bo

[PATCH] D111529: Specify Clang vector builtins.

2021-10-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:552 +operation(x, y) as pairwise tree reduction to the input. The pairs are formed +by concatenating both inputs and pairing adjacent elements. + fhahn wrote: > craig.topper wrote:

[PATCH] D111529: Specify Clang vector builtins.

2021-10-13 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz added inline comments. Comment at: clang/docs/LanguageExtensions.rst:553 +Each builtin returns a scalar equivalent to applying the specified +operation(x, y) as horizontal recursive pairwise reduction to all vector +elements. In each reduction step, ``operation(x, y)`` i

[PATCH] D109632: [clang] de-duplicate methods from AST files

2021-10-13 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. It's good to know `ASTReader::ReadMethodPool` is pretty close for both approaches. And as far as I understand, it includes the code ReadMethodPoolVisitor Visitor(*this, Sel, PriorGeneration); ModuleMgr.visit(Visitor); so the module visiting doesn't seem to be too ex

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

2021-10-13 Thread Frederic Cambus via Phabricator via cfe-commits
fcambus created this revision. fcambus added reviewers: emaste, joerg, mgorny, krytarowski. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111760 Files: clang/lib/

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

2021-10-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously without -disable-free, -clear-ast-before-backend would crash in ~ASTContext() due to various reasons.

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

2021-10-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D111270#3060484 , @dblaikie wrote: > Plan is still to address the "this only works with disable free" issue? (I've > some preference that be addressed before this feature is turned on by default) https://reviews.llvm.org/D11

[PATCH] D109128: [VFS] Use original path when falling back to external FS

2021-10-13 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 379559. keith marked 4 inline comments as done. keith added a comment. Update to remap file paths after fetching them from the external FS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews

[PATCH] D109128: [VFS] Use original path when falling back to external FS

2021-10-13 Thread Keith Smiley via Phabricator via cfe-commits
keith added a comment. Ok I've updated the diff here based on @dexonsmith's original suggestion, and some offline discussion with @JDevlieghere The new logic remaps the files and statuses, in the fallback to the external FS case, to use the originally requested path. I opted not to use the seco

[PATCH] D111566: [SYCL] Fix function pointer address space

2021-10-13 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews updated this revision to Diff 379562. eandrews added a comment. Added a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 Files: clang/lib/CodeGen/CodeGenTypes.cpp clang/test/CodeGenSYCL/functionptr-addressspace.cpp Index: cl

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

2021-10-13 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 379570. keith added a comment. Fix windows test paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-ds

[PATCH] D111728: [clang][deps] NFC: Rename building CompilerInvocation

2021-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111728/new/ https://reviews.llvm.org/D111728 __

[PATCH] D111725: [clang][deps] NFC: Rename scanning CompilerInstance

2021-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111725/new/ https://reviews.llvm.org/D111725 __

[PATCH] D111724: [clang][deps] NFC: Remove redundant CompilerInstance reference

2021-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111724/new/ https://reviews.llvm.org/D111724 __

[PATCH] D111720: [clang][deps] Ensure reported context hash is strict

2021-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:56-58 + // Ensure the reported context hash is strict. + CI.getHeaderSearchOpts().ModulesStrictContextHash = true; + IIUC, explicit modules don't really ha

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

2021-10-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a reviewer: jansvoboda11. dexonsmith added a subscriber: jansvoboda11. dexonsmith added a comment. @jansvoboda11, can you help to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111468/new/ https://reviews.llvm.org/D1114

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

2021-10-13 Thread Noah Shutty via Phabricator via cfe-commits
noajshu updated this revision to Diff 379598. noajshu added a comment. Rebase against main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp

[clang] e567f37 - [clang] Use llvm::is_contained (NFC)

2021-10-13 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-10-13T20:41:55-07:00 New Revision: e567f37dabc242cb02fb8b8b288fd05a0aebfb8f URL: https://github.com/llvm/llvm-project/commit/e567f37dabc242cb02fb8b8b288fd05a0aebfb8f DIFF: https://github.com/llvm/llvm-project/commit/e567f37dabc242cb02fb8b8b288fd05a0aebfb8f.diff L

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

2021-10-13 Thread Kai Luo via Phabricator via cfe-commits
lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. This LGTM as the start point to support int128 on AIX. We might need more patches involving libraries in the LLVM monorepo, we can do that progressively. Repository: rG LLVM Github

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

2021-10-13 Thread Henry Linjamäki via Phabricator via cfe-commits
linjamaki added a comment. > Can you explain what does this mean It was trying to clarify a potential misunderstanding of how programs are compiled when HIPSPV is targeted: For HIPSPV, the SPIR-V code generation is done by the clang driver. When we compile HIP programs for HIPCL or the HIPLZ

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

2021-10-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356 + if (CodeGenOpts.ClearASTBeforeBackend) { +// The ASTContext may be unusable after this. +C.cleanup(); C.getAllocator().Reset(); Any chance of r

[PATCH] D111778: [X86] Update CPU_SPECIFIC list.

2021-10-13 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Meanwhile update attr-target-mv.c with missing cpu test. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111778 F

<    1   2