[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 added a comment. In D111560#3056021 , @dexonsmith wrote: > In D111560#3055578 , @jansvoboda11 > wrote: > >> Note: Another approach to fixing this might be to cache the module load >> results while

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378780. haowei added a comment. Fix test failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2418-2420 + // also no children, and omit the others. None of the other current StmtAttrs + // have semantic meaning for the CFG. + if (isFallthroughStatement(A) && asc.alwaysAdd(*this, A)) {

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

craig.topper added a comment. This patch was uploaded without full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___ cfe-commits mailing list cfe-com

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378784. haowei added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378785. noajshu marked an inline comment as not done. noajshu added a comment. Make copies of string reference parameters outside the returned lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ h

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu added inline comments. Comment at: llvm/lib/Support/Caching.cpp:36 + SmallString<10> CacheName = CacheNameRef; return [=](unsigned Task, StringRef Key) -> AddStreamFn { tejohnson wrote: > noajshu wrote: > > noajshu wrote: > > > tejohnson wrote: > >

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added a comment. In D111560#3056175 , @jansvoboda11 wrote: > In D111560#3056021 , @dexonsmith > wrote: > >> In D111560#3055578 , @jansvoboda11 >> wrote: >> >

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378787. noajshu added a comment. rebase against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp l

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:41 for (const PrebuiltModuleDep &PMD : PrebuiltModuleDeps) { -Args.push_back("-fmodule-file=" + PMD.ModuleName + "=" + PMD.PCMFile); +Args.push_back("-fmodule-

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Thanks for the review, the PR is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 ___ cfe-commits mailing list cfe-commit

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 378796. keith added a comment. Fix slashes for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-d

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks, Alexey. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316/new/ https://reviews.llvm.org/D111316 _

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone updated this revision to Diff 378803. maharmstone added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/lib/Driver/ToolChains/MinGW.h clang/test/Driver

[clang] 64d1d5f - [AIX] Unsupported newly added AMDGPU clang test

Author: Jinsong Ji Date: 2021-10-11T21:34:48Z New Revision: 64d1d5f336c3356ac77c588329ce3e449cc46de3 URL: https://github.com/llvm/llvm-project/commit/64d1d5f336c3356ac77c588329ce3e449cc46de3 DIFF: https://github.com/llvm/llvm-project/commit/64d1d5f336c3356ac77c588329ce3e449cc46de3.diff LOG: [A

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. I can't see that any of the lib paths are tested at all, though I may be missing something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___ cfe-commits mailing list

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On unix systems this logic would not separate the file and directory of the DIFile unless they shared more components at the start than just the root path ch

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

rsmith added a comment. Instead of moving functions and classes/enums into the global module after creating them, it would be better to push a module scope for the global module when entering a C or C++ language linkage specification and pop the module scope when leaving the linkage specificati

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a reviewer: compnerd. keith added a comment. Adding since you might be interested in this, I think the Swift logic is also derived from this so it might have the same difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: > On Tue, Sep 14, 2021 at 10:04 AM Richard Smith > wrote: > >> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> Author: David Blaikie >>> Date: 2021-09-13T19:17:05-07:00 >>> New Rev

[PATCH] D111582: [clang] Clear IR analyses before codegen pipeline

aeubanks created this revision. Herald added a subscriber: ormris. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This saves a tiny bit of memory in non-LTO builds [1]. [1] https://llvm-compile-time-tracker.com/compare.php?from=

[clang] 1131b1e - [clang][Fuchsia] Support availability attr on Fuchsia

Author: Haowei Wu Date: 2021-10-11T15:33:04-07:00 New Revision: 1131b1eb3509b47d30a36ea9b42367ab1d7373a2 URL: https://github.com/llvm/llvm-project/commit/1131b1eb3509b47d30a36ea9b42367ab1d7373a2 DIFF: https://github.com/llvm/llvm-project/commit/1131b1eb3509b47d30a36ea9b42367ab1d7373a2.diff LOG

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG1131b1eb3509: [clang][Fuchsia] Support availability attr on Fuchsia (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://

[clang] c5fb1a0 - Revert "[Clang] Ignore BTFTag attr if used as a type attribute"

Author: Yonghong Song Date: 2021-10-11T15:34:26-07:00 New Revision: c5fb1a09533ec2ed43a80f39c1592e5ee887ef9e URL: https://github.com/llvm/llvm-project/commit/c5fb1a09533ec2ed43a80f39c1592e5ee887ef9e DIFF: https://github.com/llvm/llvm-project/commit/c5fb1a09533ec2ed43a80f39c1592e5ee887ef9e.diff

[clang] 25b3370 - PR52139: Properly handle more kinds of declaration when checking for

Author: Richard Smith Date: 2021-10-11T16:37:39-07:00 New Revision: 25b3370ff25f7a21f71e0dc6c4d7624d52cab604 URL: https://github.com/llvm/llvm-project/commit/25b3370ff25f7a21f71e0dc6c4d7624d52cab604 DIFF: https://github.com/llvm/llvm-project/commit/25b3370ff25f7a21f71e0dc6c4d7624d52cab604.diff

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith added a reviewer: probinson. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. This broke tests on windows (see the new parent revisions in the stack) otherwise the actual change's behavior, outside of the tests, is unchanged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llv

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. https://reviews.llvm.org/D111587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111352/new/ https://reviews.llvm.org/D111352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110210: [clang] NFC: include non friendly types and missing sugar in test expectations

mizvekov updated this revision to Diff 378832. mizvekov added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110210/new/ https://reviews.llvm.org/D110210 Files: clang/test/CXX/expr/expr.prim/expr.prim.lambda/p4-cxx14.cpp clan

[PATCH] D111588: [Clang][Attr] rename btf_tag to btf_decl_tag

yonghong-song created this revision. yonghong-song added reviewers: aaron.ballman, ast, anakryiko. Herald added a subscriber: jdoerfert. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Current btf_tag is applied to declaration

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378840. mizvekov added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Typ

[clang] b5e8348 - Revert "[clang][Fuchsia] Support availability attr on Fuchsia"

Author: Haowei Wu Date: 2021-10-11T17:32:38-07:00 New Revision: b5e8348bf2ded134e45dab879a13d26f5b9c5815 URL: https://github.com/llvm/llvm-project/commit/b5e8348bf2ded134e45dab879a13d26f5b9c5815 DIFF: https://github.com/llvm/llvm-project/commit/b5e8348bf2ded134e45dab879a13d26f5b9c5815.diff LOG

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

rsmith added a comment. Do you have examples showing what this does in practice for errors in real-world code? I'm concerned that stripping back to the common type sugar may produce an unintuitive result in some cases, although it certainly does seem at least theoretically nice to use a commuta

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

rsmith added inline comments. Comment at: clang/test/SemaCXX/sugared-auto.cpp:146 +return a; + return N(); // expected-error {{but deduced as 'SARS (*)() throw(Man, Vibrio)' (aka 'void (*)() throw(Man, Vibrio)')}} +} rsmith wrote: > Why don't we get `Virus`

[PATCH] D111588: [Clang][Attr] rename btf_tag to btf_decl_tag

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111588/new/ https://reviews.llvm.org/D111588 _

[clang] 998e067 - Reland "[clang][Fuchsia] Support availability attr on Fuchsia"

Author: Haowei Wu Date: 2021-10-11T18:41:29-07:00 New Revision: 998e067a0a579bd483c2a2d411385e58494ffbca URL: https://github.com/llvm/llvm-project/commit/998e067a0a579bd483c2a2d411385e58494ffbca DIFF: https://github.com/llvm/llvm-project/commit/998e067a0a579bd483c2a2d411385e58494ffbca.diff LOG

[clang] c30a528 - [Driver] Re-enable aarch64-cpus.c test for arm64-apple.

Author: Ahmed Bougacha Date: 2021-10-11T18:46:26-07:00 New Revision: c30a52852ba5e85bdd3b1b70b4add7335fabca9a URL: https://github.com/llvm/llvm-project/commit/c30a52852ba5e85bdd3b1b70b4add7335fabca9a DIFF: https://github.com/llvm/llvm-project/commit/c30a52852ba5e85bdd3b1b70b4add7335fabca9a.diff

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

jacquesguan created this revision. jacquesguan added reviewers: HsiangKai, khchen, craig.topper. Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D111517: [X86] Remove little support we had for MPX

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111517/new/ https://reviews.llvm.org/D111517

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG97f0c63783f5: [RISCV] Define _m intrinsics as builtins, instead of macros. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D110684?vs=376890&id=378859#toc Repository: rG LL

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1663 // We can trust a const value or a value of a global initializer in main(). -const VarDecl *VD = VR->getDecl(); +const VarDecl *VD = VR->getDecl()->getMostRecentDecl(); if

[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

ahatanak updated this revision to Diff 378868. ahatanak marked an inline comment as done. ahatanak added a comment. Improve comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111331/new/ https://reviews.llvm.org/D111331 Files: clang/lib/Code

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7de6962c85b: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316

[clang] db9c2d7 - [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

Author: hsmahesha Date: 2021-10-12T10:04:15+05:30 New Revision: db9c2d775130a110ada89decff7002c64cdd3364 URL: https://github.com/llvm/llvm-project/commit/db9c2d775130a110ada89decff7002c64cdd3364 DIFF: https://github.com/llvm/llvm-project/commit/db9c2d775130a110ada89decff7002c64cdd3364.diff LOG

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb9c2d775130: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/ https:

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 378875. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[clang] a162b67 - [Clang][Attr] rename btf_tag to btf_decl_tag

Author: Yonghong Song Date: 2021-10-11T22:17:17-07:00 New Revision: a162b67c98066218d0d00aa13b99afb95d9bb5e6 URL: https://github.com/llvm/llvm-project/commit/a162b67c98066218d0d00aa13b99afb95d9bb5e6 DIFF: https://github.com/llvm/llvm-project/commit/a162b67c98066218d0d00aa13b99afb95d9bb5e6.diff

[PATCH] D111588: [Clang][Attr] rename btf_tag to btf_decl_tag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa162b67c9806: [Clang][Attr] rename btf_tag to btf_decl_tag (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:392 + /// order immediately after all static allocas. + llvm::BasicBlock::iterator AllocaAddrSpaceInsertPt; + Please call this something like `PostAllocaInsertPt`. Instead of e

[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111331/new/ https://reviews.llvm.org/D111331 __

<    1   2