[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

balazske added a comment. I think a configuration option that depends on configuration of another check causes too many problems. It causes dependencies between checks, possible circular dependency (that is an error). What if the other check is not enabled (if a check configuration depends on o

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall added a reviewer: ABataev. rjmccall added a comment. This mostly looks good, but I'd like Alexey Bataev to sign off, since he authored the OpenMP support. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2124 /*Name=*/".bound

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D109950 ___

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

djtodoro added a comment. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added inline comments. Comment at: clang/docs/BitIntABI.rst:17 +This is only intended as a generic specification. The actual details for any +particular platform should be codified in that platform's ABI specification. + I think you should recommend that

[PATCH] D109506: [clangd] Print current request context along with the stack trace

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks great, thanks! Happy to commit this for you if you don't have access. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1327 +llvm::errs() << "Signalle

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3027473 , @erichkeane wrote: > In D108643#3026550 , @rjmccall > wrote: > >> I think it would be better to provide a generic ABI specification that is >> designed to "lower"

[clang] d11ec6f - [Clang] Enable IC/IF mode for __ibm128

Author: Qiu Chaofan Date: 2021-10-11T17:38:04+08:00 New Revision: d11ec6f67e45c630ab87bfb6010dcc93e89542fc URL: https://github.com/llvm/llvm-project/commit/d11ec6f67e45c630ab87bfb6010dcc93e89542fc DIFF: https://github.com/llvm/llvm-project/commit/d11ec6f67e45c630ab87bfb6010dcc93e89542fc.diff L

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11ec6f67e45: [Clang] Enable IC/IF mode for __ibm128 (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378600. mizvekov added a comment. - Handle different top level qualifiers in function parameters. - More test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283

[PATCH] D111529: Specify Clang vector builtins.

fhahn created this revision. fhahn added reviewers: scanon, erichkeane, rjmccall, aaron.ballman, dexonsmith, rsmith, craig.topper. fhahn requested review of this revision. Herald added a project: clang. This patch specifies a set of vector builtins for Clang, as discussed on cfe-dev: https://list

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378603. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mgorny added a comment. In D111081#3043831 , @mstorsjo wrote: > The change looks ok to me, but I think it'd be good to have a testcase for > finding these paths (IIRC there are a bunch of simulated sysroots under > clang/test/Driver). Seconded. There a

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:4784 + CGF.Builder.CreateStore(llvm::ConstantInt::get(CGF.IntPtrTy, 0), + NumLVal.getAddress(CGF)); llvm::Value *PrevVal = CGF.EmitLoadOfScalar(NumLVal, E->ge

[PATCH] D111518: Add release note about `TypeLoc` matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111518/new/ https://reviews.llvm.org/D111518 ___ cfe-commits mailing list cfe-comm

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378630. saiislam marked 4 inline comments as done. saiislam added a comment. 1. Changed the option from path to nvlink-command. 2. Command line arguments are now parsed using proper API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378633. saiislam added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.org/D111488 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/tools/clang-nvlink

[PATCH] D111529: Specify Clang vector builtins.

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:552 +operation(x, y) as pairwise tree reduction to the input. The pairs are formed +by concatenating both inputs and pairing adjacent elements. + I'm not sure I understand what is b

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Very cool. Comment at: clang/lib/Parse/ParsePragma.cpp:276 + +tok::OnOffSwitch OOS; +Token Tok; Move down 10 lines until you need it? =

[PATCH] D111542: [analyzer] Retrieve VLA extent from its redeclaration.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, martong. Herald added subscribers: steakhal, manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested review of this revision. Herald added a p

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 378645. mubashar_ added a comment. Added files that were missing from previous diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst clang/test/Driver/aarch64-cpus.

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, rsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using explicit Clang modules, some declarations might unexpectedly become in

[PATCH] D111542: [analyzer] Retrieve VLA extent from its redeclaration.

ASDenysPetrov added a comment. @NoQ @martong Guys, I've patched the bug. Could you check it? It works, but I have doubts using `VR->getDecl()->getMostRecentDecl();` as a correct way to get a right declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 added a comment. It'd be great if someone could clarify why the extra `IdentifierInfo` would trip up name resolution. Suggestions on naming the test file are also welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111543/new/ htt

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam created this revision. saiislam added a reviewer: MyDeveloperDay. Herald added subscribers: kerbowa, nhaehnle, jvesely. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Cleanup of D105191

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:120 + /* bitcode SDL?*/ true, + /* PostClang Link? */ false); // Add an intermediate output file. -

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme created this revision. mboehme added a project: clang. Herald added a reviewer: aaron.ballman. mboehme requested review of this revision. Herald added a subscriber: cfe-commits. This is an analog to the `annotate` attribute but for types. The intent is to allow adding arbitrary annotation

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

hans marked an inline comment as done. hans added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:280 +if (Tok.isNot(tok::l_paren)) { + PP.Diag(Tok.getLocation(), diag::warn_pragma_ms_fenv_access); + return; thakis wrote: > Is it import

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

hans updated this revision to Diff 378660. hans added a comment. Slightly better diags, try to appease clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111440/new/ https://reviews.llvm.org/D111440 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/cla

[PATCH] D111542: [analyzer] Retrieve VLA extent from its redeclaration.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1663 // We can trust a const value or a value of a global initializer in main(). -const VarDecl *VD = VR->getDecl(); +const VarDecl *VD = VR->getDecl()->getMostRecentDecl();

[PATCH] D111529: Specify Clang vector builtins.

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:538 + T __builtin_elementwise_rint(T x) return the integral value nearest to x (according to the floating point types +prevailing rounding mode) in

[PATCH] D111529: Specify Clang vector builtins.

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:565 + NaNs, fmax() return a NaN. + ET __builtin_reduce_add(VT a) \+ integer and floating po

[PATCH] D111529: Specify Clang vector builtins.

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:565 + NaNs, fmax() return a NaN. + ET __builtin_reduce_add(VT a) \+ integer and floating po

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

thakis added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:280 +if (Tok.isNot(tok::l_paren)) { + PP.Diag(Tok.getLocation(), diag::warn_pragma_ms_fenv_access); + return; hans wrote: > thakis wrote: > > Is it important that this is a wa

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

hans added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:280 +if (Tok.isNot(tok::l_paren)) { + PP.Diag(Tok.getLocation(), diag::warn_pragma_ms_fenv_access); + return; thakis wrote: > hans wrote: > > thakis wrote: > > > Is it important

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D111542: [analyzer] Retrieve VLA extent from its redeclaration.

ASDenysPetrov added a comment. @steakhal Thank you for your comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1663 // We can trust a const value or a value of a global initializer in main(). -const VarDecl *VD = VR->getDecl(); +const VarDecl *VD

[clang] 7743882 - [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

Author: Hans Wennborg Date: 2021-10-11T17:07:26+02:00 New Revision: 774388241e25529308c8bbac6012a20b62b82f29 URL: https://github.com/llvm/llvm-project/commit/774388241e25529308c8bbac6012a20b62b82f29 DIFF: https://github.com/llvm/llvm-project/commit/774388241e25529308c8bbac6012a20b62b82f29.diff

[PATCH] D111440: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG774388241e25: [MS compat] Handle #pragma fenv_access like #pragma STDC FENV_ACCESS (PR50694) (authored by hans). Repository: rG LLVM Github Monore

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. >> ! In D108643#3054443 , @rjmccall >> wrote: >> >>> ! In D108643#3027473 , >>> @erichkeane wrote: >>> ! In D108643#3026550 , @rjmccall

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov updated this revision to Diff 378684. ASDenysPetrov retitled this revision from "[analyzer] Retrieve VLA extent from its redeclaration." to "[analyzer] Retrieve incomplete array extent from its redeclaration.". ASDenysPetrov edited the summary of this revision. CHANGES SINCE LAST A

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added a comment. In D109825#3055142 , @xgupta wrote: > It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases > changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). I'm not convinced this is required - th

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. oh thanks for the clarification, I am not aware of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D111457: [clang][test] Add lit helper for windows paths

rmaz added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: keith wrote: > rmaz wrote: > > `c:\`? > Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs > lowercase i

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen added a comment. Thanks for the updates. In D109825#3055264 , @lenary wrote: > In D109825#3055142 , @xgupta wrote: > >> It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases >> changes,

[PATCH] D111557: [clang][modules] NFC: Propagate import `SourceLocation` into `HeaderSearch::lookupModule`

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch propagates the import `SourceLocation` into `HeaderSearch::lookupModule`. This

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 updated this revision to Diff 378702. jansvoboda11 added a comment. Add `SourceLocation` to remarks and test with `-verify` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923 Files: clang/incl

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

balazske added inline comments. Comment at: clang/test/Analysis/initialization.c:102 +const int glob_arr3[]; // Incomplete array declaration +const int glob_arr3[4] = {1, 2, 3}; // Incomplete Array redeclaration +void foo() { It is possible to add a

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman marked 4 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/BitIntABI.rst:17 +This is only intended as a generic specification. The actual details for any +particular platform should be codified in that platform's ABI specification.

[clang] 3550e24 - [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

Author: Victor Campos Date: 2021-10-11T17:44:09+01:00 New Revision: 3550e242fad672696da361f7ddadf53a41114dfd URL: https://github.com/llvm/llvm-project/commit/3550e242fad672696da361f7ddadf53a41114dfd DIFF: https://github.com/llvm/llvm-project/commit/3550e242fad672696da361f7ddadf53a41114dfd.diff

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3550e242fad6: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A (authored by vhscampos). Repository: rG LLVM Github Monorepo

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. If D111551 was folded into this patch, would it be possible to add tests for -tune-cpu enabling/disabling features at the correct times? Comment at: clang/test/Driver/aarch64-mtune.c:3 + +// There shouldn't be a defa

[clang] a5c3508 - [RISCV] Require tail policy argument to builtins to be an integer constant expression

Author: Craig Topper Date: 2021-10-11T09:55:04-07:00 New Revision: a5c3508ac71bf30a6d2da35f438e90cc153d8d84 URL: https://github.com/llvm/llvm-project/commit/a5c3508ac71bf30a6d2da35f438e90cc153d8d84 DIFF: https://github.com/llvm/llvm-project/commit/a5c3508ac71bf30a6d2da35f438e90cc153d8d84.diff

[PATCH] D110779: [RISCV] Require tail policy argument to builtins to be an integer constant expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c3508ac71b: [RISCV] Require tail policy argument to builtins to be an integer constant… (authored by craig.topper). Herald added a project: clang.

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

aaron.ballman added a comment. In D111228#3054263 , @balazske wrote: > I think a configuration option that depends on configuration of another check > causes too many problems. It causes dependencies between checks, possible > circular dependency (that

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis added a comment. Don't we want to diagnose the problems in the job's command line? What kind of changes can the driver do there that would affect SanitizerArgs? I wonder if diagnostics should still be performed on the job args, but presented to the user differently, mainly because we ca

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. @aaron.ballman ping. To address your concerns, I intend to create another type attribute btf_type_tag (https://reviews.llvm.org/D99), could you comment on this new approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

dblaikie added a comment. Might not hurt to have some negative test cases too - like something that is a VarDecl but has NoStub DynamicInitKind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 __

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, rsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During modular build, PCM files are typically specified via the `-fmodule-file=`

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 added a comment. Note: Another approach to fixing this might be to cache the module load results while loading the PCH too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111560/new/ https://reviews.llvm.org/D111560 __

[PATCH] D111472: [docs] Mention in release notes that we now support 2^32 alignment

aeubanks updated this revision to Diff 378719. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. mention in Clang release notes as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111472/new/ https:/

[clang] b41cfbf - [docs] Mention in release notes that we now support 2^32 alignment

Author: Arthur Eubanks Date: 2021-10-11T10:23:15-07:00 New Revision: b41cfbfcbbe27d519171b5847a8d44ca8a5a0f13 URL: https://github.com/llvm/llvm-project/commit/b41cfbfcbbe27d519171b5847a8d44ca8a5a0f13 DIFF: https://github.com/llvm/llvm-project/commit/b41cfbfcbbe27d519171b5847a8d44ca8a5a0f13.diff

[PATCH] D111472: [docs] Mention in release notes that we now support 2^32 alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb41cfbfcbbe2: [docs] Mention in release notes that we now support 2^32 alignment (authored by aeubanks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Some nitpicks, but it fixes the build, so LGTM. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378725. keith marked 2 inline comments as done. keith added a comment. Allow empty leading on windows This behavior is currently broken, the directory should never be `/` or `C:\` but the logic is broken and only handles `/` Repository: rG LLVM Github Mono

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 378729. kito-cheng added a comment. Changes: - Rebase to main - Remove b and zbproposedc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 Files: clang/include/c

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:620 + Args.MakeArgString(Twine("--nvlink-command=" + NvlinkBin)); + CmdArgs.push_back(NvlinkPath); + Nit: the variables above are used only once. It would be fine to just `push_bac

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews created this revision. eandrews added reviewers: vlastik, dylanmckay, bader. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. eandrews requested review of this revision. Functions pointers should be created with program address space. This patch fixes a crash on lvalue ref

[PATCH] D111517: [X86] Remove little support we had for MPX

MaskRay updated this revision to Diff 378737. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111517/new/ https://reviews.llvm.org/D111517 File

[clang] d409048 - [Sema] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2021-10-11T11:06:44-07:00 New Revision: d4090482013599b1c246f3553717e2a88d6b24a5 URL: https://github.com/llvm/llvm-project/commit/d4090482013599b1c246f3553717e2a88d6b24a5 DIFF: https://github.com/llvm/llvm-project/commit/d4090482013599b1c246f3553717e2a88d6b24a5.diff L

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

aaron.ballman added reviewers: njames93, hokein, whisperity. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. In D111208#3054246 , @carlosgalvezp wrote: > Awesome, thanks a lot for the review, I really improved my understanding of > t

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. I'm still worried that this solution as implemented is going to break existing users, including major one like Rust. I'm not also not a fan of special casing individual targets like Fuchsia directly inside `Driver`, I believe that any per-target logic should live in the

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3055813 , @phosek wrote: > I'm still worried that this solution as implemented is going to break > existing users, including major one like Rust. > > I'm not also not a fan of special casing individual targets like Fuch

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis created this revision. thakis added reviewers: hans, aaron.ballman. thakis requested review of this revision. `[[clang::fallthrough]]` has meaning for the CFG, but all other StmtAttrs we currently have don't. So omit them, as AttributedStatements with children cause several issues and there

[clang] 144f851 - [clang/CFG] Rewrap a line to 80 columns

Author: Nico Weber Date: 2021-10-11T14:23:51-04:00 New Revision: 144f851f6f5203969ef8b8052060ad56fcaab934 URL: https://github.com/llvm/llvm-project/commit/144f851f6f5203969ef8b8052060ad56fcaab934 DIFF: https://github.com/llvm/llvm-project/commit/144f851f6f5203969ef8b8052060ad56fcaab934.diff LO

[clang] 00ca004 - [clang] Convert a few loops to for-each

Author: Nico Weber Date: 2021-10-11T14:24:32-04:00 New Revision: 00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6 URL: https://github.com/llvm/llvm-project/commit/00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6 DIFF: https://github.com/llvm/llvm-project/commit/00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6.diff LO

[clang] 5ab2a95 - [clang] Remove an else-after-return

Author: Nico Weber Date: 2021-10-11T14:24:58-04:00 New Revision: 5ab2a95edb62e67478095e4e5619a07efc95ee21 URL: https://github.com/llvm/llvm-project/commit/5ab2a95edb62e67478095e4e5619a07efc95ee21 DIFF: https://github.com/llvm/llvm-project/commit/5ab2a95edb62e67478095e4e5619a07efc95ee21.diff LO

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3055813 , @phosek wrote: > I'm still worried that this solution as implemented is going to break > existing users, including major one like Rust. Well, it's better than calling the Project build deprecated (in favor o

[PATCH] D111570: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. CFGBuilder::addStmt() implicitly passes AddStmtChoice::AlwaysAdd to Visit() already, so this should have no behavior change. https://reviews.llvm.org/D111570 Files: clang/lib/Sema/AnalysisBa

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2410 + +CFGBlock *CFGBuilder::VisitAttributedStmt(AttributedStmt *A, + AddStmtChoice asc) { (Compare this function to `CFGBuilder::VisitStmt` in this fil

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:194 - if (MArch.startswith_insensitive("rv32")) { -// FIXME: parse `March` to find `D` extension properly -if (MArch.substr(4).contains_insensitive("d") || -MArch.startsw

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3054126 , @yonghong-song wrote: > @aaron.ballman Ping. This is to address your concern in D110127 > , could you take a look whether my proposal > for a new attribute btf_type_t

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp:56 virtual ~SimpleCases(); - // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-o

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:118 AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "amdgcn", - SubArchName, - /* bitcode SDL?*/ true, - /* Pos

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Removed extraneous StringRef conversion after previous D111322 was landed. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(S

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added a comment. In D111560#3055578 , @jansvoboda11 wrote: > Note: Another approach to fixing this might be to cache the module load > results while loading the PCH too. Can you share why you chose this approach instead, and which do you thi

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

aaron.ballman added a comment. Thank you for the fix to this! Comment at: clang/lib/Analysis/CFG.cpp:2418-2420 + // also no children, and omit the others. None of the other current StmtAttrs + // have semantic meaning for the CFG. + if (isFallthroughStatement(A) && asc.alway

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay added a comment. what @thakis said, this isn't normally my area but this is one of the files that has reverted its "clang-format clean" status with recent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://re

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks; I think this was worth it. I like how clean it looks with `-verify` in place. LGTM if you add a couple more header map tests, explained inline. Comment at:

[PATCH] D111557: [clang][modules] NFC: Propagate import `SourceLocation` into `HeaderSearch::lookupModule`

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111557/new/ https://reviews.llvm.org/D111557 __

[clang] 121b225 - AddGlobalAnnotations for function with or without function body.

Author: Chris Bieneman Date: 2021-10-11T14:50:34-05:00 New Revision: 121b2252de0eed68f2ddf5f09e924a6c35423d47 URL: https://github.com/llvm/llvm-project/commit/121b2252de0eed68f2ddf5f09e924a6c35423d47 DIFF: https://github.com/llvm/llvm-project/commit/121b2252de0eed68f2ddf5f09e924a6c35423d47.diff

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

This revision was automatically updated to reflect the committed changes. Closed by commit rG121b2252de0e: AddGlobalAnnotations for function with or without function body. (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/

[clang] 25fabc4 - Add release note about `TypeLoc` matchers.

Author: James King Date: 2021-10-11T19:57:32Z New Revision: 25fabc434ad5d1d7edd994b1fafb87e70ee2cda1 URL: https://github.com/llvm/llvm-project/commit/25fabc434ad5d1d7edd994b1fafb87e70ee2cda1 DIFF: https://github.com/llvm/llvm-project/commit/25fabc434ad5d1d7edd994b1fafb87e70ee2cda1.diff LOG: Ad

[PATCH] D111518: Add release note about `TypeLoc` matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG25fabc434ad5: Add release note about `TypeLoc` matchers. (authored by jcking1034, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111518

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song added a comment. In D99#3055928 , @aaron.ballman wrote: > In D99#3054126 , @yonghong-song > wrote: > >> @aaron.ballman Ping. This is to address your concern in D110127 >>

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song added inline comments. Comment at: clang/include/clang/AST/Type.h:4768 +private: + std::string BTFTypeTag; + aaron.ballman wrote: > I think we should be able to use a `StringRef` instead, rather than have to > worry about allocations. StringRef in

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

dexonsmith added a comment. It seems like using `CachedModuleLoads` wasn't quite right in the first place. I wonder if `-fmodule-file=` could/should use a different map (maybe one that doesn't exist yet), instead of replacing the key in CachedModuleLoads. In D111543#3054922

  1   2   >