[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

2021-10-04 Thread Xiang Li via Phabricator via cfe-commits
python3kgae created this revision. python3kgae added a reviewer: clang. python3kgae added a project: clang. python3kgae requested review of this revision. Herald added a subscriber: cfe-commits. When AnnotateAttr is on a function, AddGlobalAnnotations is only called in CodeGenModule::EmitGlobalFu

[PATCH] D106044: [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.

2021-10-04 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Herald added a subscriber: achieveartificialintelligence. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106044/new/ https://reviews.llvm.org/D106044 ___ cfe-commits maili

[PATCH] D106044: [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.

2021-10-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106044/new/ https://reviews.llvm.org/D106044 ___

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

2021-10-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Type alignment (16), choice of GPRs for argument passing (first available including r10), `va_arg` invocations, order of components (big endian), and calls to double/float conversions all check out. It may be reasonable to locate existing tests for these

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

2021-10-04 Thread Mahesha S via Phabricator via cfe-commits
hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110676/new/ https://reviews.llvm.org/D110676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

2021-10-04 Thread Mahesha S via Phabricator via cfe-commits
hsmhsm added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

2021-10-04 Thread Chris Lattner via Phabricator via cfe-commits
lattner accepted this revision. lattner added a comment. This is really great, thank you for doing this. I'd love to see reduced out of headers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111049/new/ https://reviews.llvm.org/D111049

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

2021-10-04 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. The problem is happening when user passes lambda function wit

[clang] 81fb640 - [clang-repl] Allow loading of plugins in clang-repl.

2021-10-04 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2021-10-05T05:20:30Z New Revision: 81fb640f83b6a5d099f9124739ab3049be79ea56 URL: https://github.com/llvm/llvm-project/commit/81fb640f83b6a5d099f9124739ab3049be79ea56 DIFF: https://github.com/llvm/llvm-project/commit/81fb640f83b6a5d099f9124739ab3049be79ea56.diff LO

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

2021-10-04 Thread Vassil Vassilev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81fb640f83b6: [clang-repl] Allow loading of plugins in clang-repl.

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

2021-10-04 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:223 + void LoadRequestedPlugins(); + /// } sgraenitz wrote: > This could have a minimal doxygen comment now that it's part of the public > interface. I somewhat h

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

2021-10-04 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin updated this revision to Diff 377091. mtrofin marked 2 inline comments as done. mtrofin added a comment. added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 Files: clang/test/Frontend/opt

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

2021-10-04 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin marked an inline comment as done. mtrofin added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89 + void recordUnsuccessfulInliningImpl(const InlineResult &Result) override { +if (IsInliningRecommended) + ORE.emit([&]() { +return Opt

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

2021-10-04 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Thanks for your input @mgartmann ! No apologies needed, nothing is ever perfect on the first release :) Just wanted to check if you would agree with the fix or if there's some detail I've missed. I'll add the tests asked by @whisperity CHANGES SINCE LAST ACTION

[clang] 3e9d04f - Revert "[clang-repl] Allow loading of plugins in clang-repl."

2021-10-04 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2021-10-05T06:10:38Z New Revision: 3e9d04f7e422c3e62d9adac506df8e7d42acc206 URL: https://github.com/llvm/llvm-project/commit/3e9d04f7e422c3e62d9adac506df8e7d42acc206 DIFF: https://github.com/llvm/llvm-project/commit/3e9d04f7e422c3e62d9adac506df8e7d42acc206.diff LO

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

2021-10-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D110663#3041379 , @MaskRay wrote: > In D110663#3029577 , @phosek wrote: > >> This is going to break Fuchsia as implemented. We assume that >> `{x86_64,aarch64}-unknown-fuchsia` and `{x8

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

2021-10-04 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdenny. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, arphaman, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sst

[PATCH] D111120: [clangd] Find explicit references in the base-specifier of an enum decl Partially fixes https://github.com/clangd/clangd/issues/878

2021-10-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

<    1   2