[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

shafik added a comment. In D110927#3036647 , @ASDenysPetrov wrote: > In D110927#3036436 , @steakhal > wrote: > >> I'm pretty sure that `int x4 = ((char*)arr)[1];` is supposed to be valid in >> your summary. >>

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

jsji updated this revision to Diff 376595. jsji added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/ https://reviews.llvm.org/D110955 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Index:

[clang] 9c31969 - [AIX] Don't pass namedsects in LTO mode

Author: Jinsong Ji Date: 2021-10-01T19:22:40Z New Revision: 9c31969e8df2f4b41b05e415fc9a66ff0bfa0802 URL: https://github.com/llvm/llvm-project/commit/9c31969e8df2f4b41b05e415fc9a66ff0bfa0802 DIFF: https://github.com/llvm/llvm-project/commit/9c31969e8df2f4b41b05e415fc9a66ff0bfa0802.diff LOG: [A

[PATCH] D110955: [AIX] Don't pass namedsects in LTO mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c31969e8df2: [AIX] Don't pass namedsects in LTO mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110955/new/ https://reviews.llvm.org

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

jcking1034 updated this revision to Diff 376610. jcking1034 added a comment. Clean up unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110586/new/ https://reviews.llvm.org/D110586 Files: clang/include/clang/AST/ASTTypeTraits.h clang/l

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:178 -// Unsure if this case could ever come up, but prevents an unreachable -/

[PATCH] D110586: Update `DynTypedNode` to support the conversion of `TypeLoc`s.

sbenza added inline comments. Comment at: clang/unittests/AST/ASTTypeTraitsTest.cpp:212 + DynTypedNode Node = DynTypedNode::create(tl); + EXPECT_TRUE(Node == Node); + EXPECT_FALSE(Node < Node); I don't know what we are trying to check with this self equivalenc

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 376630. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Herald added a subscriber: steven.zhang. - Only truncate **b** and not result - Add a proper test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3033489 , @rmaz wrote: > In D109632#3032381 , @vsapsai wrote: > >> What's interesting, I was able to trigger more diagnostic. Specifically, I >> got warnings about `length` amb

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Headers/altivec.h:3178 + : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) * \ + (vector float)(vector unsigned)((0x7f - (__b)) << 23 & 0x1F)),

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman updated this revision to Diff 376635. dgoldman marked an inline comment as done. dgoldman added a comment. Minor fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/ https://reviews.llvm.org/D110954 Files: clang-to

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: > On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >> >> >> >> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >>> >>> Does something like Rust's "bors" bot satisfy the herald rules need? >> >> >> >> sorry, maybe I was thinking of the high-five

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On 10/1/21 2:59 PM, Josh Stone wrote: > On 9/30/21 4:15 PM, Mehdi AMINI via llvm-dev wrote: >> On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: >>> >>> >>> >>> On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: Does something like Rust's "bors" bot satisfy the herald rules need? >>> >>> >

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

reames added a comment. In D110745#3035975 , @nikic wrote: > Sorry, but the fact that there is still no way to opt-in to the old behavior > is still a blocker from my side. If we can't use `dereferenceable + nofree` > arguments for that purpose, then we

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

cchen added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == &x[0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + Do we really expect `sa[1].f.b` be the same as `&x[0]`? Shou

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

ABataev added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == &x[0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + cchen wrote: > Do we really expect `sa[1].f.b` be the same

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. I'll take a look at this over the weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added a comment. In D49864#2857630 , @janosimas wrote: > That makes sense. > Should I add it somewhere? Or do I need to talk to someone? Please update clang-tools-extra/docs/ReleaseNotes.rst. It looks like there's no other docs for this script.

Maintenance works at llvm lab today at 7PM PST

Hello everyone, LLVM lab and build bot will be unavailable for about an hour starting from 7:00 PM PST today for some maintenance work. Thank you for understanding. Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

nathanchance added a comment. In D110656#3034181 , @nathanchance wrote: > I can test this on the Linux kernel tonight and report the results tomorrow > morning. My apologies, I did not have time to get to this last night or today and I am going to be

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov marked 12 inline comments as done. mizvekov added inline comments. Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:180 )cpp", - // FIXME: it'd be nice if this resolved to the alias instead - "struct Foo", + // It's so nic

[PATCH] D77598: Integral template argument suffix and cast printing

dblaikie added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1101 Out << ", "; -Args[I].print(Policy, Out); +if (TemplOverloaded || !Params) + Args[I].print(Policy, Out, /*IncludeType*/ true); Looks like this (& the `TemplOverload

<    1   2