[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added a subscriber: whisperity. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorCheck.cpp:26 + ast_matchers::internal::Matcher InheritsVirtualDestructor = + hasAnyBase(hasType(cxxRecordDe

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

JamesNagurne added a comment. I'll take a quick look tomorrow, but the general idea is that on calling ParseOptimizationRemark on line 1909 with a -cc1 command line containing -Rpass=inline -Rno-pass, Opts.OptimizationRemarkMissed and Opts.OptimizationRemarkAnalysis are set to valid patterns (R

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-virtual-class-destructor.cpp:216-218 +template +struct TemplatedDerived : PublicVirtualBaseStruct { +}; aaron.ballman wrote: > I think there are more i

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, rogfer01, frasercrmck. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

steakhal added a comment. nits Comment at: clang/test/Analysis/ptr-arith.c:336 + int v; + char y; +}; It's probably unnecessary. Comment at: clang/test/Analysis/ptr-arith.c:339 + +void clang_analyzer_dump(int); + I would pr

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki created this revision. Herald added subscribers: Naghasan, dexonsmith, dang, Anastasia, yaxunl, jholewinski. linjamaki updated this revision to Diff 375783. linjamaki added a comment. linjamaki updated this revision to Diff 375786. linjamaki added reviewers: yaxunl, bader. linjamaki publ

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

hans added a comment. Nice! Comment at: clang/lib/Basic/CLWarnings.cpp:17 + switch (CLWarningID) { + case 4005: return "macro-redefined"; + case 4018: return "sign-compare"; Would it be possible to reference the DiagGroup symbolically here somehow instead o

[PATCH] D110687: [Driver] Check that short triples are supported for Fuchsia

phosek created this revision. phosek added reviewers: leonardchan, haowei, gulfem. Herald added subscribers: pengfei, s.egerton, simoncook, kristof.beyls. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. {x86_64,aarch64}-unknown-fuchs

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualClassDestructorCheck.cpp:26 + ast_matchers::internal::Matcher InheritsVirtualDestructor = + hasAnyBase(hasType(cxxRecordDecl(has(cxxDestructorDecl(isVirtual()); --

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. This is going to break Fuchsia as implemented. We assume that `{x86_64,aarch64}-unknown-fuchsia` and `{x86_64,aarch64}-fuchsia` behave identically and developers are allowed to use whichever spelling they prefer. With this change that's no longer true. This may break oth

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

phosek added a comment. I'm still unsure if this is the right strategy because it creates a dependency cycle. Specifically, you have the LLVM build trigger the build of runtimes, and that build would invoke LLVM build again to ensure that the necessary tools have been built. That shouldn't be n

[clang] 4da744a - [OpenCL] Fix as_type3 invalid store creation

Author: Sven van Haastregt Date: 2021-09-29T09:40:06+01:00 New Revision: 4da744a20ff58c9b3d8df0e2eb9e8b69d9e5cc3d URL: https://github.com/llvm/llvm-project/commit/4da744a20ff58c9b3d8df0e2eb9e8b69d9e5cc3d DIFF: https://github.com/llvm/llvm-project/commit/4da744a20ff58c9b3d8df0e2eb9e8b69d9e5cc3d.

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

This revision was automatically updated to reflect the committed changes. Closed by commit rG4da744a20ff5: [OpenCL] Fix as_type3 invalid store creation (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.l

[PATCH] D110636: [OpenCL][NFC] Refactor vloada_half and vstorea_half decls

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110636/new/ https://reviews.llvm.org/D110636 ___

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 375810. vabridgers added a comment. updates per @steakhal comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cpp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers marked 3 inline comments as done. vabridgers added a comment. Thanks @steakhal and @martong for the comments! The patch has been updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

svenvh added a comment. Looks good at a first quick glance, but please fix the formatting errors that are reported on the lines that you are adding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 __

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 375811. jozefl added a comment. Rebase after updates to parent revision D108301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Fi

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. In D110258#3024418 , @david-arm wrote: > Hi @dmgreen, would you be happy for me to do the splitting-out of arch and > tuning features in a separate follow-on patch? I think it's a good idea and I > don't object to doing it, but

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. In D106102#3028584 , @manas wrote: > The pre-merge checks fail due to the patch being unable to get applied. The > troubleshooting > > suggest

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:254 + showInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: std::move of the variable 'a' of the trivially-copyable type 'int' has no effect

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. This patch seems pretty straightforward, good job @manas, and for the folks giving review comments. Aside from polishing the tests, I think it's good to go. Comment at: clang/test/Analysis/constant-folding.c:470 + +void testEqualityRules(unsigned int

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 375655. gandhi21299 added a comment. - declare failure when lowering an accessor of a callee which is not a function, in GlobalISel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp:96-97 if (Function* F = dyn_cast(A.getAliasee())) { + if (A.getLinkage() != GlobalValue::InternalLinkage) +continue; A.replaceAllUsesWith(F); If w

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/inline-calls.ll:1 ; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs < %s | FileCheck %s need to add check for gfx906 and gfx1030 Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp:96-97 if (Function* F = dyn_cast(A.getAliasee())) { + if (A.getLinkage() != GlobalValue::InternalLinkage) +continue; A.replaceAllUsesWith(F);

[clang] c9539f9 - [PowerPC] Define XL-compatible macros only for AIX and Linux

Author: Nemanja Ivanovic Date: 2021-09-29T06:14:45-05:00 New Revision: c9539f957f57c0c2c59dab98f25215f241d4debf URL: https://github.com/llvm/llvm-project/commit/c9539f957f57c0c2c59dab98f25215f241d4debf DIFF: https://github.com/llvm/llvm-project/commit/c9539f957f57c0c2c59dab98f25215f241d4debf.di

[PATCH] D110213: [PowerPC] Define XL-compatible macros only for AIX and Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9539f957f57: [PowerPC] Define XL-compatible macros only for AIX and Linux (authored by nemanjai). Changed prior to commit: https://reviews.llvm.o

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

pdhaliwal added a comment. Apologies for late reply. Most of the tests now do not try to call malloc, so no page fault errors. But all of them are producing wrong results. For e.g. declare_mapper_target.cpp produces Sum = 132608 with the patch applied. Similarly for other tests as well. So don'

[PATCH] D110485: Support [[no_unique_address]] for all targets.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D110485#3026629 , @rjmccall wrote: > MSVC gets to chose the ABI rules for their platform. It is not Clang policy > to pick

[clang] 09b67aa - [PowerPC] Implement builtin for vbpermd

Author: Nemanja Ivanovic Date: 2021-09-29T06:34:31-05:00 New Revision: 09b67aa1c38279daa54246e3f216186e35a3e5b9 URL: https://github.com/llvm/llvm-project/commit/09b67aa1c38279daa54246e3f216186e35a3e5b9 DIFF: https://github.com/llvm/llvm-project/commit/09b67aa1c38279daa54246e3f216186e35a3e5b9.di

[PATCH] D107899: [PowerPC] Implement builtin for vbpermd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09b67aa1c382: [PowerPC] Implement builtin for vbpermd (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D107899?vs=365731&

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

aaron.ballman added a comment. We typically do not introduce new off-by-default warnings into Clang because experience has shown that users typically do not enable them (so they tend not to be worth the maintenance burden). Instead, we try to make warnings that can be on-by-default with a very

[clang-tools-extra] 722e705 - Revert 9b944c184396ce55a3ad608779cc326ba12c9ee3 with fixes

Author: Salman Javed Date: 2021-09-29T08:00:45-04:00 New Revision: 722e705f72dd3077a1f51dc62717828e7ccf23e8 URL: https://github.com/llvm/llvm-project/commit/722e705f72dd3077a1f51dc62717828e7ccf23e8 DIFF: https://github.com/llvm/llvm-project/commit/722e705f72dd3077a1f51dc62717828e7ccf23e8.diff

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

aaron.ballman added a comment. Thanks for the fix, those changes LGTM! I've recommit on your behalf in 722e705f72dd3077a1f51dc62717828e7ccf23e8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

thakis added a comment. Softlinks don't work on Windows, that's why these tests use copies. clang_f_opts.c sadly started flaking almost immediately after this went in: http://45.33.8.238/win/46115/step_7.txt So I fear the Windows file system can't handle this patch as-is. Maybe we can use `rm

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D110485: Support [[no_unique_address]] for all targets.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1690 +def NoUniqueAddress : InheritableAttr { let Spellings = [CXX11<"", "no_unique_address", 201803>]; let Subjects = SubjectList<[NonBitField], ErrorDiag>; The way to do a `[[

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added inline comments. Comment at: clang/lib/Basic/CLWarnings.cpp:17 + switch (CLWarningID) { + case 4005: return "macro-redefined"; + case 4018: return "sign-compare"; hans wrote: > Would it be possible to reference the DiagGroup symbolically here some

[PATCH] D110482: [clang] Implement if consteval (P1938)

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:164 -/// True if this if statement is a constexpr if. -unsigned IsConstexpr : 1; +/// Whether this is an if constexpr if or a consteval if or neither. +IfStatementKind Kind : 3;

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-virtual-class-destructor.cpp:216-218 +template +struct TemplatedDerived : PublicVirtualBaseStruct { +}; whisperity wrote: > carlosgalvezp wrote: > > aa

[PATCH] D110482: [clang] Implement if consteval (P1938)

erichkeane added inline comments. Comment at: clang/include/clang/AST/Stmt.h:166 +/// True if this if statement is a if consteval statement. +unsigned IsConsteval : 1; aaron.ballman wrote: > erichkeane wrote: > > cor3ntin wrote: > > > erichkeane wrote:

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

fcambus created this revision. fcambus added reviewers: rsmith, xgupta. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110715 Files: clang/docs/Toolchain.rst Ind

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-virtual-class-destructor.cpp:216-218 +template +struct TemplatedDerived : PublicVirtualBaseStruct { +}; aaron.ballman wrote: > whisperity wrote: > > ca

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LG, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110715/new/ https://reviews.llvm.org/D110715

[clang] 7a7caf9 - [clang] Fix library name (libsupc++) in the admonition note.

Author: Frederic Cambus Date: 2021-09-29T19:45:06+05:30 New Revision: 7a7caf97012f53172743d650fd3c97bce99f86ef URL: https://github.com/llvm/llvm-project/commit/7a7caf97012f53172743d650fd3c97bce99f86ef DIFF: https://github.com/llvm/llvm-project/commit/7a7caf97012f53172743d650fd3c97bce99f86ef.dif

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a7caf97012f: [clang] Fix library name (libsupc++) in the admonition note. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

[PATCH] D110436: [WIP] Add %n format specifier warning

Jaysonyan updated this revision to Diff 375887. Jaysonyan added a comment. - Add more verbose warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110436/new/ https://reviews.llvm.org/D110436 Files: clang/include/clang/Basic/DiagnosticG

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis updated this revision to Diff 375891. thakis added a comment. Herald added subscribers: usaxena95, arphaman. tblgen group IDs Done, please take a look. We now have a `diag::Group` enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 F

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, +

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson added a comment. In D110276#3029952 , @thakis wrote: > Softlinks don't work on Windows, that's why these tests use copies. > > clang_f_opts.c sadly started flaking almost immediately after this went in: > http://45.33.8.238/win/46115/step_7.txt

[clang] 2f1b99c - Use rm -f to fix Windows failures from test changes

Author: Teresa Johnson Date: 2021-09-29T08:01:22-07:00 New Revision: 2f1b99ca67da18d858a4b070716790a8f53891d6 URL: https://github.com/llvm/llvm-project/commit/2f1b99ca67da18d858a4b070716790a8f53891d6 DIFF: https://github.com/llvm/llvm-project/commit/2f1b99ca67da18d858a4b070716790a8f53891d6.diff

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson added a comment. In D110276#3030390 , @tejohnson wrote: > In D110276#3029952 , @thakis wrote: > >> Softlinks don't work on Windows, that's why these tests use copies. >> >> clang_f_opts.c sadly started f

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

dyung added a comment. Hi, our internal testing started to hit an assertion failure in one of our tests after this commit. I have put the details in PR52011, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ ht

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks added a comment. In D110673#3029438 , @JamesNagurne wrote: > I'll take a quick look tomorrow, but the general idea is that on calling > ParseOptimizationRemark on line 1909 with a -cc1 command line containing > -Rpass=inline -Rno-pass, Opts.Op

[clang-tools-extra] 7674bd4 - [clang-tidy] Merges separate isa<>/assert/unreachable/dyn_cast<>/cast<> calls

Author: Simon Pilgrim Date: 2021-09-29T16:35:29+01:00 New Revision: 7674bd4d44921d2d110cfb56f2674d4e6e8a68e3 URL: https://github.com/llvm/llvm-project/commit/7674bd4d44921d2d110cfb56f2674d4e6e8a68e3 DIFF: https://github.com/llvm/llvm-project/commit/7674bd4d44921d2d110cfb56f2674d4e6e8a68e3.diff

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

beanz added a comment. I would greatly prefer to enable this by default, so let me build a toolchain and see how it holds up. The empty initializer list extension is pretty widely supported, so I single zero-initialization is way less common these days, but I'll look. Repository: rG LLVM Gi

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b10e2b1cf01: [PowerPC][AIX] Warn when using pragma align(packed) on AIX. (authored by sfertile). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107506/new/

[clang] 9b10e2b - [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

Author: Sean Fertile Date: 2021-09-29T11:53:46-04:00 New Revision: 9b10e2b1cf01b37f441d83ebc41d2c2f9f81831e URL: https://github.com/llvm/llvm-project/commit/9b10e2b1cf01b37f441d83ebc41d2c2f9f81831e DIFF: https://github.com/llvm/llvm-project/commit/9b10e2b1cf01b37f441d83ebc41d2c2f9f81831e.diff

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 375912. quinnp added a comment. Fixing failing test case after rebasing with https://reviews.llvm.org/D110213. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files:

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

aaron.ballman added a comment. In D110656#3030580 , @beanz wrote: > I would greatly prefer to enable this by default, so let me build a toolchain > and see how it holds up. Awesome, SGTM! > The empty initializer list extension is pretty widely supporte

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

simon.giesecke added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3233 + + ``QualifierAlignment`` COULD lead to incorrect code generation. + This is pretty unclear, for a number of reasons: * First, this probably only refers to a setting

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added a comment. In D109607#3030478 , @dyung wrote: > Hi, our internal testing started to hit an assertion failure in one of our > tests after this commit. I have put the details in PR52011, can you please > take a look? Sure. Thanks for report

[clang] 26db178 - [OpenCL][NFC] Refactor vloada_half and vstorea_half decls

Author: Stuart Brady Date: 2021-09-29T17:22:39+01:00 New Revision: 26db178cc2b39167a2fd69acfc8ba7ea564f3746 URL: https://github.com/llvm/llvm-project/commit/26db178cc2b39167a2fd69acfc8ba7ea564f3746 DIFF: https://github.com/llvm/llvm-project/commit/26db178cc2b39167a2fd69acfc8ba7ea564f3746.diff

[PATCH] D110636: [OpenCL][NFC] Refactor vloada_half and vstorea_half decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26db178cc2b3: [OpenCL][NFC] Refactor vloada_half and vstorea_half decls (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! lgtm Comment at: clang/include/clang/Basic/CLWarnings.h:18 +enum class Group; +}; + clang-tidy's comment about the extra semicolon seems valid CHANGES SI

[clang] 67a3d1e - [PowerPC] swdiv builtins for XL compatibility

Author: Quinn Pham Date: 2021-09-29T11:31:07-05:00 New Revision: 67a3d1e2755152608fcb1737f7d0519121e037b7 URL: https://github.com/llvm/llvm-project/commit/67a3d1e2755152608fcb1737f7d0519121e037b7 DIFF: https://github.com/llvm/llvm-project/commit/67a3d1e2755152608fcb1737f7d0519121e037b7.diff LO

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a3d1e27551: [PowerPC] swdiv builtins for XL compatibility (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375927. cor3ntin marked 20 inline comments as done. cor3ntin added a comment. - Add Bytecode gen tests - use consteval if consistently - use isConsteval/isNegatedConsteval/istNonNegatedConsteval - Address other comments Repository: rG LLVM Github Monorepo

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:195 + if (IS->isNegatedConsteval()) +return IS->getElse(); + aaron.ballman wrote: > This probably signals that we're missing some test coverage, but this is the > first I'v

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

wolfgangp added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109981/new/ https://reviews.llvm.org/D109981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

tra added a comment. > A Cuda GPU architecture ‘generic’ is added. The name is picked from the LLVM > SPIR-V Backend. In the HIPSPV code path the architecture name is inserted to > the bundle entry ID as target ID. Target ID is expected to be always present > so a component in the target triple

[PATCH] D110726: [clang] NFC: remove duplicated code around type constraint and templ arg subst

mizvekov created this revision. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110726 Files: clang/include/clang/AST/DeclTempla

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:3701 " do not include the default CUDA/HIP wrapper headers">; +def nohipwrapperinc : Flag<["-"], "nohipwrapperinc">, + HelpText<"Do not include the default HIP wrapper headers">; Is

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375940. cor3ntin added a comment. Cleanup Diagnostics In LiteralSupport Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/ch

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. clang simply just does not truly support everything msvc supports. There are no things that deals [[msvc::]] attributes at all in the clang. In fact the point of using clang on windows is that we do not want to do the same as Microsoft does. Support [[no_unique_address]

[clang] b2de52b - [clang-cl] Accept `#pragma warning(disable : N)` for some N

Author: Nico Weber Date: 2021-09-29T13:14:23-04:00 New Revision: b2de52bec17b67887456ede40ac7c6959ce26d6a URL: https://github.com/llvm/llvm-project/commit/b2de52bec17b67887456ede40ac7c6959ce26d6a DIFF: https://github.com/llvm/llvm-project/commit/b2de52bec17b67887456ede40ac7c6959ce26d6a.diff LO

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. thakis marked an inline comment as done. Closed by commit rGb2de52bec17b: [clang-cl] Accept `#pragma warning(disable : N)` for some N (authored by thakis). Changed pri

[PATCH] D110485: Support [[no_unique_address]] for all targets.

erichkeane added a comment. In D110485#3030853 , @expnkx wrote: > clang simply just does not truly support everything msvc supports. There are > no things that deals [[msvc::]] attributes at all in the clang. In fact the > point of using clang on window

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from two small nits. As for the modules question, if @rsmith doesn't get back to us, I think it's fine to address that post-commit. Comment at: clan

[clang] d7ae434 - [Driver] Check that short triples are supported for Fuchsia

Author: Petr Hosek Date: 2021-09-29T10:35:40-07:00 New Revision: d7ae43438a04bcb651ede50c19042e08514bf729 URL: https://github.com/llvm/llvm-project/commit/d7ae43438a04bcb651ede50c19042e08514bf729 DIFF: https://github.com/llvm/llvm-project/commit/d7ae43438a04bcb651ede50c19042e08514bf729.diff LO

[PATCH] D110687: [Driver] Check that short triples are supported for Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7ae43438a04: [Driver] Check that short triples are supported for Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3029825 , @pdhaliwal wrote: > Apologies for late reply. Most of the tests now do not try to call malloc, so > no page fault errors. But all of them are producing wrong results. For e.g. > declare_mapper_target.c

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

tra added a comment. > --offload’ option, which is envisioned in [1], is added for specifying > offload targets. This option is used to override default device target > (amdgcn-amd-amdhsa) for HIP compilation for emitting device code as SPIR-V > binary. The option is handled in getHIPOffloadTar

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

aeubanks updated this revision to Diff 375958. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110665/new/ https://reviews.llvm.org/D110665 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td cl

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:336-337 + for (auto &F : getModule()->functions()) { +if (const Decl *FD = Gen->GetDeclForMangledName(F.getName())) { + auto Loc = FD->getASTContext().getFullLoc(FD->getLocatio

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 375960. xbolva00 added a comment. Herald added subscribers: sstefan1, s.egerton, simoncook, aheejin, dschuff. Herald added a reviewer: jdoerfert. Emit note to explain a user how to silence this warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 375964. cor3ntin added a comment. Fix EOF & unrenamed StringKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy/checkers/

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

stuart created this revision. stuart added reviewers: svenvh, Anastasia, airlied, yaxunl. Herald added a subscriber: ldrumm. stuart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the `pure` and `const` attributes for the `vload`, `vloa

[PATCH] D85390: [Clang] Add note for bad conversion error when expression is of forward-declared type

rsmith added a comment. Please see llvm.org/PR52014 -- this patch is not properly handling cv-qualifiers. We should not produce the new note if the destination type has qualifiers that the source type does not possess, because in that case inheritance makes no difference to whether the conversi

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

thakis added a comment. It's my personal bot. It doesn't send email. IMHO the problem of how to make bots send emails hasn't been solved (they either send too much or too little), so I'm not pretending that it has been ;) Sadly the test is still failing after the `-f` change: http://45.33.8.23

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:69 def note_cast_to_void : Note<"cast expression to void to silence warning">; +def note_cast_operand_to_int : Note<"cast one or both operands to int to silence warning">;

[PATCH] D110727: [clang] don't instantiate templates with injected arguments

mizvekov created this revision. Herald added a subscriber: kristof.beyls. mizvekov updated this revision to Diff 375937. mizvekov added a comment. mizvekov updated this revision to Diff 375943. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cf

[clang] 2240deb - [clang] Minor cleanups after b2de52bec

Author: Nico Weber Date: 2021-09-29T14:28:13-04:00 New Revision: 2240deb9766cc080b351016b0d7f975d7249b113 URL: https://github.com/llvm/llvm-project/commit/2240deb9766cc080b351016b0d7f975d7249b113 DIFF: https://github.com/llvm/llvm-project/commit/2240deb9766cc080b351016b0d7f975d7249b113.diff LO

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 375969. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChecking.cpp clang/p.

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 marked 3 inline comments as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:69 def note_cast_to_void : Note<"cast expression to void to silence warning">; +def note_cast_operand_to_int : Note<"cast one or both operands

[PATCH] D110482: [clang] Implement if consteval (P1938)

cor3ntin updated this revision to Diff 375970. cor3ntin added a comment. use llvm::reverse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Bas

  1   2   >