[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

khchen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:162 // For unit stride load with mask // Input: (maskedoff, pointer, mask, vl) class RISCVUSLoadMask maybe we could have another NFC patch to update those `argument info` c

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

carlosgalvezp added a comment. Fully agree. Such an opt-in feature shouldn't break things. I'd be happy to implement it if people think it's a good idea! Would need some hand-holding though, never touched the LLVM codebase before :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 374455. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Fix clang-format and clang-tidy issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/Clan

[clang] 352a2e6 - [clang][tooling] NFC: Refactor command-line diagnostic tests

Author: Jan Svoboda Date: 2021-09-23T09:08:53+02:00 New Revision: 352a2e67162541efe79a1e144b40a054751e7d5c URL: https://github.com/llvm/llvm-project/commit/352a2e67162541efe79a1e144b40a054751e7d5c DIFF: https://github.com/llvm/llvm-project/commit/352a2e67162541efe79a1e144b40a054751e7d5c.diff L

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG352a2e671625: [clang][tooling] NFC: Refactor command-line diagnostic tests (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:449 +return false; + if (Tok->is(TT_TypenameMacro)) +return false; HazardyKnusperkeks wrote: > I think this is still right, because it is a type (according to

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

nridge updated this revision to Diff 374461. nridge marked 3 inline comments as done. nridge added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110130/new/ https://reviews.llvm.org/D110130 Files: clang-tools-e

[clang-tools-extra] 4223195 - [clangd] Ensure lambda init-capture gets semantic token

Author: Nathan Ridge Date: 2021-09-23T03:52:57-04:00 New Revision: 4223195de3eaaa9c221d1f178899f221be6264c5 URL: https://github.com/llvm/llvm-project/commit/4223195de3eaaa9c221d1f178899f221be6264c5 DIFF: https://github.com/llvm/llvm-project/commit/4223195de3eaaa9c221d1f178899f221be6264c5.diff

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4223195de3ea: [clangd] Ensure lambda init-capture gets semantic token (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D110

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

phosek added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} leonardchan wrote: > leonardchan wrote: > > phos

[PATCH] D109322: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics.

khchen added inline comments. Herald added a subscriber: achieveartificialintelligence. Comment at: clang/include/clang/Basic/riscv_vector.td:181 + // no need to specify the tail policy. + bit HasPolicy = true; + Add more comment like: If `HasPolicy`, masked op

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

pratlucas added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3299 static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) { if (FBS[AArch64::HasV8_1aOps]) Str += "ARMv8.1a"; As features can now dep

[clang] 5e28c89 - [Driver] Correctly handle static C++ standard library

Author: Petr Hosek Date: 2021-09-23T01:00:11-07:00 New Revision: 5e28c892d06f95600f8b6290ad4de38bfe142637 URL: https://github.com/llvm/llvm-project/commit/5e28c892d06f95600f8b6290ad4de38bfe142637 DIFF: https://github.com/llvm/llvm-project/commit/5e28c892d06f95600f8b6290ad4de38bfe142637.diff LO

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e28c892d06f: [Driver] Correctly handle static C++ standard library (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D11012

[clang] 904ca7d - Revert "[Driver] Correctly handle static C++ standard library"

Author: Petr Hosek Date: 2021-09-23T01:13:10-07:00 New Revision: 904ca7d2ed97bf114fd11373c722acd1e54bfaa3 URL: https://github.com/llvm/llvm-project/commit/904ca7d2ed97bf114fd11373c722acd1e54bfaa3 DIFF: https://github.com/llvm/llvm-project/commit/904ca7d2ed97bf114fd11373c722acd1e54bfaa3.diff LO

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. Looks like the linker used on `clang-ppc64le-rhel` bot doesn't support `--push-state`/`--pop-state`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 __

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

haonanya added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13379 +uint __ovld atomic_fetch_xor(volatile __global atomic_uint *object, uint operand); +uint __ovld atomic_fetch_xor(volatile __local atomic_uint *object, uint operand);i +int __ovld atomic_fetch_and(vo

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374469. kbobyrev added a comment. Perform the computation in the IncludeStructure::File space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-e

[PATCH] D109322: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2186 +}] in +def policy : RVVHeader; khchen wrote: > It seems like we can rewrite `vsetvli/vsetvl` and ` vsetvlmax` instructions > by using the `RVVHeader` mechanism? > We onl

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110315 Files: clang/lib/Sema/SemaDecl.cpp Index: clang/lib/Sema/SemaDecl.cpp

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14496 - if (FSI->UsesFPIntrin && !FD->hasAttr()) + if (FSI->UsesFPIntrin && FD && !FD->hasAttr()) FD->addAttr(StrictFPAttr::CreateImplicit(Context)); I have a reproduce test case, and

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai added a comment. Herald added a subscriber: achieveartificialintelligence. I will wait for https://reviews.llvm.org/D109322 be accepted. These two patches need to get in together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:162 // For unit stride load with mask // Input: (maskedoff, pointer, mask, vl) class RISCVUSLoadMask khchen wrote: > maybe we could have another NFC patch to update thos

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374486. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/builtins-amdgcn.

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10224 +// pointers for HIPSPV. When the language mode is HIP, the SPIRTargetInfo +// maps cuda_device to SPIR-V's CrossWorkGroup address space. +llvm::Type *LTy = CGT.ConvertType(Ty); --

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

paulwalker-arm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1850 + else +TuneCPU = "generic"; +} else What benefit does `-tune-cpu generic` provide? I'm wondering if the patch can be restricted to only add `-tune-cpu`

[PATCH] D109322: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Basic/riscv_vector.td:2186 +}] in +def policy : RVVHeader; HsiangKai wrote: > khchen wrote: > > It seems like we can re

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus closed this revision. Szelethus added a comment. Commited in rGee6913cc8317c08b603daed64b07a17a95ec926a to `release/13.x`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108912/new/ https://reviews.llvm.org

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 374369. gandhi21299 added a comment. - refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tes

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. Building with this patch Debian packages is failing with: "/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0/build-llvm/tools/clang/stage2-bins/bin/clang++" -DHAVE___CXA_THREAD_ATEXIT_IMPL -DLI

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#3017317 , @sylvestre.ledru wrote: > Building with this patch Debian packages is failing with: > > > "/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0/

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. > How was the toolchain in > /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0 > > /build-llvm > built? Only using PROJECTS

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

bader added a comment. LGTM, just one typo in addition to linter reports and I'd like John to take a look. Comment at: clang/docs/LanguageExtensions.rst:2524 mangling scheme at runtime. The mangler marks all the lambdas required to name -the SYCL kernel and emits a stable loc

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 374430. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/test/clang-tid

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:484 + AnyMemberHasInitPerUnion, [&](const FieldDecl *F) { if (!FieldsToInit.count(F)) return; aaron.ballman wr

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:484 + AnyMemberHasInitPerUnion, [&](const F

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... in textDocumen

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Although this patch is correct, running ./LLJITWithTargetProcessControl result in segmentation fault. PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace. Stack dump: 0. Program arguments: ./LLJITWithTargetProcessControl #0 0x7f

[PATCH] D110289: [libc++] Remove unused macro in __config

ldionne updated this revision to Diff 374518. ldionne added a comment. Herald added subscribers: cfe-commits, llvm-commits, dexonsmith, usaxena95, kadircet, arphaman, hiraditya. Herald added projects: LLVM, clang-tools-extra. Remove uses of __MAC_OS_X_VERSION_MIN_REQUIRED in LLVM Repository:

[PATCH] D110289: [libc++] Remove unused macro in __config

ldionne added a comment. In D110289#3016525 , @jloser wrote: > I think it's used in a few places from a quick `git grep`: [...] `__MAC_OS_X_VERSION_MIN_REQUIRED` is defined by Apple's ``. It is equivalent to `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED_

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler updated this revision to Diff 374520. ckandeler added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

sammccall accepted this revision. sammccall added a subscriber: mibintc. sammccall added a comment. This revision is now accepted and ready to land. LG because not crashing here is surely better than crashing, but I'm not sure whether the behaviour is actually right. If we can't be sure, maybe le

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. Hi, Could you please take some time to review this diff again? @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

erichkeane updated this revision to Diff 374523. erichkeane added a comment. fix typo that @bader found CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110281/new/ https://reviews.llvm.org/D110281 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/ASTContext.h clang/i

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler updated this revision to Diff 374526. ckandeler added a comment. Re-formatting, take two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 Files: clang-tools-extra/clangd/XRefs.cpp clang-tool

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

saghir updated this revision to Diff 374529. saghir added a comment. Changed approach for Sema checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaChecking.cpp clang/test

[PATCH] D110324: clangd: Do not report inline overrides twice

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 __

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM. Pleases address the test issue on commit. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13 +int testdarn_32(void) { + return __darn_32(); +} ---

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM once the code is simplified as Nemanja suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 ___

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler added a comment. Can you please merge it, too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Please add comment to tc upon commit. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1417 +vector signed int test_vec_vec_splati_ins_range(void) { + // CHE

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

yaxunl added a comment. Pls make sure the patch passes internal CI. Thanks. Comment at: clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp:264 // CHECK1: omp.inner.for.cond: -// CHECK1-NEXT:[[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4 -// CHECK1-NE

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. FYI: @craig.topper noticed my ping above and tells me he at least doesn't agree with my understanding of the hallway discussion we had a few years ago. I am hopeful he can correct my memory/interpretation of the conversation. CHANGES SINCE LAST ACTION https://rev

[clang-tools-extra] eb209c1 - clangd: Do not report inline overrides twice

Author: Christian Kandeler Date: 2021-09-23T16:09:13+02:00 New Revision: eb209c13cce99b1ad8d8e619bf2006f4376ed1ef URL: https://github.com/llvm/llvm-project/commit/eb209c13cce99b1ad8d8e619bf2006f4376ed1ef DIFF: https://github.com/llvm/llvm-project/commit/eb209c13cce99b1ad8d8e619bf2006f4376ed1ef.

[PATCH] D110324: clangd: Do not report inline overrides twice

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb209c13cce9: clangd: Do not report inline overrides twice (authored by ckandeler, committed by sammccall). Repository: rG LLVM Github Monorepo C

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

lei requested changes to this revision. lei added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Sema/Sema.h:12680 bool CheckPPCMMAType(QualType Type, SourceLocation TypeLoc); + bool CheckPPCTestDataClassType(CallExpr *TheCall)

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp:264 // CHECK1: omp.inner.for.cond: -// CHECK1-NEXT:[[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4 -// CHECK1-NEXT:[[TMP8:%.*]] = load i32, i32* [[DOTOMP_UB

[PATCH] D110324: clangd: Do not report inline overrides twice

ckandeler added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110324/new/ https://reviews.llvm.org/D110324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

RE: [clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple,mangled}

Resending to cfe-commits instead of llvm-commits (doh!). > -Original Message- > From: Robinson, Paul > Sent: Thursday, September 23, 2021 10:05 AM > To: David Blaikie ; 'llvm-comm...@lists.llvm.org' > > Cc: Adrian Prantl ; Jonas Devlieghere > > Subject: RE: [clang] 38c09ea - DebugInfo: A

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ldionne added a comment. This sounds more reasonable to me, however we need to ship `` in libc++ before we enable this, or else we're going to start suggesting that users include `` when we don't have it. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1668 +if (!CoroNamespa

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

hokein updated this revision to Diff 374538. hokein added a comment. upload a minimized testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110315/new/ https://reviews.llvm.org/D110315 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaCXX/

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

Conanap added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13 +int testdarn_32(void) { + return __darn_32(); +} lei wrote: > Isn't this valid for both 32 and 64bit? > Maybe change one of the run lines above to a 64bit test. It

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13 +int testdarn_32(void) { + return __darn_32(); +} lei wrote: > Isn't this valid for both 32 and 64bit? > Maybe change one of the run lines above to a 64bit test. I agre

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-darn-32.c:13 +int testdarn_32(void) { + return __darn_32(); +} Conanap wrote: > amyk wrote: > > lei wrote: > > > Isn't this valid for both 32 and 64bit? > > > Maybe change one of th

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14496 - if (FSI->UsesFPIntrin && !FD->hasAttr()) + if (FSI->UsesFPIntrin && FD && !FD->hasAttr()) FD->addAttr(StrictFPAttr::CreateImplicit(Context)); sammccall wrote: > hokein wrote: >

[clang] 3778c1c - [Sema] Fix a null pointer reference crash.

Author: Haojian Wu Date: 2021-09-23T16:37:37+02:00 New Revision: 3778c1cd6ef5a3286d5d49e842a2c65fffb8f3a6 URL: https://github.com/llvm/llvm-project/commit/3778c1cd6ef5a3286d5d49e842a2c65fffb8f3a6 DIFF: https://github.com/llvm/llvm-project/commit/3778c1cd6ef5a3286d5d49e842a2c65fffb8f3a6.diff LO

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3778c1cd6ef5: [Sema] Fix a null pointer reference crash. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. Thanks @xgupta for your note! The parameter passed to `EPCIndirectionUtils::Create()` in the example was referencing a moved-from value. This caused the segfault. Unfortunately, the examples don't have good test coverage so far. Repository: rG LLVM Github Monorepo

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2815 +def : Pat<(v4i32 (PPCSToV DblToUInt.A)), + (v4i32 (SUBREG_TO_REG (i64 1), (XSCVDPSXWS f64:$A), sub_64))>; defm : ScalToVecWPermute< This should be `XSCVDPUXWS`? =

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

amyk accepted this revision as: amyk. amyk added a comment. LGTM as long as Lei's comment is addressed. Thanks Quinn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 __

[clang] 8ecf366 - Fix buildbot error.

Author: Haojian Wu Date: 2021-09-23T17:04:46+02:00 New Revision: 8ecf3660f2de3b88d10db0fd52d0bc80bda33dcc URL: https://github.com/llvm/llvm-project/commit/8ecf3660f2de3b88d10db0fd52d0bc80bda33dcc DIFF: https://github.com/llvm/llvm-project/commit/8ecf3660f2de3b88d10db0fd52d0bc80bda33dcc.diff LO

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

thakis added a comment. Arm Mac: http://45.33.8.238/macm1/18463/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110315/new/ https://reviews.llvm.org/D110315 ___ cfe-commits mailing list cfe-comm

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

Conanap updated this revision to Diff 374556. Conanap added a comment. Added test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110273/new/ https://reviews.llvm.org/D110273 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-St

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374561. quinnp added a comment. Added a comment to the out-of-range argument test case to describe the behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 File

[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

pengfei created this revision. pengfei added reviewers: LuoYuanke, craig.topper, RKSimon, yubing. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374563. quinnp added a comment. Word change. valid -> expected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/Se

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp:264 // CHECK1: omp.inner.for.cond: -// CHECK1-NEXT:[[TMP7:%.*]] = load i32, i32* [[DOTOMP_IV]], align 4 -// CHECK1-NEXT:[[TMP8:%.*]] = load i32, i32* [[DOTOMP_UB

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

Conanap updated this revision to Diff 374565. Conanap added a comment. Moved test case back to original file and use `#ifdef __PPC64__` instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110282/new/ https://reviews.llvm.org/D110282 Files: clang/lib/Sema/SemaChecking.cpp clang/te

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

amyk accepted this revision as: amyk. amyk added a comment. Thanks for updating the tests and description, Albion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110282/new/ https://reviews.llvm.org/D110282 ___ cfe-commits mailing list cfe-com

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added a comment. @martong BTW, this patch is the first one in the stack. There are also D107339 and D108032 . You could also express your opinion there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1042

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added a comment. @vsavchenko gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106823/new/ https://reviews.llvm.org/D106823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

labrinea updated this revision to Diff 374572. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org/D110065 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h clang/test/Driver/aarch64-cpus.c clang/test/Preprocessor/aarch64-

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

xgupta accepted this revision. xgupta added a comment. I can push this for you @fcambus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/ https://reviews.llvm.org/D110041 ___ cfe-commits mailing

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f5ca8cc2158: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils. (authored by fcambus, committed by xgupta). Repository: rG

[clang] 7f5ca8c - [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

Author: Frederic Cambus Date: 2021-09-23T21:16:43+05:30 New Revision: 7f5ca8cc2158debe3f09eb19b4613e75e124 URL: https://github.com/llvm/llvm-project/commit/7f5ca8cc2158debe3f09eb19b4613e75e124 DIFF: https://github.com/llvm/llvm-project/commit/7f5ca8cc2158debe3f09eb19b4613e75e124.dif

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

tejohnson added a comment. Few follow ups below. Comment at: clang/test/CodeGen/thinlto-funcattr-prop.ll:16 + +; CHECK: ^2 = gv: (guid: 13959900437860518209, summaries: (function: (module: ^0, flags: (linkage: external, visibility: default, notEligibleToImport: 0, live: 1, ds

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

rnk added a comment. In D110257#3016918 , @hsmhsm wrote: > That said, it is still good idea (and actually an explicitly not mandated > requirement) to maintain the contiguity of the static allocas at the top of > the basic block as one cluster, and it s

[PATCH] D110252: Added note about Whatstyle and Unformat

MyDeveloperDay added a comment. Whatstyle has not been updated since Dec 2020, is it going to cover the latest style configuration options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110252/new/ https://reviews.llvm.org/D110252 ___

[clang] f9912fe - [PowerPC] Add range checks for P10 Vector Builtins

Author: Quinn Pham Date: 2021-09-23T11:05:49-05:00 New Revision: f9912fe4eac91f27965c22d015b3109c5158d050 URL: https://github.com/llvm/llvm-project/commit/f9912fe4eac91f27965c22d015b3109c5158d050 DIFF: https://github.com/llvm/llvm-project/commit/f9912fe4eac91f27965c22d015b3109c5158d050.diff LO

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9912fe4eac9: [PowerPC] Add range checks for P10 Vector Builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374578. Conanap added a comment. Updated test cases, fixed a typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/CodeGen/PowerPC/test-vector-ins

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap marked 3 inline comments as done. Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:8 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \ +; RUN: -mcpu=pwr7 < %s | FileCheck %s + kamaub wrote: > It

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D110260#3018110 , @sgraenitz wrote: > Thanks @xgupta for your note! The parameter passed to > `EPCIndirectionUtils::Create()` in the example was re

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson added a comment. In D110276#3016312 , @tejohnson wrote: > In D110276#3016295 , @thakis wrote: > >> Oh, the win failure >> (https://buildkite.com/llvm-project/premerge-checks/builds/57480#f7da3275-775a-4

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

martong added a comment. In D104285#3018257 , @ASDenysPetrov wrote: > @martong > BTW, this patch is the first one in the stack. There are also D107339 > and D108032 > . You could also

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

thakis added a comment. In D103938#3013503 , @thakis wrote: > This flags this code from absl: Did you see this comment? Looks like this relanded, but it still warns there even though it has an effect there I think (?) Repository: rG LLVM Github Mono

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. In D110260#3018412 , @xgupta wrote: > Yeah we need testcases, now it says > > JIT session error: Symbols not found: [ return1 ] > JIT session error: Failed to materialize symbols: { (main, { foo_body }) } > Unable to lazily comp

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:65 - return cast(Op.getGlobal()); + return dyn_cast(Op.getGlobal()); } I think this is not the right place for this. If we can determine the callee function, we

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman added a comment. In D103938#3013503 , @thakis wrote: > This flags this code from absl: > > template typename std::enable_if::value, > int>::type = > (GenT{}, 0)> > constexpr FlagDefaultArg DefaultArg(int) {

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

tra added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:116-117 + // Enums corresponding to clang options for linking bitcode, i.e., + // -mlink-builtin-bitcode or -mlink-bitcode-file + enum BitCodeLinkOpt { It appears that what we deal

  1   2   >