[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373982. ggeorgakoudis added a comment. Rebase and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

kamaub added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3518 +// valid. The argument must be either a 'float' or a 'double'. +bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) { + QualType ArgType = TheCall->getArg(0)->getType(); lei wrot

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

MaskRay added a comment. Do you know why `--target=armv8l-unknown-linux-gnueabihf` picks `armhf-unknown-linux-gnueabihf` instead of `armv8l-unknown-linux-gnueabihf`? (For new tests, prefer `--target=` to `-target `; space separated driver options are not the convention.) The direction the Clang

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

MaskRay added inline comments. Comment at: clang/test/Driver/arm-float-abi-runtime-path.c:7 +// RUN:-resource-dir=%S/Inputs/arm_float_abi_runtime_path 2>&1 | FileCheck -check-prefix=ARMHF %s +// RUN: %clang %s -target armv7-unknown-linux-gnueabihf -print-runtime-dir \ +/

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d66649adf28: [OpenMP] Codegen aggregate for outlined function captures (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

phosek added a comment. In D110142#3013138 , @MaskRay wrote: > Do you know why `--target=armv8l-unknown-linux-gnueabihf` picks > `armhf-unknown-linux-gnueabihf` instead of `armv8l-unknown-linux-gnueabihf`? > (For new tests, prefer `--target=` to `-target

[clang] 131e878 - Print nullptr_t namespace qualified within std::

Author: David Blaikie Date: 2021-09-21T11:21:40-07:00 New Revision: 131e8786640a49daf533b7ead4d3b5b82e0aea2a URL: https://github.com/llvm/llvm-project/commit/131e8786640a49daf533b7ead4d3b5b82e0aea2a DIFF: https://github.com/llvm/llvm-project/commit/131e8786640a49daf533b7ead4d3b5b82e0aea2a.diff

[PATCH] D110044: Print nullptr_t namespace qualified within std::

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG131e8786640a: Print nullptr_t namespace qualified within std:: (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D110044: Print nullptr_t namespace qualified within std::

dblaikie added inline comments. Comment at: clang/lib/AST/Type.cpp:3045 case NullPtr: -return "nullptr_t"; +return "std::nullptr_t"; case Overload: aaron.ballman wrote: > dblaikie wrote: > > aaron.ballman wrote: > > > Should this be `::std::nullptr_

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a comment. seeing buildbot failures after this patch landed https://lab.llvm.org/staging/#/builders/183/builds/1598 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 _

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

MaskRay added a comment. LGTM. I looked at this in 2019 but did not change because GNU ld 2.25 (2014) introduced --push-state. (gold added it in 2016 but I think we can have higher version requirement for gold.) In 2021, binutils 2.24 (2013) compatibility should be irrelevant now...

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

MaskRay added inline comments. Comment at: clang/test/Driver/linux-ld.c:499 +// RUN: %clangxx -no-canonical-prefixes -x c++ %s -### -o %t.o 2>&1 \ +// RUN: -target x86_64-unknown-linux-gnu \ `-no-canonical-prefixes` is only useful when the CHECK lines inspe

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3013233 , @ronlieb wrote: > seeing buildbot failures after this patch landed > https://lab.llvm.org/staging/#/builders/183/builds/1598 Looking it at @ronlieb, thanks for reporting Repository: rG LLVM Github

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 373999. anirudhp added a comment. - Reduced the number of test lines in target-data.c, since we don't have to check for every combination of arch,cpu for the SystemZ target (for both elf and z/OS) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. In D109362#3013253 , @anirudhp wrote: > - Reduced the number of test lines in target-data.c, since we don't have to > check for every combination of arch,cpu for the SystemZ target (for both elf > and z/OS) These changes still

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay accepted this revision. MaskRay added a comment. Thanks for cleaning up RUN lines :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mai

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374000. quinnp added a comment. Adding a testcase where the second parameter of vec_splati_ins is out of the range 0,1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp marked 2 inline comments as done. anirudhp added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > MaskRay wrote:

[clang] d9308aa - [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

Author: Matheus Izvekov Date: 2021-09-21T21:41:20+02:00 New Revision: d9308aa39b236064a680ca57178af3c731e13e49 URL: https://github.com/llvm/llvm-project/commit/d9308aa39b236064a680ca57178af3c731e13e49 DIFF: https://github.com/llvm/llvm-project/commit/d9308aa39b236064a680ca57178af3c731e13e49.dif

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9308aa39b23: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO (authored by mizvekov). Repository: rG LLVM Github Monorepo CH

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

dblaikie added a comment. Given this is about being preserved into debug info - I imagine it'll have the same behavior as using a typedef in a function return type - whenever that currently shows up in the DWARF, this attribute would. Where it doesn't, this doesn't. So I wouldn't expect this f

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3013233 , @ronlieb wrote: > seeing buildbot failures after this patch landed > https://lab.llvm.org/staging/#/builders/183/builds/1598 This looks like another AMDGPU issue. The code in question doesn't do anything

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

vsapsai updated this revision to Diff 374016. vsapsai added a comment. Add a [failing] test case that checks handling methods from transitive modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123 Files

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:57 + + std::string NewText = " " + Qualifier + " "; + NewText += Next->TokenText; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Does not need to be addres

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a comment. Please revert the patch so our buildbot can resume greeness, and we can look into it with urgency today (me or Jon) as it should be reproducible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llv

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

vsapsai updated this revision to Diff 374017. vsapsai added a comment. Simplify the test and make it less sensitive to what "method" clang selects to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

JonChesterfield added a subscriber: dpalermo. JonChesterfield added a comment. @ronlieb can you apply this to amd-stg-open? If it breaks there we have a chance of trying a debugger on it. @dpalermo might be available again now. @jdoerfert I debug stuff like this by inspection, guesswork and a DI

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3013437 , @ronlieb wrote: > Please revert the patch so our buildbot can resume greeness, and we can look > into it with urgency today (me or Jon) > as it should be reproducible Sounds good. @ggeorgakoudis let's reve

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. Cool! I like the idea of *compile-time* dispatch. LGTM except minor warnings from clang-tidy. Could you fix them before committing this change? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

thakis added a comment. This flags this code from absl: template ::value, int>::type = (GenT{}, 0)> constexpr FlagDefaultArg DefaultArg(int) { return {FlagDefaultSrc(GenT{}.value), FlagDefaultKind::kOneWord}; } (https://source.chromium.org/chromium/chromium/src/+/main:

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3012647 , @rmaz wrote: >> What folks are thinking about writing less in METHOD_POOL? > > I prefer the idea of it, but I think the `ReadMethodPoolVisitor` also has to > be changed for this to work. When it finds a selec

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks reasonable. Can you give us some time to test this on the Linux kernel? Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:3 + +// RUN: %clang_cc1

[clang] 52832cd - [CodeGen] regenerate test checks; NFC

Author: Sanjay Patel Date: 2021-09-21T16:53:41-04:00 New Revision: 52832cd917af00e2b9c6a9d1476ba79754dcabff URL: https://github.com/llvm/llvm-project/commit/52832cd917af00e2b9c6a9d1476ba79754dcabff DIFF: https://github.com/llvm/llvm-project/commit/52832cd917af00e2b9c6a9d1476ba79754dcabff.diff

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374028. tra added a comment. Minor cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sem

[PATCH] D110201: [clang] Make -Rpass imply -Rpass=.*

aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously with -Rpass (and friends) we'd have remarks "enabled", but without an actual regex. As seen in the tes

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added a comment. In D109632#3013523 , @vsapsai wrote: > 2. Serialize only methods owned by the current module (and change > `ReadMethodPoolVisitor` appropriately). Would that require visiting all in-memory modules every time there's a global

[PATCH] D110201: [clang] Make -Rpass imply -Rpass=.*

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110201/new/ https://reviews.llvm.org/D110201 _

[clang] b93359e - [PowerPC] Support for vector bool int128 on vector comparison builtins

Author: Albion Fung Date: 2021-09-21T16:29:37-05:00 New Revision: b93359ea3fe59ea0c652f5e61ee68231e2fb60c4 URL: https://github.com/llvm/llvm-project/commit/b93359ea3fe59ea0c652f5e61ee68231e2fb60c4 DIFF: https://github.com/llvm/llvm-project/commit/b93359ea3fe59ea0c652f5e61ee68231e2fb60c4.diff L

[PATCH] D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93359ea3fe5: [PowerPC] Support for vector bool int128 on vector comparison builtins (authored by Conanap). Repository: rG LLVM Github Monorepo C

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dexonsmith added a comment. I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be resolved safely. Can you add some background information about why this was originally a specifier, and why it's safe to fix it now? (If you don't know, I suggest looking through git-blame to f

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374034. tra added a comment. Undo useless NOLINT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sem

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. Most of clang-tidy warnings are irrelevant -- it tries to parse the header all by itself, without CUDA headers. It also ignores `NOLINTNEXTLINE(clang-diagnostic-error)` which was intended to suppress the warning triggered by `#error`. The only useful one was in SemaChecking

[clang] e1ed021 - [clang] Make -Rpass imply -Rpass=.*

Author: Arthur Eubanks Date: 2021-09-21T14:35:56-07:00 New Revision: e1ed02181ffcfea7de952d252a5e25953c822251 URL: https://github.com/llvm/llvm-project/commit/e1ed02181ffcfea7de952d252a5e25953c822251 DIFF: https://github.com/llvm/llvm-project/commit/e1ed02181ffcfea7de952d252a5e25953c822251.diff

[PATCH] D110201: [clang] Make -Rpass imply -Rpass=.*

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1ed02181ffc: [clang] Make -Rpass imply -Rpass=.* (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D110160: [clang][tooling] NFC: Refactor command-line diagnostic tests

dexonsmith added a comment. Stepping back, maybe it'd be better to use a more generic option that is unlikely to have special behaviour in any target (or downstream). Best one I could find is triggering `err_drv_unknown_language` with `-x this-is-an-unknown-language`. WDYT?

[PATCH] D110204: Make DiagnosticInfoResourceLimit's limit param required

aeubanks created this revision. aeubanks added a reviewer: dblaikie. Herald added subscribers: foad, dexonsmith, kerbowa, hiraditya, tpr, nhaehnle, jvesely, arsenm. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D110204: Make DiagnosticInfoResourceLimit's limit param required

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110204/new/ https://reviews.llvm.org/D110204

[clang] e422343 - Make DiagnosticInfoResourceLimit's limit param required

Author: Arthur Eubanks Date: 2021-09-21T15:27:58-07:00 New Revision: e42234383e2c0a7472413cd8047889f6ad4afc88 URL: https://github.com/llvm/llvm-project/commit/e42234383e2c0a7472413cd8047889f6ad4afc88 DIFF: https://github.com/llvm/llvm-project/commit/e42234383e2c0a7472413cd8047889f6ad4afc88.diff

[PATCH] D110204: Make DiagnosticInfoResourceLimit's limit param required

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe42234383e2c: Make DiagnosticInfoResourceLimit's limit param required (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

yonghong-song updated this revision to Diff 374057. yonghong-song added a comment. - change to use DeclOrTypeAttr in Attr.td to indicate the attribute can be used for declarations or type qualifier. - add explanation of why the change in AttrDocs.td and the test. Repository: rG LLVM Github Mo

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

yonghong-song added a comment. @aaron.ballman Addressed your comments, please take a look. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110116/new/ https://reviews.llvm.org/D110116 ___ cfe-commi

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374059. Conanap marked an inline comment as done. Conanap added a comment. Removed AIX test line as it has the same code gen as BE CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/P

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374064. quinnp added a comment. Separating the switch case in ISelLowering into two switch cases. One for `compare_exp_` and another for `test_data_class`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/ne

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. In D110127#3012215 , @aaron.ballman wrote: >> First, to build linux kernel with btf_tag annotated user pointer, we have >> >> #define __user __attribute__((btf_tag("user"))) >> and the linux kernel contains code like below

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ronlieb added a subscriber: pdhaliwal. ronlieb added a comment. @pdhaliwal i will pass the problem over to Pushpinder Singh who should be waking up soon. George, thank you for reverting it. i can reproduce the issue on a local system. building latest (revert present) passes. Revert the revert an

[PATCH] D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

hoy created this revision. Herald added subscribers: ormris, modimo, wenlei, dang, pengfei, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: MaskRay. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D110129: [DebugInfo] Support typedef with btf_tag attributes

yonghong-song updated this revision to Diff 374073. yonghong-song added a comment. - updated tests based on @probinson suggestions. - The only thing left is for llvm/test/DebugInfo/X86/attr-btf_tag-typedef.ll for which I didn't use `%itanium_abi_triple` as it seems only available for %clang ...

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

tlively added a comment. Nice! Thanks for writing this :D Do you know what happens when you actually try to compile some code with `-mrelaxed-simd`? I'm concerned that it will throw an error because the "relaxed-simd" target feature has not yet been defined in the backend (specifically in WebAs

[PATCH] D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. thanks for the change. control this through metadata is more reliable than through LTO time flags. Scheduling a non-op pass shouldn't incur overhead either. lgtm. Repository: rG LLVM Githu

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. This patch doesn't seem to break anything on my side. @saiislam could you 1. address all the in-source review comments 2. update the title to `[Clang][OpenMP] Add partial support for Static Device Libraries` 3. update the patch description about what works and what doesn'

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen reopened this revision. ychen added a comment. This revision is now accepted and ready to land. reopen to fix tests failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 _

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen updated this revision to Diff 374078. ychen edited the summary of this revision. ychen added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. This revision now requires review to proceed. - Check the scope correctly: first

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen updated this revision to Diff 374080. ychen added a comment. - Remove accidentally included change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen requested review of this revision. ychen added a comment. This and 45c0ebe00efb should make `-Werror` build of libcxx tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D110210: [clang] NFC: include non friendly types and missing sugar in test expectations

mizvekov created this revision. mizvekov edited the summary of this revision. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dump of all diagnostics of all tests under `clang/test/{CXX,SemaCXX,SemaTemplate}` was analyzed , a

[PATCH] D110213: [PowerPC] Define XL-compatible macros only for AIX and Linux

nemanjai created this revision. nemanjai added reviewers: PowerPC, dim. Herald added subscribers: steven.zhang, shchenz, kbarton. nemanjai requested review of this revision. Herald added a project: clang. Since XLC only ever shipped on PowerPC AIX and Linux, it is not reasonable to provide the co

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

nemanjai added a comment. In D104386#2979830 , @dim wrote: > In D104386#2977302 , @nemanjai > wrote: > >> The idea with putting all of these in a separate function was to: >> >> 1. Make it easy to limit it to spe

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. @ldionne @Quuxplusone Now the compiler wouldn't emit warning for any more. So I think this is good. Do you feel good with this? This is necessary to conform the implementation of coroutine since the compiler would search coroutine components in corresponding namespac

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

tianshilei1992 updated this revision to Diff 374089. tianshilei1992 added a comment. It looks better to use `enum` in this case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 Files: clang/lib/CodeGen/C

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#3013955 , @ye-luo wrote: > This patch doesn't seem to break anything on my side. > @saiislam could you > > 1. address all the in-source review comments > 2. update the title to `[Clang][OpenMP] Add partial support for

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

dblaikie added a comment. (A possibly more robust option - so that this doesn't regress if someone adds a new "return true" codepath & forgets to release the cleanup (it looks like a pretty long function with several exits, etc) - would be to move the code into an "impl" function and have the o

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. In D95588#3003090 , @Jim wrote: > Any feedback? I think this patch is good enough to be accepted. Ping? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

beanz added a subscriber: lhames. beanz added a comment. I was talking with @lhames the other day about building a `doWithCleanup` abstraction that could take a labmda to perform and a lambda to cleanup on failure. I was thinking I may take a stab at that this week. Repository: rG LLVM Gith

[clang] d31dfc3 - DebugInfo: Unify some printing policy adjustments

Author: David Blaikie Date: 2021-09-21T19:30:12-07:00 New Revision: d31dfc30115705332034a81b6b2ab904ca1cf029 URL: https://github.com/llvm/llvm-project/commit/d31dfc30115705332034a81b6b2ab904ca1cf029 DIFF: https://github.com/llvm/llvm-project/commit/d31dfc30115705332034a81b6b2ab904ca1cf029.diff

[clang] db6f1e8 - DebugInfo: Don't suppress inline namespaces when printing template template parameter names

Author: David Blaikie Date: 2021-09-21T19:30:13-07:00 New Revision: db6f1e8a8857ccaa339304131373f3150528e812 URL: https://github.com/llvm/llvm-project/commit/db6f1e8a8857ccaa339304131373f3150528e812 DIFF: https://github.com/llvm/llvm-project/commit/db6f1e8a8857ccaa339304131373f3150528e812.diff

[PATCH] D109799: [RISCV] add Half-precision test for clang

achieveartificialintelligence updated this revision to Diff 374095. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D109799 Files: clang/test/CodeGen/RISCV/

[PATCH] D109799: [RISCV] add Half-precision test for clang

achieveartificialintelligence added a comment. In D109799#3008067 , @craig.topper wrote: > This patch is really large and touches tests for integer operations. Can you > just pre-commit the removal of lines with just comment characters. No need to > re

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

dblaikie added a comment. In D109865#3014106 , @beanz wrote: > I was talking with @lhames the other day about building a `doWithCleanup` > abstraction that could take a labmda to perform and a lambda to cleanup on > failure. > > I was thinking I may tak

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Ping On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > Hey Richard - was just going back over some of the modular codegen code > (due to a discussion on the EWG mailing list about file extensions that > ended up touching on the nature of how modules are built) - and I came > across this cod

[PATCH] D109799: [RISCV] add Half-precision test for clang

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D109799 ___

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:442 + +if (STI.getFeatureBits()[RISCV::FeatureExtZpsfoperand] && +!STI.getFeatureBits()[RISCV::Feature64Bit]) { Jim wrote: > jrtc27 wrote: > > The table

[PATCH] D109799: [RISCV] add Half-precision test for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe247fed23b92: [RISCV] add Half-precision test for clang (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2ff049b - DebugInfo: Don't use preferred template names in debug info

Author: David Blaikie Date: 2021-09-21T20:08:16-07:00 New Revision: 2ff049b12ee3fb60581835a28bf9d0acc1723f23 URL: https://github.com/llvm/llvm-project/commit/2ff049b12ee3fb60581835a28bf9d0acc1723f23 DIFF: https://github.com/llvm/llvm-project/commit/2ff049b12ee3fb60581835a28bf9d0acc1723f23.diff

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. The amount of duplication here really depresses me and is only going to get worse once codegen is added, but TableGen isn't able to have operands that use different register classes based on even HwMode, that I know of, and whilst you could make use of multi classes to g

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:539 +let RegAltNameIndices = [ABIRegAltName] in { + foreach Index = [0, 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, This needs to be coordinated with D95588; you both define GPR p

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10221 +ABIArgInfo SPIRABIInfo::classifyKernelArgumentType(QualType Ty) const { + if (getContext().getLangOpts().HIP && getTarget().getTriple().isSPIRV()) { +// Coerce pointer arguments with default

[PATCH] D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

MaskRay added a comment. lld/test/ELF/lto/pseudo-probe-lto.ll needs update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110209/new/ https://reviews.llvm.org/D110209 ___ cfe-commits mailing list cfe-comm

[PATCH] D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

hoy added a comment. In D110209#3014334 , @MaskRay wrote: > lld/test/ELF/lto/pseudo-probe-lto.ll needs update Good catch, thanks. I also moved the pass into x86 backend only, as there are a lot test failures on other targets and we don't really need th

[PATCH] D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

hoy updated this revision to Diff 374126. hoy added a comment. Updating D110209 : [CSSPGO] Set PseudoProbeInserter as a default pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110209/new/ https://reviews.llvm.

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

jlebar added a comment. > One alternative would be to use run-time dispatch, but, given that texture > lookup is a single instruction, the overhead would be > substantial-to-prohibitive. I guess I'm confused... Is the parameter value that we're "overloading" on usually/always a constant? In

<    1   2