[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > anirudhp wrote: > > MaskRay wrote: > > > If you add so man

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

thakis added a comment. Thanks, reverted in 9197834535364efff505580ef940ad41cd293275 for now. Here's a shorter cmake invocation that repros it: `cmake -GNinja -DCLANG_ENABLE_STATIC_ANALYZER=OFF ../llvm-project/llvm '-DLLVM_E

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Thx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108823/new/ https://reviews.llvm.org/D108823

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

lei added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3518 +// valid. The argument must be either a 'float' or a 'double'. +bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) { + QualType ArgType = TheCall->getArg(0)->getType(); I don't thi

[clang] 96d3319 - Sema: relax va_start checking further for Windows AArch64

Author: Saleem Abdulrasool Date: 2021-09-20T21:23:33Z New Revision: 96d3319d6f024b17ac725d9595548acc4787003c URL: https://github.com/llvm/llvm-project/commit/96d3319d6f024b17ac725d9595548acc4787003c DIFF: https://github.com/llvm/llvm-project/commit/96d3319d6f024b17ac725d9595548acc4787003c.diff

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 373711. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Conti

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22414 + + EXPECT_EQ("int a = (int)b;", format("int a = (\n" + "int\n" csmulhern wrote: > MyDev

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1414 // CHECK-LE: ret <4 x float> return vec_splati_ins(vfa, 0, 1.0f); } Need to add a testcase where param `b` to `vec_splati_ins(a,b,c)` is not 0 or 1. Repository: rG

[clang] f119170 - [clang] Fix a few comment typos to cycle bots

Author: Nico Weber Date: 2021-09-20T18:48:34-04:00 New Revision: f11917057923bce7f9c04282b4a3b15ef0aad0d6 URL: https://github.com/llvm/llvm-project/commit/f11917057923bce7f9c04282b4a3b15ef0aad0d6 DIFF: https://github.com/llvm/llvm-project/commit/f11917057923bce7f9c04282b4a3b15ef0aad0d6.diff LO

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: dang, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This currently only de

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian added a comment. I followed https://reviews.llvm.org/rGb7b9fdc114c1f9c788da914dac5c343277805446 for this, hope it's right, ptal Thomas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111 ___

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jdoerfert added a comment. The runtime code is missing, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110108/new/ https://reviews.llvm.org/D110108 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jhuber6 added a comment. In D110108#3010861 , @jdoerfert wrote: > The runtime code is missing, right? Yes, was going to make that a separate patch, also need to fix the LLVM tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] bde305b - [clang] Fix a few comment more typos to cycle bots

Author: Nico Weber Date: 2021-09-20T19:42:49-04:00 New Revision: bde305baf631004b8d00081f11e62b33e1665e45 URL: https://github.com/llvm/llvm-project/commit/bde305baf631004b8d00081f11e62b33e1665e45 DIFF: https://github.com/llvm/llvm-project/commit/bde305baf631004b8d00081f11e62b33e1665e45.diff LO

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. Here's expanded and formatted version of the header: https://gist.github.com/Artem-B/ec4290809650f5092d61d6dafa6b0131 It may help to see what's going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://review

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 373747. tra edited the summary of this revision. tra added a comment. cosmetic cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/include/clang/Basi

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, linux kernel has a __user attribute ([1]) defined as __attribute__((noderef, add

[clang] 60ab686 - [clang] Fix a few more comment typos to cycle bots

Author: Nico Weber Date: 2021-09-20T20:06:03-04:00 New Revision: 60ab6861ed13e4f1e2729f8add6366a7be223d80 URL: https://github.com/llvm/llvm-project/commit/60ab6861ed13e4f1e2729f8add6366a7be223d80 DIFF: https://github.com/llvm/llvm-project/commit/60ab6861ed13e4f1e2729f8add6366a7be223d80.diff LO

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373755. ggeorgakoudis added a comment. Fix for clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers added a comment. Thanks for the patch! Please fix the lint checks. `git-clang-format HEAD~` should help, and IIRC there is a git hook when using `arc diff` (though maybe that requires one time setup? I seem to have an `.arclint` file in my `llvm-projects` checkout.

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers added a comment. Please amend the bug description to link to: - https://bugs.llvm.org/show_bug.cgi?id=50322 - https://lore.kernel.org/lkml/20210822075122.864511-17-keesc...@chromium.org/ (You can do `git commit --amend; arc diff --verbatim` to have `arc` update the patch descrip

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s +// nickdesaulniers wrote: > Would `-emit-codegen-only` b

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); Do we want to check somewh

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); tianshilei1992 wrote: > Do we wan

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +

[PATCH] D110044: Print nullptr_t namespace qualified within std::

dblaikie added a comment. In D110044#3009201 , @aaron.ballman wrote: >> This improves diagnostic (& important to me, DWARF) accuracy > > FWIW, I don't think the diagnostic particularly needs more accuracy here -- I > think users know what `nullptr_t` ty

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are already making an effort to skip selectors that have methods only from other modules. But in edge cases we ke

[PATCH] D110044: Print nullptr_t namespace qualified within std::

dblaikie updated this revision to Diff 373768. dblaikie added a comment. Add debug info test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110044/new/ https://reviews.llvm.org/D110044 Files: clang/lib/AST/Type.cpp clang/test/AST/ast-dump-

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. Looks like in `METHOD_POOL` we don't need the transitive closure for performance reasons. And we are kinda trying to store only data the module owns > // Only write this selector if it's not in an existing AST or something > // changed. But even if a single method i

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. This fixed the builder: http://meinersbur.de:8011/#/builders/76/builds/803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___ cfe-c

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge added a comment. In D110051#3009378 , @kadircet wrote: > I am not aware of how the intersecting hints are handled in the > implementation on the client side nor in the proposal today. After this patch > we might still produce them if for whatever

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge updated this revision to Diff 373782. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110051/new/ https://reviews.llvm.org/D110051 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, btf_tag attribute supports record, field, gl

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek created this revision. phosek added reviewers: MaskRay, mcgrathr. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When statically linking C++ standard library, we shouldn't add -Bdynamic after including the library on the link

[PATCH] D110129: [DebugInfo] Support typedef with btf_tag attributes

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-comm

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. The corresponding clang codegen and llvm implementation: https://reviews.llvm.org/D110129 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/ https://reviews.llvm.org/D110127 __

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

uabelho added a comment. Hi @ychen, A whole bunch of libcxx testcases fail for me when I run with this patch: Failed Tests (90): libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/assign.pass.cpp libc++ :: std/numerics/rand/r

<    1   2