[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

jhuber6 added a comment. In D109997#3007216 , @jdoerfert wrote: > You checked that this works with the usage in the RT, right? Worked when I tested it. Want me to make a patch for it off of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, and yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109997/new/ https://reviews.llvm.org/D109997 _

[clang] 7efb825 - Revert "OpenMP 5.0 metadirective"

Author: cchen Date: 2021-09-17T16:14:16-05:00 New Revision: 7efb825382c0a8372597aaf75a319fa379573fd4 URL: https://github.com/llvm/llvm-project/commit/7efb825382c0a8372597aaf75a319fa379573fd4 DIFF: https://github.com/llvm/llvm-project/commit/7efb825382c0a8372597aaf75a319fa379573fd4.diff LOG: Re

[clang] 347f3c1 - OpenMP 5.0 metadirective

Author: alokmishra.besu Date: 2021-09-17T16:30:06-05:00 New Revision: 347f3c186d3fd86628904450d2f4ee0ffd428150 URL: https://github.com/llvm/llvm-project/commit/347f3c186d3fd86628904450d2f4ee0ffd428150 DIFF: https://github.com/llvm/llvm-project/commit/347f3c186d3fd86628904450d2f4ee0ffd428150.dif

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. I reapplied the patch since I forgot to add author's name in the commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 ___ cfe-commits mai

[clang] 9ff848c - Revert "[OpenMP] Use irbuilder as default for masked and master construct"

Author: cchen Date: 2021-09-17T16:44:09-05:00 New Revision: 9ff848c5cd88947714f3d9bf03a3adbb84066736 URL: https://github.com/llvm/llvm-project/commit/9ff848c5cd88947714f3d9bf03a3adbb84066736 DIFF: https://github.com/llvm/llvm-project/commit/9ff848c5cd88947714f3d9bf03a3adbb84066736.diff LOG: Re

[clang] 843390c - Apply proper source location to fallthrough switch cases.

Author: Adrian Prantl Date: 2021-09-17T14:45:04-07:00 New Revision: 843390c58ae660fa356c534fdc8b19756f8d175c URL: https://github.com/llvm/llvm-project/commit/843390c58ae660fa356c534fdc8b19756f8d175c DIFF: https://github.com/llvm/llvm-project/commit/843390c58ae660fa356c534fdc8b19756f8d175c.diff

[PATCH] D109940: Apply proper source location to fallthrough switch cases

This revision was automatically updated to reflect the committed changes. Closed by commit rG843390c58ae6: Apply proper source location to fallthrough switch cases. (authored by aprantl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[PATCH] D109977: LLVM Driver Multicall tool

beanz added inline comments. Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:404 -int main(int argc, char **argv) { +int llvm_objcopy_main(int argc, char **argv) { InitLLVM X(argc, argv); aganea wrote: > Shouldn't we say: > ``` > int objcopy_main(int ar

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g updated this revision to Diff 373351. guitard0g added a comment. Add test case suggestions from reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 Files: clang/lib/Format/UnwrappedLine

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g added a comment. When looking at test case suggestions, I happened upon another problem that occurs when handling preprocessor directives. The following code is properly formatted (following llvm style, with ColumnLimit=0): SomeClass::SomeClass() : a{a}, b{b} {} However t

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g updated this revision to Diff 373366. guitard0g added a comment. Fix failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unit

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3006520 , @rmaz wrote: > The case we have is more like: > > .m -> A -> long list of partially shared deps -> Foundation >-> B -> long list of partially shared deps -> Foundation >-> C -> long list of

[clang] c30d773 - [OpenMP] Change debugging symbol to weak_odr linkage

Author: Joseph Huber Date: 2021-09-17T21:25:24-04:00 New Revision: c30d7730ebde18d61b33ae1de9ded69dac6ea6be URL: https://github.com/llvm/llvm-project/commit/c30d7730ebde18d61b33ae1de9ded69dac6ea6be DIFF: https://github.com/llvm/llvm-project/commit/c30d7730ebde18d61b33ae1de9ded69dac6ea6be.diff

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGc30d7730ebde: [OpenMP] Change debugging symbol to weak_odr linkage (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109997/new/ https://

[PATCH] D91944: OpenMP 5.0 metadirective

phosek added a comment. We started seeing a test failure in `Clang :: OpenMP/metadirective_device_kind_codegen.c` on our macOS bot after this change landed (we aren't seeing it on other systems): Script: -- : 'RUN: at line 1'; /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. In D103938#3006540 , @aaron.ballman wrote: > There were a few behavioral changes to tests that I had questions about. > Also, can you add an additional test case that shows the behavior when the > left operand of the comma expres

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 373390. ychen added a comment. - Restore an useful comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. Thanks for the review. Comment at: clang/test/Sema/exprs.c:19 if (0) { -0 / (0 ? 1 : 0); // expected-warning {{expression result unused}} } ychen wrote: > aaron.ballman wrote: > > Why did we lose this diagnostic (and the above c

[PATCH] D110017: [clang] Removes leak sanitizer support on FreeBSD since it is unsupported

devnexen created this revision. devnexen added a reviewer: emaste. devnexen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110017 Files: clang/lib/Driver/ToolChains/FreeBS

<    1   2