[clang] 339c734 - [Clang][AVR] Fix definitions on AVR target

Author: Mara Sophie Grosch Date: 2021-09-12T11:00:59+02:00 New Revision: 339c7340422425755cec4d28a6ff1d1f6ea4a528 URL: https://github.com/llvm/llvm-project/commit/339c7340422425755cec4d28a6ff1d1f6ea4a528 DIFF: https://github.com/llvm/llvm-project/commit/339c7340422425755cec4d28a6ff1d1f6ea4a528.

[PATCH] D109653: Fix some definitions on AVR target

This revision was automatically updated to reflect the committed changes. Closed by commit rG339c73404224: [Clang][AVR] Fix definitions on AVR target (authored by LittleFox94). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109653/new/ https://review

[PATCH] D109653: Fix some definitions on AVR target

LittleFox94 added a comment. This is committed by now, but I would still love to know if this would have been ok to just commit (and have post-commit review) :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109653/new/ https://reviews.llvm.org/D10

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei created this revision. pengfei added reviewers: LuoYuanke, craig.topper, RKSimon, yubing. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github M

[PATCH] D109653: Fix some definitions on AVR target

xgupta added a comment. Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit message. Though if you spend some time on Phabricator, you will be aware of which kind of patches need reviews and which can be committed directly. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

steveire added a comment. FYI - there's nothing "anti-inclusive" about East/West. In Qt I proposed a change which added properties to an object. Those properties in my change were named "Left"/"Right". The reviewer objected to those names because "scripts which are not Right-to-Left exist". So

[PATCH] D109607: [X86][WIP] Refactor GetSSETypeAtOffset

pengfei updated this revision to Diff 372118. pengfei added a comment. Fix lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/X86/avx

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

the_o added a comment. In D109372#2989299 , @edward-jones wrote: > In D109372#2987411 , @jrtc27 wrote: > >> In D109372#2987405 , @MaskRay >> wrote: >> >>> The name "over

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372119. pengfei added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/X86/avx512fp

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372120. pengfei added a comment. Change to use `getFPTypeAtOffset`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/lib/CodeGen/TargetInfo.cpp clang/

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372122. pengfei added a comment. Fix format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/X86/avx512

[PATCH] D109659: Fix scan-build-py executable lookup path

serge-sans-paille created this revision. serge-sans-paille added reviewers: sylvestre.ledru, isthismyaccount, phosek. Herald added a subscriber: whisperity. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Once installed, s

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei updated this revision to Diff 372123. pengfei added a comment. Ues `getTypeAllocSize`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ https://reviews.llvm.org/D109607 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGe

[PATCH] D109659: Fix scan-build-py executable lookup path

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109659/new/ https://reviews.llvm.org/D109659 _

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

craig.topper added a comment. Does gcc use the same builtin name? Our general policy is to have the same interface as gcc if we have a builtin. So if gcc has these builtins the should work the same way. For IFMA I think I made them commutable by swapping the operands between the builtin and th

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 372143. saghir added a comment. Rebased before commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c clang/test

[clang] 203cd01 - [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

Author: Ahsan Saghir Date: 2021-09-12T20:39:27-05:00 New Revision: 203cd01b54ddd720be17b8e19207ff5af4a22d4c URL: https://github.com/llvm/llvm-project/commit/203cd01b54ddd720be17b8e19207ff5af4a22d4c DIFF: https://github.com/llvm/llvm-project/commit/203cd01b54ddd720be17b8e19207ff5af4a22d4c.diff

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203cd01b54dd: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 372149. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

saghir updated this revision to Diff 372151. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/p

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 372150. salman-javed-nz added a comment. Changes in this latest patch: - `LineIsMarkedWithNOLINT()`: Moved `NOLINTBEGIN/END` aspects into a separate function. - `LineIsWithinNOLINTBEGIN()`: A `NOLINTBEGIN/END` region is only considered valid if both

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz added a comment. In D108560#2989295 , @aaron.ballman wrote: > Is this syntax used by any other tools? It seems Google have implemented `NOLINTBEGIN` and `NOLINTEND` support in cpplint. I see lines such as `// NOLINTBEGIN(whitespace/line

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3417 + llvm::Type *T1 = getFPTypeAtOffset(IRType, IROffset + NextFP, TD); + if (T1 == nullptr) { +if (NextFP == 2) Would you add comments on each case like previous code? ==

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei added a comment. > More specifically, with the following command, both cc1 and lld will run in > default mode, which is -O0 for cc1 and -O2 for lld. > > clang -flto 1.cpp -v -fuse-ld=lld I'm wondering is this the expected behavior or an oversight of pass pipeline setup? In what scenari

[clang-tools-extra] 5a85f9b - Add semantic token modifier for non-const reference parameter

Author: Tom Praschan Date: 2021-09-13T00:51:09-04:00 New Revision: 5a85f9b1d48c4367bf697adc0f62ed5c9378f0f3 URL: https://github.com/llvm/llvm-project/commit/5a85f9b1d48c4367bf697adc0f62ed5c9378f0f3 DIFF: https://github.com/llvm/llvm-project/commit/5a85f9b1d48c4367bf697adc0f62ed5c9378f0f3.diff

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a85f9b1d48c: Add semantic token modifier for non-const reference parameter (authored by tom-anders, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. Apologies, forgot about this. Commited now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added a comment. In D109658#2996412 , @craig.topper wrote: > Does gcc use the same builtin name? Our general policy is to have the same > interface as gcc if we have a builtin. So if gcc has these builtins the > should work the same way. No. W

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

pekka.jaaskelainen added a comment. In D108367#2966746 , @pekka.jaaskelainen wrote: > @Anastasia I used to have svn commit access, but haven't committed anything > for a long while in LLVM, so don't know if I can get them back to github by > just aski

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2996201 , @ye-luo wrote: > @saiislam do my test cases work on your side? I tried this patch and still > got linking failure. Hey @ye-luo, I am able to successfully compile and run all (36) tests in https://github.co

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. I did some experiments to confirm the benefits of adding a noundef attribute to the function parameter. (test result link ) One of the most significant advantages of this

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

craig.topper added a comment. In D109658#2996714 , @pengfei wrote: > In D109658#2996412 , @craig.topper > wrote: > >> Does gcc use the same builtin name? Our general policy is to have the same >> interface as gc