[PATCH] D109632: [clang] de-duplicate methods from AST files

manmanren added a comment. This looks good to me in general. Since it should not change functionality, it may not be possible to write a test case. Manman Comment at: clang/lib/Serialization/ASTReader.cpp:8194 +if (seen.insert(M).second) { + S.addMethodToGlobalList(&

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:8194 +if (seen.insert(M).second) { + S.addMethodToGlobalList(&List, M); +} manmanren wrote: > Does it make sense to check for duplication inside addMethodToGlobalList, as

[clang] 29b44ca - [OpenMP] Add flag for setting debug in the offloading device

Author: Joseph Huber Date: 2021-09-10T18:19:19-04:00 New Revision: 29b44ca896e7c5d9fef20f3660cbe5eb321b91ea URL: https://github.com/llvm/llvm-project/commit/29b44ca896e7c5d9fef20f3660cbe5eb321b91ea DIFF: https://github.com/llvm/llvm-project/commit/29b44ca896e7c5d9fef20f3660cbe5eb321b91ea.diff

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29b44ca896e7: [OpenMP] Add flag for setting debug in the offloading device (authored by jhuber6). Changed prior to commit: https://reviews.llvm.or

[PATCH] D106674: Runtime for Interop directive

RaviNarayanaswamy added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2990234 , @cchen wrote: > @alokmishra.besu do you mind if I push the patch for solving those assertions > with rebase? The patch does not change the logic in your program and I've > made sure that the tests coul

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen created this revision. cchen added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. cchen requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch supports construct trait set selector by using the existed

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2346 - VMI.ConstructTraits.push_back(Selector.Properties.front().Kind); + // VMI.ConstructTraits.push_back(Selector.Properties.front().Kind); } I'm now removing this line sin

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/test/OpenMP/declare_variant_construct_codegen_1.c:23 +#define N 100 + +void p_vxv(int *v1, int *v2, int *v3, int n); This test is from sollve test suite: https://github.com/SOLLVE/sollve_vv/blob/master/tests/5.0/dec

[clang] 3205dd3 - [clang-format] Restrict the special handling for K&R C to C/C++

Author: owenca Date: 2021-09-10T15:51:35-07:00 New Revision: 3205dd3d59b3cc36f96b7eff6387de8d2f42825f URL: https://github.com/llvm/llvm-project/commit/3205dd3d59b3cc36f96b7eff6387de8d2f42825f DIFF: https://github.com/llvm/llvm-project/commit/3205dd3d59b3cc36f96b7eff6387de8d2f42825f.diff LOG: [

[PATCH] D109582: [clang-format] Restrict the special handling for K&R C to C/C++

This revision was automatically updated to reflect the committed changes. Closed by commit rG3205dd3d59b3: [clang-format] Restrict the special handling for K&R C to C/C++ (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109582/new

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley added a comment. Thanks! I don't have commit access, I was just reading here what to do: > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your beha

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added a comment. Cool! We certainly need more tests but the design you came up with is certainly nicer than what I had in mind. One thing I wanted to do though is keep track of the constructs in the OpenMPIRBuilder instead. So move the /// Vector of declare variant construct traits

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372031. waltl edited the summary of this revision. waltl added a comment. Merge arc-blocks-avoid-heapify.m into arc-blocks.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372032. cchen added a comment. Herald added a reviewer: sscalpone. [OpenMP 5.0] metadirective This patch supports OpenMP 5.0 metadirective features. It is implemented keeping the OpenMP 5.1 features like dynamic user condition in mind. A new function, getBestW

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372034. cchen added a comment. Remove redundant file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Recu

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372035. waltl added a comment. Trivial cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cl

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372038. cchen added a comment. Remove debug info and spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/A

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. Can you add a driver test, which tests both `-fobjc-avoid-heapify-local-blocks` and `-fno-objc-avoid-heapify-local-blocks`? Other than that, LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 372005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extr

[PATCH] D109638: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy created this revision. Herald added subscribers: modimo, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Pseudo probe instrumentation was missing from O0 build. It is needed in cases where some

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 372041. keith added a comment. Handle all cases by passing relative path to ExternalFS first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/rel

[PATCH] D109638: [CSSPGO] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372042. hoy edited the summary of this revision. hoy added a comment. Updating D109638 : [CSSPGO] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. @hokein any plans to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith added reviewers: ashi1, tra, yaxunl. keith added a comment. Since you all were involved in adding this feature in the beginning I'd appreciate a review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://reviews.llvm.org/D1094

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. Hi, I have no write access to LLVM, can you commit D109408 for me? Thanks a lot Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109408/new/ https://reviews.llvm.org/D109408

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372056. waltl added a comment. Added driver flags, and tests for them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.93

Jim updated this revision to Diff 372058. Jim added a comment. Update to 0.96 and remove Zprvsfextra Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c clang/test/Pr

<    1   2