[clang] fe611b1 - [clang] Move the soname declaration in a variable at the top of the file

Author: Sylvestre Ledru Date: 2021-08-27T09:07:12+02:00 New Revision: fe611b1da84b9442c093739394d336af9e99c1a1 URL: https://github.com/llvm/llvm-project/commit/fe611b1da84b9442c093739394d336af9e99c1a1 DIFF: https://github.com/llvm/llvm-project/commit/fe611b1da84b9442c093739394d336af9e99c1a1.dif

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe611b1da84b: [clang] Move the soname declaration in a variable at the top of the file (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro abandoned this revision. djtodoro added a comment. In D108618#2968626 , @rjmccall wrote: > Does LLVM model `noinline` as a call-site attribute in the way that would be > necessary to get that effect? Also, are you actually having a problem here

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. I'm good with words like `List of Strings` but I don't think we need `Enum` `unsigned` I think Integer, I'm not sure what the code is even going to do if you supply a -ve, Warn I hope! (there's contribution idea number 2 for you right there!) ;-) Repository:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1984 +auto checkTypeIsTypedef = [](auto &&checkTypeIsTypedef, + const auto Ty) -> bool { + bool isTypedef = false; Hah. The knot-tying here

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

rjmccall added a comment. Alright, no worries. It was reasonable to ask if this was something we should fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108618/new/ https://reviews.llvm.org/D108618 _

[PATCH] D108792: [M68k] Update pointer data layout

glaubitz added a comment. @ricky26 Could you also get this fix backported in the LLVM fork of Rust? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108792/new/ https://reviews.llvm.org/D108792 ___ cfe-comm

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, xazax.hun. Herald added subscribers: martong, mgehre, rnkovacs. NoQ requested review of this revision. Herald added a project: clang-tools-extra. Low-level code may occasionally deal with direct access by concrete a

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

whisperity added a comment. I'm a bit confused about this, but it has been a while since I read this patch. Am I right to think that the code in the patch and the original submission (the patch summary) diverged since the review started? I do not see anything "removed" from the test files, only

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

whisperity added a comment. What happens for something like the following? Maybe it's also worth a test case? bool wait_analogue_pin(volatile int* address, int threshold) { while (*address < threshold) {} return true; } Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTIO

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

MyDeveloperDay added a comment. Possible bug https://bugs.llvm.org/show_bug.cgi?id=51640 Comment at: clang/include/clang/Format/Format.h:547 /// false: - /// enum - /// { + /// enum { /// A, Post commit Nit: @lunasorcery Rule of thumb in

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

gribozavr2 added a comment. > What happens for something like the following? Maybe it's also worth a test > case? WDYT about the test on line 614? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108808/new/ https://reviews.llvm.org/D108808

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

whisperity added a comment. In D108808#2968742 , @gribozavr2 wrote: > In D108808#2968721 , @whisperity > wrote: > >> What happens for something like the following? Maybe it's also worth a test >> case? > > WDYT

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, curdeius, HazardyKnusperkeks. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. LLVM 13.0.0-rc2 shows change of behaviour in enum and interface BraceWrapping (likely

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock; HazardyKnusperkeks wrote: > Should there be a test for the

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 369045. qiucf marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py clang/include/clang-c/Index

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5159 BT->getKind() == BuiltinType::LongDouble || +BT->getKind() == BuiltinType::Ibm128 || (getContext().getTargetInfo().hasFloat128Type() && rjmccall wrote: > qiuc

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

MyDeveloperDay updated this revision to Diff 369046. MyDeveloperDay added a comment. Remove the unnecessary comment changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108810/new/ https://reviews.llvm.org/D108810 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/F

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3803 + if (Line.startsWith(Keywords.kw_interface) && + Style.BraceWrapping.AfterClass) +return t

[PATCH] D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses.

NoQ added a comment. In D108808#2968721 , @whisperity wrote: > What happens for something like the following? Maybe it's also worth a test > case? > > bool wait_analogue_pin(volatile int* address, int threshold) { > while (*address < threshold) {}

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. >> I'll run this warning against ChromeOS and see if I spot any interesting >> results. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 ___ cfe-commits mailing lis

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added a comment. Thanks for the review. Comment at: clang/test/CodeGen/X86/avx512fp16-builtins.c:4223 + +// CFC ADD PH + LuoYuanke wrote: > MADD? They are marks used when adding tests. We can remove them now. Repository: rG LLVM Github Monorepo CHA

[clang] 6ad47e1 - [analyzer] Catch leaking stack addresses via stack variables

Author: Balazs Benics Date: 2021-08-27T11:31:16+02:00 New Revision: 6ad47e1c4fbfa8a752cb711acdf242fed3f16a68 URL: https://github.com/llvm/llvm-project/commit/6ad47e1c4fbfa8a752cb711acdf242fed3f16a68 DIFF: https://github.com/llvm/llvm-project/commit/6ad47e1c4fbfa8a752cb711acdf242fed3f16a68.diff

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ad47e1c4fbf: [analyzer] Catch leaking stack addresses via stack variables (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107078/new/

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

MyDeveloperDay updated this revision to Diff 369052. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Address Nit to reduce if nesting [--] Global test environment tear-down [==] 814 tests from 25 test suites ran. (41295 ms total) [ PASSED ]

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3803 + if (Line.startsWith(Keywords.kw_interface) && + Style.BraceWrapping.AfterClass) +return true; krasimir wrote: > nit: the `&& Style.BraceWrapping.Aft

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:666-677 +if (Style.PackConstructorInitializers == FormatStyle::PCIS_BinPack) { + bool OnCurrentLine = false; + IO.mapOptional("ConstructorInitializerAllOnOneLineOrOnePerLine", +

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:1189 GoogleStyle.DerivePointerAlignment = true; + GoogleStyle.PackConstructorInitializers = FormatStyle::PCIS_NextLine; GoogleStyle.IncludeStyle.IncludeCategories = {{"^", 2, 0, false},

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan updated this revision to Diff 369061. owenpan added a comment. Added backward compatibility for the default value `PCIS_NextLine` in Google and Chromium styles and aforementioned cleanups. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108752/new/ https://reviews.llvm.org/D10875

[clang] 8d3f112 - [M68k] Update pointer data layout

Author: Ricky Taylor Date: 2021-08-27T11:47:27+01:00 New Revision: 8d3f112f0cdbed2311aead86bcd72e763ad55255 URL: https://github.com/llvm/llvm-project/commit/8d3f112f0cdbed2311aead86bcd72e763ad55255 DIFF: https://github.com/llvm/llvm-project/commit/8d3f112f0cdbed2311aead86bcd72e763ad55255.diff

[PATCH] D108792: [M68k] Update pointer data layout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d3f112f0cdb: [M68k] Update pointer data layout (authored by ricky26). Changed prior to commit: https://reviews.llvm.org/D108792?vs=368995&id=3690

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

owenpan added a comment. In D108752#2967040 , @MyDeveloperDay wrote: > This looks good, I like to move towards one style, it was getting too > confusing. I agree! > Did you test this on a large code base at all? No. I don't think it's necessary (as t

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

ronlieb added inline comments. Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:111 +set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908 gfx1010 gfx1031) if (DEFINED LIBOMPTARGET_AMDGCN_GFXLIST) set(mcpus ${LIBOMPTARGET_AMDGCN_GFXLIST})

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield updated this revision to Diff 369067. JonChesterfield added a comment. - uint32 to unsigned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108708/new/ https://reviews.llvm.org/D108708 Files: clang/lib/Basic/Targets/AMDGPU.h llvm

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield updated this revision to Diff 369069. JonChesterfield added a comment. - add 1030 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108708/new/ https://reviews.llvm.org/D108708 Files: clang/lib/Basic/Targets/AMDGPU.h llvm/include/l

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield marked an inline comment as done. JonChesterfield added a subscriber: dhruvachak. JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:111 +set(mcpus gfx700 gfx701 gfx801 gfx803 gfx900 gfx902 gfx906 gfx908 gfx1010

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield added inline comments. Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:1921 DP("Max_Teams: %d\n", Max_Teams); -DP("RTLDeviceInfoTy::Warp_Size: %d\n", RTLDeviceInfoTy::Warp_Size); +DP("RTLDeviceInfoTy::Warp_Size: %d\n", WarpSize); DP("R

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. since amdgpu buildbots are red, at Jon's request, i applied patch on latest trunk build. applies clean, builds fine, no additional regressions in bheck-openmp compiler now accepts -march=gfx

[clang] 78f92c3 - [openmp][amdgpu] Initial gfx10 offloading implementation

Author: Jon Chesterfield Date: 2021-08-27T12:34:03+01:00 New Revision: 78f92c38101fd1f6788500b3362d3c9c28213bc0 URL: https://github.com/llvm/llvm-project/commit/78f92c38101fd1f6788500b3362d3c9c28213bc0 DIFF: https://github.com/llvm/llvm-project/commit/78f92c38101fd1f6788500b3362d3c9c28213bc0.di

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78f92c38101f: [openmp][amdgpu] Initial gfx10 offloading implementation (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3788-3790 +if (Line.First && Line.First->Next && +Line.First->isOneOf(Keywords.kw_internal, tok::kw_public, +tok::kw_private, tok::kw_protected) && -

[clang] 6808856 - [analyzer] MallocOverflow should consider comparisons only preceding malloc

Author: Balazs Benics Date: 2021-08-27T14:41:26+02:00 New Revision: 68088563fbadba92a153cbe03c1586033b19322d URL: https://github.com/llvm/llvm-project/commit/68088563fbadba92a153cbe03c1586033b19322d DIFF: https://github.com/llvm/llvm-project/commit/68088563fbadba92a153cbe03c1586033b19322d.diff

[PATCH] D107804: [analyzer] MallocOverflow should consider comparisons only preceding malloc

This revision was automatically updated to reflect the committed changes. Closed by commit rG68088563fbad: [analyzer] MallocOverflow should consider comparisons only preceding malloc (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LL

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Ok, well, the reason I proposed this patch in the first place was that I have been working on a `.clang-format` schema (https://json-schema.org/) :) and I spotted the inconsistency. I checked, and clang-format reports an error if we give a negative value to an optio

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 369081. FederAndInk added a comment. Use yaml type style for clang-format documentation (`String`, `Integer`, `List of Strings`, ...) instead of c++ types. Fix typo in clang/Format/Format.h Regenarate ClangFormatStyleOptions.rst Repository: rG LLVM

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. For now, I handle plural manually, but it can be changed, I also kept Unsigned, what are your thoughts? Thanks for being so kind and responsive, it's really great to work on that :) as it is my first contribution to clang. Repository: rG LLVM Github Monorepo CH

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM, thanks for adding that and fixing the spelling mistake, let the others have time to chip in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llv

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

MyDeveloperDay updated this revision to Diff 369082. MyDeveloperDay added a comment. Handle comments before the enum CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108810/new/ https://reviews.llvm.org/D108810 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTe

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CV

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

owenpan added a comment. LGTM. Comment at: clang/lib/Format/TokenAnnotator.cpp:3799 +if (Style.BraceWrapping.AfterEnum) { + if (Line.startsWith(tok::kw_enum) || + Line.startsWith(tok::kw_typedef, tok::kw_enum)) Nit: I think it would be a littl

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

martong added a comment. Nice work! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:361 + while (!SCtx->inTopFrame()) { +auto p = FramesModifying.insert(SCtx); +if (!p.second) Why don't we add the stack frame here to `FramesModifyingC

[PATCH] D107804: [analyzer] MallocOverflow should consider comparisons only preceding malloc

martong added a comment. Probably it is too late, but the title of this change is misleading. I think is should be either `MallocOverflow should consider comparisons AFTER malloc` or `MallocOverflow should NOT consider comparisons only preceding malloc`. Repository: rG LLVM Github Monorepo

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. In D108765#2969036 , @FederAndInk wrote: > For now, I handle plural manually, but it can be changed, I also kept > Unsigned, what are your thoughts? I think thats ok for now, did you try building the file with sphinx

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CVT,

[clang] 8a780a2 - [clang-format] Group options that pack constructor initializers

Author: owenca Date: 2021-08-27T06:27:46-07:00 New Revision: 8a780a2f18c590e27e51a2ab3cc81b481c42b42a URL: https://github.com/llvm/llvm-project/commit/8a780a2f18c590e27e51a2ab3cc81b481c42b42a DIFF: https://github.com/llvm/llvm-project/commit/8a780a2f18c590e27e51a2ab3cc81b481c42b42a.diff LOG: [

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a780a2f18c5: [clang-format] Group options that pack constructor initializers (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108752/new

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CV

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:675 + /// retrieved from a CallEnter is the *caller's* stack frame! The inlined + /// function's stack should be retrieved from \p CallExitBeginN. + virtual bo

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. > look at the html Done, thanks > I assume you don't have commit access, we'll need your name and email address Here it is: Ludovic Jozeau it should also be on my profile > but if you think you might like to work on some other things, it might be > worth get tin

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:802 +// TODO: Operator delete is hardly the only deallocator -- Can we reuse +// isFreeingCall() or something thats already here? +auto Deallocations = match( --

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CVT,

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

spatel added a reviewer: efriedma. spatel added a comment. I'm not familiar with this library, and I haven't looked at current state of how we enable/map optional libs in a while... We definitely want to avoid adding another target option/debug flag, and if we can avoid relying on a function par

[PATCH] D106191: [clang] Option control afn flag

lebedev.ri added a comment. FWIW i think this part is fine in principle. Not sure about errno. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 ___ cfe-commits m

[PATCH] D108818: [clang] Add a -canonical-prefixes option

thakis created this revision. thakis added reviewers: hans, rnk. Herald added a subscriber: dang. thakis requested review of this revision. In https://reviews.llvm.org/D47480 I complained that there's no positive form of this flag, so let's add one :) https://gcc.gnu.org/PR29931 also has a pendin

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

fanbo-meng created this revision. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Marking test as unsupported for the same reason as https://reviews.llvm.org/D105204 Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108819/new/ https://reviews.llvm.org/D108819 _

[PATCH] D104344: [modules] Track how headers are included by different modules.

jansvoboda11 added a comment. If my understanding is correct, this patch only changes how we track `HeaderFileInfo::{isImport,NumIncludes}` and makes sure to store the necessary info into AST files. Right? Can you explain how values of these members can prevent Clang from importing the header

[PATCH] D108822: [python bindings] Add missing cursor kind in Clang Python's bindings.

ColinChargy created this revision. ColinChargy added a reviewer: rsmith. ColinChargy added a project: clang. Herald added a subscriber: arphaman. ColinChargy requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Some of the values i

[PATCH] D104344: [modules] Track how headers are included by different modules.

jansvoboda11 added a comment. FYI, a clangd test is failing in CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, lei, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya, qcolombet. NeHuang requested review of this revision. This patch marks splat immediate instructions `XXSPLTIDP` and `XXSPLT

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. Yes, there are a couple of issues of implicit cast to be fixed. Current test is just a placeholder. I copied and pasted from the one for `update` clause and just replaced all `update`s with `compare`. I’m also working on that. Repository: rG LLVM Github Monore

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Ashimaru added a comment. In my company we are using a lot of standard checks and it becomes time consuming - this patch would be extremely useful to us and non of proposals montioned @alexfh seem to solve the issue. We would like to select which directories containing headers would be checked

[clang] 9d7a77c - [MCParser][z/OS] Mark test as unsupported for the z/OS Target

Author: Fanbo Meng Date: 2021-08-27T11:45:38-04:00 New Revision: 9d7a77c26d2f68e1c3b58b61d792d371bd3ed224 URL: https://github.com/llvm/llvm-project/commit/9d7a77c26d2f68e1c3b58b61d792d371bd3ed224 DIFF: https://github.com/llvm/llvm-project/commit/9d7a77c26d2f68e1c3b58b61d792d371bd3ed224.diff LO

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d7a77c26d2f: [MCParser][z/OS] Mark test as unsupported for the z/OS Target (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108819/ne

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 369112. ZarkoCA added a comment. Rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/aix32-co

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev created this revision. Herald added subscribers: hiraditya, inglorion. ABataev requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108826 Files: clang

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

lebedev.ri added subscribers: spatel, lebedev.ri. lebedev.ri added a comment. I think there is something really wrong with vectorzer passes in LTO pipelines. Can you say whether the problem you are observing is in ThinLTO, Full LTO, or both? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn created this revision. fhahn added reviewers: erichkeane, rjmccall, thegameg, anemet. fhahn requested review of this revision. Herald added a project: clang. At the moment, the various math builtins only accept the scalar types defined by libm. This patch extends __builtin_fminf to also acc

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn added a comment. > This brings Clang more in line with GCC, which already supports math builtins > with ext_vector_type arguments. This is unfortunately not correct. When I tried this with GCC the `ext_vector_type` attribute was dropped and it fell back to `float`. Repository: rG LLVM

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

erichkeane added a comment. I think I would want some level of examination/analysis as to whether we want to do this with all of the vector-types, instead of just the `ext_vector_type`. Comment at: clang/lib/Sema/SemaChecking.cpp:16544 + E, AA_P

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn updated this revision to Diff 369135. fhahn added a comment. Updated to remove stray comment. In D108832#2969512 , @erichkeane wrote: > I think I would want some level of examination/analysis as to whether we want > to do this with all of the vec

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn updated this revision to Diff 369136. fhahn marked 2 inline comments as done. fhahn added a comment. Use ExprError() instead of ExprResult(true). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108832/new/ https://reviews.llvm.org/D108832 File

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16544 + E, AA_Passing)) + return ExprResult(true); + erichkeane wrote: > Doing this as ExprResult(true) is absurdly jarring. Updated, thanks! =

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

erichkeane added a comment. Codewise I'm ok, but I don't feel comfortable making the direction decision. I'd like to see some level of 'state of things' on the vector types (like, under what conditions does GCC support this, and under what types??), but even then I'm not sure I'm the right one

[clang] fe177a1 - Fix assertion when passing function into inline asm's input operand

Author: Jason Liu Date: 2021-08-27T13:39:41-04:00 New Revision: fe177a1773e4f88dde1aa37d34a0d3f8cb582f14 URL: https://github.com/llvm/llvm-project/commit/fe177a1773e4f88dde1aa37d34a0d3f8cb582f14 DIFF: https://github.com/llvm/llvm-project/commit/fe177a1773e4f88dde1aa37d34a0d3f8cb582f14.diff LOG

[PATCH] D107941: Fix assertion when passing function into inline asm's input operand

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe177a1773e4: Fix assertion when passing function into inline asm's input operand (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Githu

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969471 , @lebedev.ri wrote: > I think there is something really wrong with vectorzer passes in LTO > pipelines. > Can you say whether the problem you are observing is in ThinLTO, Full LTO, or > both? I saw it in Fu

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra updated this revision to Diff 369140. tra edited the summary of this revision. tra added a comment. Added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 Files: clang/include/clang/Sema/S

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

lebedev.ri added a comment. In D108826#2969547 , @ABataev wrote: > In D108826#2969471 , @lebedev.ri > wrote: > >> I think there is something really wrong with vectorzer passes in LTO >> pipelines. >> Can you say

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#2968503 , @yaxunl wrote: > need a test for non-template static member function as kernel. also need > codegen tests. I've added more tests for different code paths leading to the kernel call. Interestingly enough, only t

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969594 , @lebedev.ri wrote: > In D108826#2969547 , @ABataev wrote: > >> In D108826#2969471 , @lebedev.ri >> wrote: >> >>> I think th

[clang] 2930c83 - [OpenMP][FIX] Allow declare variant to work with reference types

Author: Johannes Doerfert Date: 2021-08-27T13:12:14-05:00 New Revision: 2930c839a5877356db6966409f4f9f2cdbcf3a07 URL: https://github.com/llvm/llvm-project/commit/2930c839a5877356db6966409f4f9f2cdbcf3a07 DIFF: https://github.com/llvm/llvm-project/commit/2930c839a5877356db6966409f4f9f2cdbcf3a07.d

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

This revision was automatically updated to reflect the committed changes. Closed by commit rG2930c839a587: [OpenMP][FIX] Allow declare variant to work with reference types (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/

[clang] ed367b9 - [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

Author: mydeveloperday Date: 2021-08-27T19:13:53+01:00 New Revision: ed367b9dff10ee1df9ac1984eb2ad7544da7ab06 URL: https://github.com/llvm/llvm-project/commit/ed367b9dff10ee1df9ac1984eb2ad7544da7ab06 DIFF: https://github.com/llvm/llvm-project/commit/ed367b9dff10ee1df9ac1984eb2ad7544da7ab06.diff

[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed367b9dff10: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C#… (authored by MyDeveloperDay). Repository: rG LLVM Git

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

spatel added a comment. In D108826#2969604 , @ABataev wrote: > In D108826#2969594 , @lebedev.ri > wrote: > >> Aha, so full lto. That is consistent with the phase ordering dilemma @spatel >> discovered: D102002 <

[PATCH] D108826: [SLP][LTO][WIP]Allow full SLP in LTO only at link time.

ABataev added a comment. In D108826#2969677 , @spatel wrote: > In D108826#2969604 , @ABataev wrote: > >> In D108826#2969594 , @lebedev.ri >> wrote: >> >>> Aha, so full lt

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369157. stevewan added a comment. Make TypeInfo carry more information about "aligned" attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/inclu

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 369158. modimo added a comment. Check for CachedAttributes count in map rather than value so conservative results are not re-calculated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.l

  1   2   >