[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368744. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Add `-march=x86-64` that i forgot :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D10866

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin updated this revision to Diff 368746. cor3ntin added a comment. Fix comments following Aaron's feedback, remove braces deemed unecessary by the guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin marked 4 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexId

[PATCH] D108735: [clang][Emscripten] Define __unix family of macros

sbc100 created this revision. Herald added subscribers: wingo, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This will allow us to remove these from the downstream driver: https://github.com/emscripten-core/emscrip

[PATCH] D108735: [clang][Emscripten] Define __unix family of macros

sbc100 added a comment. Landing this will allow us to land https://github.com/emscripten-core/emscripten/pull/14953 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108735/new/ https://reviews.llvm.org/D108735 ___

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

amyk accepted this revision as: amyk. amyk added a comment. We wanted `vec_clr_first` to translate to vclrrb for LE, and to vclrlb for BE, and the opposite mapping for `vec_clr_last`, so I think this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri added a comment. Thanks everyone! I don't expect that there will be any further feedback, so i plan on landing this tomorrow, unless there is further feedback before then. Comment at: llvm/test/CodeGen/MIR/X86/load-with-1gb-alignment.mir:1 +# RUN: llc -run-pass=none

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:422-423 -ExprResult ArgExpr( -Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); +ExprResult ArgExpr(Actions.CorrectDelayedTyposInExpr( +ParseAttribut

[clang] c05d30e - [clang][Emscripten] Define __unix family of macros

Author: Sam Clegg Date: 2021-08-25T19:24:47-04:00 New Revision: c05d30e444a1208a8a872002d1146b5cf55e370a URL: https://github.com/llvm/llvm-project/commit/c05d30e444a1208a8a872002d1146b5cf55e370a DIFF: https://github.com/llvm/llvm-project/commit/c05d30e444a1208a8a872002d1146b5cf55e370a.diff LOG

[PATCH] D108735: [clang][Emscripten] Define __unix family of macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc05d30e444a1: [clang][Emscripten] Define __unix family of macros (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin created this revision. Herald added a subscriber: dexonsmith. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to The Unicode standard, line feed and vertical tab should be considered line breaks. See notably htt

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham updated this revision to Diff 368781. bnbarham added a comment. Ended up just using DiagnosticError and reading the args from PartialDiagnostic. Still not really happy with this, but I think the alternative of allowing multiple in-flight diagnostics should be a separate PR regardless (

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1;

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song added a comment. In D106618#2965546 , @dblaikie wrote: > The clang side might benefit from a test with a function declaration, a call > to that function, but no definition of it - with optimizations enabled, clang > should emit the DISubpr

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song updated this revision to Diff 368789. yonghong-song added a comment. - add annotations to DISubprogram generated for extern functions called in the current cu and add a test for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1066

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1; ---

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

kito-cheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:106 + assert(RVVBitsMin % 128 == 0 && + "RVV requires vector length in multiples of 128!"); + assert(RVVBitsMax % 128 == 0 && RISC-V require VLEN in power of 2, m

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. Then I'm OK with this change. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset Imp

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Allowing multiple PartialDiagnostic to be in-flight/delayed is a nice goal but it's not clear if it's worth it. Also I'm not sure it is worth investing into making delayed diagnostic easier

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368793. tianqing added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://reviews.llvm.org/D105462 Files: clang/docs/ClangCommandLineReference.rst clang/

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:158 + // Enable CRC32 if SSE4.2 is enabled and CRC32 is not explicitly set. + I = Features.find("sse4.2"); craig.topper wrote: > Why doesn't

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:160 + // enabled. + I = Features.find("sse4.2"); + if (I != Features.end() && I->getValue() && I guess I don't understand why this is coded differently than mmx, popcnt, and xsave

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

dblaikie added inline comments. Comment at: clang/test/CodeGen/attr-btf_tag-disubprogram-2.c:5-14 +#define __tag2 __attribute__((btf_tag("tag2"))) + +struct t1 { + int a; +}; + +extern int __tag1 __tag2 foo(struct t1 *); Any particular reason this needs to be sp

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368795. tianqing marked an inline comment as done. tianqing added a comment. Use existing code in X86.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://reviews.llvm.org/D105462 Files: cl

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:160 + // enabled. + I = Features.find("sse4.2"); + if (I != Features.end() && I->getValue() && craig.topper wrote: > I guess I don't understa

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. @MaskRay Any more questions for this line change? Thanks : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 ___ cfe-commits mailing lis

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham updated this revision to Diff 368798. bnbarham marked 2 inline comments as done. bnbarham added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Updated error handling and added the clang-format `#include` changes in. Repository: rG LLVM Github Monor

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); +

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song added inline comments. Comment at: clang/test/CodeGen/attr-btf_tag-disubprogram-2.c:5-14 +#define __tag2 __attribute__((btf_tag("tag2"))) + +struct t1 { + int a; +}; + +extern int __tag1 __tag2 foo(struct t1 *); dblaikie wrote: > Any particular rea

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song updated this revision to Diff 368805. yonghong-song added a comment. - rename test file names properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106618/new/ https://reviews.llvm.org/D106618 Files: clang/lib/CodeGen/CGDebugInfo.

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Eh, sure, don't mind about the test either way (the other test cases are optimization agnostic, I think - so they could all be lumped in together - there might also be a flag to turn on ca

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); + } MaskRay wrote: > Add `if (OSLibDir != "lib")` thumbs up. Repos

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song added a comment. We have llvm::DINode::DIFlags CGDebugInfo::getCallSiteRelatedAttrs() const { // Call site-related attributes are only useful in optimized programs, and // when there's a possibility of debugging backtraces. if (!CGM.getLangOpts().Optimize || DebugKind

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki added a comment. Thanks for the review. In an upcoming HIPSPV patch there will be a test that depends on this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D108367 ___

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin updated this revision to Diff 368812. sunlin added a comment. Update for do not add duplicate path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 Files: clang/lib/Driver/ToolChains/Linux.cpp I

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin marked an inline comment as done. sunlin added a comment. Hi @MaskRay , The patch is updated as your comment. Please review again. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +if (OSLibDir != "lib") { + addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); drop

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @rsmith ping again. Could you help take a look at this patch? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 ___ cfe-com

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki planned changes to this revision. linjamaki added a comment. Thanks. I will make a patch for adding spirv triples and new target info and update this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D10

[clang] 6da811f - [clang][deps] Reset non-modular language and preprocessor options

Author: Jan Svoboda Date: 2021-08-26T08:43:21+02:00 New Revision: 6da811fd5c7158eecaf25f0e417131f2e7dfb35f URL: https://github.com/llvm/llvm-project/commit/6da811fd5c7158eecaf25f0e417131f2e7dfb35f DIFF: https://github.com/llvm/llvm-project/commit/6da811fd5c7158eecaf25f0e417131f2e7dfb35f.diff L

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6da811fd5c71: [clang][deps] Reset non-modular language and preprocessor options (authored by jansvoboda11). Changed prior to commit: https://revie

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd280a76908e8: [Driver][Linux] Fix regression when -DLIBCXX_LIBDIR_SUFFIX=64 (authored by Lin Sun , committed by MaskRay). Changed

[clang] d280a76 - [Driver][Linux] Fix regression when -DLIBCXX_LIBDIR_SUFFIX=64

Author: Lin Sun Date: 2021-08-25T23:50:17-07:00 New Revision: d280a76908e841da9e956a113d219e35247272bf URL: https://github.com/llvm/llvm-project/commit/d280a76908e841da9e956a113d219e35247272bf DIFF: https://github.com/llvm/llvm-project/commit/d280a76908e841da9e956a113d219e35247272bf.diff LOG:

<    1   2