[clang] 5fc4828 - [clang] Don't generate warn-stack-size when the warning is ignored

Author: Yi Kong Date: 2021-08-25T14:58:45+08:00 New Revision: 5fc4828aa6c6df03bd98b1f066e85655383d0cce URL: https://github.com/llvm/llvm-project/commit/5fc4828aa6c6df03bd98b1f066e85655383d0cce DIFF: https://github.com/llvm/llvm-project/commit/5fc4828aa6c6df03bd98b1f066e85655383d0cce.diff LOG:

[PATCH] D108686: [clang] Don't generate warn-stack-size when the warning is ignored

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc4828aa6c6: [clang] Don't generate warn-stack-size when the warning is ignored (authored by kongyi). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: htt

[clang] ea08c4c - [CUDA] Fix static device variables with -fgpu-rdc

Author: Jonas Hahnfeld Date: 2021-08-25T09:31:22+02:00 New Revision: ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83 URL: https://github.com/llvm/llvm-project/commit/ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83 DIFF: https://github.com/llvm/llvm-project/commit/ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83.diff

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGea08c4cd1c08: [CUDA] Fix static device variables with -fgpu-rdc (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108456/new/ https://re

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

sberg added a comment. In D106924#2919406 , @sberg wrote: > Bisecting shows that this commit causes > > $ echo foo | clang -E -P - > > foo > > to emit a leading newline now. > > That breaks e.g. LibreOffice's `configure`, which uses `echo > __clan

[clang] 83c633e - [clang][deps] Collect precompiled deps from submodules too

Author: Jan Svoboda Date: 2021-08-25T10:35:34+02:00 New Revision: 83c633ea1a5b015cf25056aa1855842cd92c077d URL: https://github.com/llvm/llvm-project/commit/83c633ea1a5b015cf25056aa1855842cd92c077d DIFF: https://github.com/llvm/llvm-project/commit/83c633ea1a5b015cf25056aa1855842cd92c077d.diff L

[PATCH] D108540: [clang][deps] Collect precompiled deps from submodules too

This revision was automatically updated to reflect the committed changes. Closed by commit rG83c633ea1a5b: [clang][deps] Collect precompiled deps from submodules too (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D108540?vs=368064&id=368575#toc Repository: rG L

[clang] 3b8f536 - [clang][deps] Use top-level modules as precompiled dependencies

Author: Jan Svoboda Date: 2021-08-25T10:51:34+02:00 New Revision: 3b8f536fec2f7dfd5dc69c6516c20c5b48b38409 URL: https://github.com/llvm/llvm-project/commit/3b8f536fec2f7dfd5dc69c6516c20c5b48b38409 DIFF: https://github.com/llvm/llvm-project/commit/3b8f536fec2f7dfd5dc69c6516c20c5b48b38409.diff L

[PATCH] D108647: [clang][deps] Use top-level modules as precompiled dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b8f536fec2f: [clang][deps] Use top-level modules as precompiled dependencies (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D108647?vs=368394&id=368580#toc Repository:

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:268 +// omitted from the version string. E.g., rv32i2p0, rv32i2, rv32i2p1. +static Error getExtensionVersion(StringRef MArch, StringRef Ext, StringRef In, + unsigned &Major,

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368583. lebedev.ri added a comment. In D108661#2963726 , @arsenm wrote: > Could use some MIR tests to make sure that parser doesn't explode Added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b5088cb - [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

Author: Jan Svoboda Date: 2021-08-25T11:14:16+02:00 New Revision: b5088cb408222eba4611e6121293166904ca48e6 URL: https://github.com/llvm/llvm-project/commit/b5088cb408222eba4611e6121293166904ca48e6 DIFF: https://github.com/llvm/llvm-project/commit/b5088cb408222eba4611e6121293166904ca48e6.diff L

[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5088cb40822: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments (authored by jansvoboda11). Repository: rG LLVM Github Mon

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 368589. tianqing added a comment. - Update behavior of -msse4.2 option. - Add test for -msse4.2 and -mno-crc32. - Fix some format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105462/new/ https://review

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing marked 2 inline comments as done. tianqing added inline comments. Comment at: clang/lib/Headers/crc32intrin.h:31 +static __inline__ unsigned int __DEFAULT_FN_ATTRS +_mm_crc32_u8(unsigned int __C, unsigned char __D) +{ pengfei wrote: > ditto. Not sure abo

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Basic/Targets/SPIR.h:146 +// See comment on the SPIRDefIsGenMap table. +bool IsHIPSPV = Opts.HIP && Opts.CUDAIsDevice; // FIXME: SYCL s

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in I am s

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Do you think we can test this somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D

[PATCH] D108461: [OpenCL] Supports optional generic address space in C++ for OpenCL 2021

Anastasia added a comment. In D108461#2960030 , @Topotuna wrote: > `__opencl_c_generic_address_space` should not have been chosen as the first > feature to be addressed out of all OpenCL 3.0 optional core features. This is > because `__opencl_c_device_e

[PATCH] D108392: [OpenCL] Fix parsing of opencl-c.h in CL 3.0 with device-scope atomics enabled

Anastasia added a subscriber: azabaznov. Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_device,

[PATCH] D108692: [clang-format] Support TypeScript override keyword

jankuehle created this revision. jankuehle requested review of this revision. Herald added a project: clang. TypeScript 4.3 added a new "override" keyword for class members. This lets clang-format know about it, so it can format code using it properly. Repository: rG LLVM Github Monorepo http

[PATCH] D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, yaxunl. Herald added a reviewer: aaron.ballman. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change defines

[PATCH] D108692: [clang-format] Support TypeScript override keyword

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Let me know if you would like me to commit this for you in case you don't have commit rights for LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#2964190 , @rjmccall wrote: > I agree with James; I know you've reached out to the Itanium ABI group about > mangling, but ABI involvement needs to mean also reaching out and getting > psABI agreement about repre

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. In D106343#2892946 , @Anastasia wrote: > The extension spec seems to also mention `atomic_half`. Are planning to add > it too? Hi, Anastasia. I also have some work to translate these atomic builtins on SPIRV currently, so I'd

[PATCH] D108692: [clang-format] Support TypeScript override keyword

jankuehle added a comment. Thank you for the amazingly quick review, krasimir. I don't have commit access. So it would be great, if you could commit this for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108692/new/ https://reviews.llvm.org/D1

[clang] e708808 - [clang-format] Support TypeScript override keyword

Author: Jan Kuehle Date: 2021-08-25T14:11:50+02:00 New Revision: e708808f875f58344ecaad66d9e6e167ca7ac90a URL: https://github.com/llvm/llvm-project/commit/e708808f875f58344ecaad66d9e6e167ca7ac90a DIFF: https://github.com/llvm/llvm-project/commit/e708808f875f58344ecaad66d9e6e167ca7ac90a.diff LO

[PATCH] D108692: [clang-format] Support TypeScript override keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rGe708808f875f: [clang-format] Support TypeScript override keyword (authored by jankuehle, committed by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus created this revision. Szelethus added reviewers: NoQ, martong, balazske, vsavchenko, steakhal, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun,

[PATCH] D108692: [clang-format] Support TypeScript override keyword

MyDeveloperDay added a comment. Thanks for adding this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108692/new/ https://reviews.llvm.org/D108692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. I also added new dump methods -- I had a trouble before realizing that `CallEnter`'s stack frame is actually the *caller's*, not the *callee's* stack frame. Changes in `findModifyingFrames` aim to make the function more readable, and make sure that the correct stack f

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Oh, I find why the CI still fails. Since the compiler used to compile libcxx in the CI doesn't contain the change in this patch! So it would still lookup coroutine components in std::experimental namespace. So here are the failures.

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

aaron.ballman added a reviewer: rsmith. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:8646 Expr *Cur = CurInit.get(); - Expr *BaseExpr = new (S.Context) - OpaqueValueExpr(Cur->getExprLoc(), Cur->getType(), -

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

lei requested changes to this revision. lei added a comment. This revision now requires changes to proceed. I think there is something wrong with this diff cause there is no context available for `PPCInstrInfo.cpp`. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1548 +

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#2964740 , @aaron.ballman wrote: > I've already reached out to the psABI maintainers and have started those > discussions before ever considering the mangling questions: > https://gitlab.com/x86-psABIs/x86-64-AB

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dgoldman added a comment. Does this change the behavior of TypePrinter or DeclPrinter - not sure if there are existing tests for those with ObjC code? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___

[clang] 360ced3 - [analyzer] Ignore IncompleteArrayTypes in getStaticSize() for FAMs

Author: Balazs Benics Date: 2021-08-25T16:12:17+02:00 New Revision: 360ced3b8fd2cfb9f2a26deb739e6c381e98b9a5 URL: https://github.com/llvm/llvm-project/commit/360ced3b8fd2cfb9f2a26deb739e6c381e98b9a5 DIFF: https://github.com/llvm/llvm-project/commit/360ced3b8fd2cfb9f2a26deb739e6c381e98b9a5.diff

[PATCH] D105184: [analyzer] Ignore IncompleteArrayTypes in getStaticSize() for FAMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG360ced3b8fd2: [analyzer] Ignore IncompleteArrayTypes in getStaticSize() for FAMs (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

NeHuang created this revision. NeHuang added reviewers: amyk, lei, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, nemanjai. NeHuang requested review of this revision. Herald added a project: clang. This patch renames the vector clear left/right builtin

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. hjl.tools wrote: > craig.topper

[clang] df1f4e0 - Revert "[analyzer] Ignore IncompleteArrayTypes in getStaticSize() for FAMs"

Author: Balazs Benics Date: 2021-08-25T16:43:25+02:00 New Revision: df1f4e0cc6ec9a734aae41ffd48ee8b2007fcabb URL: https://github.com/llvm/llvm-project/commit/df1f4e0cc6ec9a734aae41ffd48ee8b2007fcabb DIFF: https://github.com/llvm/llvm-project/commit/df1f4e0cc6ec9a734aae41ffd48ee8b2007fcabb.diff

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1; --

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2958633 , @jyknight wrote: > In D106577#2944086 , @aaron.ballman > wrote: > >> @jyknight, are you on the WG14 reflectors btw? Would you like to carry on >> with this dis

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1;

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modifies OpenCL 3.0 optional core feature macro definitions so that the

[clang] 2e192ab - [CodeExtractor] Preserve topological order for the return blocks.

Author: Vyacheslav Zakharin Date: 2021-08-25T08:09:01-07:00 New Revision: 2e192ab1f457918484d3f41b9d2271a9dd8a9de3 URL: https://github.com/llvm/llvm-project/commit/2e192ab1f457918484d3f41b9d2271a9dd8a9de3 DIFF: https://github.com/llvm/llvm-project/commit/2e192ab1f457918484d3f41b9d2271a9dd8a9de3

[PATCH] D108673: [CodeExtractor] Preserve topological order for the return blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e192ab1f457: [CodeExtractor] Preserve topological order for the return blocks. (authored by vzakhari). Herald added a project: clang. Herald added a

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. In D107775#2964937 , @dgoldman wrote: > Does this change the behavior of TypePrinter or DeclPrinter - not sure if > there are existing tests for those with ObjC code? I put a case for it in the declprinter so it is handled

[clang] e5646b9 - Revert "Revert "[analyzer] Ignore IncompleteArrayTypes in getStaticSize() for FAMs""

Author: Balazs Benics Date: 2021-08-25T17:19:06+02:00 New Revision: e5646b9254e0150e7897bd2658fa0b19eef39070 URL: https://github.com/llvm/llvm-project/commit/e5646b9254e0150e7897bd2658fa0b19eef39070 DIFF: https://github.com/llvm/llvm-project/commit/e5646b9254e0150e7897bd2658fa0b19eef39070.diff

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. pengfei wrote: > hjl.tools wrot

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368650. kstoimenov added a comment. Updated from the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td l

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG832aae738bec: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM Github

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:531 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3; constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1; ---

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:158 + // Enable CRC32 if SSE4.2 is enabled and CRC32 is not explicitly set. + I = Features.find("sse4.2"); Why doesn't this say "not explicitly disabled" like the others above?

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368663. kstoimenov added a comment. Upload after submitting the main patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: llvm/lib/Transforms/Instrument

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield created this revision. JonChesterfield added reviewers: dpalermo, jdoerfert, tianshilei1992, ronlieb, ye-luo, grokos. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision.

[PATCH] D108708: [openmp][amdgpu] Initial gfx10 offloading implementation

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 + +template constexpr const GV &getAMDGPUGridValues() { + static_assert(wavesize == 32 || wavesize == 64, ""); Want to resolve this at compile time for the

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a number of language and preprocessor options that are reset in the `

[clang] cc4bfd7 - [Sema][ObjC] Allow conversions between pointers to ObjC pointers and

Author: Akira Hatanaka Date: 2021-08-25T10:22:29-07:00 New Revision: cc4bfd7f59d5a0024ada2a5c2a6f46d53290882b URL: https://github.com/llvm/llvm-project/commit/cc4bfd7f59d5a0024ada2a5c2a6f46d53290882b DIFF: https://github.com/llvm/llvm-project/commit/cc4bfd7f59d5a0024ada2a5c2a6f46d53290882b.diff

[PATCH] D107021: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and pointers to structs

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc4bfd7f59d5: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1070

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

schittir created this revision. schittir added reviewers: aaron.ballman, erichkeane. schittir added a project: clang. schittir requested review of this revision. Herald added a subscriber: cfe-commits. Avoid nullptr dereferencing of 'Constraint'; NFC Klocwork static code analysis exposed this bug

[clang] 846e562 - [Clang] add support for error+warning fn attrs

Author: Nick Desaulniers Date: 2021-08-25T10:34:18-07:00 New Revision: 846e562dcc6a9a611d844dc0d123da95629a0567 URL: https://github.com/llvm/llvm-project/commit/846e562dcc6a9a611d844dc0d123da95629a0567 DIFF: https://github.com/llvm/llvm-project/commit/846e562dcc6a9a611d844dc0d123da95629a0567.di

[PATCH] D106030: [Clang] add support for error+warning fn attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG846e562dcc6a: [Clang] add support for error+warning fn attrs (authored by nickdesaulniers). Changed prior to commit: https://reviews.llvm.org/D106030?vs=366717&id=368678#toc Repository: rG LLVM Githu

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! There is no way for this to be null because `emitRethrow()` is what should be called in that case. I'll land this on your behalf sometime shortly (perhaps as late as tomorr

[clang] 66e37c9 - [Preprocessor] Elide empty line(s) at start of file.

Author: Michael Kruse Date: 2021-08-25T12:48:59-05:00 New Revision: 66e37c99ef5d7da1b17b3bbaa4ef05b633a473f7 URL: https://github.com/llvm/llvm-project/commit/66e37c99ef5d7da1b17b3bbaa4ef05b633a473f7 DIFF: https://github.com/llvm/llvm-project/commit/66e37c99ef5d7da1b17b3bbaa4ef05b633a473f7.diff

[clang] 666906a - [test] Fix indention. NFC.

Author: Michael Kruse Date: 2021-08-25T12:48:59-05:00 New Revision: 666906a8032709e59ca6c9fb7b7a5e05cafbd3bf URL: https://github.com/llvm/llvm-project/commit/666906a8032709e59ca6c9fb7b7a5e05cafbd3bf DIFF: https://github.com/llvm/llvm-project/commit/666906a8032709e59ca6c9fb7b7a5e05cafbd3bf.diff

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template:4 +"directory": "DIR", +"command": "clang -fsyntax-only DIR/tu.c -fmo

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. I'm getting test failures for the newly added llvm/test/CodeGen/X86/attr-dontcall.ll, thought there's not much info other than > Exit Code: 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://revie

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff updated this revision to Diff 368687. sepavloff added a comment. Updated patch - Moved tests into header files. It should facilitate writing tests for various modes (strict exceptions, fast math etc), - Added Makefile, - Enhanced diagnostics if test fails, - Avoid C++, it makes easier

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

dblaikie added a comment. The clang side might benefit from a test with a function declaration, a call to that function, but no definition of it - with optimizations enabled, clang should emit the DISubprogram for that function for the purpose of call site DWARF, I think? (or maybe that behavio

[PATCH] D108712: Avoid nullptr dereferencing of 'SubExpr'; NFC

schittir added a comment. In D108712#2965433 , @aaron.ballman wrote: > LGTM! There is no way for this to be null because `emitRethrow()` is what > should be called in that case. > > I'll land this on your behalf sometime shortly (perhaps as late as tomo

[clang] ea1c01d - PR51105: look through ConstantExpr when looking for a braced string literal initialization.

Author: Richard Smith Date: 2021-08-25T11:36:11-07:00 New Revision: ea1c01dde03b45e0b33d3883147d3b4fb489978c URL: https://github.com/llvm/llvm-project/commit/ea1c01dde03b45e0b33d3883147d3b4fb489978c DIFF: https://github.com/llvm/llvm-project/commit/ea1c01dde03b45e0b33d3883147d3b4fb489978c.diff

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. Fixup: https://reviews.llvm.org/D108718 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 ___ cfe-commits mailing list cfe-commit

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

rnk created this revision. rnk added reviewers: zero9178, mibintc, erichkeane. rnk requested review of this revision. Herald added a project: clang. This change would treat the token `or` in system headers as an identifier, and elsewhere as an operator. As reported in llvm.org/pr42427, many users

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, minor comments below. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2639-2643 +if (UnrolledCLI) { + OMPLoopNestStack.push_back(UnrolledCLI); +} else {

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems reasonable to me. The changes for `/permissive` and `/permissive-` I think are a better way about this, and now that there is a trivial workaround (`QUERY_H_RESTRICTION_PER

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

zero9178 accepted this revision. zero9178 added a comment. Thanks a lot for the patch :) Wanted this bit of code to be removed for quite some time. > Since D103773 , clang-cl's default mode > completely disables C++ operator > names. That means that query.h com

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368702. stevewan added a comment. Herald added a subscriber: jfb. Add recursive check for typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/

[PATCH] D108308: [WIP] Cleanup identifier parsing.

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. In general, I'm in favor of these changes. They help identify (pun *totally* intended) where we're improperly expecting ASCII identifiers in places, which can hopefully be addressed i

[PATCH] D108308: [WIP] Cleanup identifier parsing.

cor3ntin added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:702 // Helper functions to lex the remainder of a token of the specific type. - bool LexIdentifier (Token &Result, const char *CurPtr); + bool LexIdentifierContinue(Token &Result, const char

[PATCH] D108308: [WIP] Cleanup identifier parsing.

aaron.ballman added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:701 // Helper functions to lex the remainder of a token of the specific type. + bool LexIdentifierContinue(Token &Result, const char *CurPtr); Something like this then? Repos

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Re-requesting review, since the test does cover the changes to `ModuleDepCollector.cpp`. Comment at: clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template:4 +"directory": "DIR", +"co

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: > stevew

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: jfb. aaron.ballman added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:95-96 + case '?': + case 'n': + case 't': +return true; cor3ntin wrote: > aaron.ballman wrote:

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template:4 +"directory": "DIR", +"command": "clang -fsyntax-only DIR/tu.c -fmodules -fimplicit-module-maps -fmodules-cache-path=DIR/cache -include DIR/header.h -o DIR/tu

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

rnk added a comment. In D108720#2965642 , @zero9178 wrote: > Just a heads up, the patch added `/permissive` and `/permissive-`, but made > neither the default as to not be a breaking change. That means that clang-cl > still parses operator keywords and

[PATCH] D108710: [clang][deps] Reset non-modular language and preprocessor options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM with after adding a comment to the testcase. Thanks for explaining! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108710/new/ https

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

arsenm added inline comments. Comment at: llvm/test/CodeGen/X86/load-with-1gb-alignment.mir:1 +# RUN: llc -run-pass machine-cp -o - %s | FileCheck %s + Should use -run-pass=none, and go in test/CodeGen/MIR/X86 Comment at: llvm/test/CodeGen/X86/

[clang] 9dc92bb - [OpenCL][NFC] Fix code example in __remove_address_space documentation.

Author: Justas Janickas Date: 2021-08-25T21:24:32+01:00 New Revision: 9dc92bba6c742216096e33402a1a8aebf5ca48b7 URL: https://github.com/llvm/llvm-project/commit/9dc92bba6c742216096e33402a1a8aebf5ca48b7 DIFF: https://github.com/llvm/llvm-project/commit/9dc92bba6c742216096e33402a1a8aebf5ca48b7.dif

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368716. stevewan marked an inline comment as done. stevewan added a comment. Avoid unannotated fall-through between cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 5 PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368719. lebedev.ri added a comment. @arsenm i do not understand how i can avoid having IR there, but addressed other nits. thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#2964740 , @aaron.ballman wrote: > In D108643#2964190 , @rjmccall > wrote: > >> I agree with James; I know you've reached out to the Itanium ABI group about >> mangling, but

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri updated this revision to Diff 368722. lebedev.ri added a comment. Address rest of nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D108661 Files: clang/include/clang/Sema/Sema.h clang/test/CXX

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

jdoerfert added a comment. Seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D108661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] db3d029 - Effectively revert 33c3d8a916c / D33782

Author: Reid Kleckner Date: 2021-08-25T14:41:26-07:00 New Revision: db3d029fbe09925ea42a3279b1abb244fa547cff URL: https://github.com/llvm/llvm-project/commit/db3d029fbe09925ea42a3279b1abb244fa547cff DIFF: https://github.com/llvm/llvm-project/commit/db3d029fbe09925ea42a3279b1abb244fa547cff.diff

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108702/new/ https://reviews.llvm.org/D108702 _

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3d029fbe09: Effectively revert 33c3d8a916c / D33782 (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D108720?vs=368693&id=36

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

lebedev.ri added a comment. @arsenm are you happy with the test coverage here? In D108661#2963519 , @craig.topper wrote: > Wild speculation. This may be a historical artifact of LoadInst and StoreInst > having their getAlignment() function written like

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

arsenm added inline comments. Comment at: llvm/test/CodeGen/MIR/X86/load-with-1gb-alignment.mir:1 +# RUN: llc -run-pass=none -o - %s | FileCheck %s + Needs to add -march/-mtriple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

  1   2   >