Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Apologies. As explained in another thread, this was a mistake of mine as I reverted 2 CLs instead of 1 (mine). This was resolved with the original author. My own CL ended up breaking some 32-bit builders. On Mon, Aug 16, 2021 at 1:22 PM David Blaikie wrote: > Please include in the commit message

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

Ah, thanks for the details! On Mon, Aug 16, 2021 at 1:26 PM Kostya Kortchinsky wrote: > Apologies. > As explained in another thread, this was a mistake of mine as I reverted 2 > CLs instead of 1 (mine). > This was resolved with the original author. > My own CL ended up breaking some 32-bit build

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added a comment. The order in X86Parser.def is determined by how bits are allocated in to feature vector in libgcc. They're not in any priority order that I know of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://re

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance updated this revision to Diff 366733. nathanchance marked an inline comment as not done. nathanchance edited the summary of this revision. nathanchance added a comment. - Update commit message (forgot to use `arc diff --edit --verbatim`) [David] Repository: rG LLVM Github Monorepo

[clang] f22ba51 - [Remarks] Emit optimization remarks for atomics generating CAS loop

Author: Anshil Gandhi Date: 2021-08-16T14:56:01-06:00 New Revision: f22ba51873509b93732015176b778465f40c6db5 URL: https://github.com/llvm/llvm-project/commit/f22ba51873509b93732015176b778465f40c6db5 DIFF: https://github.com/llvm/llvm-project/commit/f22ba51873509b93732015176b778465f40c6db5.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

cjdb added a comment. @JonasToth, @aaron.ballman suspects that there's enough overlap between this patch and D107873 to consider merging the two efforts. I'm happy to collaborate, but we should probably check that our goals are aligned. Are you active on the L

[PATCH] D108083: add sanitizer support to hexagon

vitalybuka added a comment. Can you cut this into separate peaces, at least patch per sanitizer for "asan lsan ubsan scudo scudo_standalone cfi safestack"? Some common peaces could be probably extracted as well. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_

[PATCH] D108083: add sanitizer support to hexagon

vitalybuka added a comment. Do we have public bot for hexagon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note {{

[PATCH] D98061: [InstrProfiling] Generate runtime hook for Fuchsia

kile added a comment. Apologies, reporting on the incorrect revision :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98061/new/ https://reviews.llvm.org/D98061 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947907 , @vitalybuka wrote: > Can you cut this into separate peaces, at least patch per sanitizer for "asan > lsan ubsan scudo scudo_standalone cfi safestack"? Sure, that's no problem. While I'm breaking it up, us the

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947914 , @vitalybuka wrote: > Do we have public bot for hexagon? I think we have one intended to for checking hexagon-unknown-elf and perhaps not one for hexagon-unknown-linux-musl. I believe that only the Linux targe

[PATCH] D107296: Treat inttypes.h as a built-in header

dexonsmith resigned from this revision. dexonsmith added reviewers: bruno, vsapsai. dexonsmith added subscribers: bruno, vsapsai. dexonsmith added a comment. @bruno or @vsapsai, any chance one of you knows whether this is correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 366760. a.elovikov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Another version. My main goal here is to gradually move more stuff from clang/ to llvm/ so I'm open to other suggestions in doing so. Repository:

[clang] d8a08fa - Clean up test for -f{, no-}implicit-modules-uses-lock

Author: Duncan P. N. Exon Smith Date: 2021-08-16T16:23:04-07:00 New Revision: d8a08fae0af9aa09c108b3e7c60f192249dd2098 URL: https://github.com/llvm/llvm-project/commit/d8a08fae0af9aa09c108b3e7c60f192249dd2098 DIFF: https://github.com/llvm/llvm-project/commit/d8a08fae0af9aa09c108b3e7c60f192249dd

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

dexonsmith added inline comments. Comment at: clang/test/Modules/implicit-modules-use-lock.m:21 + +// CHECK-NO-LOCKS-NOT: remark: +// CHECK-LOCKS: remark: locking '{{.*}}.pcm' to build module 'X' [-Rmodule-lock] arichardson wrote: > jansvoboda11 wrote: > > dexon

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

Quuxplusone added a comment. > Can we either emit that [`a &= foo()`] as a suggestion if the code looks like > `a = a & foo()`? Or simply not emit a warning? The problem is that if `a` is boolean, then `a = a & something` is 99% for sure a typo — 99% of the time, the programmer meant `a = a &&

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common (1/8)

bcain updated this revision to Diff 366766. bcain retitled this revision from "add sanitizer support to hexagon" to "[sanitizer] Add hexagon support to sanitizer-common (1/8)". bcain edited the summary of this revision. bcain added a comment. Decomposed to just the sanitizer-common portion. Now

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

leonardchan created this revision. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. Not all downstream users may want to build all tools shipped with clang. `clang-repl` for us in particular can sometimes lead to flaky builds wh

[clang] 9ed4a94 - [clang] Expose unreachable fallthrough annotation warning

Author: Nathan Chancellor Date: 2021-08-16T17:14:55-07:00 New Revision: 9ed4a94d6451046a51ef393cd62f00710820a7e8 URL: https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8 DIFF: https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8.d

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: clang/CMakeLists.txt:468 +option(CLANG_BUILD_CLANG_REPL_DEFAULT "Build clang-repl by default." OFF) + Apart from name bikeshedding, it's more likely we'll want this `ON

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed4a94d6451: [clang] Expose unreachable fallthrough annotation warning (authored by nathanchance). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107933/new/

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

leonardchan added a comment. > @leonardchan, @phosek, I am not aware of such flag. Do you know how much > memory does LTO + clang-repl consume and would it make sense to ping some of > the LTO folks for their advice? I played around a bit with adding a flag and it turned out to be not as diffi

[PATCH] D107296: Treat inttypes.h as a built-in header

vsapsai added a comment. In general it is correct but there is no test case. I have a test case but it fails for other reasons. And I wasn't able to find time to address these "other reasons". I'll post my version of the test case soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1996 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v16f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v16i16, Legal); + setOperationAction(ISD::STRICT_SINT_TO_F

[PATCH] D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon

bcain created this revision. bcain added reviewers: sidneym, kparzysz. bcain added a project: clang. Herald added subscribers: s.egerton, simoncook. bcain requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108178 Files: clang/lib/Driver/ToolChain

[PATCH] D67149: Fix argument order for BugType instation for

MTC added a comment. Herald added a subscriber: martong. Hi @NoQ, sorry to bother you. This patch has been on hold for a very long time. It should not have been fixed yet. What's next? Abandon the patch, or improve it yourself? Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[clang] c411c1b - Fix missing qualifier in template type diffing

Author: Weverything Date: 2021-08-16T18:34:18-07:00 New Revision: c411c1bd7f7d3550d24333f80980c0be6481d34a URL: https://github.com/llvm/llvm-project/commit/c411c1bd7f7d3550d24333f80980c0be6481d34a DIFF: https://github.com/llvm/llvm-project/commit/c411c1bd7f7d3550d24333f80980c0be6481d34a.diff L

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.or

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

jyknight added a comment. It appears as though this commit was reverted in Apple's XCode Clang fork -- the behavior currently in XCode matches the behavior of upstream Clang prior to this patch. Presuming that's correct, I think we should revert this upstream as well. There doesn't seem to be a

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

tstellar added a comment. > Not all downstream users may want to build all tools shipped with clang. > clang-repl for us in particular can sometimes lead to flaky builds when > testing a toolchain built with LTO. Can we just fix clang-repl instead? I think there needs to be a more compelling

[clang] b31199b - [AVR][clang] Improve search for avr-libc installation path

Author: Ben Shi Date: 2021-08-17T11:51:35+08:00 New Revision: b31199bab4865deef4e778d7a028c8ec64285654 URL: https://github.com/llvm/llvm-project/commit/b31199bab4865deef4e778d7a028c8ec64285654 DIFF: https://github.com/llvm/llvm-project/commit/b31199bab4865deef4e778d7a028c8ec64285654.diff LOG:

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

This revision was automatically updated to reflect the committed changes. Closed by commit rGb31199bab486: [AVR][clang] Improve search for avr-libc installation path (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. It seems we need not adding this test, since a similiar test is added in https://reviews.llvm.org/rGb31199bab4865deef4e778d7a028c8ec64285654 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.

[clang] 198e677 - [analyzer] Add option to SATest.py for extra checkers

Author: Deep Majumder Date: 2021-08-17T10:42:57+05:30 New Revision: 198e6771e24fb5d8d9f3b155445ecc2a4f211004 URL: https://github.com/llvm/llvm-project/commit/198e6771e24fb5d8d9f3b155445ecc2a4f211004 DIFF: https://github.com/llvm/llvm-project/commit/198e6771e24fb5d8d9f3b155445ecc2a4f211004.diff

[PATCH] D106739: [analyzer] Add option to SATest.py for extra checkers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG198e6771e24f: [analyzer] Add option to SATest.py for extra checkers (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added subscribers: samitolvanen, pcc. v.g.vassilev added a comment. In D96033#2948243 , @leonardchan wrote: >> @leonardchan, @phosek, I am not aware of such flag. Do you know how much >> memory does LTO + clang-repl consume and would it make

Re: [clang] c411c1b - Fix missing qualifier in template type diffing

Perhaps the test case could be stripped down a bit? template class Array {}; template class S {}; template Array Make(); void Call() { Array> v = Make>(); } Seems to exhibit the same issue, by the looks of it. On Mon, Aug 16, 2021 at 6:38 PM via cfe-commits wrote: > > Author: Weverything

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim marked an inline comment as done. Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:186-188 + [FeatureExtZpsfoperand, +FeatureExtZpn, +FeatureExtZprvsfextra]>; jrtc27 wr

<    1   2