[PATCH] D107944: [hmaptool] Port to python3

2021-08-11 Thread Nathan Lanza via Phabricator via cfe-commits
lanza created this revision. lanza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just a few trivial changes -- change the interpreter and fix a few byte-vs-string issues. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

2021-08-11 Thread Wenlei He via Phabricator via cfe-commits
wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3896 - // These two forms of profiling info can't be used together. - if (const Arg *A1 = Args.getLastArg(o

[PATCH] D104854: Introduce intrinsic llvm.isnan

2021-08-11 Thread Siva Chandra via Phabricator via cfe-commits
sivachandra added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:22193 +DAG.getConstant(0x45, DL, MVT::i8)); + + return DAG.getSetCC(DL, ResultVT, Extract, DAG.getConstant(1, DL, MVT::i8), While I do not understand t

[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

2021-08-11 Thread Wei Mi via Phabricator via cfe-commits
wmi accepted this revision. wmi added a comment. In D107876#2939691 , @hoy wrote: > In D107876#2939624 , @wmi wrote: > >> Could you remind me the discriminator difference between debug info based >> AFDO and pseu

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

2021-08-11 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107946 Files: clang/lib/Headers/avx512fp16intrin.h clang/lib/Headers/avx512vlfp16

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

2021-08-11 Thread gehry via Phabricator via cfe-commits
Sockke updated this revision to Diff 365916. Sockke added a comment. update! @aaron.ballman @MTC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-e

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

2021-08-11 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks Freddy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107946/new/ https://reviews.llvm.org/D107946 _

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

2021-08-11 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added a comment. Any test case update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107946/new/ https://reviews.llvm.org/D107946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D107946: [X86] Reverse *_set_ph and *_setr_ph 's set order.

2021-08-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:92 #define _mm512_setr_ph(__h1, __h2, __h3, __h4, __h5, __h6, __h7, __h8, __h9, \ __h10, __h11, __h12, __h13, __h14, __h15, __h16, __h17, \ Can we

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

2021-08-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 365918. krasimir added a comment. - apply reviewer suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107907/new/ https://reviews.llvm.org/D107907 Files: clang/lib/Format/TokenAnnotator.cpp clang/un

[PATCH] D106738: [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created for vector builtins.

2021-08-11 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106738/new/ https://reviews.llvm.org/D106738

[clang] 0fc27ef - [clang-format] handle trailing comments in function definition detection

2021-08-11 Thread Krasimir Georgiev via cfe-commits
Author: Krasimir Georgiev Date: 2021-08-12T08:55:54+02:00 New Revision: 0fc27ef19670676689d3317948c81eb171bb25f8 URL: https://github.com/llvm/llvm-project/commit/0fc27ef19670676689d3317948c81eb171bb25f8 DIFF: https://github.com/llvm/llvm-project/commit/0fc27ef19670676689d3317948c81eb171bb25f8.d

[PATCH] D107907: [clang-format] handle trailing comments in function definition detection

2021-08-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fc27ef19670: [clang-format] handle trailing comments in function definition detection (authored by krasimir). Repository: rG LLVM Github Monorepo

<    1   2