[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @aaron.ballman Thanks for the review and comments. I'll update it ASAP. Comment at: clang/include/clang/AST/Expr.h:4959 + /// Return an value-expression under the given index. + /// aaron.ballman wrote: > +1 ===

[PATCH] D107559: [clang] Fix libclang linking on Solaris

MaskRay added a comment. ld.lld, GNU ld, and gold support `/* */`. I am not sure about Solaris ld -z gnu-version-script-compat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/ https://reviews.llvm.org/D107559 ___

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

craig.topper added a comment. I put up a patch for a simple fix for this in the backend. https://reviews.llvm.org/D107581 The generated code is not optimal, but maybe better than frontend workarounds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

vsapsai added a comment. As long as JSON dumper still compiles, it looks good to me. Just have a few small nits. Comment at: clang/include/clang/AST/TextNodeDumper.h:47 + /// Indicates if we can deserialize declarations from the ExternalASTSource. + bool Deserialize = true;

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro added a comment. In D107559#2928851 , @tstellar wrote: > Is there any kind of comment that is supported by all linkers? Seems there isn't. In that case, we could either move the comments to a separate file (`libclang.README`?), strip the comments wh

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364526. kbobyrev added a comment. Trim the patch even further: only extract locations, prune header marking logic etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426

[PATCH] D107559: [clang] Fix libclang linking on Solaris

tstellar added a comment. In D107559#2928999 , @ro wrote: > In D107559#2928851 , @tstellar > wrote: > >> Is there any kind of comment that is supported by all linkers? > > Seems there isn't. In that case, we cou

[clang] b4c0307 - Fix clang-interpreter build after 2487db1f286222e2501c2fa8e8244eda13f6afc3

Author: Jon Roelofs Date: 2021-08-05T10:05:36-07:00 New Revision: b4c0307d598004cfd96c770d2a4a84a37c838ba9 URL: https://github.com/llvm/llvm-project/commit/b4c0307d598004cfd96c770d2a4a84a37c838ba9 DIFF: https://github.com/llvm/llvm-project/commit/b4c0307d598004cfd96c770d2a4a84a37c838ba9.diff L

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a comment. FWIW, fp-contract=on has been the documented default for clang since version 5. https://releases.llvm.org/5.0.1/tools/clang/docs/ClangCommandLineReference.html#cmdoption-clang-ffp-contract This change just brought the behavior into conformance with the documentat

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

aaron.ballman added a comment. In D107420#2928975 , @craig.topper wrote: > I put up a patch for a simple fix for this in the backend. > https://reviews.llvm.org/D107581 The generated code is not optimal, but > maybe better than frontend workarounds.

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

cebowleratibm added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:238 +if (this->Context.getTargetInfo().getTriple().isOSAIX()) + Diag(PragmaLoc, diag::warn_pragma_align_not_xl_compatible); Action = Sema::PSK_Push_Set; Does this diagnosti

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

craig.topper added a comment. In D107420#2929039 , @aaron.ballman wrote: > In D107420#2928975 , @craig.topper > wrote: > >> I put up a patch for a simple fix for this in the backend. >> https://reviews.llvm.org

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

erichkeane added a comment. In D107420#2929115 , @craig.topper wrote: > In D107420#2929039 , @aaron.ballman > wrote: > >> In D107420#2928975 , @craig.topper >> wrote: >

[clang] 509854b - [clang] Replace asm with __asm__ in cuda header

Author: Jon Chesterfield Date: 2021-08-05T18:46:57+01:00 New Revision: 509854b69cea0c9261ac21ceb22012a53e7a800b URL: https://github.com/llvm/llvm-project/commit/509854b69cea0c9261ac21ceb22012a53e7a800b DIFF: https://github.com/llvm/llvm-project/commit/509854b69cea0c9261ac21ceb22012a53e7a800b.di

[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG509854b69cea: [clang] Replace asm with __asm__ in cuda header (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cjdb updated this revision to Diff 364555. cjdb marked 10 inline comments as done. cjdb added a comment. - adds TODOs - adds asserts - removes "imported" SourceManager (apparently there was already a pointer in `Result`) - fixes C++ documentation to match opening line of RST doc Repository: r

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.h:20-21 +namespace readability { +/// Flags uses of symbol-based bitwise and logical operators. +class AlternativeTokensCheck : public C

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364525. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - addressed reviewer feedback and updated test accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364527. gandhi21299 added a comment. added missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: llvm/include/llvm/CodeGen/TargetLowering.h l

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12155 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "A floating-point atomic instruction with no following use" +" will

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

phosek created this revision. phosek added reviewers: mibintc, andrew.w.kaylor, rjmccall, zahiraam, hans, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D74436

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added a comment. Thanks! I think it looks good, I've suggested some more simplifications to termination detection. If you can delete the rest I'd like to take a final look at the rest of the details. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:680 +// We

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 marked an inline comment as done. gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12155 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "A floating-point atomic instruction w

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12155 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "A floating-point atomic instruction with no following use" +" will

[PATCH] D107559: [clang] Fix libclang linking on Solaris

MaskRay added inline comments. Comment at: clang/tools/libclang/libclang.map:1 -/* If you add a symbol to this file, make sure to add it with the correct - * version. For example, if the LLVM main branch is LLVM 14.0.0, add new - * symbols with the version LLVM_14. - * On platfo

[PATCH] D107559: [clang] Fix libclang linking on Solaris

MaskRay added inline comments. Comment at: clang/tools/libclang/libclang.map:1 -/* If you add a symbol to this file, make sure to add it with the correct - * version. For example, if the LLVM main branch is LLVM 14.0.0, add new - * symbols with the version LLVM_14. - * On platfo

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

sfertile updated this revision to Diff 364570. sfertile added a comment. Only emit diagnostic on bitfield members, which is the only difference in align(packed) behaviour XL and clang/xlclang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107506/ne

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

sfertile added a comment. Good point Chris. The only difference in layout is related to bitfield members, so I have moved the warning to `VerifyBitField` as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107506/new/ https://reviews.llvm.

[clang] c38efb4 - [clang] Implement -falign-loops=N (N is a power of 2) for non-LTO

Author: Fangrui Song Date: 2021-08-05T12:17:50-07:00 New Revision: c38efb4899eac7b82daaf1320ad79f6271f9648a URL: https://github.com/llvm/llvm-project/commit/c38efb4899eac7b82daaf1320ad79f6271f9648a DIFF: https://github.com/llvm/llvm-project/commit/c38efb4899eac7b82daaf1320ad79f6271f9648a.diff

[PATCH] D106701: [clang] Implement -falign-loops=N (N is a power of 2) for non-LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc38efb4899ea: [clang] Implement -falign-loops=N (N is a power of 2) for non-LTO (authored by MaskRay). Changed prior to commit: https://reviews.ll

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12118 -TargetLowering::AtomicExpansionKind -SITargetLowering::shouldExpandAtomicRMWInIR(AtomicRMWInst *RMW) const { +TargetLowering::AtomicExpansionKind SITargetLowering::reportAtomicExpand( +

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364574. gandhi21299 marked 4 inline comments as done. gandhi21299 added a comment. requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: llvm

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

gAlfonso-bit updated this revision to Diff 364584. gAlfonso-bit added a comment. Improved patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 Files: clang/include/clang/AST/ComparisonCategories.h Index: clang/include/clang/AST/Comparison

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

rsmith added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > aaron.ballman wrote: > > cor3ntin wrote: > > > cor3ntin wrote: > > > > aaron.ballman wrote: > > >

[PATCH] D107595: [clang] fix transformation of template arguments for concept specializations

mizvekov created this revision. mizvekov published this revision for review. mizvekov added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR50864. This fixes error caused by substitution failures on template arguments for concept specializations. W

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "__alignof__()" operator, when used on a type, always returns the `ABIAlign` if the type is marked `__attribute__((aligned()))`. However, the "al

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan added a comment. This is a split of the query portion from https://reviews.llvm.org/D107394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107598/new/ https://reviews.llvm.org/D107598 ___ cfe-co

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364606. cor3ntin added a comment. - Add tests for typeid All the tests suggested by Richard pass as expected without having to modify the implementation of type id itself! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated rsmith wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > cor3ntin

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364610. kbobyrev added a comment. Trim the patch even further: the scope is now simply findAllReferences mechanism. Add more tests and improve functionality (handle using decls and implicit types). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. It would be nice if the diagnostic could be deferred to layout, in case the struct is defined but not used in a header, but I understand that #pragma pack(1) and #pragma align(pa

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364615. kbobyrev added a comment. Add one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-e

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

lunasorcery marked an inline comment as done. lunasorcery added a comment. Yes, that would be "Luna Kirkby " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107125/new/ https://reviews.llvm.org/D107125 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364625. kbobyrev added a comment. Exclude std:: namespace handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM, other then 1 small test update. Comment at: clang/test/Layout/aix-alignof-align-and-pack-attr.cpp:21 +// CHECK: @{{.*}}test2{{.*}}c{{.*}} = global %"struct.test2::C

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan updated this revision to Diff 364630. stevewan added a comment. Add third test case as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107598/new/ https://reviews.llvm.org/D107598 Files: clang/lib/AST/ASTContext.cpp clang/tes

[clang] a919165 - [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

Author: Steven Wan Date: 2021-08-05T18:18:58-04:00 New Revision: a91916500d67155ca17bfdf3294541f871f90a45 URL: https://github.com/llvm/llvm-project/commit/a91916500d67155ca17bfdf3294541f871f90a45 DIFF: https://github.com/llvm/llvm-project/commit/a91916500d67155ca17bfdf3294541f871f90a45.diff LO

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa91916500d67: [AIX] "aligned" attribute should not decrease type alignment returned by… (authored by stevewan). Repository: rG LLVM Github Monorep

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

mhjacobson created this revision. mhjacobson added reviewers: benshi001, MaskRay, dylanmckay. Herald added subscribers: Jim, krytarowski. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AVR, `.ctors` is used, not `.init_array`

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns created this revision. thomasjohns added a reviewer: marksl. Herald added a subscriber: hiraditya. thomasjohns requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Add a CTLZ pseudo instruction to tablegen and the ability to exp

[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

nickdesaulniers created this revision. nickdesaulniers added a reviewer: aaron.ballman. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The diagnostic texts for warning on attributes that don't appear on the initial declarat

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra updated this revision to Diff 364653. tra added a comment. Updated post D106769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106401/new/ https://reviews.llvm.org/D106401 Files: clang/lib/Driver/ToolChains/

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107610/new/ https://reviews.llvm.org/D107610 _

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns added inline comments. Comment at: llvm/lib/Target/ARC/ARCInstrInfo.td:314 defm NORMH : ArcUnaryEXT5Inst<0b001000,"normh">; + +// TODO: Add `Requires<[HasBitScan]>` predicate when available. I just realized I made a bad merge here and dropped the `

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra added a comment. I've updated the patch and added a test to verify that the knob does work as expected. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106401/new/ https://reviews.llvm.org/D106401 ___

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns added inline comments. Comment at: llvm/lib/Target/ARC/ARCInstrInfo.td:314 defm NORMH : ArcUnaryEXT5Inst<0b001000,"normh">; + +// TODO: Add `Requires<[HasBitScan]>` predicate when available. thomasjohns wrote: > I just realized I made a bad merge h

[PATCH] D107611: [ARC] Add codegen for llvm.ctlz intrinsic for the ARC backend

thomasjohns updated this revision to Diff 364657. thomasjohns added a comment. Fix missing `}` after bad merge. Move CTLZ next to other pseudo instructions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107611/new/ https://reviews.llvm.org/D107611 Files: clang/lib/Basic/Targets/ARC.h

[PATCH] D106737: [clang] [hexagon] Add resource include dir

bcain updated this revision to Diff 364665. bcain retitled this revision from "DRAFT - [clang] [hexagon] Add resource include dir" to "[clang] [hexagon] Add resource include dir". bcain added a comment. Herald added a subscriber: ormris. Add a test case, address failing test. Repository: rG L

[clang] dae7add - [AVR][clang] Pass '-fno-use-init-array' to cc1 as default

Author: Matt Jacobson Date: 2021-08-06T10:14:23+08:00 New Revision: dae7adda949993bd96aa50c551dc64ddebba7923 URL: https://github.com/llvm/llvm-project/commit/dae7adda949993bd96aa50c551dc64ddebba7923 DIFF: https://github.com/llvm/llvm-project/commit/dae7adda949993bd96aa50c551dc64ddebba7923.diff

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rGdae7adda9499: [AVR][clang] Pass '-fno-use-init-array' to cc1 as default (authored by mhjacobson, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

mhjacobson added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107610/new/ https://reviews.llvm.org/D107610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

cebowleratibm added inline comments. Comment at: clang/test/Sema/aix-pragma-align-packed-warn.c:13 + short a : 8; // expected-warning {{#pragma align(packed) may not be compatible with objects generated with AIX XL C/C++}} + short b : 8; // expected-warning {{#pragma align(p

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe added a comment. In D107420#2928975 , @craig.topper wrote: > I put up a patch for a simple fix for this in the backend. > https://reviews.llvm.org/D107581 The generated code is not optimal, but > maybe better than frontend workarounds. THX f

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

Jake-Egan updated this revision to Diff 364685. Jake-Egan added a comment. Only define if AIX is the target and host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D107242 Files: clang/lib/Basic/Targets/PPC.c

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

cebowleratibm added inline comments. Comment at: clang/test/Preprocessor/not-host-aix.c:2 +// UNSUPPORTED: system-aix +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-unknown-linux-gnu -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix PPC-LINUX %

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

cebowleratibm added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:306 + llvm::Triple HostTriple(llvm::sys::getProcessTriple()); + if (HostTriple.isOSAIX() && getTriple().isOSAIX()) { +Builder.defineMacro("__HOS_AIX__"); suggest using a temp r

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/PPC.cpp:260 + } else if (getTriple().isOSAIX()) { +// Also define _ARCH_PPC64 for 32-bit on AIX. +Bui

[PATCH] D105877: [Coroutines] Run coroutine passes by default

ChuanqiXu added a comment. In D105877#2924157 , @ChuanqiXu wrote: > In D105877#2923257 , @nikic wrote: > >> I noticed that this change had a measurable impact on `O0` memory usage, >> which I wouldn't have expect

<    1   2