[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied updated this revision to Diff 364372. airlied added a comment. Added a comment on the subgroups difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 Files: clang/lib/Headers/opencl-c-base

[PATCH] D105881: [flang][driver] Refactor boolean options

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. In D105881#2926523 , @awarzynski wrote: > Yes. Updating printHelp >

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong marked 4 inline comments as done. martong added a comment. Thanks for the review! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2112-2113 + assert(ClsMembers.contains(Old)); + assert(ClsMembers.getHeight() > 1 && + "Class should have at

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong updated this revision to Diff 364373. martong marked 4 inline comments as done. martong edited the summary of this revision. martong added a comment. - Remove superfluous clang_analyzer_printState - Assert on isEmpty instead of using getHeight Repository: rG LLVM Github Monorepo CHANG

[clang] 39dac1f - [clang] Add clang builtins support for gfx90a

Author: Anshil Gandhi Date: 2021-08-05T02:08:06-06:00 New Revision: 39dac1f7f65691487dbdc969e343108db5b0f765 URL: https://github.com/llvm/llvm-project/commit/39dac1f7f65691487dbdc969e343108db5b0f765 DIFF: https://github.com/llvm/llvm-project/commit/39dac1f7f65691487dbdc969e343108db5b0f765.diff

[PATCH] D106862: [clang] Remove misleading assertion in FullSourceLoc

jansvoboda11 added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106862/new/ https://reviews.llvm.org/D106862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This wraps the image and rw images usages in the correct macros Repository: rG LLVM Github Mono

[PATCH] D107540: [OMPBuilder] Clarify CanonicalLoopInfo. NFC.

Meinersbur created this revision. Herald added subscribers: wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, hiraditya. Herald

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied added a subscriber: azabaznov. airlied added a comment. Add @azabaznov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 ___ cfe-commits mailing list cfe-

[PATCH] D107145: clangd: Add new semantic token modifier "virtual"

ckandeler added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107145/new/ https://reviews.llvm.org/D107145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor updated this revision to Diff 364385. teemperor added a comment. - Make setter propagate 'deserialize' to the node dumper (thanks Volodymyr!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 Files: clang/include/clang/AST/ASTNodeTrave

[clang] e345b45 - Mark tests as requiring AMDGPU target

Author: Oliver Stannard Date: 2021-08-05T10:02:51+01:00 New Revision: e345b45bf1b5db03f00c3b3612d2653790a2b879 URL: https://github.com/llvm/llvm-project/commit/e345b45bf1b5db03f00c3b3612d2653790a2b879 DIFF: https://github.com/llvm/llvm-project/commit/e345b45bf1b5db03f00c3b3612d2653790a2b879.dif

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko requested changes to this revision. vsavchenko added a comment. This revision now requires changes to proceed. Oh, wait! I found a bug! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko added a comment. Now it captures (and makes bold) one extra arrow from the previous note. Correct example attached! F18364580: report-e4b488.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 _

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1373 + var array = []; + for (var i = lower; i <= upper; ++i) { + array.push(i); ASDenysPetrov wrote: > NoQ wrote: > > Shouldn't it be `i < upper`? > `[lower, u

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

lebedev.ri added a comment. I don't personally care, but i think this diag doesn't make sense. What is "backend"? Which one? All of them? What happens when one, but not all of them supports it? What if i don't intend to codegen this into an assembly, but only want to produce the IR? Repository

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

peixin updated this revision to Diff 364389. peixin added a comment. @Meinersbur Thanks for the review. Removed the typo fixes and gave the alloca register one name. Also found some typos of invalid case style for variable 'cur' in llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp and will fix th

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. Ping? The build failure is due to the name of the newly introduced `kRISCVJumpTableEntrySize`. Though I think we can put these magic numbers (4 and 8) just into `LowerTypeTestsModule::getJumpTableEntrySize`.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal marked an inline comment as done. steakhal added a comment. In D107078#2917892 , @NoQ wrote: > Y'all writing really good patches lately. Awesome, thank you! Comment at: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal updated this revision to Diff 364393. steakhal added a comment. - `The temporary` -> `Temporary ` - `full expression` -> `full-expression` I did not fix the extra blue 'bubble' note issue, and I think that is out of the scope of this patch. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied updated this revision to Diff 364395. airlied added a comment. found a few more places to replace these and fix them up. there might still be some strays in there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 Files: clang/lib/Hea

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

airlied updated this revision to Diff 364396. airlied added a comment. missed a couple of hunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/Hea

[PATCH] D107547: [CodeGen] Align calling convention bit-width to bitcode

Xinglong created this revision. Xinglong added reviewers: rudkx, rjmccall, rsmith. Xinglong added a project: clang. Xinglong requested review of this revision. Herald added a subscriber: cfe-commits. According to https://reveiws.llvm.org/D13826, bitcode use 10 bits to represent calling convention

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9528 QualType T2 = NextParam(F2, I2, I == 0); -if (!T1.isNull() && !T1.isNull() && !Context.hasSameUnqualifiedType(T1, T2)) +if (!T1.isNull() && !T2.isNull() && !Context.hasSameUnqualifiedTyp

[clang] 92b00ff - [OpenCL] Reduce duplicate defs by using multiclasses; NFC

Author: Sven van Haastregt Date: 2021-08-05T11:06:33+01:00 New Revision: 92b00ffe0fb3199515c9267a1fad96d3bf44d1ea URL: https://github.com/llvm/llvm-project/commit/92b00ffe0fb3199515c9267a1fad96d3bf44d1ea DIFF: https://github.com/llvm/llvm-project/commit/92b00ffe0fb3199515c9267a1fad96d3bf44d1ea.

[PATCH] D107151: [OpenCL] Reduce duplicate defs by using multiclasses; NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG92b00ffe0fb3: [OpenCL] Reduce duplicate defs by using multiclasses; NFC (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107151/new/ http

[clang] 55a9615 - [flang][driver] Refactor boolean options

Author: Andrzej Warzynski Date: 2021-08-05T10:20:47Z New Revision: 55a96155995465416118774add8ef09c30dbebda URL: https://github.com/llvm/llvm-project/commit/55a96155995465416118774add8ef09c30dbebda DIFF: https://github.com/llvm/llvm-project/commit/55a96155995465416118774add8ef09c30dbebda.diff

[PATCH] D105881: [flang][driver] Refactor boolean options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55a961559954: [flang][driver] Refactor boolean options (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D105881?vs=3642

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke updated this revision to Diff 364404. Sockke added a comment. format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/test/clang-tidy/checkers/p

[clang] 530ea28 - Correct a lot of diagnostic wordings for the driver

Author: Aaron Ballman Date: 2021-08-05T07:04:55-04:00 New Revision: 530ea28fefc4652823a187a149e8001cbf4af18f URL: https://github.com/llvm/llvm-project/commit/530ea28fefc4652823a187a149e8001cbf4af18f DIFF: https://github.com/llvm/llvm-project/commit/530ea28fefc4652823a187a149e8001cbf4af18f.diff

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

olestrohm created this revision. olestrohm added reviewers: Anastasia, rjmccall. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This patch fixes initializing temporaries, which are cur

[PATCH] D107365: clangd: Make documentation property of completion items more similar

ckandeler updated this revision to Diff 364412. ckandeler added a comment. Addressed lint complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107365/new/ https://reviews.llvm.org/D107365 Files: clang-tools-extra/clangd/CodeComplete.cpp I

[PATCH] D105426: [clangd] WIP: Unused header warnings

kbobyrev updated this revision to Diff 364413. kbobyrev added a comment. Significantly decrease the scope of this change. Focus on "IWYU as a library", do not propagate into the other parts of clangd yet and keep the change self-contained for the most part. Repository: rG LLVM Github Monorepo

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch! Do you need me to commit it on your behalf? If so, what name and email address would you like me to use for patch attribution in git? CHANGES SIN

[PATCH] D107497: [PowerPC][AIX] Limit attribute aligned to 4096.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107497/new/ https://reviews.llvm.org/D107497

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Topotuna wrote: > Anastasia wrote: > > Anastasia wrote: > > > Maybe we could title it something like: > > > > > > `Address space r

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

steakhal added a comment. First and foremost, I think this is a great change. I think the diagnostic is on the point. BTW it seems like you missed two notes in `misc-ps-region-store.m` causing a test fail: error: 'note' diagnostics seen but not expected: File /home/steakhal/git/llvm-proj

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. In D107366#2927842 , @vsavchenko wrote: > Now it captures (and makes bold) one extra arrow from the previous note. > Correct example attached! > F18364580: report-e4b488.html Damn. I've

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:24 #define cl_khr_subgroup_clustered_reduce 1 +#define cl_ext_float_atomics +#ifdef cl_khr_fp16 svenvh wrote: > Should this be defined as `1`? > > Should this define be tested in `cl

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364418. ASDenysPetrov added a comment. Final fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp Index: clang/lib/StaticAnalyzer/Core/H

[PATCH] D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4064-4068 if (Context.getTargetInfo().isTLSSupported()) { unsigned MaxTLSAlign = Context.toCharUnitsFromBits(Context.getTargetInfo().getMaxTLSAlign()) .getQuantity();

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 364420. Topotuna added a comment. Documentation section title reworded CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExtensions.rst clang/lib/Headers/opencl-c-base.h clan

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. F18367476: report-86a04f.html - Final sample file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ cfe-commits mailing list cf

[PATCH] D107558: [clang] [clang-repl] Fix linking against LLVMLineEditor

mgorny created this revision. mgorny added reviewers: v.g.vassilev, mstorsjo. mgorny requested review of this revision. LLVMLineEditor library is part of the LLVM dylib. Move it into LLVM_LINK_COMPONENTS to avoid duplicate linking when dylib is being used. This fixes building standalone clang ag

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro created this revision. ro added reviewers: clang, tstellar, MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, mgorny, jyknight. ro requested review of this revision. Herald added a subscriber: cfe-commits. Linking `libclang.so` is currently broken on Solaris: ld: f

[PATCH] D107528: [llvm][clang][NFC] updates inline licence info

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. There are some spurious whitespace changes that should be dropped, but otherwise, this LGTM. Thank you for the cleanup! Comment at: clang/lib/Tooling/Dependenc

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe added a comment. In D107420#2927856 , @lebedev.ri wrote: > I don't personally care, but i think this diag doesn't make sense. > What is "backend"? Which one? All of them? What happens when one, but not all > of them supports it? > What if i don

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added a comment. Sorry about the delay here, and welcome back! The core design looks sensible to me - we talked about making this part of the background index (which could reuse more code) but we don't actually want the data mixed together. Main points in the implementation are: - s

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:75 + return std::move(x4); + // CHECK-MESSAGES: :[[@LINE-1]]

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:4959 + /// Return an value-expression under the given index. + /// Comment at: clang/include/clang/AST/Expr.h:4970 + /// - `this` if there's no expression for

[PATCH] D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.

sfertile updated this revision to Diff 364436. sfertile added a comment. - Fixed spelling mistake - Check that VD is non-nulll earlier. - added warning that the requested alignment is too small. - renamed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.

sfertile marked 3 inline comments as done. sfertile added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4081 +if (Ty->isVectorType() && AlignVal < 16) + return; + } aaron.ballman wrote: > This should produce a diagnostic rather than silen

[PATCH] D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2989-2990 "requested alignment is less than minimum alignment of %1

[PATCH] D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test"

fanbo-meng created this revision. Herald added a subscriber: krytarowski. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit d91234b21c1a1a34d98157089a8769d8f9a32f06

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. How about we just change the NoteTag to this: "Failed stream operation could have left the error or eof flags set, or the file position indicator indeterminate"? We could add a `NoteTags` to `feof` and `ferror` that narrows this down, for example: fread(F); // note

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/AlternativeTokensCheck.cpp:61 +FixItHint AlternativeTokensCheck::createReplacement(SourceLocation Loc, +StringRef S, int N) const { + // On

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

MTC added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:75 + return std::move(x4); + // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: passing result of std::move() as a const reference argument; no move will actually happe

[PATCH] D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test"

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107565/new/ https://reviews.llvm.org/D107565 _

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:51 + hasReturnValue(anyOf( + ignoringImplicit(ignoringParenCasts(MoveCallMatcher)), + cxxConstructExpr(hasDeclaration(cxxConstructorDecl

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:801 // 0b00010: implied 0F 38 leading opcode bytes // 0b00011: implied 0F 3A leading opcode bytes // 0b00100-0b1: Reserved for future use Add commen

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:261 + showInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: std::move of the variable 'a' of the trivially-copyable type 'int' has no effec

[clang] 5181be3 - [PowerPC][AIX] Limit attribute aligned to 4096.

Author: Sean Fertile Date: 2021-08-05T09:51:16-04:00 New Revision: 5181be344adbf7ba7dffc73526893d4e7750d34c URL: https://github.com/llvm/llvm-project/commit/5181be344adbf7ba7dffc73526893d4e7750d34c DIFF: https://github.com/llvm/llvm-project/commit/5181be344adbf7ba7dffc73526893d4e7750d34c.diff

[PATCH] D107497: [PowerPC][AIX] Limit attribute aligned to 4096.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5181be344adb: [PowerPC][AIX] Limit attribute aligned to 4096. (authored by sfertile). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107497/new/ https://revi

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:261 + showInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: std::move of the variable 'a' of the trivially-copyable type 'int' has no effect

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh requested changes to this revision. svenvh added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/opencl-c-base.h:24 #define cl_khr_subgroup_clustered_reduce 1 +#define cl_ext_float_atomics +#ifdef cl_khr_fp16

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

steakhal added a comment. In D107051#2928089 , @steakhal wrote: > First and foremost, I think this is a great change. I think the diagnostic is > on the point. > BTW it seems like you missed two notes in `misc-ps-region-store.m` causing a > test fail: >

[clang] 91e3995 - Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test"

Author: Fanbo Meng Date: 2021-08-05T10:14:02-04:00 New Revision: 91e399519580930623e1eb7be43374f0ba8aba41 URL: https://github.com/llvm/llvm-project/commit/91e399519580930623e1eb7be43374f0ba8aba41 DIFF: https://github.com/llvm/llvm-project/commit/91e399519580930623e1eb7be43374f0ba8aba41.diff LO

[PATCH] D107565: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test"

This revision was automatically updated to reflect the committed changes. Closed by commit rG91e399519580: Revert "[SystemZ][z/OS] Update target specific __attribute__((aligned)) value… (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 ___ cfe-commits mailing list

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 364242. gandhi21299 added a comment. - added more negative tests - fixed some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/B

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-fp-atomics-unsupported-gfx7.cl:8 +} \ No newline at end of file Add new line. Comment at: clang/test/CodeGenOpenCL/unsupported-fadd2f16-gfx908.cl:1 +// REQUIRES: amd

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364256. gandhi21299 added a comment. - fixed remarks in SIISelLowering for hw instruction generation - fixed test accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.o

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12146 +OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); +Remark << "A floating-point atomic instruction will generate an unsafe" + " hardware

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 364266. gandhi21299 added a comment. - combined tests into a single file - renamed tests for consistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files:

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. Thanks a lot for the review, I will merge this patch in :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits mailing

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

This revision was automatically updated to reflect the committed changes. Closed by commit rG39dac1f7f656: [clang] Add clang builtins support for gfx90a (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://rev

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. I will merge this patch in as soon as the builds are successful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits ma

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

balazske added a comment. If the original memory object is not known the static size is not known too. Every pointer with unknown source can point into a bigger data structure. Comment at: clang/test/Analysis/return-ptr-range.cpp:11 +int *test_global_ptr() { + do { // expecte

[PATCH] D107558: [clang] [clang-repl] Fix linking against LLVMLineEditor

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107558/new/ https://reviews.llvm.org/D107558 ___ cfe-commits mailing lis

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

jsji added a comment. > x64 debian > Clang.Driver::ppc-mprivileged-support-check.c The changed test is failing ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/ https://reviews.llvm.org/D107461 __

[PATCH] D106550: [PowerPC] Allow MMA builtins to accept restrict qualified pointers

saghir updated this revision to Diff 364467. saghir added a comment. Addressed review comments. Added another test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaCheckin

[clang] d99e946 - [clang] [clang-repl] Fix linking against LLVMLineEditor

Author: Michał Górny Date: 2021-08-05T16:51:47+02:00 New Revision: d99e9461b07988914cba573800cd1862f277e155 URL: https://github.com/llvm/llvm-project/commit/d99e9461b07988914cba573800cd1862f277e155 DIFF: https://github.com/llvm/llvm-project/commit/d99e9461b07988914cba573800cd1862f277e155.diff

[PATCH] D107558: [clang] [clang-repl] Fix linking against LLVMLineEditor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd99e9461b079: [clang] [clang-repl] Fix linking against LLVMLineEditor (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

steakhal added a comment. In D107051#2928536 , @balazske wrote: > If the original memory object is not known the static size is not known too. > Every pointer with unknown source can point into a bigger data structure. You are right, but IMO pointers to

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 364486. RedDocMD added a comment. Bug fix in modelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cp

[clang] f888e44 - [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.

Author: Sean Fertile Date: 2021-08-05T11:15:12-04:00 New Revision: f888e442bcc547301b58e77667eb261c0391b897 URL: https://github.com/llvm/llvm-project/commit/f888e442bcc547301b58e77667eb261c0391b897 DIFF: https://github.com/llvm/llvm-project/commit/f888e442bcc547301b58e77667eb261c0391b897.diff

[PATCH] D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.

This revision was automatically updated to reflect the committed changes. sfertile marked an inline comment as done. Closed by commit rGf888e442bcc5: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var. (authored by sfertile). Changed prior to commit: https://reviews.llvm.org

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 364490. RedDocMD added a comment. Never gonna give you up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModelin

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:133-134 "readability-uppercase-literal-suffix"); +CheckFactories.registerCheck( +"readability-use-alternative-tokens"); CheckFactories.re

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

balazske updated this revision to Diff 364495. balazske added a comment. Fixes in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107051/new/ https://reviews.llvm.org/D107051 Files: clang/lib/StaticAnalyzer/Checkers/ReturnPointerRangeChecke

[PATCH] D107559: [clang] Fix libclang linking on Solaris

MaskRay added inline comments. Comment at: clang/tools/libclang/libclang.map:1 -/* If you add a symbol to this file, make sure to add it with the correct - * version. For example, if the LLVM main branch is LLVM 14.0.0, add new - * symbols with the version LLVM_14. - * On platfo

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:76 +def err_fe_backend_error_attr : + Error<"call to %0 declared with attribute error: %1">, BackendInfo; +def warn_fe_backend_warning_attr : ===

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ASTLookup.cpp:26 + // and we have a TypedefDecl with the name 'FILE'. + for (Decl *D : LookupRes) +if (auto *TD = dyn_cast(D)) `Decl *D` -> `const Decl *D`. Same for the other loo

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke added a comment. Thank you for your reviews, @Quuxplusone, @whisperity, @MTC. I was also considering adding new diagnoses to the current check for these special cases, but I am not sure how to classify and describe them correctly, and whether they need to be added to the new check. First

[clang] 6b0f359 - Fix signal during the call to checkOpenMPLoop.

Author: Jennifer Yu Date: 2021-08-05T08:59:35-07:00 New Revision: 6b0f35931a44b0fbd27297f83087d3a4c352e83f URL: https://github.com/llvm/llvm-project/commit/6b0f35931a44b0fbd27297f83087d3a4c352e83f DIFF: https://github.com/llvm/llvm-project/commit/6b0f35931a44b0fbd27297f83087d3a4c352e83f.diff L

[PATCH] D107385: Fix signal during the call to checkOpenMPLoop.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b0f35931a44: Fix signal during the call to checkOpenMPLoop. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107385/new/ https://reviews.l

[PATCH] D107559: [clang] Fix libclang linking on Solaris

tstellar added a comment. Is there any kind of comment that is supported by all linkers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/ https://reviews.llvm.org/D107559 ___ cfe-commits mailing

[PATCH] D107051: [clang][analyzer] Improve bug report in alpha.security.ReturnPtrRange

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Aside from the inline nit, I think it's good to go. Let some time for the others to catch up, they might have objections. Comment at: clang/test/Analysis/return-ptr-range

  1   2   >