[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe updated this revision to Diff 363991. FreddyYe added a comment. rebase and refactor clang-format and clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107420/new/ https://reviews.llvm.org/D107420 Files: clang/include/clang/Basic

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

protze.joachim added a comment. The use case, where I see the current behavior as an issue is linking multiple object files compiled from different languages. Many build systems will pass CFLAGS as well as FFLAGS to the linker command in such case. To automatically link the necessary language-sp

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. Still LGTM. BTW, I liked that in the old version the help string included "In GCC =0 is the same as =1". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, rogfer01, frasercrmck, khchen. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

hans added a subscriber: tstellar. hans added a comment. Also +@tstellar since I believe this went in before the 13 branch point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added a comment. Ping. @vsavchenko Could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106823/new/ https://reviews.llvm.org/D106823 ___ cfe-commits mailing list cfe-commit

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

vsavchenko added a comment. Looking great! I have a couple of nit picks and I kind of want to check that it doesn't affect the performance on a different set of projects as well. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2112-2113 + assert(ClsMember

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 364013. TaoPan added a comment. Change selection of entry block text section from IMAGE_COMDAT_SELECT_ANY to return value of getSelectionForCOFF() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https:

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. @rnk Thanks for your review comments! Could you please help to review my reply and new modification? @MaskRay Could you please also help to review? Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712 + COFF::IMAGE_SCN_MEM_READ |

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

kiranchandramohan added a comment. Thanks @peixin for the patch. Could you remove the OpenMP 1.0 target from the description? That is a target for the Flang team and since this patch touches clang as well, it might be confusing. I believe this is modelling the ordered construct with a region. C

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus added a comment. Maybe if I added this under an alpha checker option? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105819/new/ https://reviews.llvm.org/D105819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. @rampitec what should I be testing exactly in the IR test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits mailing

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added a comment. In D106909#2923724 , @gandhi21299 wrote: > @rampitec what should I be testing exactly in the IR test? Produced call to the intrinsic. All of these tests there doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } gandhi21299 wrote: > rampitec wrote: > > gand

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } rampitec wrote: > gandhi21299 wrote: > > r

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 added a comment. Passed PSDB, @rampitec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. It still does not do anything useful and still produces useless, wrong and misleading remarks for all targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 __

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added a comment. @HazardyKnusperkeks @MyDeveloperDay Could you please review the last version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-commits mailing list cfe-com

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

kadircet added a comment. Ok if you think that setting GCC version to higher values by default won't break anything, I think we should update this for all of clang instead. Apparently that was something done in the past already in https://github.com/llvm/llvm-project/commit/b5fe494a2cdd33a0b069

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1352-1356 + // key 'j' + if (event.keyCode == 74) { navigateTo(/*up=*/false); - } else if (event.key == "k") { + // key 'k' + } else if (event.keyCode == 75) { ---

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364030. ASDenysPetrov added a comment. Fixed the range in `range` function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp Index: clang/

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:664 + } + // NextPragma is after us but before the next symbol. Our reign is over. + break; I suppose this is not correct in cases like. ``` #pragma mark - Outer

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko added a comment. Can you please also attach an HTML file just to verify that it works? Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1293 +var classListAdd = function(el, theClass) { + if(!el.className.baseVal) +el.className += " " + theClass; --

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

xbolva00 added a comment. >> I think we should update this for all of clang instead. But first you need to prove that clang matches gcc x.y.z. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107304/new/ https://reviews.llvm.org/D107304

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

protze.joachim added a comment. Since I see this as a regression over clang-12, I posted https://bugs.llvm.org/show_bug.cgi?id=51339 as a release blocking issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99

[clang] 0556138 - [clang][cli] Expose -fno-cxx-modules in cc1

Author: Jan Svoboda Date: 2021-08-04T13:46:40+02:00 New Revision: 0556138624edf48621dd49a463dbe12e7101f17d URL: https://github.com/llvm/llvm-project/commit/0556138624edf48621dd49a463dbe12e7101f17d DIFF: https://github.com/llvm/llvm-project/commit/0556138624edf48621dd49a463dbe12e7101f17d.diff L

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rG0556138624ed: [clang][cli] Expose -fno-cxx-modules in cc1 (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106864/new/ https://revi

[clang] 2718ae3 - [clang][deps] Substitute clang-scan-deps executable in lit tests

Author: Jan Svoboda Date: 2021-08-04T13:55:14+02:00 New Revision: 2718ae397b29f339e65c1e3ca5e834b648732d20 URL: https://github.com/llvm/llvm-project/commit/2718ae397b29f339e65c1e3ca5e834b648732d20 DIFF: https://github.com/llvm/llvm-project/commit/2718ae397b29f339e65c1e3ca5e834b648732d20.diff L

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG2718ae397b29: [clang][deps] Substitute clang-scan-deps executable in lit tests (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1071

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke created this revision. Sockke added reviewers: alexfh, aaron.ballman, whisperity, steven.zhang, MTC. Herald added subscribers: rnkovacs, xazax.hun. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. There are incorrec

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364065. aaron.ballman added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely, emaste. Fixing the tests I couldn't test locally but were found by the CI pipeline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364068. ASDenysPetrov added a comment. Corrected nits. Thanks to "the sharp eye" @vsavchenko =). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics

[PATCH] D106152: [analyzer] Move test case to existing test file and remove duplicated test file.

ASDenysPetrov added a comment. I think the patch is pretty safe, then I decided to load it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106152/new/ https://reviews.llvm.org/D106152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3819 + let Args = [StringArgument<"UserDiagnostic">]; + let Subjects = SubjectList<[Function], ErrorDiag>; + let Documentation = [ErrorAttrDocs]; nickdesaulniers wrote: > aaron.

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 364074. RedDocMD added a comment. Better modelling, bug fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrMode

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:133-134 "readability-uppercase-literal-suffix"); +CheckFactories.registerCheck( +"readability-use-alternative-tokens"); CheckFactories.re

[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

erichkeane added a subscriber: aaron.ballman. erichkeane added a comment. This seems lie an incomplete fix. Is this the ONLY configuration that this has trouble with? Also, the error message seems awkward, @aaron.ballman : Can you suggest a better spelling? Repository: rG LLVM Github Monor

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

joerg added a comment. This discussion is becoming pointless. Clang is not a 1:1 replacement for later GCC versions. Easiest example is the support for `__builtin_apply` and friends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107304/new/ https:

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364078. ASDenysPetrov added a comment. Replaced a closure in `highlightArrowsForSelectedEvent ` with function object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. F18343863: report-cdf7f5.html This is a sample file which now should work both on IE and Chromium-based browsers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. I have incorporated the bug-fixes suggested last meeting (except the pointer escape one). And it seems to have had dramatic results - now the only extra errors being reported are the pointer escape ones (5 of them, from 3 different projects). Some projects are actually

[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:334-335 +const auto ResultTy = TheCall->getArg(2)->getType()->getPointeeType(); +// Input compination below will also emit integer value larger than +// 128 bits in backend, disallow same

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

peixin added a comment. @kiranchandramohan Thanks for the review. Removed the OpenMP 1.0 target from the description. The simd clause does need more changes and I think it also depend simd directive in the OpenMPIRBuilder. According to the CHECK5 in the test case `ordered_codegen.cpp`, it does

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

erichkeane added a comment. Just some thoughts! See what you like/don't like here, i'm not attached to my suggestions. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:86 +def err_drv_mix_cuda_hip : Error< + "mixed CUDA and HIP compilation is not supported">; +

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a subscriber: kbsmith1. mibintc added a comment. There was a long discussion on cfe-dev about this issue approximately January-February 2020 including @scanon @andrew.w.kaylor and many others. While there wasn't 100% consensus to move to ffp-contract=on there are many reasons to

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88 +def err_drv_bad_target_id : Error< + "invalid target ID: %0 (a target ID is a processor name followed by an " + "optional list of predefined features post-fixed by a plus or

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364093. aaron.ballman marked 5 inline comments as done. aaron.ballman added a comment. Updating based on review feedback and restarting the CI pipeline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3405 +/// half member at the specified offset. For example, {int,{half}} has a +/// float at offset 4. It is conservatively correct for this routine to return +/// false. float -> hal

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman added a comment. In D107402#2925402 , @erichkeane wrote: > The changes in this patch are all fine to me! I'm a little disturbed that it > only broke 1 test though... Thanks for the review! The test coverage for driver diagnostics definit

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. The changes in this patch are all fine to me! I'm a little disturbed that it only broke 1 test though... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://rev

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:38 + +#pragma omp begin declare variant match(device = {arch(amdgcn)}) + Given that declare variant didn't work elsewhere, it probably doesn't

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

sfertile marked 2 inline comments as done. sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1783 +if (FieldPacked) { + FieldAlign = UnpackedFieldAlign = 1; +} else if (!MaxFieldAlignment.isZero()) { stevewan wrote: >

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

sfertile updated this revision to Diff 364097. sfertile added a comment. Don't update the unpacked field align based on IsPacked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106900/new/ https://reviews.llvm.org/D106900 Files: clang/lib/AST/Rec

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. We do not want to define __PRIVILEGED__. There is no use case for the definition and gcc does not define it.

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. The divergence with GCC is regrettable. Unfortunately defining _ARCH_PPC64 in 32-bit has been a long-standing discrepancy between xlc and gcc and one I don't expect gc

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

frasercrmck added a comment. Sorry, I can't find if we wrote it down in some other patch -- and someone can correct me if I'm wrong -- but in one of the recent LLVM RISC-V sync-up calls we agreed that we'd skip v0.10-rc and move straight to supporting v1.0 when it's made final. So I think this

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan accepted this revision. stevewan added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106900/new/ https://reviews.llvm.org/D106900 ___ cfe-commits mailing list cfe-commit

[clang] b8f612e - [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

Author: Sean Fertile Date: 2021-08-04T11:03:25-04:00 New Revision: b8f612e780e50cfb62bc0196b6367e4587949f88 URL: https://github.com/llvm/llvm-project/commit/b8f612e780e50cfb62bc0196b6367e4587949f88 DIFF: https://github.com/llvm/llvm-project/commit/b8f612e780e50cfb62bc0196b6367e4587949f88.diff

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sfertile marked an inline comment as done. Closed by commit rGb8f612e780e5: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment. (authored by sfertile).

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:38 + +#pragma omp begin declare variant match(device = {arch(amdgcn)}) + JonChesterfield wrote: > Given that declare variant didn't work elsewhere, i

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } Is there a reason this should be restricted to variables? For

[clang] f3eb5f9 - [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef

Author: Pushpinder Singh Date: 2021-08-04T15:24:46Z New Revision: f3eb5f900d2ae6c8e1c03d1b250415a7b7aa39b1 URL: https://github.com/llvm/llvm-project/commit/f3eb5f900d2ae6c8e1c03d1b250415a7b7aa39b1 DIFF: https://github.com/llvm/llvm-project/commit/f3eb5f900d2ae6c8e1c03d1b250415a7b7aa39b1.diff L

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:260 + } else { +if (getTriple().isOSAIX()) + Builder.defineMacro("_ARCH_PPC64"); cebowleratibm wrote: > A comment is warranted here to explain that __ARCH_PPC64 is

[PATCH] D107468: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3eb5f900d2a: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107243: [AIX] Define __THW_PPC__ macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. __THW_PPC__ is a macro historically defined by xlc on AIX and defining it may help users port to clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107468: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Yes, ship it. We'll look at fixing variant and pull the ifdef back out once it's working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D107468: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ye-luo, ronlieb. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a reviewer: jdo

[PATCH] D107294: [clang-tidy] adds warning to suggest users replace symbols with words

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/UseAlternativeTokensCheck.cpp:41-42 + Finder->addMatcher( + binaryOperation(hasAnyOperatorName("&&", "||", "!", "&", "|", "~", "^")) + .bind("operator"), + this);

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 updated this revision to Diff 364132. gandhi21299 added a comment. - eliminated the scope argument as per discussion - added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:595 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "A hardware instruction was generated"; + return Remark; Nothing was generated

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } @rampitec @arsenm I don't quite remember i

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. In D106891#2925692 , @gandhi21299 wrote: > - eliminated the scope argument as per discussion > - added more tests You have updated wrong patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. JBTW, patch title is way too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

ye-luo added a comment. I testing with aomp 13.0-5 on ubuntu 20.04.2 LTS (Focal Fossa) yeluo@epyc-server:~$ offload-arch -a gfx906 ERROR: offload-arch not found for 10de:2486. yeluo@epyc-server:~$ offload-arch -c gfx906 sramecc+ xnack- yeluo@epyc-server:~$ offload-arch -n gfx906 1

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

probinson added a comment. I see that the UserManual has been updated, but this behavior change should probably also be mentioned in the Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 _

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364134. aaron.ballman added a comment. More testing fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Cud

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88 +def err_drv_bad_target_id : Error< + "invalid target ID: %0 (a target ID is a processor name followed by an " + "optional list of predefined features post-fixed by a plus or mi

[clang] e57e1e4 - [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

Author: Bradley Smith Date: 2021-08-04T16:10:37Z New Revision: e57e1e4e00264b77b2b35ad2bf419a48aecdd6bc URL: https://github.com/llvm/llvm-project/commit/e57e1e4e00264b77b2b35ad2bf419a48aecdd6bc DIFF: https://github.com/llvm/llvm-project/commit/e57e1e4e00264b77b2b35ad2bf419a48aecdd6bc.diff LOG:

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe57e1e4e0026: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate… (authored by bsmith). Changed prior to commit: https:

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88 +def err_drv_bad_target_id : Error< + "invalid target ID: %0 (a target ID is a processor name followed by an " + "optional list of predefined features post-fixed by a plus or min

[PATCH] D107420: [WIP][sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe updated this revision to Diff 364154. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. I'll refactor clang-format later. Pls help review the new condition and diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe marked an inline comment as done. FreddyYe added a comment. Addressed. THX review! Comment at: clang/test/Sema/builtins-overflow.c:45 +unsigned _ExtInt(128) result; +_Bool status = __builtin_mul_overflow(x, y, &result); // expected-error {{__builtin_mul_overfl

[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8351-8353 +def err_overflow_builtin_special_combination_max_size : Error< + "__builtin_mul_overflow does not suport unsigned overflow check aft

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

rnk added a comment. In D94639#2918559 , @SeTSeR wrote: > Thank you for the detailed answer. I'll discuss our use case with our team. > Should I create a separate ticket for this? Or maybe it would be better if I > submitted the PR adding this flag? It'

[PATCH] D107477: [LLVM][AST][NFC] Resolve Fixme: Make CXXRecordDecl *Record const.

gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107477 Files: clang/include/clang/AST/C

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 364152. gandhi21299 added a comment. updating test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/l

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "gfx90a-insts")

[PATCH] D107241: [AIX] Define __THW_BIG_ENDIAN__ macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107241/new/ https://reviews.llvm.org/D107241

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:664 + } + // NextPragma is after us but before the next symbol. Our reign is over. + break; kadircet wrote: > I suppose

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldm

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

sfertile added inline comments. Comment at: clang/test/Layout/aix-alignof-align-and-pack-attr.cpp:11 + +// CHECK: @c = global %struct.C zeroinitializer, align 2 Minor nit: I think the other test can live in this file, highlighting the difference between the 2 ca

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "gfx90a-insts") +TA

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364172. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Drive

[PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

tra added a comment. In D106960#2925610 , @ye-luo wrote: > my second GPU is NVIDIA 3060Ti (sm_86) > I build my app daily with -Xopenmp-target=nvptx64-nvidia-cuda -march=sm_80. > > About sm_80 binary able ot run on sm_86 > https://docs.nvidia.com/cuda/ampe

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

ArcsinX added a comment. In D107304#2924886 , @kadircet wrote: > Ok if you think that setting GCC version to higher values by default won't > break anything, I think that GCC version should be the same, which was used to build the project: it can be hi

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

aprantl added a comment. @teemperor is there a reason why the fixed patch never landed? This looks a good improvement to have. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 ___ cfe-commits mailing l

[PATCH] D107393: Apply -fmacro-prefix-map to __builtin_FILE()

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/CodeGen/macro-prefix-map.c:1 +// RUN: %clang_cc1 -fmacro-prefix-map=%p=/UNLIKELY/PATH -emit-llvm -o - %s | FileCheck %s + T

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364186. stevewan added a comment. Merge tests into one file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp clang/test/Layout

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics in GFX90A

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12139 +OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); +Remark << "A hardware instruction was generated"; +return Remark; rampite

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics in GFX90A

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12139 +OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); +Remark << "A hardware instruction was generated"; +return Remark; gandhi2129

  1   2   >