[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb updated this revision to Diff 363546. cjdb marked 5 inline comments as done. cjdb edited the summary of this revision. cjdb added a comment. applies feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107292/new/ https://reviews.llvm.org/D1

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added inline comments. Comment at: clang/test/Parser/warn-declare-references-with-symbols.cpp:2 +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -Wdeclare-references-with-symbols -verify %s + aaron.ballman

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

dblaikie added a comment. Not a huge objection - but minor quandry: What's the motivation for this patch? I don't know of any codebase that encourages/uses the alternative tokens and I wonder if adding more usability to them is a worthwhile investment in clang's codebase complexity, etc. Repo

[clang] f575f37 - [clang][darwin] Add support for the -mtargetos= option to the driver

Author: Alex Lorenz Date: 2021-08-02T12:45:40-07:00 New Revision: f575f371822f6a07483b21701165492224a846bb URL: https://github.com/llvm/llvm-project/commit/f575f371822f6a07483b21701165492224a846bb DIFF: https://github.com/llvm/llvm-project/commit/f575f371822f6a07483b21701165492224a846bb.diff L

[PATCH] D106316: [clang][darwin] Add support for the -mtargetos= option to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf575f371822f: [clang][darwin] Add support for the -mtargetos= option to the driver (authored by arphaman). Herald added a project: clang. Repository

[PATCH] D106864: [clang][cli] Expose -fno-cxx-modules in cc1

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106864/new/ https://reviews.llvm.org/D106864 ___ cfe-commits mailing list c

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 363550. beanz added a comment. Updates based on post-commit feedback from @lattner on D106732 . This should inline the determination for emitting warnings, but keep the actual warning emission in a call. Repository: rG LLV

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Clang uses 4.2.1 as a def

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added a comment. In D107292#2920637 , @dblaikie wrote: > Not a huge objection - but minor quandry: What's the motivation for this > patch? I don't know of any codebase that encourages/uses the alternative > tokens and I wonder if adding more usabil

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

dblaikie added a comment. In D107292#2920746 , @cjdb wrote: > In D107292#2920637 , @dblaikie > wrote: > >> Not a huge objection - but minor quandry: What's the motivation for this >> patch? I don't know of any c

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

cjdb added a subscriber: eric_niebler. cjdb added a comment. In D107292#2920774 , @dblaikie wrote: > In D107292#2920746 , @cjdb wrote: > >> In D107292#2920637 , @dblaikie

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 363562. dgoldman marked 4 inline comments as done. dgoldman added a comment. More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-to

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:13 +namespace { +class CollectPragmaMarks : public clang::PPCallbacks { kadircet wrote: > can you nest this inside `clang::clangd` and drop the qualifiers ? Done, had to keep

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

manas updated this revision to Diff 363572. manas added a comment. upgrade cmake-3.21.0 to cmake-3.21.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 Files: clang/utils/analyzer/Dockerfile Index: cl

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

manas added a comment. Fixing another broken dependency packages error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 ___ cfe-commits mailing list cfe-commits

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. @cor3ntin: Sure, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 ___

[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references

Quuxplusone added a comment. @dblaikie wrote: > Not a huge objection - but minor quandry: What's the motivation for this > patch? AIUI, this diagnostic is a PR stunt, similar to Clang's existing `-Wunicode-homoglyph`: test.cpp:3:13: warning: treating Unicode character as identifier charac

[PATCH] D107312: [analyzer] Fix deprecated plistlib functions

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

joerg added a comment. What do you mean with "GCC macros are correct"? Clang is *not* GCC 5 and not 1:1 compatible with GCC 5. Project that have checks like that should arrive in 2010... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107304/new/ h

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 363581. nickdesaulniers marked 2 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reusing existing Diag/Notes, remove test comment, add test for indirect call Repository: rG LLVM Githu

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6026 +depend on optimizations, while providing diagnostics pointing to precise +locations of the call site in the source. + }]; aaron.ballman wrote: > nickdesaulnier

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:783 + else +Diags.Report(DiagID) << CalleeName << D.getMsgStr(); +} nickdesaulniers wrote: > aaron.ballman wrote: > > nickdesaulniers wrote: > > > aaron.ballman wrote: > >

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3816 + +def Error : Attr { + let Spellings = [GCC<"error">]; aaron.ballman wrote: > nickdesaulniers wrote: > > aaron.ballman wrote: > > > I think this should be an inheritable a

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

lunasorcery updated this revision to Diff 363582. lunasorcery added a comment. How does this look? I've got a 'control' test to demonstrate the diagnostic as a child of ignored-qualifiers, as well as a test to demonstrate this diagnostic can be disabled in isolation. CHANGES SINCE LAST ACTION

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

ArcsinX added a comment. In D107304#2920960 , @joerg wrote: > What do you mean with "GCC macros are correct"? Imagine that we have a project and we build it with GCC, we have `compile_commands.json` file which contains all compile command used to build

[clang] 65e9d7e - Improve UBSan documentation

Author: Mitch Phillips Date: 2021-08-02T15:10:21-07:00 New Revision: 65e9d7efb090756e16bbb5ff929efbc795a8b0d4 URL: https://github.com/llvm/llvm-project/commit/65e9d7efb090756e16bbb5ff929efbc795a8b0d4 DIFF: https://github.com/llvm/llvm-project/commit/65e9d7efb090756e16bbb5ff929efbc795a8b0d4.diff

[PATCH] D106908: Improve UBSan documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG65e9d7efb090: Improve UBSan documentation (authored by hctim). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D106908?vs=362138&

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

kbsmith1 abandoned this revision. kbsmith1 added a comment. Doesn't seem to have community support, abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107004/new/ https://reviews.llvm.org/D107004

[clang] b40a2a5 - [clang] Add support for optional flag -fnew-infallible to restrict exception propagation

Author: modimo Date: 2021-08-02T15:45:06-07:00 New Revision: b40a2a533a9dfb8dd5afb1f3b7d277da1e19f235 URL: https://github.com/llvm/llvm-project/commit/b40a2a533a9dfb8dd5afb1f3b7d277da1e19f235 DIFF: https://github.com/llvm/llvm-project/commit/b40a2a533a9dfb8dd5afb1f3b7d277da1e19f235.diff LOG: [

[PATCH] D105225: [clang] Add support for optional flag -fnew-infallible to restrict exception propagation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb40a2a533a9d: [clang] Add support for optional flag -fnew-infallible to restrict exception… (authored by modimo). Herald added a project: clang. Hera

[PATCH] D107261: [clang] [MinGW] Let the last of -mconsole/-mwindows have effect

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107261/new/ https://reviews.llvm.org/D107261 _

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2919775 , @tstellar wrote: > Do we have all the issues fixed in trunk yet or do we need to revert in the > release/13.x branch. All known issues have been fixed on trunk. However, @alexfh said they are going to do

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This allows both sets of definitions to exist on CL 3.0 Repository: rG LLVM Github Monorepo ht

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

airlied added a subscriber: azabaznov. airlied added a comment. @azabaznov is this what you meant? I haven't tested this yet as my clang dev box died, but I'll get to it as soon as I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107318/new/ h

[PATCH] D107141: [Inline-asm] Add semacheck for unsupported constraint

pengfei added a comment. > First I did not say "code doesn't make much sense to me". This is copy form > your description. Oop, my bad understanding. :) > both gcc and icc generated code is not making sense to you. Yes. Unless there's document to specify the behavior clearly. > So instead, yo

[PATCH] D107323: [clang-tidy] Add skip-headers; use skipLocation and setTraversalScope

chh created this revision. Herald added subscribers: kbarton, xazax.hun, nemanjai. chh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. [clang-tidy] Add skip-headers; use skipLocation and setTraversalScope - This depends on http

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363624. AMDChirag added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cp

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 363625. AMDChirag added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cp

[clang] 77ebfba - [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

Author: Chirag Khandelwal Date: 2021-08-03T10:27:47+05:30 New Revision: 77ebfba68b9aa89e9ccbcdf8e285afa0661c8ca4 URL: https://github.com/llvm/llvm-project/commit/77ebfba68b9aa89e9ccbcdf8e285afa0661c8ca4 DIFF: https://github.com/llvm/llvm-project/commit/77ebfba68b9aa89e9ccbcdf8e285afa0661c8ca4.d

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77ebfba68b9a: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0. (authored by AMDChirag). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D43477: [CFG] [analyzer] Add MaterializeTemporaryExpr into the construction context.

lxfind added a comment. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, baloghadamsoftware. Hi! I have a question regarding the implementation of "VisitMaterializeTemporaryExpr". Specifically, I wonder if we should skip visiting

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

thakis added a comment. Any news here? This has been broken for over a day now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-c

[PATCH] D107325: [clang-tidy] Fix command line is too long issue which breaks test on Windows

dougpuob created this revision. Herald added a subscriber: xazax.hun. dougpuob requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Command line is too long with check_clang_tidy.py program on Windows, because the configuration is t

<    1   2