[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. @MaskRay I experience that the failing test clang/test/Index/preamble-reparse-changed-module.m is non-deterministic and currently I cannot reproduce the fail. I added details in D95159 . Are you able to reproduce if you clean your bui

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse accepted this revision. morehouse added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Verifier/operand-bundles.ll:91 + %l = load i32, i32* %ptr + call void @g() [ "type"(metadata !"_ZTSFvE.generalized"), "type"(metadata !"_Z

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7 -#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0 #define LANG_VER_OK ---

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:91 /// sync. void sync() { ReachedEnd |= Children.front()->reachedEnd(); sammccall wrote: > I stared at this for a while and this change makes me think about th

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a subscriber: jmorse. akhuang added a comment. In D106582#2897815 , @dblaikie wrote: > In D106582#2897678 , @akhuang wrote: > >> In D106582#2897599 , @dblaik

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev updated this revision to Diff 360968. kbobyrev added a comment. Add another 7% compared to the patched version: cache Child->peek() in the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://reviews.llvm.org/D106528 Fi

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev updated this revision to Diff 360970. kbobyrev added a comment. Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://reviews.llvm.org/D106528 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360972. dgoldman added a comment. Merge pragmas outside of the DocumentOutline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/Coll

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360977. Meinersbur added a comment. - Introduce types::isDerivedFromC - Print input type in error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 Files:

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); dblaikie wrote: > Is the v

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk updated this revision to Diff 360978. rnk added a comment. - move Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106585/new/ https://reviews.llvm.org/D106585 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-enum-i12

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Because of how large the switch construct would have been, I created a new function `types::isDerivedFromC` together with the other functions. These commonly have default-cases so compilers would not warn when `Types.def` is amended, but `isDerivedFromC` can be found

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360980. dgoldman added a comment. Misc vector changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-too

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. PTAL, now merge outside of DocumentOutline although the algorithm I've used is roughly the same Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 _

[clang] 8322593 - PR51158: Don't emit -Wswitch or -Wcovered-switch-default for empty enums

Author: David Blaikie Date: 2021-07-22T14:51:56-07:00 New Revision: 83225936af317e6bdd7103a8a039c51a29ce9f57 URL: https://github.com/llvm/llvm-project/commit/83225936af317e6bdd7103a8a039c51a29ce9f57 DIFF: https://github.com/llvm/llvm-project/commit/83225936af317e6bdd7103a8a039c51a29ce9f57.diff

[clang] 3e2ad26 - [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

Author: Amy Huang Date: 2021-07-22T14:52:36-07:00 New Revision: 3e2ad26b08a23e786e64e8e47547d25a1b5a7f28 URL: https://github.com/llvm/llvm-project/commit/3e2ad26b08a23e786e64e8e47547d25a1b5a7f28 DIFF: https://github.com/llvm/llvm-project/commit/3e2ad26b08a23e786e64e8e47547d25a1b5a7f28.diff LOG

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ad26b08a2: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); rnk wrote: > dblaikie

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko updated this revision to Diff 361001. ivanmurashko added a comment. The LIT test was added: build] ./bin/llvm-lit -v ../clang/test/SemaCXX/pr51171-crash.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.l

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

craig.topper added a comment. I think this looks good to me. @luismarques or @jrtc27 any further feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 361002. vitalybuka added a comment. fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasa

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh added a comment. Some Android developers and legacy code care less about clang-tidy warnings. Newer developers spend a lot of time to get lint-free new code. So Android source tree has a lot of clang-tidy flags like header-filter, checks, and warnings-as-errors to select checks for different m

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898343 , @vitalybuka wrote: > fix crash weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however exact cmake from bot does Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko updated this revision to Diff 361005. ivanmurashko added a comment. LIT test was updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 Files: clang/lib/Sema/SemaTemplateDeduction.cpp cl

[PATCH] D106611: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit db7efcab7dd9

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 361014. cjdb marked 12 inline comments as done. cjdb added a comment. - applies all of @aaron.ballman's suggested changes - turns warnings into errors and deletes warning group - replaces `interleave` with `join` - properly abandons LF transmuting The only thing

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added a comment. I can't help but feel the assembly syntax for the register pair instructions shouldn't include both registers (perhaps in curly braces). The implicit use of the other register when reading the source is rather ugly, and particularly hard to remember when the RV64 version

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added a comment. Oh, technically none of the clang changes belong in this patch. Those are for the Clang driver and preprocessor, not the MC layer which is purely llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://review

[clang] 96c6349 - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-22T16:20:27-07:00 New Revision: 96c63492cb952431fd9732146663fe227f8c52c1 URL: https://github.com/llvm/llvm-project/commit/96c63492cb952431fd9732146663fe227f8c52c1 DIFF: https://github.com/llvm/llvm-project/commit/96c63492cb952431fd9732146663fe227f8c52c1.diff

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96c63492cb95: [hwasan] Use stack safety analysis. (authored by fmayer, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 481084f - [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

Author: Thomas Lively Date: 2021-07-22T16:31:12-07:00 New Revision: 481084f669e10beb89b2e1a75bc67e7fb8125941 URL: https://github.com/llvm/llvm-project/commit/481084f669e10beb89b2e1a75bc67e7fb8125941 DIFF: https://github.com/llvm/llvm-project/commit/481084f669e10beb89b2e1a75bc67e7fb8125941.diff

[PATCH] D106611: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481084f669e1: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9 (authored by tlively). Repository: rG LLVM Github Monorepo CH

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. One question -- does it have to be a function calling other functions just for the sake of preserving them? Can it be a flat array of pointers to the functions you need to keep arou

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert abandoned this revision. aaronpuchert added a comment. In D101566#2896911 , @aaron.ballman wrote: > Off-by-default warnings are generally discouraged unless there's a very > compelling reason to have them. There are IMO valuable warnings t

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898350 , @vitalybuka wrote: > In D105703#2898343 , @vitalybuka > wrote: > >> fix crash > > weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however >

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman, ast. yonghong-song added a project: debug-info. Herald added a subscriber: jdoerfert. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman, ast. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LL

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. H

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. H

[PATCH] D106619: [Clang][LLVM] generate btf_tag annotations for DIGlobalVariable

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. H

[PATCH] D106620: [Clang][LLVM] generate btf_tag annotations for func parameters

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. H

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

bnbarham added a comment. In D95159#2897941 , @mibintc wrote: > Can you suggest how to find the problem? Thanks a lot. @mibintc the test is reusing the module cache directory and that's causing some issues between runs, sorry about that. You could add a

[clang] e4ed93c - [PowerPC] Implement XL compatible behavior of __compare_and_swap

Author: Kai Luo Date: 2021-07-23T01:16:02Z New Revision: e4ed93cb25acc624a1d32e77d2c63c8c25fddbae URL: https://github.com/llvm/llvm-project/commit/e4ed93cb25acc624a1d32e77d2c63c8c25fddbae DIFF: https://github.com/llvm/llvm-project/commit/e4ed93cb25acc624a1d32e77d2c63c8c25fddbae.diff LOG: [Powe

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ed93cb25ac: [PowerPC] Implement XL compatible behavior of __compare_and_swap (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t kito-cheng wrote: > I guess you want to verify `vfredsum.vs` and `

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t jacquesguan wrote: > kito-cheng wrote: > > I guess you want to ver

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t craig.topper wrote: > jacquesguan wrote: > > kito-cheng wrote: > >

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

hubert.reinterpretcast added a comment. In D106577#2897588 , @aaron.ballman wrote: > In D106577#2897522 , @jyknight > wrote: > >> I'm not sure we should be populating this. >> >> The _value_ is determined by wha

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361079. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/

[PATCH] D95590: [RISCV] Define preprocessor definitions for 'P' extension

Jim updated this revision to Diff 361087. Jim added a comment. Recover it. Split preprocessor definitions part of D95588 to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95590/new/ https://reviews.llvm.org/D

[PATCH] D95589: [RISCV] Support experimental 'P' extension 0.9

Jim updated this revision to Diff 361088. Jim added a comment. Recover it. Split arch version for P extension of D95588 to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95589/new/ https://reviews.llvm.org/D9

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

necipfazil updated this revision to Diff 361091. necipfazil marked 10 inline comments as done. necipfazil added a comment. Fix nits in documentation and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D10590

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. In D95588#2898470 , @jrtc27 wrote: > Oh, technically none of the clang changes belong in this patch. Those are for > the Clang driver and preprocessor, not the MC layer which is purely llvm. I move the clang changes to D95589

<    1   2   3