[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f5b2ea6cd85: [UpdateCCTestChecks] Implement --global-value-regex (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://re

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b0a948a81e6: [UpdateCCTestChecks] Implement --global-hex-value-regex (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D106370: [Analyzer][solver][NFC] Add explanatory comments to trivial eq classes

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

martong added a comment. Here it is: https://reviews.llvm.org/D106370 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106136/new/ https://reviews.llvm.org/D106136 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

anjankgk created this revision. anjankgk added reviewers: hubert.reinterpretcast, cebowleratibm, Whitney. anjankgk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes the changes in the driver that converts the medium code mode

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-bits'.

khchen added a comment. In D106347#2890123 , @jrtc27 wrote: > Why can't we just save target-features itself as a module flag instead of > inventing yet another equivalent encoding? Especially since a long bitfield > is brittle, you can't reorder or remo

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. Or, we can find another symbiotic way. You can make changes the way without painfull part of thinking about IE. And I will prepare the next patch adjusting it. Thus, revisions would be smaller. That's would be easier for you to test all the things before the load.

[clang] 59d2ba2 - [PowerPC] Semachecking for XL compat builtin icbt

Author: Quinn Pham Date: 2021-07-20T11:05:22-05:00 New Revision: 59d2ba2a3de976798a82cfd9d66e426907480ecf URL: https://github.com/llvm/llvm-project/commit/59d2ba2a3de976798a82cfd9d66e426907480ecf DIFF: https://github.com/llvm/llvm-project/commit/59d2ba2a3de976798a82cfd9d66e426907480ecf.diff LO

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59d2ba2a3de9: [PowerPC] Semachecking for XL compat builtin icbt (authored by quinnp, committed by kamaub). Changed prior to commit: https://review

[PATCH] D106375: Thread safety analysis: Mock getter for private mutexes can be undefined

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Usage in an annotation is no odr-use, so I think there needs to be no definition. Upside is that

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

vabridgers added a comment. This change fixed the downstream crash. Thanks for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106361/new/ https://reviews.llvm.org/D106361 ___ cfe-com

[clang] 5b899c2 - [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

Author: Fangrui Song Date: 2021-07-20T09:18:24-07:00 New Revision: 5b899c22f3d28331598b2b5ad244723c9d094064 URL: https://github.com/llvm/llvm-project/commit/5b899c22f3d28331598b2b5ad244723c9d094064 DIFF: https://github.com/llvm/llvm-project/commit/5b899c22f3d28331598b2b5ad244723c9d094064.diff

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b899c22f3d2: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian… (authored by MaskRay). Repository: rG LLVM Github Monor

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:119-131 -Optional RISCVTTIImpl::getMaxVScale() const { - // There is no assumption of the maximum vector length in V specification. - // We use the value specified by users as t

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3816 + +def Error : Attr { + let Spellings = [GCC<"error">]; nickdesaulniers wrote: > aaron.ballman wrote: > > I think this should be an inheritable attribute (same below) so that

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse accepted this revision. jmorse added a comment. In D106084#2887702 , @dblaikie wrote: > It'd be preferable not to split these two cases (current "limited" versus > "ctor" homing) - because they rely on the same assumption, that the whole > progra

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. In D106084#2890541 , @probinson wrote: > @jmorse am I remembering correctly, that we require dllimport-style > annotations, so "limited" actually includes these types even if they aren't > constructed locally? I am vague on the

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 ___

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. lgtm -- thanks! please give a day for other reviewers to add any last minute comments, then i think we can land this. Comment at: clang/lib/Sema/SemaC

[PATCH] D106298: [OpenMP] Creating the `NumTeams` and `ThreadLimit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 360190. josemonsalve2 added a comment. I've fixed all the clang tests. It is also not possible to provide a default for `omp target` because the code relies on a nullptr being returned for generating the right runtime call. Therefore I reverted that cha

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG700d07f8ce6f: ThinLTO: Fix inline assembly references to static functions with CFI (authored by samitolvanen). Repository: rG LLVM Github Monorepo

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 360196. josemonsalve2 added a comment. Forgot to run `git-clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRunti

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360199. RedDocMD added a comment. Retrieving patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360202. RedDocMD added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp clang/li

[clang] e8bc871 - [PowerPC][test] Don't write to srcdir

Author: Fangrui Song Date: 2021-07-20T10:50:11-07:00 New Revision: e8bc871ca2780788ad580bb23ef2621b09e6394b URL: https://github.com/llvm/llvm-project/commit/e8bc871ca2780788ad580bb23ef2621b09e6394b DIFF: https://github.com/llvm/llvm-project/commit/e8bc871ca2780788ad580bb23ef2621b09e6394b.diff

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

MaskRay added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:10 +// RUN: -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8 +// RUN: not %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \ +// RUN: -target-cpu pwr7 2>&1 | File

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

aaron.ballman added a comment. In D104601#2886412 , @Meinersbur wrote: > In D104601#2877855 , @aaron.ballman > wrote: > >> I don't think they'd *add* it, I worry it's already used by their build >> system for r

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea updated this revision to Diff 360208. labrinea added a comment. This revision uses `i512` to pass the asm operands by-value. I've explained in my last comment what would be the challenges had we chosen `[i64 x 8]`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94098/new/ https

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a subscriber: phosek. Ericson2314 added a comment. @phosek would you mind reviewing this one next? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 ___

[clang] 1a762f9 - [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

Author: Victor Huang Date: 2021-07-20T13:06:22-05:00 New Revision: 1a762f93f81640768dc9e9d933780fff32cfa639 URL: https://github.com/llvm/llvm-project/commit/1a762f93f81640768dc9e9d933780fff32cfa639 DIFF: https://github.com/llvm/llvm-project/commit/1a762f93f81640768dc9e9d933780fff32cfa639.diff

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a762f93f816: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL… (authored by NeHuang). Repository: rG LLVM Github Monorep

[clang] c68f247 - [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

Author: Alex Lorenz Date: 2021-07-20T11:11:28-07:00 New Revision: c68f247275eed94a4f4b97ad53b4d599acfd181a URL: https://github.com/llvm/llvm-project/commit/c68f247275eed94a4f4b97ad53b4d599acfd181a DIFF: https://github.com/llvm/llvm-project/commit/c68f247275eed94a4f4b97ad53b4d599acfd181a.diff L

[PATCH] D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68f247275ee: [clang-scan-deps] ignore top-level module dependencies that aren't actually… (authored by arphaman). Herald added a project: clang. Re

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + fhahn wrote: > is there a reason we need to allow 'empty' initialisation? What does it m

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + SaurabhJha wrote: > fhahn wrote: > > is there a reason we need to allow 'empty' initiali

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360218. RedDocMD added a comment. Minimal modelling of destructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. This is a minimal model of destructors in smart-ptr. Other than the need to probably model the destructor of the pointee, is there anything else to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://rev

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

Any chance some of this series of patches could have test coverage included? (like small clang test cases that exercise only a narrow part of the codegen & works with force-opaque-pointers due to these changes?) On Sat, Jul 17, 2021 at 9:48 AM Nikita Popov via cfe-commits < cfe-commits@lists.llvm.

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360222. mibintc added a comment. Partially respond to @aaron.ballman 's review by refactoring a change into a separate commit, but I'll push back on another request, I'll add that reply inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2890469 , @probinson wrote: >> (hence the renaming of "limited" a long time ago to "standalone-debug" to >> create a policy/philosophy around what goes in each category). > > Sorry, what? I thought -fstandalone-debug

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106074/new/ https://reviews.llvm.org/D106074 ___ cfe-commits mailing lis

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc marked an inline comment as done. mibintc added a comment. Question for Aaron Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo &NameInfo, QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified,

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:603 + +long f(); //expected-note {{declared here}} +auto consteval g(auto a) { Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:608 + +auto e = g(f()); /

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo &NameInfo, QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified, - ConstexprSpecKind ConstexprKind, +

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360225. mibintc added a comment. Removed use of auto, and used different capitalization for local var name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 Files: cl

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops! Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106303/new/ https://reviews.llvm.org/D106303 __

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

aaron.ballman added a comment. The changes LGTM, but I'd appreciate additional sign-off from someone with more expertise in this area. @rjmccall, can you take a look to see if it addresses your concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D105926: [PowerPC] Extra test case for LDARX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a7711f33a04: [PowerPC] Extra test case for LDARX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 360235. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/cxx2a-cons

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated aaron.ballman wrote: > Here's an interesting test case: > ``` > #include > > struct S { > virtual void f(); >

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

On Tue, Jul 20, 2021 at 11:52 AM Nikita Popov wrote: > On Tue, Jul 20, 2021 at 8:27 PM David Blaikie wrote: > >> Any chance some of this series of patches could have test coverage >> included? (like small clang test cases that exercise only a narrow part of >> the codegen & works with force-opaq

[clang] a8262a3 - [clang][darwin] add support for Mac Catalyst availability

Author: Alex Lorenz Date: 2021-07-20T12:51:57-07:00 New Revision: a8262a383bc627cef3de78e60bbbedb788157a50 URL: https://github.com/llvm/llvm-project/commit/a8262a383bc627cef3de78e60bbbedb788157a50 DIFF: https://github.com/llvm/llvm-project/commit/a8262a383bc627cef3de78e60bbbedb788157a50.diff L

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8262a383bc6: [clang][darwin] add support for Mac Catalyst availability (authored by arphaman). Herald added a project: clang. Repository: rG LLVM

[clang] ce8024e - [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

Author: Melanie Blower Date: 2021-07-20T16:02:09-04:00 New Revision: ce8024e8ff76e7be8b9ffa1a39d1dc9310bf74c7 URL: https://github.com/llvm/llvm-project/commit/ce8024e8ff76e7be8b9ffa1a39d1dc9310bf74c7 DIFF: https://github.com/llvm/llvm-project/commit/ce8024e8ff76e7be8b9ffa1a39d1dc9310bf74c7.diff

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce8024e8ff76: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Repository: rG LLVM Github Monorepo

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. ZarkoCA requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Remove the previous er

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, gbiv, dblaikie, cor3ntin. Herald added a reviewer: george.burgess.iv. Herald added subscribers: usaxena95, kadircet. cjdb requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a

[clang] 05a6d74 - [clang] NFC, move DarwinSDKInfo to lib/Basic

Author: Alex Lorenz Date: 2021-07-20T13:22:48-07:00 New Revision: 05a6d74c4845221907e25971937242b72489ef55 URL: https://github.com/llvm/llvm-project/commit/05a6d74c4845221907e25971937242b72489ef55 DIFF: https://github.com/llvm/llvm-project/commit/05a6d74c4845221907e25971937242b72489ef55.diff L

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

MaskRay added a comment. This breaks `clang/test/Index/preamble-reparse-changed-module.m` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 ___ cfe-commits mailing

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:437 + diag::pp_pragma_include_instead_system_reserved) +<< Filename << 2 << ('{' + Aliases + '}'); + } I wasn't able to work out how to escape braces inside diagn

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

MaskRay added inline comments. Comment at: clang/test/Preprocessor/predefined-flteval-macro.c:332 +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64 -fsyntax-only %s +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64-unknown-linux -fsyntax-only %s +#ifndef FE

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891545 , @MaskRay wrote: > This breaks `clang/test/Index/preamble-reparse-changed-module.m` > > http://45.33.8.238/linux/51638/step_7.txt I saw this fail on console when i do "ninja check-clang" but when I run each ste

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

morehouse added a comment. This patch broke the sanitizer-windows bot: https://lab.llvm.org/buildbot/#/builders/127/builds/14257 Failed Tests (4): cfi-devirt-lld-thinlto-x86_64 :: anon-namespace.cpp cfi-devirt-lld-thinlto-x86_64 :: simple-pass.cpp cfi-standalone-lld-thinlto-x86_64

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

MaskRay added a comment. In D93769#2891549 , @mibintc wrote: > In D93769#2891545 , @MaskRay wrote: > >> This breaks `clang/test/Index/preamble-reparse-changed-module.m` >> >> http://45.33.8.238/linux/51638/step_7.tx

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/test/Preprocessor/predefined-flteval-macro.c:332 +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64 -fsyntax-only %s +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64-unknown-linux -fsyntax-only %s +#ifndef FE

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. In D104058#2891551 , @morehouse wrote: > This patch broke the sanitizer-windows bot: > https://lab.llvm.org/buildbot/#/builders/127/builds/14257 > > Failed Tests (4): > cfi-devirt-lld-thinlto-x86_64 :: anon-namespace.

[clang] d48ad35 - Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly"

Author: Melanie Blower Date: 2021-07-20T16:40:55-04:00 New Revision: d48ad358b1e84698f1070cec50c7586b78865265 URL: https://github.com/llvm/llvm-project/commit/d48ad358b1e84698f1070cec50c7586b78865265 DIFF: https://github.com/llvm/llvm-project/commit/d48ad358b1e84698f1070cec50c7586b78865265.diff

[clang] 3434ac9 - [PowerPC] Store, load, move from and to registers related builtins

Author: Albion Fung Date: 2021-07-20T15:46:14-05:00 New Revision: 3434ac9e39026ae19870a3356d744649dc85777e URL: https://github.com/llvm/llvm-project/commit/3434ac9e39026ae19870a3356d744649dc85777e DIFF: https://github.com/llvm/llvm-project/commit/3434ac9e39026ae19870a3356d744649dc85777e.diff L

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3434ac9e3902: [PowerPC] Store, load, move from and to registers related builtins (authored by Conanap). Changed prior to commit: https://reviews.l

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360261. quinnp added a comment. Rebasing to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Ta

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

zoecarver added a comment. Can't wait to start using this! (Note: this is not a full review, just some thoughts.) Do you have a test case where // private: header one *exists* // private: header two #include<__header_one.h> // public: header three #include<__header_two.h> I t

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 360267. samitolvanen added a comment. Folded in D106392 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files: llvm/lib/Tra

[PATCH] D106340: [Clang][RISCV] Add half-precision FP for vle16/vse16.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106340/new/ https://reviews.llvm.org/D106340 ___

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

efriedma added a comment. Can you add a helper somewhere for the `BT->getKind() == BuiltinType::SveBool ? getLangOpts().ArmSveVectorBits / getCharWidth() : getLangOpts().ArmSveVectorBits)` pattern? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891552 , @MaskRay wrote: > In D93769#2891549 , @mibintc wrote: > >> In D93769#2891545 , @MaskRay wrote: >> >>> This breaks `clang/test/Ind

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 360269. whisperity marked 4 inline comments as done. whisperity added a comment. - Remove orthogonal/half-baked changes. - Fix a mistake in the logic changing only a temporary state. - Add a missing //FIXME//. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity added a comment. In D106361#2890458 , @aaron.ballman wrote: > The rename from `CommonType` to `CoreType` could probably be done as a > separate NFC to make the review a bit easier, if we decide that's a good > terminology switch. I'm not cer

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:476-477 + +QualType NewCoreType = CoreType; +NewCoreType.addFastQualifiers(Quals.getFastQualifiers()); +NewCoreType.getQualifiers().addQualifiers(Qu

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. @dblaikie, does https://bugs.llvm.org/show_bug.cgi?id=18733#c17 change anything about your position? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101566/new/ https://reviews.llvm.org/D101566

[clang] 808bbc2 - [clang][darwin] Add support for macOS -> Mac Catalyst

Author: Alex Lorenz Date: 2021-07-20T14:25:33-07:00 New Revision: 808bbc2c47028ff5c2cc0bf7a1d5140adec9202a URL: https://github.com/llvm/llvm-project/commit/808bbc2c47028ff5c2cc0bf7a1d5140adec9202a DIFF: https://github.com/llvm/llvm-project/commit/808bbc2c47028ff5c2cc0bf7a1d5140adec9202a.diff L

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG808bbc2c4702: [clang][darwin] Add support for macOS -> Mac Catalyst (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2891647 , @zoecarver wrote: > Can't wait to start using this! (Note: this is not a full review, just some > thoughts.) > > Do you have a test case where > > // private: header one > *exists* > > // private: heade

[clang] 1d68eca - [clang] fix oops: enable implicit moves in MSVC compatibility mode

Author: Matheus Izvekov Date: 2021-07-20T23:32:05+02:00 New Revision: 1d68ecafd6ad9ba8857c78e567abbc58810329c1 URL: https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1 DIFF: https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1.dif

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d68ecafd6ad: [clang] fix oops: enable implicit moves in MSVC compatibility mode (authored by mizvekov). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 360278. Meinersbur added a comment. - Rename -felide-unnecessary-whitespace to -fminimize-whitespace - Add -fminimize-whitespace only vlid to be used to docs - Adjust some code comments - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

rnk added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias); nickdes

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added a comment. In D101566#2891699 , @aaronpuchert wrote: > @dblaikie, does https://bugs.llvm.org/show_bug.cgi?id=18733#c17 or the > following comment change anything about your position? No, not really. This patch is still conflating two th

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap added a comment. I'm aware of the getting target issue; the fix will be up soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 ___ cfe-commits mailing

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2831746 , @dblaikie wrote: > but for my money this seems pretty problematic - will make quoted text in > compiler diagnostics weird/difficult to read, etc. FWIW, clang has a line length limit of 4096

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra created this revision. tra added reviewers: nikic, fhahn. Herald added subscribers: bixia, hiraditya, yaxunl. tra requested review of this revision. Herald added projects: clang, LLVM. Attempt to enable MemCpyOpt unconditionally in D104801 uncovered the fact

[clang] 5f55761 - [clang] Fix the capitalization of the DarwinSDKInfoTest unittest filename to avoid case-sensitive FS build errors

Author: Alex Lorenz Date: 2021-07-20T14:53:08-07:00 New Revision: 5f557616c6b13adbe244b3583459a926628c3466 URL: https://github.com/llvm/llvm-project/commit/5f557616c6b13adbe244b3583459a926628c3466 DIFF: https://github.com/llvm/llvm-project/commit/5f557616c6b13adbe244b3583459a926628c3466.diff L

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM (one comment in the test), although it'd be good to get someone more involved in lib/CodeGen to take a quick look / sign off (ideally someone that knows the use case for `!srcloc`

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > aaron.ballman wrote: > > Here's an interesting test case: > > ``` > > #include > > > > struct

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra updated this revision to Diff 360293. tra edited the summary of this revision. tra added a comment. Fixed the option name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106401/new/ https://reviews.llvm.org/D106401 Files: clang/lib/Driver/Too

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. Here is the proof of correctness of the algorithm using Z3: https://gist.github.com/weirdsmiley/ad6a9dbf3370e96d29f9e90068931d25 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 ___

<    1   2   3   >