[clang] 9cfec72 - [clang] Refactor AST printing tests to share more infrastructure

2021-07-14 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2021-07-14T19:44:18-04:00 New Revision: 9cfec72ffeec242783b70e792c50bd163dcf9dbb URL: https://github.com/llvm/llvm-project/commit/9cfec72ffeec242783b70e792c50bd163dcf9dbb DIFF: https://github.com/llvm/llvm-project/commit/9cfec72ffeec242783b70e792c50bd163dcf9dbb.diff

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-14 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfec72ffeec: [clang] Refactor AST printing tests to share more infrastructure (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-14 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. @dyung I appreciate the help tracking this down! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 ___ cfe-commits mailing list cfe-commit

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

2021-07-14 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:402-403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; break; JDevlieghere wrote: > What's the p

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

2021-07-14 Thread Victor Huang via Phabricator via cfe-commits
NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15081 } + case PPC::BI__builtin_ppc_cmpb: { +llvm::Type *Ty = Ops[0]->getType(); NeHuang wrote: > nemanjai wrote: > > I find it rather sur

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

2021-07-14 Thread Victor Huang via Phabricator via cfe-commits
NeHuang updated this revision to Diff 358761. NeHuang marked 4 inline comments as done. NeHuang added a comment. Address review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 Files

<    1   2   3