[clang] 8fe058d - [clang] Document llvm options controlling pragma unroll

Author: Yaxun (Sam) Liu Date: 2021-07-12T16:42:50-04:00 New Revision: 8fe058dbe49b060c85f490ece2268c32b0fad7c8 URL: https://github.com/llvm/llvm-project/commit/8fe058dbe49b060c85f490ece2268c32b0fad7c8 DIFF: https://github.com/llvm/llvm-project/commit/8fe058dbe49b060c85f490ece2268c32b0fad7c8.dif

[PATCH] D105035: [clang] Document llvm options controlling pragma unroll

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe058dbe49b: [clang] Document llvm options controlling pragma unroll (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks reasonable to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 __

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ https://reviews.llvm.org/D105834 __

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

nemanjai added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \ +// RUN: -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8 Oh, I believe you're missi

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

dblaikie added a comment. Not sure I quite follow - is this an alternative to/replacement for D105662 ? Is the intent to revert D105662 after this (D105835 ) (& some corresponding change to ll

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

MaskRay added a comment. In D105835#2872362 , @dblaikie wrote: > Not sure I quite follow - is this an alternative to/replacement for D105662 > ? Is the intent to revert D105662 > after

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

osandov added a comment. I tested my reproducer and it also fixes it, thanks. Should it be an error to specify `-fno-dwarf-directory-asm` together with `-gdwarf-5`, since that produces incorrect results? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

MaskRay added a comment. In D105835#2872393 , @osandov wrote: > I tested my reproducer and it also fixes it, thanks. Should it be an error to > specify `-fno-dwarf-directory-asm` together with `-gdwarf-5`, since that > produces incorrect results? I tho

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

arichardson added a comment. In D98113#2872080 , @jroelofs wrote: >> compiler-rt depends on a libc, typically newlib, which then depends on your >> compiler > > The builtins should only depend on compiler-provided headers, and not on the > rest of libc.

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

osandov accepted this revision. osandov added a comment. This revision is now accepted and ready to land. That's fair enough. I don't know if I'm qualified to review this, but this I think this is a better solution than my fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2872080 , @jroelofs wrote: >> compiler-rt depends on a libc, typically newlib, which then depends on your >> compiler > > The builtins should only depend on compiler-provided headers, and not on the > rest of libc. Agree

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

dblaikie accepted this revision. dblaikie added a comment. Sure, sounds OK. Please make the corresponding change to llc and revert the other patch after this one & the llc one are done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105835/new/ htt

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358087. ZarkoCA added a comment. - Warning should only apply to members of struct - Re-word warning slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files:

[clang] 51fc742 - [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

Author: Fangrui Song Date: 2021-07-12T15:46:20-07:00 New Revision: 51fc742ce716a09359f4f87ffe3876cb7ff9479d URL: https://github.com/llvm/llvm-project/commit/51fc742ce716a09359f4f87ffe3876cb7ff9479d DIFF: https://github.com/llvm/llvm-project/commit/51fc742ce716a09359f4f87ffe3876cb7ff9479d.diff

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51fc742ce716: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm (authored by MaskRay). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:3003-3010 +} else if (CGM.getTriple().isOSAIX()) + // On AIX, all thread_local vars will have init routines regardless of + // whether they are const-initialized or not. S

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. These 3 are fairly simple, pipes, workgroups and subgroups. Repository: rG LLVM Github Monorepo

[PATCH] D105014: added some example code for llvm::Expected

dblaikie added subscribers: lhames, dblaikie. dblaikie added a comment. +@lhames for context as the author/owner of `llvm::Error` and associated things. Perhaps it'd be handy to have some descriptions of the problems you encountered, @kuhnel, and how you went about trying to resolve them, to hel

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

kkwli0 added a comment. Is the diff from HEAD? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. ping It would be nice if we could get this into clang 13 since the ccache part detects support for `-fnormalize-whitespace` when detecting clang 13+. Probing the compiler for whether it supports `-fnormalize-whitespace` on every run would be prohibitively expensive.

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. It looks like this patch breaks the utils/update_cc_test_checks/check-globals.test on stand-alone builds of clang, because it hard codes lit to lit.py in the llvm source tree. I think it should using the lit passed to -DLLVM_EXTERNAL_LIT= (if that option was specified

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:836 + clang::CharUnits Align = + CGM.getNaturalTypeAlignment(getContext().getSizeType()); + llvm::Value *V; I don't think this alignment is correct. A vin

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfadd.c:13 +// ASM-NOT: warning #include HsiangKai wrote: > craig.topper wrote: > > Do you plan to bring back the ASM check for all tests? > No, I will remove it. Thi

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 __

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb updated this revision to Diff 358127. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102728/new/ https://reviews.llvm.org/D102728 Files: clang/lib/Sema/SemaChe

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

NoQ added a comment. This is amazing, great progress! I added the parent revision because it didn't compile on pre-merge checks otherwise. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:801 +// must be a superset of, but not necessarily equal to ExitOwner

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 358130. kito-cheng added a comment. Changes: - Using RISCVISAInfo in riscv::getRISCVABI - Allow rv32e for -march. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https:/

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. Looks great, thanks for reusing the reusables! Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +} You

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:42 + // keep entries in canonical order of extension. + typedef std::map + OrderedExtensionMap; craig.topper wrote: > Could this be a sorted vector? Would require a good

[clang] cad9b7f - [analyzer] Print time taken to analyze each function

Author: SharmaRithik Date: 2021-07-13T04:52:47Z New Revision: cad9b7f708e2b2d19d7890494980c5e427d6d4ea URL: https://github.com/llvm/llvm-project/commit/cad9b7f708e2b2d19d7890494980c5e427d6d4ea DIFF: https://github.com/llvm/llvm-project/commit/cad9b7f708e2b2d19d7890494980c5e427d6d4ea.diff LOG:

[PATCH] D105565: [analyzer] Print time taken to analyze each function

This revision was automatically updated to reflect the committed changes. Closed by commit rGcad9b7f708e2: [analyzer] Print time taken to analyze each function (authored by RithikSharma). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added inline comments. Comment at: clang/test/Driver/riscv-abi.c:68 -// RUN: %clang -target riscv64-unknown-elf %s -### -o %t.o -march=rv64d -mabi=lp64d 2>&1 \ +// RUN: %clang -target riscv64-unknown-elf %s -### -o %t.o -march=rv64ifd -mabi=lp64d 2>&1 \ // RUN: | Fi

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:3004 +} else if (CGM.getTriple().isOSAIX()) + // On AIX, all thread_local vars will have init routines regardless of + // whether they are const-initialized or not. Since

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

pattop created this revision. Herald added subscribers: steven.zhang, shchenz, nemanjai. pattop requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Musl treats PowerPC SPE as a soft-float target (as the PowerPC SPE ABI is soft-float compatible)

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:69 +def sub_lo : SubRegIndex<32>; +def sub_hi : SubRegIndex<32, 32>; luismarques wrote: > jrtc27 wrote: > > This assumes RV32, and is not clear it applies to register pairs > What

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

nridge added a comment. Will building with this option just prevent linking the clang-tidy checks into clangd, or will it also prevent building them in the first place? In my experience, it's the building that's the primary compile time expense, so if the intention is to address https://github.

[clang] 20176bc - [clang] Refactor AST printing tests to share more infrastructure

Author: Nathan Ridge Date: 2021-07-13T01:48:30-04:00 New Revision: 20176bc7dd3f431db4c3d59b51a9f53d52190c82 URL: https://github.com/llvm/llvm-project/commit/20176bc7dd3f431db4c3d59b51a9f53d52190c82 DIFF: https://github.com/llvm/llvm-project/commit/20176bc7dd3f431db4c3d59b51a9f53d52190c82.diff

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20176bc7dd3f: [clang] Refactor AST printing tests to share more infrastructure (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1

chh added a comment. Sam, the revision summary is updated. Could you review it again? The new summary would clarify a few points: - This --skip-headers is a new feature, not just a transparent run-time saving. It should be used carefully with header-filter and system-headers, and similarly han

[PATCH] D105254: [RISCV] Support machine constraint "S"

kito-cheng added a comment. RISC-V GCC site has update the document for 'S'. https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=18a463bb666cc8f3421589e7641ec617acb84741 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

tstellar created this revision. tstellar added a reviewer: jdenny. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. We want to use LLVM_EXTERNAL_LIT if defined for the %lit substitution. Repository: rG LLVM Github Monorepo https://r

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. In D104714#2872826 , @tstellar wrote: > It looks like this patch breaks the > utils/update_cc_test_checks/check-globals.test on stand-alone builds of > clang, because it hard codes lit to lit.py in the llvm source tree. I thin

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:69 +def sub_lo : SubRegIndex<32>; +def sub_hi : SubRegIndex<32, 32>; Jim wrote: > luismarques wrote: > > jrtc27 wrote: > > > This assumes RV32, and is not clear it applies to regi

<    1   2