[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103871: [Clang][RISCV] Implement vsseg.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103871/new/ https://reviews.llvm.org/D103871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103872: [Clang][RISCV] Implement vssseg.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103872/new/ https://reviews.llvm.org/D103872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. could you add tests showing the impact of using `[[likely]]` and `[[unlikely]]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 __

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff updated this revision to Diff 357857. sepavloff added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/strictf

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 updated this revision to Diff 357862. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 added a comment. Handle system input files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.llv

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

teemperor added a comment. @v.g.vassilev For LLDB you need to change the `TypeSystemClang::SetExternalSource` function to this (it just moves the `setHasExternalLexicalStorage` one line up. You can just add that change and the compilation fix to this commit. void TypeSystemClang::SetExternal

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong added a comment. Uhh, what the hell happened with the `Stack`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105692/new/ https://reviews.llvm.org/D105692 ___ cfe-commits mailing list cfe-commits@

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:310 +struct DeclFilter { + DeclFilter(ClangTidyContext &Ctx, SourceManager &SM) + : Context(Ctx), Sources(SM) { chh wrote: > sammccall wrote: > > Ctx is ultimately unuse

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske updated this revision to Diff 357872. balazske added a comment. Herald added a subscriber: mgorny. Added the unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637 Files: clang/include/clan

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske updated this revision to Diff 357873. balazske added a comment. Removed "garbage" from end of test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637 Files: clang/include/clang/StaticAnalyze

[clang] 41ce5ec - [PowerPC] Remove unnecessary 64-bit guards from altivec.h

Author: Nemanja Ivanovic Date: 2021-07-12T04:59:00-05:00 New Revision: 41ce5ec5f6f3a03d70e0010e3a140fe129800637 URL: https://github.com/llvm/llvm-project/commit/41ce5ec5f6f3a03d70e0010e3a140fe129800637 DIFF: https://github.com/llvm/llvm-project/commit/41ce5ec5f6f3a03d70e0010e3a140fe129800637.di

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer created this revision. Herald added subscribers: ormris, hiraditya. fmayer updated this revision to Diff 357514. fmayer added a comment. fmayer edited the summary of this revision. fmayer updated this revision to Diff 357544. fmayer edited the summary of this revision. fmayer updated this re

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 added a comment. I run a quick benchmark where an empty TU is configured with an explicitly built PCH that imports Cocoa. Dependency scanning without minimization takes 226 ms, with this patch 303 ms and 325 ms when padding minimized files to the original size. Since we'll eventual

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357832. Conanap marked 6 inline comments as done. Conanap added a comment. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jr

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357833. Conanap added a comment. Removed unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[clang] de59f56 - [OpenMP] Support OpenMP 5.1 attributes

Author: Aaron Ballman Date: 2021-07-12T06:51:19-04:00 New Revision: de59f564400de1b0fe30ae07f3c800562a025e27 URL: https://github.com/llvm/llvm-project/commit/de59f564400de1b0fe30ae07f3c800562a025e27 DIFF: https://github.com/llvm/llvm-project/commit/de59f564400de1b0fe30ae07f3c800562a025e27.diff

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews, everyone. I've commit in de59f564400de1b0fe30ae07f3c800562a025e27 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/ne

[PATCH] D105629: [TSan] Add SystemZ support

iii updated this revision to Diff 357889. iii added a comment. - Fix a local variable naming issue CheckAndProtect(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105629/new/ https://reviews.llvm.org/D105629 Files: clang/lib/Driver/ToolChains/L

[PATCH] D105629: [TSan] Add SystemZ support

iii marked an inline comment as done. iii added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:781 + // TSAN. Act as if we ran out of memory. + internal_munmap(res, sz); + errno = errno_ENOMEM; dvyukov wrote: > TS

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia added a comment. In D105526#2863386 , @airlied wrote: > I've dropped the __SPIR__ change in the base header until things are resolved > for library SPIR users to disable extension defines. Makes sense! But this is not a full diff again. Would

[PATCH] D105601: opencl-c.h: reorder atomic operations

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105601/new/ https://reviews.llvm.org/D105601 _

[PATCH] D105601: opencl-c.h: reorder atomic operations

Anastasia added subscribers: azabaznov, svenvh. Anastasia added a comment. CC to @svenvh and @azabaznov. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105601/new/ https://reviews.llvm.org/D105601 ___ cfe

[clang] 84e4296 - [PowerPC] Fix rounding mode for vec_round in altivec.h

Author: Nemanja Ivanovic Date: 2021-07-12T06:11:27-05:00 New Revision: 84e429693fe5f225fe68b9dd54043cddb9c4cd4c URL: https://github.com/llvm/llvm-project/commit/84e429693fe5f225fe68b9dd54043cddb9c4cd4c DIFF: https://github.com/llvm/llvm-project/commit/84e429693fe5f225fe68b9dd54043cddb9c4cd4c.di

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104915/new/ https://reviews.llvm.org/D104915 _

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen added a comment. Sorry for the late response. Looks like you have handled the issues and more in your patch. Thank you for fixing my blunders. 😄 Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:727 TARGET_BUILTIN(__bmma_m8n8k128_ld_c, "vi*iC*UiIi", "", AN

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103401/new/ https://reviews.llvm.org/D103401 _

[clang] f042e0a - Fix the Clang documentation builder; NFC.

Author: Aaron Ballman Date: 2021-07-12T07:59:18-04:00 New Revision: f042e0a0f88391c611002e55afec5c37604b5819 URL: https://github.com/llvm/llvm-project/commit/f042e0a0f88391c611002e55afec5c37604b5819 DIFF: https://github.com/llvm/llvm-project/commit/f042e0a0f88391c611002e55afec5c37604b5819.diff

[PATCH] D104975: Implement P1949

cor3ntin added inline comments. Comment at: clang/lib/Lex/UnicodeCharSets.h:229 +static const llvm::sys::UnicodeCharRange XIDContinueRanges[] = { +{0x0030, 0x0039}, {0x005F, 0x005F}, {0x00B7, 0x00B7}, +{0x0300, 0x036F}, {0x0387, 0x0387}, {0x0483, 0x0487},

[clang] 8747234 - Partially implement P1401R5 (Narrowing contextual conversions to bool)

Author: Corentin Jabot Date: 2021-07-12T08:06:27-04:00 New Revision: 8747234032c9c6270a6198ab3cca14ce2bd18721 URL: https://github.com/llvm/llvm-project/commit/8747234032c9c6270a6198ab3cca14ce2bd18721 DIFF: https://github.com/llvm/llvm-project/commit/8747234032c9c6270a6198ab3cca14ce2bd18721.diff

[PATCH] D105127: Implement P1401R5

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the patch! I've committed on your behalf in 8747234032c9c6270a6198ab3cca14ce2bd18721 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

steffenlarsen requested changes to this revision. steffenlarsen added a comment. This revision now requires changes to proceed. Good stuff! Thanks for adding this and adjusting the test generator. I have requested some minor changes, though nothing critical. Are the test failures related to thes

[PATCH] D105629: [TSan] Add SystemZ support

iii marked an inline comment as done. iii added a comment. Regarding the openmp test failures: I tried check-openmp on a x86_64 machine, and they occur both with and without this patch series, so must be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

ymandel added a comment. Given that you're removing a declaration, consider using `tooling::getAssociatedRange` https://source.corp.google.com/piper///depot/google3/third_party/llvm/llvm-project/clang/include/clang/Tooling/Transformer/SourceCode.h;l=44 It does have a different semantics than t

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:87 +static bool hasStdClassWithName(const CXXRecordDecl *RD, +const ArrayRef &Names) { + if (!RD || !RD->getDeclContext()->isStdNamespace()) -

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev added a comment. In D104918#2870582 , @teemperor wrote: > @v.g.vassilev For LLDB you need to change the > `TypeSystemClang::SetExternalSource` function to this (it just moves the > `setHasExternalLexicalStorage` one line up. You can just ad

[clang-tools-extra] 187e050 - [clang-tidy] performance-unnecessary-copy-initialization: Disable structured bindings.

Author: Felix Berger Date: 2021-07-12T09:55:27-04:00 New Revision: 187e050b33bbee1ef210c83f5595c283ba671909 URL: https://github.com/llvm/llvm-project/commit/187e050b33bbee1ef210c83f5595c283ba671909 DIFF: https://github.com/llvm/llvm-project/commit/187e050b33bbee1ef210c83f5595c283ba671909.diff

[PATCH] D105727: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rG187e050b33bb: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 1af97c9 - [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

Author: Abbas Sabra Date: 2021-07-12T17:06:07+03:00 New Revision: 1af97c9d0b02002586473b4b9845b0c390504a27 URL: https://github.com/llvm/llvm-project/commit/1af97c9d0b02002586473b4b9845b0c390504a27 DIFF: https://github.com/llvm/llvm-project/commit/1af97c9d0b02002586473b4b9845b0c390504a27.diff L

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1af97c9d0b02: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda… (authored by AbbasSabra, committed by vsavchenko). R

[clang] e49985b - Remove unused parameter from parseMSInlineAsm.

Author: Simon Tatham Date: 2021-07-12T15:07:03+01:00 New Revision: e49985bb6065d4f5ea69fe578e326ec6d43a6b24 URL: https://github.com/llvm/llvm-project/commit/e49985bb6065d4f5ea69fe578e326ec6d43a6b24 DIFF: https://github.com/llvm/llvm-project/commit/e49985bb6065d4f5ea69fe578e326ec6d43a6b24.diff

[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe49985bb6065: Remove unused parameter from parseMSInlineAsm. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 357942. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2870291 , @jdoerfert wrote: > First: > Do I assume right this this feature was simply disabled without any plan to: > > - inform the authors (me) > - update the documentation > - re-enable support eventually or provide alt

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske updated this revision to Diff 357947. balazske added a comment. Using the new symbol "uninterestingness" feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 Files: clang/lib/StaticAnalyzer

[clang] 11b47c1 - Reland "[clang-repl] Implement partial translation units and error recovery."

Author: Vassil Vassilev Date: 2021-07-12T15:21:22Z New Revision: 11b47c103a36371576711cae1f7527c26f78efb5 URL: https://github.com/llvm/llvm-project/commit/11b47c103a36371576711cae1f7527c26f78efb5 DIFF: https://github.com/llvm/llvm-project/commit/11b47c103a36371576711cae1f7527c26f78efb5.diff LO

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, steakhal, martong, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity,

[PATCH] D105254: [RISCV] Support machine constraint "S"

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. In D105254#2852489 , @luismarques wrote: > Makes sense. Let's wait for the GCC Bugzilla feedback. With 'S' now documented on the GNU side,

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this re

[clang] 2071ce9 - [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces

Author: Bardia Mahjour Date: 2021-07-12T11:41:16-04:00 New Revision: 2071ce9d4559d444a065d78248a7381bf121b766 URL: https://github.com/llvm/llvm-project/commit/2071ce9d4559d444a065d78248a7381bf121b766 DIFF: https://github.com/llvm/llvm-project/commit/2071ce9d4559d444a065d78248a7381bf121b766.diff

[PATCH] D105666: [PowerPC] [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces that compare vector bool types with vector signed types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2071ce9d4559: [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces (authored by bmahjour). Repository: rG LLVM Github Monorepo

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. Ping @aaron.ballman and @ldionne Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105439/new/ https://reviews.llvm.org/D105439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] ef49d92 - [PowerPC] Implement trap and conversion builtins for XL compatibility

Author: Albion Fung Date: 2021-07-12T11:04:17-05:00 New Revision: ef49d925e2a788248473b847a0e51835c6ca854f URL: https://github.com/llvm/llvm-project/commit/ef49d925e2a788248473b847a0e51835c6ca854f DIFF: https://github.com/llvm/llvm-project/commit/ef49d925e2a788248473b847a0e51835c6ca854f.diff L

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGef49d925e2a7: [PowerPC] Implement trap and conversion builtins for XL compatibility (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1036

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Quuxplusone added a comment. Given that the goal is to get `include-what-you-use` to stop suggesting that users `#include <__detail/fooimpl.h>` when what they want is spelled ``, I think what's desired here (if anything) would be a pragma targeted at `include-what-you-use` (and other tools). Ba

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2871429 , @Quuxplusone wrote: > Given that the goal is to get `include-what-you-use` to stop suggesting that > users `#include <__detail/fooimpl.h>` when what they want is spelled > ``, I think what's desired here (if a

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko I've updated the summary. I hope, I addressed your question. Currently, this patch has some issues and may not fully reflect the summary. I'll update it soon(not without your suggestions). Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:97 + else() +set(temp_path "${temp_path}/${current_segment}") + endif() phosek wrote: > This isn't set before so it should be

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx

Ericson2314 updated this revision to Diff 357969. Ericson2314 added a comment. Herald added projects: clang, libc++, libc++abi, libunwind. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Herald added a reviewer: libc++abi. Herald added a reviewer: libunwind.

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or simila

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 357970. jamieschmeiser added a comment. Respond to review comments: Update to tests to create common LINUX/AIX portions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/

[PATCH] D104381: [analyzer] Added a test case for PR46264

ASDenysPetrov added a comment. @NoQ Just a ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104381/new/ https://reviews.llvm.org/D104381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added a comment. In D105254#2871278 , @luismarques wrote: > In D105254#2852489 , @luismarques > wrote: > >> Makes sense. Let's wait for the GCC Bugzilla feedback. > > With 'S' now documented on the GNU s

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively updated this revision to Diff 357983. tlively added a comment. - Check types of splats as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105755/new/ https://reviews.llvm.org/D105755 Files: clang/include/clang/Basic/BuiltinsWebAssembl

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc", "simd128"

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbabfc63b1be: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cbabfc6 - [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

Author: Thomas Lively Date: 2021-07-12T10:32:18-07:00 New Revision: cbabfc63b1be274316552d3eaaf7b2ad88c4c073 URL: https://github.com/llvm/llvm-project/commit/cbabfc63b1be274316552d3eaaf7b2ad88c4c073 DIFF: https://github.com/llvm/llvm-project/commit/cbabfc63b1be274316552d3eaaf7b2ad88c4c073.diff

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff updated this revision to Diff 357988. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/D103395 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/consta

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx updated this revision to Diff 357993. flx added a comment. Make offset operations safer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105734/new/ https://reviews.llvm.org/D105734 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCo

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx marked 2 inline comments as done. flx added a comment. Thanks for the review! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:51 + if (Tok && !Invalid) { +size_t Offset = std::strcspn(TextAfter, "\n"); +auto PastNewLine = Stm

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:50 + size_t Offset = std::strcspn(TextAfter, "\n"); + return Loc.getLocWithOff

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 358004. quinnp added a comment. Adding tests for each of the features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think this looks good, thanks for fixing this! I believe there should be a few more tests for all the corner cases we can run into here (those tests can all be just Python AP

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 358005. airlied added a comment. full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/Headers/opencl-c.h ==

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

lei added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3278 + StringRef DiagArg = "") { + if (!S.Context.getTargetInfo().hasFeature(FeatureToCheck)) { +if (!DiagArg.empty()) { may I suggest early exit instead? ```

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc", "simd128"

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx updated this revision to Diff 358010. flx marked 2 inline comments as done. flx added a comment. Invert end of string logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105734/new/ https://reviews.llvm.org/D105734 Files: clang-tools-extra/

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide builtins for compatibility with the XL compiler. Thi

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai added a comment. The testing is a bit overkill. A single test case with run lines for `-mcpu=pwr7-10` and a single prefix for each should suffice. For each prefix, just check for `+/-` for all the features you expect. The triples can be randomly distributed across the 4 run lines. And

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

MaskRay created this revision. MaskRay added reviewers: debug-info, dblaikie, osandov. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While GNU as only allows the directory form of the .file directive for DWARF v5, the integrated p

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4790 +llvm::Value *Arg2 = llvm::ConstantExpr::getBitCast( +cast(dtor.getCallee()), FpTy); +CGF.EmitNounwindRuntimeCall(AtExit, {Arg1, Arg2}); The functio

[clang] 798fe3c - [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

Author: Steven Wan Date: 2021-07-12T15:31:15-04:00 New Revision: 798fe3c774a1af75c8735933ded749fa62f39594 URL: https://github.com/llvm/llvm-project/commit/798fe3c774a1af75c8735933ded749fa62f39594 DIFF: https://github.com/llvm/llvm-project/commit/798fe3c774a1af75c8735933ded749fa62f39594.diff LO

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

This revision was automatically updated to reflect the committed changes. Closed by commit rG798fe3c774a1: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105635/new/

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added a comment. Need to merge with https://reviews.llvm.org/D105501 changes once approved for pwr9 (or later processor) only sema checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 __

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra updated this revision to Diff 358041. tra marked an inline comment as done. tra edited the summary of this revision. tra added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105384/new/ https://reviews.llvm.

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-multiply.ll:9 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \ +; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefix=CHECK-64 + amyk wrote: > Does it ma

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx-mma.py:35-38 +def make_mma_ops(geoms, types_a, types_b, types_c, types_d, b1ops=None): ops = [] + if b1ops is None: +b1ops = [""] steffenlarsen wrote: > Default initializers that us

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358043. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. Why do you want to ship the builtins as part of your sysroot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 ___ cfe-commits mailing li

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. > compiler-rt depends on a libc, typically newlib, which then depends on your > compiler The builtins should only depend on compiler-provided headers, and not on the rest of libc. Agreed re: the rest of compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 358049. quinnp added a comment. Addressing review comments. Using an early exit for SemaFeatureCheck and combining the 3 test cases into 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://revi

[clang-tools-extra] 0ec8120 - [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

Author: Felix Berger Date: 2021-07-12T16:23:04-04:00 New Revision: 0ec812023b43992810499b04222348fdbdb41ef2 URL: https://github.com/llvm/llvm-project/commit/0ec812023b43992810499b04222348fdbdb41ef2 DIFF: https://github.com/llvm/llvm-project/commit/0ec812023b43992810499b04222348fdbdb41ef2.diff

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ec812023b43: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10573

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. The analysis should not run at -O0. Otherwise, LGTM. What kind of code size improvement do you see? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

clayborg requested changes to this revision. clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1305 + + // If a function has an auto return type we need to find the defintion since + // that will have the deduced return typ

[PATCH] D105365: [Lexer] Fix bug in `makeFileCharRange` called on split tokens.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105365/new/ https://reviews.llvm.org/D105365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

  1   2   >