[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 357608. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D105727: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured bindings.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, gribozavr2. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Structured bindings can currently trigger the check an

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

vitalybuka added a subscriber: kcc. vitalybuka added a comment. Why do we need this? I thought the plan to have instrumentation with better callbacks which will be small and close to efficiency to inlined instrumentation. In this case we will make it default and can avoid another frontend switc

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 357612. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

lebedev.ri created this revision. lebedev.ri added reviewers: rjmccall, erichkeane, rsmith, thakis, jdoerfert. lebedev.ri added a project: LLVM. Herald added a subscriber: jfb. lebedev.ri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We h

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 357613. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 357616. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 357625. NeHuang marked 3 inline comments as done. NeHuang added a comment. Address review comments on test case and remove change not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://re

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3356 + case PPC::BI__builtin_ppc_maddld: +return SemaFeatureCheck(*this, TheCall, "power9-vector", +diag::err_ppc_builtin_only_on_pwr9); amyk wrote: > This

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 357626. NeHuang added a comment. Remove entry check in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D95182: [clang][Fuchsia] Turn on Relative VTables for Fuchsia

leonardchan abandoned this revision. leonardchan added a comment. Abandoned since D102374 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95182/new/ https://reviews.llvm.org/D95182 _

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx created this revision. flx added reviewers: ymandel, aaron.ballman, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. When deleting the copy assignment statement because copied

[PATCH] D105737: Implement delimited escape sequences.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a proposed C++ paper (P2290R1) that has not been accepted yet \x{} \u{} and \o{} are accepted in all languages mode in characters

[PATCH] D105707: [HIP] Move std headers after device malloc/free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccb10266f56b: [HIP] Move std headers after device malloc/free (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-comm

[clang] ccb1026 - [HIP] Move std headers after device malloc/free

Author: Aaron En Ye Shi Date: 2021-07-09T21:20:16Z New Revision: ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc URL: https://github.com/llvm/llvm-project/commit/ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc DIFF: https://github.com/llvm/llvm-project/commit/ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc.diff LO

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 357642. Ericson2314 added a comment. Rebased, fixed unintersting conflicts, organized docs better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/t

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 357644. quinnp added a comment. Parameterizing the ppc builtin arch sema error. This change is made assuming that the SemaFeatureCheck will be used by other builtins in the future. SemaFeatureCheck is commented to avoid an unused function error when building

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

erichkeane added a comment. This seems logical to me. The comment needs some love, so I made my best suggestion. Comment at: clang/lib/CodeGen/CGExpr.cpp:1855 +// If this is a simple volatile store to a null pointer (and said null +// pointre is not defined), then we

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

lebedev.ri updated this revision to Diff 357648. lebedev.ri marked 2 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. In D105728#2868281 , @erichkeane wrote: > This seems logical to me. The comment nee

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Give this a bit for other reviewers (it is afterall friday afternoon in the US:)), but this seems like an improvement to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

jdoerfert added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif estewart08 wrote: > JonChesterfield wrote: > > jdoerfert wrote: > > > That seems to be fundamentally broken

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff created this revision. dschuff added a reviewer: azakai. Herald added subscribers: sunfish, hiraditya, jgravelle-google, sbc100. dschuff requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added projects: clang, LLVM. This fix goes along with d1a96e906

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff added a reviewer: sbc100. dschuff added a comment. This fix should go in ASAP (or else we should revert d1a96e906cc03a95cfd41a1f22bdda92651250c7 ) to fix the mismatch between LLVM and clang. Repository: rG LLVM Git

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

kripken added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:175 +if (T.isOSEmscripten()) + resetDataLayout("e-m:e-p:32:32-i64:64-f128:64-n32:64-S128-ni:1"); +else Should this not be resetDataLayout("e-m:e-p:64:64-i64:64-f128:64-

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff updated this revision to Diff 357665. dschuff added a comment. - fix wasm64 copypasta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105749/new/ https://reviews.llvm.org/D105749 Files: clang/lib/Basic/Targets/WebAssembly.h llvm/lib/Targ

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:175 +if (T.isOSEmscripten()) + resetDataLayout("e-m:e-p:32:32-i64:64-f128:64-n32:64-S128-ni:1"); +else kripken wrote: > Should this not be > > resetDataLayout("e-m:e-p:

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif jdoerfert wrote: > estewart08 wrote: > > JonChesterfield wrote: > > > jdoerfert wrote: > > > > That se

[clang] ac02baa - WebAssembly: Update datalayout to match fp128 ABI change

Author: Derek Schuff Date: 2021-07-09T16:51:36-07:00 New Revision: ac02baab48c2ff512e40140e2fe6845d2b6a636f URL: https://github.com/llvm/llvm-project/commit/ac02baab48c2ff512e40140e2fe6845d2b6a636f DIFF: https://github.com/llvm/llvm-project/commit/ac02baab48c2ff512e40140e2fe6845d2b6a636f.diff

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac02baab48c2: WebAssembly: Update datalayout to match fp128 ABI change (authored by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. LDARX and LWARX sometimes gets optimized out by the compiler when it i

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357680. Conanap added a comment. Update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/built

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

sunfish added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/varargs.ll:5 -target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" -target triple = "wasm32-unknown-unknown" +target triple = "wasm32-unknown-emscripten" It appears this change means t

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357681. Conanap added a comment. Added modifier to $1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/bu

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357684. Conanap added a comment. Fixed more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/b

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535 - def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">, - Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>; } Just curious, compiler optimizes the

[clang] e522010 - [WebAssembly] Custom combines for f64x2.promote_low_f32x4

Author: Thomas Lively Date: 2021-07-09T18:59:29-07:00 New Revision: e5220104d0708e02f2faaacc091189fb3e47e30c URL: https://github.com/llvm/llvm-project/commit/e5220104d0708e02f2faaacc091189fb3e47e30c DIFF: https://github.com/llvm/llvm-project/commit/e5220104d0708e02f2faaacc091189fb3e47e30c.diff

[PATCH] D105675: [WebAssembly] Custom combines for f64x2.promote_low_f32x4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5220104d070: [WebAssembly] Custom combines for f64x2.promote_low_f32x4 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

nemanjai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535 - def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">, - Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>; } lkail wrote: > Just curious, compi

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlfp16intrin.h:74 +static __inline__ __m256h __DEFAULT_FN_ATTRS256 _mm256_abs_ph(__m256h __A) { + return (__m256h)_mm256_and_epi32(_mm256_set1_epi32(0x7FFF7FFF), (__m256i)__A); +} craig.topper w

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma added a comment. The part I'm confused about is that you're forcing it to use "*r". At the IR level, LLVM handles something like `call void asm sideeffect "#$0", "r"([8 x i64] %c)` fine. You'll have to do a bit of work to teach clang to emit that, but it shouldn't be that hard. I th

<    1   2