[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 356838. ychen marked 2 inline comments as done. ychen added a comment. - Move `raw frame` description to `Switched-Resume` section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.or

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2859237 , @ChuanqiXu wrote: > In D97915#2848816 , @ychen wrote: > >>> Thanks for clarifying. Let's solve the semantics problem first. >>> With the introduction about 'raw frame', I t

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

NoQ added a comment. WDYT about the following format: Equality constraints: reg_$0 == reg_$1 == reg_$2 Disequality constraints: reg_$0 != reg_$3, != reg_$4 Comma is a bit hard to notice but otherwise kinda nicely readable? Repository: rG LLVM Github Monorep

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Microsoft STL currently has some issues with P2266 . We disable it for now in that mode, but we might come back la

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai added a comment. Can you please add a test for this similar to `clang/test/Driver/ppc-pcrel.cpp` and other similar tests? Also, I imagine this will produce some warnings from the back end since the back end doesn't know what these target features mean. Can you please see what happens w

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

mizvekov updated this revision to Diff 356844. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105518/new/ https://reviews.llvm.org/D105518 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/lib/Sema/SemaStmt.cpp

[clang] f2d5fce - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-07T02:54:55+02:00 New Revision: f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 URL: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 DIFF: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365.dif

[PATCH] D105380: [clang] fixes named return of variables with dependent alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2d5fce86e81: [clang] fixes named return of variables with dependent alignment (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105380/n

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. @aaron.ballman I created a DR for the option of temporarily disabling the effects of this change under "-fms-compatibility". https://reviews.llvm.org/D105518 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2860916 , @ychen wrote: > In D97915#2859237 , @ChuanqiXu wrote: > >> In D97915#2848816 , @ychen wrote: >> Thanks for clarifying. Let

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

vsapsai added a comment. This problem shouldn't happen based on module-level name hashing but for some reason it is happening. If I'm not mistaken, InMemoryModuleCache uses .pcm file name as the key. But that file name should contain a hash part that is based on the modulemap path. But framewor

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2860984 , @ChuanqiXu wrote: > In D97915#2860916 , @ychen wrote: > >> In D97915#2859237 , @ChuanqiXu >> wrote: >> >>> In D97915#2848816

[PATCH] D105526: opencl-c.h: some CL3.0 compat bits

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. This is some of the easier pieces of making the opencl-c.h header CL 3.0 compatible. Repository:

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham added a comment. In D105328#2861028 , @vsapsai wrote: > This problem shouldn't happen based on module-level name hashing but for some > reason it is happening. If I'm not mistaken, InMemoryModuleCache uses .pcm > file name as the key. But that

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham updated this revision to Diff 356861. bnbarham added a comment. Updated the test comment with the actual cause (ie. `Top` being recompiled and inserted, not `M`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105328/new/ https://reviews.l

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar created this revision. tstellar added reviewers: dim, MaskRay. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105527 Files: clang/tools/libclang/CMakeLists.tx

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. I tried to keep this simple and only add the Linux support for now. There seem to be some subtle differences of how different operating systems handle export lists and linker scripts, and I wasn't confident about how to make this work on those systems. Repository:

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 356864. TaoPan added a comment. Update dependent D99487 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: llvm/lib/CodeGen/AsmPr

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:425 + Features["isa207"] = llvm::StringSwitch(CPU) + .Case("pwr9", true) Will it be better if name to `isa2_07`, `isa3_0` to make it less confusing? Besides, in

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

This revision was automatically updated to reflect the committed changes. Closed by commit rG593bf9b4ded3: [Clang][RISCV] Implement vlseg and vlsegff. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2861036 , @ychen wrote: > In D97915#2860984 , @ChuanqiXu wrote: > >> In D97915#2860916 , @ychen wrote: >> >>> In D97915#2859237

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 356874. TaoPan added a comment. git rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/C

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:489 DeclRefs[ND].push_back( -SymbolRef{SM.getFileLoc(Loc), Roles, ASTNode.Parent}); +SymbolRef{SM.getFileLoc(Loc), Roles, getRefContainer(ASTNode.Parent)}); // Don

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction See https://bugs.llvm.org/show_bug.cgi?id=50797#c6

hokein created this revision. hokein added a reviewer: dgoldman. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105533 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/Sema/typo-correction-no-hang.c I

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} What does this do? A hard-coded list cannot catch up with the real dynamic symbol list.

<    1   2