[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

2021-07-05 Thread Queen Dela Cruz via Phabricator via cfe-commits
qdelacru created this revision. qdelacru added a reviewer: aaron.ballman. qdelacru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When there is unknown type in a struct in code compiled with -Wcast-align, the compiler crashes due to clang

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

2021-07-05 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/stack-folding-fp-avx512fp16vl-fma.ll:193-194 +define <8 x half> @stack_fold_fmsub123ph(<8 x half> %a0, <8 x half> %a1, <8 x half> %a2) { + ;check-label: stack_fold_fmsub123ph: + ;check: vfmsub213ph {{-?[0-9

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

2021-07-05 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 356585. pengfei added a comment. Fix the capitalization mismatch in tests. Thanks Sanjay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105268/new/ https://reviews.llvm.org/D105268 Files: clang/include/clang

[clang] 7d10dd6 - [PowerPC] Implament Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Albion Fung via cfe-commits
Author: Albion Fung Date: 2021-07-05T21:35:41-05:00 New Revision: 7d10dd60ce126a6a0a29aa1f3948f596bd6e4fb0 URL: https://github.com/llvm/llvm-project/commit/7d10dd60ce126a6a0a29aa1f3948f596bd6e4fb0 DIFF: https://github.com/llvm/llvm-project/commit/7d10dd60ce126a6a0a29aa1f3948f596bd6e4fb0.diff L

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Albion Fung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7d10dd60ce12: [PowerPC] Implament Load and Reserve and Store Conditional Builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D105236?vs=356562&id=356590#toc Repository:

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

2021-07-05 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 356589. chh edited the summary of this revision. chh added a comment. No more change to or derivation from MatchFinder, but override two member functions in MultiplexConsumer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llv

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

2021-07-05 Thread Queen Dela Cruz via Phabricator via cfe-commits
qdelacru updated this revision to Diff 356591. qdelacru added a comment. Fix format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://reviews.llvm.org/D105451 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-cast-align.c Index: clang/test/Sema/warn-cast

[clang] 203b48c - [PowerPC] Removed a test case meant for a later patch

2021-07-05 Thread Albion Fung via cfe-commits
Author: Albion Fung Date: 2021-07-05T22:31:17-05:00 New Revision: 203b48c71a0db835bd0d6869311578dbd7cc8b71 URL: https://github.com/llvm/llvm-project/commit/203b48c71a0db835bd0d6869311578dbd7cc8b71 DIFF: https://github.com/llvm/llvm-project/commit/203b48c71a0db835bd0d6869311578dbd7cc8b71.diff L

[PATCH] D105454: Removed accidentally added file

2021-07-05 Thread Albion Fung via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203b48c71a0d: [PowerPC] Removed a test case meant for a later patch (authored by Conanap). Herald added a project: clang. Herald added a subscriber:

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Albion Fung via Phabricator via cfe-commits
Conanap added a comment. In D105236#2858909 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/50465/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Hi! I accidentally included a test case meant fo

[PATCH] D105436: [analyzer][solver] Use all sources of constraints

2021-07-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. such passes @ much LLVM > Performance measurements also show the we are within the same margins. Great! I'd expect massive constraint solver improvements to actually make performance //better// bec

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: dblaikie. nridge requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105457 Files: clang/unittests/AST/ASTPrint.h clang

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

2021-07-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:218-219 + + if (isStdOstreamOperatorCall(Call)) +return true; + When you're doing `evalCall` you're responsible for modeling *all* aspects of the call. One does no

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. This is the refactor patch discussed in https://reviews.llvm.org/D104619#2846262. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 ___ c

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

2021-07-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 356604. nridge added a comment. Rebase on top of refactor patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp clang/unittest

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

2021-07-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D104619#2846262 , @dblaikie wrote: > If there's already some duplication, perhaps a pre-patch to generalize that > functionality, then using that functionality in this patch? I posted the patch to generalize the AST printing t

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

2021-07-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:159 +// indexed, we walk further up because Ref::Container should always be +// an indexed symbol. +const Decl *getRefContainer(const Decl *Enclosing, can you also add

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 356605. nridge added a comment. Move a piece of Decl-specific code into DeclPrinterTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 Files: clang/unittests/AS

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

2021-07-05 Thread Raul Tambre via Phabricator via cfe-commits
tambre added inline comments. Comment at: clang/test/SemaCXX/cxx2a-lambda-decltype-this.cpp:1-4 +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -emit-llvm-only %s +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -fdelayed-template-parsing %s +// RUN: %clang_cc1 -std=c

<    1   2