[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen marked 5 inline comments as done. ychen added a comment. In D97915#2829581 , @ChuanqiXu wrote: > A remained question. > > - what's the semantics if user specified their allocation/deallocation > functions? > > Previously, we discussed for the ::oper

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 353567. ychen marked an inline comment as done. ychen added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBui

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 353570. MyDeveloperDay added a comment. - Add release note - Add default Column Limit of 0 for default Json Style (add unit test to ensure column limits can still be used) - this minimises the differences between what Notepad++'s JSON Format plugin

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:284 +- Basic Support has been adding for Formatting .json files (with very limited options) + curdeius wrote: > Maybe instead of putt

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. Hi @kiranchandramohan How do I restart the build? It says I don't have permission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 ___

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

kiranchandramohan added a comment. It could be because you are not the author. Can you commandeer the patch (option available in the Add Action menu below)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. In D93373#2832533 , @kiranchandramohan wrote: > It could be because you are not the author. Can you commandeer the patch > (option available in the Add Action menu below)? Just did that. Still the same error: You do not hav

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2815386 , @probinson wrote: >>> 0x002a: DW_TAG_variable >>> DW_AT_name ("oldname") >>> DW_AT_type (0x003f "int") >>> DW_AT_external (tru

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

kiranchandramohan added a comment. Can you rebase and update the patch? It seems to have built for the latest revision (Harbormaster completed remote builds in B110336 : Diff 353548). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 353579. AMDChirag added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp clang/test/

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. Oh great! That triggered it! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:151 + Optional VisitNonLocLazyCompoundVal(nonloc::LazyCompoundVal LCV) { +return Visit(LCV.getRegion()); + } NoQ wrote: > vsav

[clang] d7227a5 - [clang][Analyzer] Track null stream argument in alpha.unix.Stream .

Author: Balázs Kéri Date: 2021-06-22T11:16:56+02:00 New Revision: d7227a5bc718940fa9bf90ba443e1dff6ded68cc URL: https://github.com/llvm/llvm-project/commit/d7227a5bc718940fa9bf90ba443e1dff6ded68cc DIFF: https://github.com/llvm/llvm-project/commit/d7227a5bc718940fa9bf90ba443e1dff6ded68cc.diff L

[PATCH] D104640: [clang][Analyzer] Track null stream argument in alpha.unix.Stream .

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7227a5bc718: [clang][Analyzer] Track null stream argument in alpha.unix.Stream . (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10464

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6a91ee6: [Clang][OpenMP] Monotonic does not apply to SIMD (authored by huntergr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/ https://rev

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. @kiranchandramohan It failed again. Apparently, it automatically attempted to add a patch D93105 which is already merged. I removed that patch as dependency before (edit related revisions), but it seems to have been added again. Am I

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:280-281 + if (c < 0 && c != INT_MIN && d < 0) { +clang_analyzer_eval((c + d) == -1); // expected-warning{{FALSE}} +clang_analyzer_eval((c + d) == 0); // expected-warning{{FALSE}} +cl

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. In D97915#2832446 , @ychen wrote: > In D97915#2829581 , @ChuanqiXu wrote: > >> A remained question. >> >> - what's the semantics if user specified their allocation/deallocation >> functio

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2832286 , @jdoerfert wrote: > In D102107#2824581 , @ABataev wrote: > >> In D102107#2823706 , @jdoerfert >> wrote: >> >>> In D102107#28

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 353596. mizvekov added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. - Update more tests. - Slightly improved error recovery: deduce type for non-three-way relational comparisons. Repository: rG LLVM Github Monorep

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2569296 , @jonpa wrote: >> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >> single hook will make the patch slightly smaller. > > Patch updated to call the new hook testFPKind() and make it tak

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Userbla added a comment. I applied this fix locally to a branch based off llvm 11.x and the `FormatTest.FormatsTypedefEnum` test now fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ https://reviews.llvm.org/D44609 _

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

Userbla added a comment. I applied this fix locally to a branch based off llvm 11.x and the `FormatTest.FormatsTypedefEnum` test now fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 _

[PATCH] D104649: Thread safety analysis: Rename parameters of ThreadSafetyAnalyzer::intersectAndWarn (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the terminology cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104649/new/ https://reviews.llvm.org/D1

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

JonChesterfield added a comment. Looks very similar to the cuda workaround. Any chance we can #include to use the same code in both? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 __

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaron.ballman added a comment. I think the CI failure (libarcher.races::lock-unrelated.c) is not related to this patch but is a tsan thing, but you may want to double-check that just in case. I think this looks reasonable, but I'd like to hear from @delesley before landing.

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 marked an inline comment as done. predator5047 added a comment. @hans Can you commit on my behalf? Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https:/

[PATCH] D104550: [analyzer] Implement getType for SVal

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:151 + Optional VisitNonLocLazyCompoundVal(nonloc::LazyCompoundVal LCV) { +return Visit(LCV.getRegion()); + } vsavchenko wrote: > NoQ wrote: > > vsavchenko wrote: > > > NoQ wrote:

[PATCH] D104550: [analyzer] Implement getType for SVal

Szelethus added a comment. This is not an urgent, but still a very important issue: `SVal` is likely among the first things a new developer in the analyzer sees. Its common around the university here that some students barely halfway through their BSc are given smaller tasks, like the implement

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

Szelethus added a comment. Ping. The main question with this patch really is whether we want TableGen at all or not, as for what we generate precisely and how we'd utilize it is a discussion for later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko added a comment. In D104550#2832983 , @Szelethus wrote: > This is not an urgent, but still a very important issue: `SVal` is likely > among the first things a new developer in the analyzer sees. Its common > around the university here that so

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

Userbla added a comment. In D93938#2832825 , @Userbla wrote: > I applied this fix locally to a branch based off llvm 11.x and the > `FormatTest.FormatsTypedefEnum` test now fails. So this test is failing: TEST_F(FormatTest, LongEnum) { FormatStyle

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

vsavchenko added a comment. In D104439#2832984 , @Szelethus wrote: > Ping. > > The main question with this patch really is whether we want TableGen at all > or not, as for what we generate precisely and how we'd utilize it is a > discussion for later.

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

Userbla added a comment. In D93938#2833045 , @Userbla wrote: > It fails in the second case because we don't respect the 'AfterEnum = true' > and collapse the brace. It appears there is buggy logic in the > `remainingLineCharCount` stuff which others have

[PATCH] D104550: [analyzer] Implement getType for SVal

Szelethus added a comment. In D104550#2833020 , @vsavchenko wrote: > Do you think that "for the sake of incremental approach"-like comment can > help? A `TODO:` should be good enough for now. I see this is still a moving target. Repository: rG LLVM

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression...

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

daltenty updated this revision to Diff 353636. daltenty added a comment. - clang-format - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 Files: clang/include/clang/Basic/LangOptions.de

[clang] a83ce95 - [clang] Remove unused capture in closure

Author: Graham Hunter Date: 2021-06-22T15:09:39+01:00 New Revision: a83ce95b097689f4ebd2c3b45c0778d0b6946d00 URL: https://github.com/llvm/llvm-project/commit/a83ce95b097689f4ebd2c3b45c0778d0b6946d00 DIFF: https://github.com/llvm/llvm-project/commit/a83ce95b097689f4ebd2c3b45c0778d0b6946d00.diff

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

yaxunl requested changes to this revision. yaxunl added a comment. This revision now requires changes to proceed. can we add a test to https://github.com/llvm/llvm-project/blob/main/clang/test/Headers/hip-header.hip just to make sure these functions are still available for HIP? Thanks. Reposit

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. This option is already supported by update_test_checks.py, but

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

ashi1 added a comment. Looks OK to me, please address other review comments. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 ___ cfe-commits mailing lis

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 __

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

This revision was automatically updated to reflect the committed changes. Closed by commit rG68d133a3e8c9: [OpenMP] Simplify GPU memory globalization (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D97680?vs=347097&id=353650#toc Repository: rG LLVM Github Monorepo C

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

vsavchenko updated this revision to Diff 353649. vsavchenko added a comment. Restore behavior for nullptr declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 Files: clang/include/clang/StaticAn

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added a comment. In D104505#2831811 , @tra wrote: > In D104505#2831644 , @yaxunl wrote: > >> However, this does cause source level incompatibilities, i.e. CUDA code that >> passes nvcc does not pass clang.

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 353651. mizvekov added a comment. - Add one more test case. - Formating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/include/clang/Basic/OpenCLOptions.h:80 +return Opts.OpenCLCPlusPlus || Opts.OpenCLVersion == 200 || + (Opts.OpenCLVersion

[PATCH] D104716: [analyzer] Fix assertion failure on code with transparent unions

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added inline comments. Comment at: clang/test/Parser/cxx-template-argument.cpp:28 +(void)(&t==p);// expected-error {{use '> ='}} +(void)(&t>=p);// expected-error {{use '> >'}} expected-error {{ordered comparison of function pointers}} +(void)(&t>>=p)

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

kadircet updated this revision to Diff 353658. kadircet marked an inline comment as done. kadircet added a comment. - Also handle ObjcCategoryImplDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104540/new/ https://reviews.llvm.org/D104540 Files

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918 + // from the index, we reduce the noise in all the other completion scopes. + if (llvm::isa(&ND)) +return false; dgoldman wrote: > Seems like we should also ignore O

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. >> Since you use `== ' '` twice, `remainingLineCharCount` will count only >> consecutive spaces, right? >> But you want to count other characters, no? >> So, IIUC, the condition you want is `rF[wI] != '\n' && !(rF[wI] == ' ' && >> rF[wI - 1] == ' ')` (mind the n

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

Quuxplusone added a comment. > There isn't any wording on it or anything, yet, but we must jump the gun here > and just do away with it pronto. I think "must" is the wrong word here. "Might as well"? Anyway, I agree with this general idea, FWLIW. Comment at: clang/lib/Sema/S

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11815 +if (IsError) + return Opc != BO_Cmp ? Context.getLogicalOperationType() : QualType(); + } Quuxplusone wrote: > Peanut gallery says: Is `QualType()` the right "placeholder" to

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

aprantl accepted this revision. aprantl added a comment. Block copy helpers don't have any source code associated with them, so as long as they are described by a DISubprogram, the exact format of it most likely does not matter. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1957

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:2144 CGM); // This is necessary to avoid inheriting the previous line number. + StartFunction(GlobalDecl(), ReturnTy, Fn, FI, args); Same here — th

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

ldionne abandoned this revision. ldionne added a comment. Herald added a project: clang-tools-extra. Revisiting this, I don't think we need to move forward with this. Let's just carry our downstream patch until we don't need it anymore (which should be soon ish), and leave upstream Clang as it i

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks a lot for fixing this and sorry Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101899/new/ https://reviews.llvm.org/D101899 ___

[clang] 03d7e61 - [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes

Author: Joseph Huber Date: 2021-06-22T12:38:10-04:00 New Revision: 03d7e61c87eb94083d22ff55cf30c0a378ab6824 URL: https://github.com/llvm/llvm-project/commit/03d7e61c87eb94083d22ff55cf30c0a378ab6824 DIFF: https://github.com/llvm/llvm-project/commit/03d7e61c87eb94083d22ff55cf30c0a378ab6824.diff

[PATCH] D102824: [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03d7e61c87eb: [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes (authored by jhuber6). Herald added subscribers: cfe-commits, ormris.

[clang] 78d404a - [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

Author: Alexandru Octavian Butiu Date: 2021-06-22T18:40:16+02:00 New Revision: 78d404a11dd33c8349fd9b6ef5876d523c457f0e URL: https://github.com/llvm/llvm-project/commit/78d404a11dd33c8349fd9b6ef5876d523c457f0e DIFF: https://github.com/llvm/llvm-project/commit/78d404a11dd33c8349fd9b6ef5876d523c4

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d404a11dd3: [clang][c++20] Fix false warning for unused private fields when a class has… (authored by Alexandru Octavian Butiu

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added a comment. In D102186#2832900 , @predator5047 wrote: > @hans Can you commit on my behalf? > Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Sure! Pushed as https://github.com/llvm/llvm-project/commit/78d404a11dd33c8349

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

This revision was automatically updated to reflect the committed changes. Closed by commit rG7adf713a5e22: [libc++] Change forward_list::swap to use propagate_on_container_swap for… (authored by airglow923, committed by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f53d791 - Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

Author: Fangrui Song Date: 2021-06-22T09:55:20-07:00 New Revision: f53d791520d85c5404381ff3ad92cb918256029d URL: https://github.com/llvm/llvm-project/commit/f53d791520d85c5404381ff3ad92cb918256029d DIFF: https://github.com/llvm/llvm-project/commit/f53d791520d85c5404381ff3ad92cb918256029d.diff

[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf53d791520d8: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in… (authored by MaskRay). Repository: rG LLVM Github Mon

[PATCH] D102507: [HIP] Support in device code

ldionne added a comment. In D102507#2830688 , @yaxunl wrote: > In D102507#2792087 , @rsmith wrote: > >> @ldionne How should we go about establishing whether libc++ would be >> prepared to officially support CUDA?

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

This revision was automatically updated to reflect the committed changes. Closed by commit rG4474958d3a97: ThinLTO: Fix inline assembly references to static functions with CFI (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 353705. ellis added a comment. Correctly link the runtime symbol for Mach-O. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options

[PATCH] D104505: [HIP] Defer operator overloading errors

tra added a comment. In D104505#2833271 , @yaxunl wrote: > Such host/device overloading resolution induced issue is not limited to > device functions calling host functions. It does not change the fact that the code in the test above is invalid, regard

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 353709. RedDocMD added a comment. Logic for handling special cases, when both are unique_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/Stati

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 353716. quinnp marked 2 inline comments as done. quinnp added a comment. Fixing the 32bit AIX run line in the testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 353719. mibintc added a comment. Herald added subscribers: jdoerfert, hiraditya. This patch addresses almost all the review comments, not yet sure about @aaron.ballman 's question about CoreOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353721. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Addressed comments: - Removed redundant `elseif` and CHECK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.l

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc created this revision. mibintc added a reviewer: aaron.ballman. mibintc added a project: clang. Herald added subscribers: kerbowa, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. mibintc requested review of this revision. Herald added a subscriber: aheejin. In the

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779 CmdArgs.push_back("-mabi=vec-extabi"); +else if (A->getOption().getID() == options::OPT_mabi_EQ_vec_default) + CmdArgs.push_back("-mabi=

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

vsavchenko added a comment. Looks like a solid start! Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + + bool addTransition = false; + ProgramStateRef State = C.getState(); nit: variable names should be capitalized C

[clang] 9480162 - Improve clang -Wframe-larger-than= diagnostic

Author: Fangrui Song Date: 2021-06-22T11:20:49-07:00 New Revision: 948016228fdfb647ad7bcc978fde173504e3df82 URL: https://github.com/llvm/llvm-project/commit/948016228fdfb647ad7bcc978fde173504e3df82 DIFF: https://github.com/llvm/llvm-project/commit/948016228fdfb647ad7bcc978fde173504e3df82.diff

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added a comment. In D104505#2833746 , @tra wrote: > In D104505#2833271 , @yaxunl wrote: > >> Such host/device overloading resolution induced issue is not limited to >> device functions calling host functio

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI H

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484 __

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak updated this revision to Diff 353729. ahatanak marked 2 inline comments as done. ahatanak added a comment. Delete comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/ https://reviews.llvm.org/D104082 Files: clang/lib/Code

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 ___

[clang] f4c06bc - [CodeGen] Don't create fake FunctionDecls when generating block/byref

Author: Akira Hatanaka Date: 2021-06-22T11:42:53-07:00 New Revision: f4c06bcb67a1eba13a7f164961586dddaf8ebd5f URL: https://github.com/llvm/llvm-project/commit/f4c06bcb67a1eba13a7f164961586dddaf8ebd5f DIFF: https://github.com/llvm/llvm-project/commit/f4c06bcb67a1eba13a7f164961586dddaf8ebd5f.diff

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c06bcb67a1: [CodeGen] Don't create fake FunctionDecls when generating block/byref (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

thakis added a comment. Looks like this breaks check-llvm on mac, see http://45.33.8.238/mac/32814/summary.html Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://re

[clang] bc768aa - [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

Author: Joseph Huber Date: 2021-06-22T15:10:19-04:00 New Revision: bc768aac2e4ebc3613f1e5601b15f663a6385044 URL: https://github.com/llvm/llvm-project/commit/bc768aac2e4ebc3613f1e5601b15f663a6385044 DIFF: https://github.com/llvm/llvm-project/commit/bc768aac2e4ebc3613f1e5601b15f663a6385044.diff

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc768aac2e4e: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102940/new/ htt

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

nickdesaulniers added a comment. In D104342#2831738 , @dblaikie wrote: >> In D104342#2831717 , @dblaikie >> wrote: >> >>> Probably worth at least writing up the risk/instability in the docs for the >>> warning (

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

JonChesterfield added a comment. Looks like the __OPENMP_AMDGCN__ guard is sound to me, but can't really argue against having more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 __

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353748. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. - Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI ---

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" Why not use `--implicit-check-not`?

[clang] 64cf5eb - [clang-format] Add new LambdaBodyIndentation option

Author: Vitali Lovich Date: 2021-06-22T21:46:16+02:00 New Revision: 64cf5eba06bd4f81954253b1e7a10be6fe92403e URL: https://github.com/llvm/llvm-project/commit/64cf5eba06bd4f81954253b1e7a10be6fe92403e DIFF: https://github.com/llvm/llvm-project/commit/64cf5eba06bd4f81954253b1e7a10be6fe92403e.diff

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cf5eba06bd: [clang-format] Add new LambdaBodyIndentation option (authored by vlovich, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D102706?vs=347152&id=353753#to

[PATCH] D104664: [PowerPC][NFC] Clean up builtin sema checks

NeHuang accepted this revision. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Please give it some time (~24hrs) before commit to wait for the other reviewers' comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. In D104342#2834119 , @nickdesaulniers wrote: > In D104342#2831738 , @dblaikie > wrote: > >>> In D104342#2831717

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. @HazardyKnusperkeks thank you for the accept, if there are no objections from @curdeius , @krasimir and @sammccall I'd like to proceed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://r

[clang] 7942ebd - [clang] Add cc1 option for dumping layout for all complete types

Author: David Tenty Date: 2021-06-22T16:27:26-04:00 New Revision: 7942ebdf01b35fae240cd8a0550a3da9f03615c4 URL: https://github.com/llvm/llvm-project/commit/7942ebdf01b35fae240cd8a0550a3da9f03615c4 DIFF: https://github.com/llvm/llvm-project/commit/7942ebdf01b35fae240cd8a0550a3da9f03615c4.diff L

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

This revision was automatically updated to reflect the committed changes. Closed by commit rG7942ebdf01b3: [clang] Add cc1 option for dumping layout for all complete types (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/n

  1   2   >