[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

MaskRay updated this revision to Diff 353510. MaskRay added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104667/new/ https://reviews.llvm.org/D104667 Files: clang/test/Misc/backend-resource-limit-diagnostics.cl clang/test/Mi

[PATCH] D104664: [PowerPC][NFC] Clean up builtin sema checks

lei updated this revision to Diff 353515. lei added a comment. remove extra ";" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104664/new/ https://reviews.llvm.org/D104664 Files: clang/lib/Sema/SemaChecking.cpp Index: clang/lib/Sema/SemaCheckin

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2831746 , @dblaikie wrote: > This is probably more @aaron.ballman 's wheelhouse, but for my money this > seems pretty problematic - will make quoted text in compiler diagnostics > weird/difficult to read, etc. It

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. Some bikeshedding: Calls to `AvoidConcat` could be avoided by always inserting a space between tokens at the cost of making the output larger. In the current form, the flag could also be named `-fminimize-whitespace`. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

dblaikie added a comment. One of the concerns I'd have, for instance (have you done some broad testing of these patches on sizable code bases?) is that it wouldn't surprise me if clang had some scalability bugs/issues with very long source lines - so it might be necessary to introduce some (arb

[PATCH] D104619: [clang] [WIP] Fix for https://bugs.llvm.org/show_bug.cgi?id=50774

dblaikie added a comment. This'll need a test case & does the change pass all existing tests? Also, the patch description could use more detail - it can refer to the bug for more context, but there should be enough detail in the patch title/description to understand the general purpose, etc. (an

[PATCH] D104619: [clang] [WIP] Fix for https://bugs.llvm.org/show_bug.cgi?id=50774

nridge added a comment. Thanks for having a look! In D104619#2831953 , @dblaikie wrote: > This'll need a test case Definitely. Do you have a suggestion for what test suite that should go into? I had a quick look but couldn't find anything that obviousl

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay updated this revision to Diff 353519. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Mention the one-time exception for .profraw compatibility Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D104619: [clang] [WIP] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

dblaikie added a comment. In D104619#2831956 , @nridge wrote: > Thanks for having a look! > > In D104619#2831953 , @dblaikie > wrote: > >> This'll need a test case > > Definitely. Do you have a suggestion for wha

[PATCH] D104677: [OpenMP] Apply fix for isnan, isinf and isinfinite for amdgcn.

estewart08 created this revision. Herald added subscribers: guansong, yaxunl. estewart08 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This fixes issues with various return types(bool/int) and

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1411 +if ((LHS.From() < 0 && RHS.From() < 0)) { + llvm::APSInt CrucialPoint = Tmin - LHS.From(); + if (RHS.Includes(CrucialPoint)) { vsavchenko wrote:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1395 + + if (Min > Max) { +// This implies that an overflow has occured as either boundary would have vsavchenko wrote: > I commented on this part previously, y

[PATCH] D104677: [OpenMP] Apply fix for isnan, isinf and isinfinite for amdgcn.

estewart08 updated this revision to Diff 353527. estewart08 added a comment. Attempt to use clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 Files: clang/lib/Headers/__clang_hip_cmath.h c

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Word on the grapevine is that the committee recently had an unanimous vote on eliminating relational function pointer comparisons. There isn't any word

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing updated this revision to Diff 353536. tianqing added a comment. Fix lint comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/X86.cpp clang/lib/Driver/Tool

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

tianqing marked an inline comment as done. tianqing added inline comments. Comment at: clang/include/clang/Driver/Options.td:3214 -def mgeneral_regs_only : Flag<["-"], "mgeneral-regs-only">, Group, - HelpText<"Generate code which only uses the general purpose registers (AArc

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/test/Analysis/constant-folding.c:280-281 + if (c < 0 && c != INT_MIN && d < 0) { +clang_analyzer_eval((c + d) == -1); // expected-warning{{FALSE}} +clang_analyzer_eval((c + d) == 0); // expected-warning{{FALSE}} +clang_a

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 353548. AMDChirag added a comment. Rebased to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp cla

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, glad AMD GPUs are catching up on the math header support now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://revi

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#2824581 , @ABataev wrote: > In D102107#2823706 , @jdoerfert > wrote: > >> In D102107#2821976 , @ABataev >> wrote: >> >>> We used th

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/test/Analysis/constant-folding.c:280-281 + if (c < 0 && c != INT_MIN && d < 0) { +clang_analyzer_eval((c + d) == -1); // expected-warning{{FALSE}} +clang_analyzer_eval((c + d) == 0); // expected-warning{{FALSE}} +clang_a

[PATCH] D104640: [clang][Analyzer] Track null stream argument in alpha.unix.Stream .

balazske added a comment. Thanks for the quick accept. The goal is to make this checker non-alpha. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:838 + auto R = std::make_unique( + BT_FileNull, "Stream pointer might be NULL.", N); + if (Strea

<    1   2