[clang] b88eb85 - [clang] use correct builtin type for defaulted comparison analyzer

2021-06-16 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2021-06-17T02:08:31+02:00 New Revision: b88eb855b53184161ad1ea0eea1962100941cf0b URL: https://github.com/llvm/llvm-project/commit/b88eb855b53184161ad1ea0eea1962100941cf0b DIFF: https://github.com/llvm/llvm-project/commit/b88eb855b53184161ad1ea0eea1962100941cf0b.dif

[PATCH] D103760: [clang] use correct builtin type for defaulted comparison analyzer

2021-06-16 Thread Matheus Izvekov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb88eb855b531: [clang] use correct builtin type for defaulted comparison analyzer (authored by mizvekov). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

2021-06-16 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh added a comment. Friendly ping reviewers. Now this change can pass all clang-tidy tests. Please feel free to comment and/or add other reviewers. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

2021-06-16 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 352617. ychen marked 3 inline comments as done. ychen added a comment. - Remove AlignedAllocator & AlignedDeallocator. - Use 'OverAllocateFrame' - Get rid of `if (HasAlignArg)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

2021-06-16 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:743-744 +CGM.getIntrinsic(llvm::Intrinsic::coro_align, SizeTy)); +auto *AlignedUpAddr = EmitBuiltinAlignTo(AlignedAllocateCall, CoroAlign, + S.getAli

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-16 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing updated this revision to Diff 352616. tianqing added a comment. Respect order of options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103943/new/ https://reviews.llvm.org/D103943 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/X86.cpp clang/lib/Dri

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

2021-06-16 Thread Wang Tianqing via Phabricator via cfe-commits
tianqing added a comment. In D103943#2812638 , @RKSimon wrote: > I don't know much about target feature inheritance - does this guarantee that > the entire sse/avx/avx512 level chain is correctly disabled? setFeatureEnabled queries ImpliedFeatures to di

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-06-16 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D102107#2821976 , @ABataev wrote: > We used this kind of codegen initially but later found out that it causes a > large overhead when gathering pointers into a record. What about hybrid > scheme where the first args are pas

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-16 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD updated this revision to Diff 352621. RedDocMD added a comment. Added more info to the TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/include/clang/StaticAnalyzer/Core/PathSe

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-16 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:3 +// RUN: -analyzer-checker=core,cplusplus.Move,alpha.cplusplus.SmartPtr\ +// RUN: -analyzer-config cplusplus.SmartPtrModeling:ModelSmartPtrDer

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

2021-06-16 Thread Deep Majumder via Phabricator via cfe-commits
RedDocMD added a comment. I would suppose that constructor calls are properly handled. (ie, member constructors are called properly). As for modelling destructors, there is a separate problem - since we don't have a `Stmt`, the `postCall` handler keeps on crashing. Repository: rG LLVM Github

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

2021-06-16 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. When should we expect this to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

2021-06-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin marked an inline comment as done. cor3ntin added a comment. In D103380#2823746 , @cjdb wrote: > When should we expect this to land? Thanks for the nudge, Chris! Please let me know if I can help move this forward :) Repository: rG LLVM Github

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

2021-06-16 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. It misses the part in llvm now. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:437-475 +void emitDynamicAlignedDealloc(CodeGenFunction &CGF, + llvm::BasicBlock *AlignedFreeBB, + llvm::CallInst

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

2021-06-16 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3334 return SemaBuiltinConstantArgRange(TheCall, 3, 0, 7); + case PPC::BI__builtin_ppc_tw: { +return SemaBuiltinConstantArgRange(TheCall, 2, 1, 31); Unnecessary brace? =

[PATCH] D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file

2021-06-16 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, martong, balazske, steakhal, xazax.hun. Szelethus added a project: clang. Herald added subscribers: manas, dang, ASDenysPetrov, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whi

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

2021-06-16 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D103096#2822965 , @ASDenysPetrov wrote: > In D103096#2821750 , @vsavchenko > wrote: > >> Hey, great work! I think that casts are extremely important, but it looks >> like you mix

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-16 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s // R

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-06-16 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c:56 +unsigned int testrotatel4(unsigned int rs, unsigned int shift) { + return __rotatel4(rs, shift); +} For these tests against builtin mapping to an intrinsic, could we o

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

2021-06-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 352625. balazske added a comment. Fixed typo error in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103792/new/ https://reviews.llvm.org/D103792 Files: clang/lib/AST/ASTImporter.cpp clang/unittes

<    1   2