[PATCH] D101506: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC

2021-06-15 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3302af9d4c39: Support: Remove F_{None,Text,Append} compatibility synonyms, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101506

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

2021-06-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:124 - // 28 bits left in a 64-bit word. + // True if this identifier is a literal operator without whitespace. + unsigned IsLiteralOperatorWithoutWhitespace : 1; I'm

[clang] 994bb93 - [PowerPC] Moving defineXLCompatMacros() definition

2021-06-15 Thread Albion Fung via cfe-commits
Author: Quinn Pham Date: 2021-06-15T14:25:43-05:00 New Revision: 994bb937f020a014c7039151169649a7076ca9b1 URL: https://github.com/llvm/llvm-project/commit/994bb937f020a014c7039151169649a7076ca9b1 DIFF: https://github.com/llvm/llvm-project/commit/994bb937f020a014c7039151169649a7076ca9b1.diff LO

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

2021-06-15 Thread Albion Fung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG994bb937f020: [PowerPC] Moving defineXLCompatMacros() definition (authored by quinnp, committed by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 352215. vitalybuka added a comment. Herald added a subscriber: dexonsmith. restore few lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104279/new/ https://reviews.llvm.org/D104279 Files: clang/lib/Dri

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-15 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Another +1 for it failing intermittently on the bot I watch over, llvm-clang-x86_64-sie-ubuntu-fast. Anything that can be done to stabilize the test or to remove it would be appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

2021-06-15 Thread Francois JEAN via Phabricator via cfe-commits
Wawha added a comment. Indeed, I found another case with a regression: return iter::chain.from_iterable( [](auto&& ite) -> auto& { return ite.second; }); it's format all inline. And also another different in that case (without lambda): ASSERT_NO_THROW(

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

2021-06-15 Thread Fred Grim via Phabricator via cfe-commits
feg208 added a comment. In D101868#2820075 , @dyung wrote: > Another +1 for it failing intermittently on the bot I watch over, > llvm-clang-x86_64-sie-ubuntu-fast. Anything that can be done to stabilize the > test or to remove it would be appreciated!

[PATCH] D104295: removes redundant test

2021-06-15 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. I'll commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104295/new/ https://reviews.llvm.org/D104295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] efebe76 - Remove redundant test that was causing intermittent build bot failures.

2021-06-15 Thread Douglas Yung via cfe-commits
Author: Douglas Yung Date: 2021-06-15T12:46:03-07:00 New Revision: efebe76e93d50562a0d834e39f096eac24aa3c0c URL: https://github.com/llvm/llvm-project/commit/efebe76e93d50562a0d834e39f096eac24aa3c0c DIFF: https://github.com/llvm/llvm-project/commit/efebe76e93d50562a0d834e39f096eac24aa3c0c.diff

[PATCH] D104295: removes redundant test

2021-06-15 Thread Douglas Yung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGefebe76e93d5: Remove redundant test that was causing intermittent build bot failures. (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1042

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 352221. vitalybuka added a comment. remove unrelated fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104279/new/ https://reviews.llvm.org/D104279 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp comp

[clang] 6478ef6 - [asan] Remove Asan, Ubsan support of RTEMS and Myriad

2021-06-15 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2021-06-15T12:59:05-07:00 New Revision: 6478ef61b1a4dd86f520b199e0fd6762e8306353 URL: https://github.com/llvm/llvm-project/commit/6478ef61b1a4dd86f520b199e0fd6762e8306353 DIFF: https://github.com/llvm/llvm-project/commit/6478ef61b1a4dd86f520b199e0fd6762e8306353.diff L

[PATCH] D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6478ef61b1a4: [asan] Remove Asan, Ubsan support of RTEMS and Myriad (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

2021-06-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: gribozavr2. ymandel requested review of this revision. Herald added a project: clang. Currently, the implementation combines OOP and overloads, using a template to tie the two together. In practice, this has proven confusing with no benefits

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

2021-06-15 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Stencil.cpp:158 break; } +return (OpName + "(\"" + Id + "\")").str(); Please use spaces

[clang] dc3bd11 - Adding the rest of the C11 papers to the status page.

2021-06-15 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2021-06-15T16:13:26-04:00 New Revision: dc3bd11e5b6be7a5430b32dc8155e2435a542918 URL: https://github.com/llvm/llvm-project/commit/dc3bd11e5b6be7a5430b32dc8155e2435a542918 DIFF: https://github.com/llvm/llvm-project/commit/dc3bd11e5b6be7a5430b32dc8155e2435a542918.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

2021-06-15 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. There are several files other than CGBlocks.cpp in which `FunctionDecl::Create` is called to create fake FunctionDecls. Do those places have to be fixed too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https:

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

2021-06-15 Thread Seraphime Kirkovski (VMware) via Phabricator via cfe-commits
skirkovski added a comment. Ping, I do not have commit access, can someone submit this as time permits ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cf

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

2021-06-15 Thread Felix Berger via Phabricator via cfe-commits
flx updated this revision to Diff 352233. flx marked an inline comment as done. flx added a comment. Directly examine initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.llvm.org/D103021 Files: clang-tools-extr

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 352234. awarzynski added a comment. Add missing test (forgot to add when making the submission) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 Files: clang/incl

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

2021-06-15 Thread Felix Berger via Phabricator via cfe-commits
flx updated this revision to Diff 352236. flx added a comment. Remove now unnecessary FunctionDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.llvm.org/D103021 Files: clang-tools-extra/clang-tidy/performance/Unnece

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

2021-06-15 Thread Felix Berger via Phabricator via cfe-commits
flx marked an inline comment as done. flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode(&InitializingVar .bi

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

2021-06-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:125 + // True if this identifier is a literal operator without whitespace. + unsigned IsLiteralOperatorWithoutWhitespace : 1; + This is per-declaration state; I don't think we

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

2021-06-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 352237. ymandel added a comment. try to fix tabs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104317/new/ https://reviews.llvm.org/D104317 Files: clang/lib/Tooling/Transformer/Stencil.cpp Index: clang/lib/

[PATCH] D104317: [libTooling][NFC] Refactor implemenation of Transformer Stencils to use standard OOP

2021-06-15 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/Stencil.cpp:158 break; } +return (OpName + "(\"" + Id + "\")").str(); gribozavr2 wrote: > Please use spaces instead of tabs (throughout the patch). I think those markers indi

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 352240. quinnp added a comment. Changed the target architecture of tests to follow the convention: BE-pwr7 LE-pwr8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Fi

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

2021-06-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: llvm/test/Linker/warn-stack-frame.ll:6 + +; CHECK-MISMATCH: error: linking module flags 'warn-stack-size': IDs have conflicting values + dblaikie wrote: > If you like, you could make this a function attribute in

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

2021-06-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D98799#2820198 , @ahatanak wrote: > There are several files other than CGBlocks.cpp in which > `FunctionDecl::Create` is called to create fake FunctionDecls. Do those > places have to be fixed too? This issue in this particu

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a subscriber: rsmith. vitalybuka added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-06-15 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis added a comment. In D102107#2819869 , @lebedev.ri wrote: > (This is not offload-specific, right?) > This does not bring any compatibility issues, right? It's not offload-specific, so the patch applies to host OpenMP too. The patch, as is,

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2021-06-15 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 352268. ggeorgakoudis added a comment. Update non-remark tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse leonardchan wrote: > leonardchan wrote:

[clang] bddef53 - [docs] Exclude FlangOption and re-generate ClangCommandLineReference.rst

2021-06-15 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2021-06-15T15:22:07-07:00 New Revision: bddef537776e15fa21e2ec11a4b2543d6d91fedc URL: https://github.com/llvm/llvm-project/commit/bddef537776e15fa21e2ec11a4b2543d6d91fedc DIFF: https://github.com/llvm/llvm-project/commit/bddef537776e15fa21e2ec11a4b2543d6d91fedc.diff

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

2021-06-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Herald added a subscriber: ormris. In D101832#2736636 , @MaskRay wrote: > I think @vitalybuka has concrete suggestion on the naming. If ignorelist is used, I can delete `-fsanitize-coverage-blocklist=` Repository: rG LLVM Git

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

2021-06-15 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 352271. mizvekov added a comment. -bugs +tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp cla

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

2021-06-15 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430 +void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) { + CHECK_EQ(0, unique_id_); // try to catch bad stack reuse vitalybuka wrote: > leonardchan wrote: > >

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

2021-06-15 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:54 +inline uptr GetShadowOffset() { + return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address; +} I think you'll eventually need to make this an `#if` or `if conste

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

2021-06-15 Thread Manas Gupta via Phabricator via cfe-commits
manas updated this revision to Diff 352283. manas edited the summary of this revision. manas added a comment. Herald added a subscriber: martong. Add logic for computing rangeset for an expression containing BO_Add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

2021-06-15 Thread Manas Gupta via Phabricator via cfe-commits
manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1401-1402 + +// FIXME: This case in particular is resulting in failed assertion. +Range First = Range(Tmin, Max); +Range Second = Range(Min, Tmax); I cha

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-15 Thread Kevin Athey via Phabricator via cfe-commits
kda updated this revision to Diff 352287. kda marked 2 inline comments as done. kda added a comment. - more beauty, added UsersManual changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clan

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-15 Thread Kevin Athey via Phabricator via cfe-commits
kda updated this revision to Diff 352289. kda marked 2 inline comments as done. kda added a comment. - more consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clang/docs/AddressSanitize

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-15 Thread Kevin Athey via Phabricator via cfe-commits
kda added a comment. F17415480: _usr_local_google_home_kda_src_uar_llvm-project_build_tools_clang_docs_html_AddressSanitizer.html.png Comment at: clang/docs/AddressSanitizer.rst:18 +* Use-after-return (clang flag `-fsanitize-address-use-a

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

2021-06-15 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added subscribers: jansvoboda11, vsapsai, dexonsmith. bruno added a comment. Thanks for working on this, comments inline. @vsapsai @jansvoboda11 @dexonsmith any headermap related concerns on your side? Comment at: clang/lib/Lex/HeaderSearch.cpp:445 +return None;

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

2021-06-15 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > Assuming I'm answering the correct question that the returns_nonnull is > preserved through a PCH, the answer is yes. Thanks! > As mentioned this isn't strictly needed and the BE can elide

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

2021-06-15 Thread Andrew Gallagher via Phabricator via cfe-commits
andrewjcg updated this revision to Diff 352299. andrewjcg added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/Inputs/impl

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

2021-06-15 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: qcolombet, dblaikie. Herald added subscribers: dexonsmith, jdoerfert, pengfei, hiraditya. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commit

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!! ---

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

2021-06-15 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. @rjmccall Added some tests covering these semantics: clang/test/SemaObjCXX/block-capture.mm and also some extra documentation to checkEscapingByref. Not sure if I got the terminology right here.. @Quuxplusone any other interesting corner cases for these new tests? Rep

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

2021-06-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. what're the rules about module level attributes like this? For instance: Does this affect/hinder inlining (if the attributes don't match between the caller and callee)? Other situations that might matter? Comment at: llvm/lib/CodeGen/PrologEpilogInse

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: clang/docs/AddressSanitizer.rst:19 +* Enable ``runtime`` with: ``ASAN_OPTIONS=detect_stack_use_after_return=1`` +* Use-after-scope (clang flag ``-fsanitize-address-use-after-scope``) * Double-free, invalid free s

[PATCH] D104344: [modules] Track how headers are included by different modules.

2021-06-15 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we are using `HeaderSearch` state from building a module and if an invisible submodule imports a non-modul

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

2021-06-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D97915#2819871 , @ychen wrote: > - Merge D102145 by @ChuanqiXu's request. Thanks a lot. Could you add me as a reviewer? So that I can see this patch in my main page. Repository: rG LLVM

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2021-06-15 Thread Jim Lin via Phabricator via cfe-commits
Jim added a comment. Any comments? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D87981: [X86] AMX programming model.

2021-06-15 Thread Bing Yu via Phabricator via cfe-commits
yubing added inline comments. Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4675 } +case Intrinsic::x86_tilestored64_internal: { + unsigned Opc = X86::PTILESTOREDV; It seems there should be a check here, according to line4575: ``` if (!Subtar

[PATCH] D104275: [compiler-rt][hwasan] Add GetShadowOffset function

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:54 +inline uptr GetShadowOffset() { + return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address; +} mcgrathr wrote: > I think you'll eventually need to make this an

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

2021-06-15 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck -check-prefix=PERMISSIVE-MINUS-OVERWRITE %s +// PERMISSIVE-MINUS-OV

[PATCH] D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=

2021-06-15 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D101832#2820465 , @MaskRay wrote: > In D101832#2736636 , @MaskRay wrote: > >> I think @vitalybuka has concrete suggestion on the naming. > > If ignorelist is used, I can delete `-fsa

[PATCH] D104348: [index] Fix performance regression with indexing macros

2021-06-15 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir created this revision. benlangmuir added a reviewer: arphaman. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using FileIndexRecord with macros, symbol references can be seen out of source order, which was cau

[PATCH] D104350: [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

2021-06-15 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. vsapsai added a reviewer: dexonsmith. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104350 Files: clang/include/clang/Serialization/AS

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

2021-06-15 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. vsapsai added reviewers: jansvoboda11, bruno. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. There is a separate field `isPragmaOnce` and when `isImport` combines both, it complicates HeaderFileInfo seri

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

2021-06-15 Thread Markus Böck via Phabricator via cfe-commits
zero9178 added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck -check-prefix=PERMISSIVE-MINUS-OVERWRITE %s +// PERMISSIVE-MINUS-

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

2021-06-15 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:444-447 void MarkFileIncludeOnce(const FileEntry *File) { HeaderFileInfo &FI = getFileInfo(File); -FI.isImport = true; FI.isPragmaOnce = true; This affects the resu

[PATCH] D104344: [modules] Track how headers are included by different modules.

2021-06-15 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 352326. vsapsai added a comment. Split out smaller parts as separate reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 Files: clang/include/clang/Lex/HeaderS

[clang] 4590b40 - [Debug-Info] guard DW_LANG_C_plus_plus_14 under strict dwarf

2021-06-15 Thread Chen Zheng via cfe-commits
Author: Chen Zheng Date: 2021-06-16T03:17:56Z New Revision: 4590b406c02e4e6803d2644195dbb78bc09c25c7 URL: https://github.com/llvm/llvm-project/commit/4590b406c02e4e6803d2644195dbb78bc09c25c7 DIFF: https://github.com/llvm/llvm-project/commit/4590b406c02e4e6803d2644195dbb78bc09c25c7.diff LOG: [D

[clang] 285dd08 - [Driver] Delete -fsanitize-coverage-blocklist= in favor of -fsanitize-coverage-ignorelist=

2021-06-15 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2021-06-15T20:32:24-07:00 New Revision: 285dd08b56215840d721961add4a355b60d673a7 URL: https://github.com/llvm/llvm-project/commit/285dd08b56215840d721961add4a355b60d673a7 DIFF: https://github.com/llvm/llvm-project/commit/285dd08b56215840d721961add4a355b60d673a7.diff

[PATCH] D87981: [X86] AMX programming model.

2021-06-15 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4675 } +case Intrinsic::x86_tilestored64_internal: { + unsigned Opc = X86::PTILESTOREDV; yubing wrote: > It seems there should be a check here, according to line4575:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

2021-06-15 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. It looks not easy to review completely. After a rough review, the first suggest is to remove the contents that should be in 'D102147 ', it makes the complex problem more complex I think. I would try to do more detailed review and test

<    1   2